145612 2015-06-03 13:08:12 -0700 Caps lock indicator should not be shown in read-only or disabled field 2015-06-03 15:36:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=145613 InRadar P2 Normal --- 1 dbates dbates webkit-bug-importer oldest_to_newest 1099232 0 dbates 2015-06-03 13:08:12 -0700 We should not show the caps lock indicator in a read-only or disabled field. 1099241 1 254202 dbates 2015-06-03 13:21:54 -0700 Created attachment 254202 Patch We need to abstract the caps lock logic so as to support automated testing. Currently we check the actual hardware keyboard state for the caps lock key to determine whether to draw the caps lock indicator. Filed bug #145613 to add support for testing the caps lock indicator in DRT/WTR. 1099243 2 webkit-bug-importer 2015-06-03 13:24:54 -0700 <rdar://problem/21227454> 1099311 3 dbates 2015-06-03 15:36:11 -0700 Committed r185173: <http://trac.webkit.org/changeset/185173> 254202 2015-06-03 13:21:54 -0700 2015-06-03 14:24:48 -0700 Patch bug-145612-20150603132134.patch text/plain 5533 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM5NjE0OGJmMzZiMzYy ZmU2ZmMxMmEyNDFkMTE3ODc5NzMxMGQ0MC4uZGIwYmQ3YTRiNTExZjdiOWFlYmQwMDJhODY4N2Q4 NmNlMWM0Y2I0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTAzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDYXBzIGxvY2sgaW5kaWNh dG9yIHNob3VsZCBub3QgYmUgc2hvd24gaW4gcmVhZC1vbmx5IG9yIGRpc2FibGVkIGZpZWxkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU2MTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvVGV4 dEZpZWxkSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRGaWVsZElucHV0VHlw ZTo6ZGlzYWJsZWRBdHRyaWJ1dGVDaGFuZ2VkKTogVXBkYXRlIGNhcHMgbG9jayBpbmRpY2F0b3Ig c3RhdGUuCisgICAgICAgIChXZWJDb3JlOjpUZXh0RmllbGRJbnB1dFR5cGU6OnJlYWRvbmx5QXR0 cmlidXRlQ2hhbmdlZCk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6VGV4dEZpZWxkSW5wdXRU eXBlOjpzaG91bGREcmF3Q2Fwc0xvY2tJbmRpY2F0b3IpOiBEbyBub3QgZHJhdyB0aGUgY2FwcyBs b2NrIGluZGljYXRvcgorICAgICAgICB3aGVuIHRoZSBmaWVsZCBpcyByZWFkLW9ubHkgb3IgZGlz YWJsZWQuCisKIDIwMTUtMDYtMDMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBTdWJwaXhlbCByZW5kZXJpbmc6IENvbXBvc2l0ZWQgbGF5ZXIgd2l0aCBzdWJwaXhl bCBnYXAgZG9lcyBub3QgZ2V0IHBhaW50ZWQgcHJvcGVybHkgd2hlbiBpdHMgcG9zaXRpb24gY2hh bmdlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcAppbmRleCA5 NDVhZDI4NmJjNDYzNGUzMjY3MjE4YzkwNWM1ODU5NjYyZDk2NmUxLi5hMmExMDM3ZWI2YTNiNmE4 OGYwYTllODU5ODhhMGUzYWNlMTFhZDEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L1RleHRGaWVsZElucHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0Rmll bGRJbnB1dFR5cGUuY3BwCkBAIC0zNTgsMTIgKzM1OCwxNCBAQCB2b2lkIFRleHRGaWVsZElucHV0 VHlwZTo6ZGlzYWJsZWRBdHRyaWJ1dGVDaGFuZ2VkKCkKIHsKICAgICBpZiAobV9pbm5lclNwaW5C dXR0b24pCiAgICAgICAgIG1faW5uZXJTcGluQnV0dG9uLT5yZWxlYXNlQ2FwdHVyZSgpOworICAg IGNhcHNMb2NrU3RhdGVNYXlIYXZlQ2hhbmdlZCgpOwogfQogCiB2b2lkIFRleHRGaWVsZElucHV0 VHlwZTo6cmVhZG9ubHlBdHRyaWJ1dGVDaGFuZ2VkKCkKIHsKICAgICBpZiAobV9pbm5lclNwaW5C dXR0b24pCiAgICAgICAgIG1faW5uZXJTcGluQnV0dG9uLT5yZWxlYXNlQ2FwdHVyZSgpOworICAg IGNhcHNMb2NrU3RhdGVNYXlIYXZlQ2hhbmdlZCgpOwogfQogCiBib29sIFRleHRGaWVsZElucHV0 VHlwZTo6c3VwcG9ydHNSZWFkT25seSgpIGNvbnN0CkBAIC01NDksNiArNTUxLDkgQEAgYm9vbCBU ZXh0RmllbGRJbnB1dFR5cGU6OnNob3VsZERyYXdDYXBzTG9ja0luZGljYXRvcigpIGNvbnN0CiAg ICAgaWYgKGVsZW1lbnQoKS5kb2N1bWVudCgpLmZvY3VzZWRFbGVtZW50KCkgIT0gJmVsZW1lbnQo KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKGVsZW1lbnQoKS5pc0Rpc2FibGVk T3JSZWFkT25seSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBGcmFtZSogZnJhbWUg PSBlbGVtZW50KCkuZG9jdW1lbnQoKS5mcmFtZSgpOwogICAgIGlmICghZnJhbWUpCiAgICAgICAg IHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3 MDQxNWE4ODY2YWIwMmFlYmNkNmI5MzhhZGNkNGNjYTFmNjEwZTk0Li4xOTBkYjEyZDY0NTExYzQx YTZjOWE4NTdmZTFkZTlhN2U3YjY5YmU3IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDYtMDMgIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIENhcHMgbG9jayBpbmRpY2F0b3Igc2hvdWxkIG5vdCBi ZSBzaG93biBpbiByZWFkLW9ubHkgb3IgZGlzYWJsZWQgZmllbGQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTYxMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWFudWFsVGVzdHMvcGFzc3dvcmQtY2Fw cy1sb2NrLXNob3VsZC1ub3Qtc2hvdy1pbi1yZWFkLW9ubHktZmllbGQuaHRtbDogQWRkZWQuCisg ICAgICAgICogTWFudWFsVGVzdHMvcGFzc3dvcmQtY2Fwcy1sb2NrLXNob3VsZC1ub3Qtc2hvdy13 aGVuLWZpZWxkLWJlY29tZXMtZGlzYWJsZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogTWFudWFs VGVzdHMvcGFzc3dvcmQtY2Fwcy1sb2NrLXNob3VsZC1ub3Qtc2hvdy13aGVuLWZpZWxkLWJlY29t ZXMtcmVhZC1vbmx5Lmh0bWw6IEFkZGVkLgorCiAyMDE1LTA2LTAxICBDc2FiYSBPc3p0cm9nb27D oWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2NtYWtlXSBTdXBwcmVzcyBwYXJlbnRo ZXNlcy1lcXVhbGl0eSB3YXJuaW5ncwpkaWZmIC0tZ2l0IGEvTWFudWFsVGVzdHMvcGFzc3dvcmQt Y2Fwcy1sb2NrLXNob3VsZC1ub3Qtc2hvdy1pbi1yZWFkLW9ubHktZmllbGQuaHRtbCBiL01hbnVh bFRlc3RzL3Bhc3N3b3JkLWNhcHMtbG9jay1zaG91bGQtbm90LXNob3ctaW4tcmVhZC1vbmx5LWZp ZWxkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNjczOGM5NGZlZmY0ZmQxMGI2ZjU1OTVlNDVjZjRlZmFiYTMy YzQ4NQotLS0gL2Rldi9udWxsCisrKyBiL01hbnVhbFRlc3RzL3Bhc3N3b3JkLWNhcHMtbG9jay1z aG91bGQtbm90LXNob3ctaW4tcmVhZC1vbmx5LWZpZWxkLmh0bWwKQEAgLTAsMCArMSwxMiBAQAor PCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0IGNhbiBiZSB1c2Vk IHRvIHZlcmlmeSB0aGF0IHRoZSBjYXBzIGxvY2sgaW5kaWNhdG9yIGlzIG5vdCBzaG93biBpbiBh IHJlYWQtb25seSBwYXNzd29yZCBmaWVsZC48L3A+Cis8b2w+CisgICAgPGxpPkNsaWNrIG9uIHRo ZSBwYXNzd29yZCBmaWVsZCAoYmVsb3cpIHRvIGZvY3VzIGl0LjwvbGk+CisgICAgPGxpPlByZXNz IHRoZSBjYXBzIGxvY2sga2V5IG9uIHRoZSBrZXlib2FyZC48L2xpPgorPC9vbD4KKzxwPlRoaXMg dGVzdCBGQUlMRUQgaWYgdGhlIGNhcHMgbG9jayBpbmRpY2F0b3IgaXMgc2hvd24uIE90aGVyd2lz ZSwgaXQgUEFTU0VELjwvcD4KKzxpbnB1dCB0eXBlPSJwYXNzd29yZCIgcmVhZG9ubHk+Cis8L2Jv ZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9NYW51YWxUZXN0cy9wYXNzd29yZC1jYXBzLWxvY2st c2hvdWxkLW5vdC1zaG93LXdoZW4tZmllbGQtYmVjb21lcy1kaXNhYmxlZC5odG1sIGIvTWFudWFs VGVzdHMvcGFzc3dvcmQtY2Fwcy1sb2NrLXNob3VsZC1ub3Qtc2hvdy13aGVuLWZpZWxkLWJlY29t ZXMtZGlzYWJsZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44ZWE2MTYzNmVlNTY3YmIwNGJjYzI4NmFhNWQx NGVjYjgwYTE1YzU1Ci0tLSAvZGV2L251bGwKKysrIGIvTWFudWFsVGVzdHMvcGFzc3dvcmQtY2Fw cy1sb2NrLXNob3VsZC1ub3Qtc2hvdy13aGVuLWZpZWxkLWJlY29tZXMtZGlzYWJsZWQuaHRtbApA QCAtMCwwICsxLDEyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8cD5UaGlz IHRlc3QgY2FuIGJlIHVzZWQgdG8gdmVyaWZ5IHRoYXQgdGhlIGNhcHMgbG9jayBpbmRpY2F0b3Ig aXMgbm90IHNob3duIHdoZW4gdGhlIHBhc3N3b3JkIGZpZWxkIGJlY29tZXMgZGlzYWJsZWQuPC9w PgorPG9sPgorICAgIDxsaT5DbGljayBvbiB0aGUgcGFzc3dvcmQgZmllbGQgKGJlbG93KSB0byBm b2N1cyBpdC48L2xpPgorICAgIDxsaT5QcmVzcyB0aGUgY2FwcyBsb2NrIGtleSBvbiB0aGUga2V5 Ym9hcmQuPC9saT4KKzwvb2w+Cis8cD5UaGlzIHRlc3QgRkFJTEVEIGlmIHRoZSBjYXBzIGxvY2sg aW5kaWNhdG9yIGlzIHNob3duLiBPdGhlcndpc2UsIGl0IFBBU1NFRC48L3A+Cis8aW5wdXQgdHlw ZT0icGFzc3dvcmQiIG9ua2V5ZG93bj0idGhpcy5kaXNhYmxlZCA9IHRydWU7Ij4gPCEtLSBBcHBL aXQgb25seSBkaXNwYXRjaGVzIGEga2V5ZG93biBldmVudCB3aGVuIHRoZSBjYXBzIGxvY2sga2V5 IGlzIGVuYWJsZWQuIC0tPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTWFudWFsVGVz dHMvcGFzc3dvcmQtY2Fwcy1sb2NrLXNob3VsZC1ub3Qtc2hvdy13aGVuLWZpZWxkLWJlY29tZXMt cmVhZC1vbmx5Lmh0bWwgYi9NYW51YWxUZXN0cy9wYXNzd29yZC1jYXBzLWxvY2stc2hvdWxkLW5v dC1zaG93LXdoZW4tZmllbGQtYmVjb21lcy1yZWFkLW9ubHkuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zM2Yw ZjkxMTMyYWRkZTkxZTYwODMwYjBhZmUzNDY2MTg4ZDA0MTRiCi0tLSAvZGV2L251bGwKKysrIGIv TWFudWFsVGVzdHMvcGFzc3dvcmQtY2Fwcy1sb2NrLXNob3VsZC1ub3Qtc2hvdy13aGVuLWZpZWxk LWJlY29tZXMtcmVhZC1vbmx5Lmh0bWwKQEAgLTAsMCArMSwxMiBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0IGNhbiBiZSB1c2VkIHRvIHZlcmlmeSB0aGF0 IHRoZSBjYXBzIGxvY2sgaW5kaWNhdG9yIGlzIG5vdCBzaG93biB3aGVuIHRoZSBwYXNzd29yZCBm aWVsZCBiZWNvbWVzIHJlYWQtb25seS48L3A+Cis8b2w+CisgICAgPGxpPkNsaWNrIG9uIHRoZSBw YXNzd29yZCBmaWVsZCAoYmVsb3cpIHRvIGZvY3VzIGl0LjwvbGk+CisgICAgPGxpPlByZXNzIHRo ZSBjYXBzIGxvY2sga2V5IG9uIHRoZSBrZXlib2FyZC48L2xpPgorPC9vbD4KKzxwPlRoaXMgdGVz dCBGQUlMRUQgaWYgdGhlIGNhcHMgbG9jayBpbmRpY2F0b3IgaXMgc2hvd24uIE90aGVyd2lzZSwg aXQgUEFTU0VELjwvcD4KKzxpbnB1dCB0eXBlPSJwYXNzd29yZCIgb25rZXlkb3duPSJ0aGlzLnJl YWRPbmx5ID0gdHJ1ZTsiPiA8IS0tIEFwcEtpdCBvbmx5IGRpc3BhdGNoZXMgYSBrZXlkb3duIGV2 ZW50IHdoZW4gdGhlIGNhcHMgbG9jayBrZXkgaXMgZW5hYmxlZC4gLS0+Cis8L2JvZHk+Cis8L2h0 bWw+Cg==