145592 2015-06-02 22:01:55 -0700 Web Inspector: Remove uses of delete in Sidebar related code 2015-06-03 09:46:55 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1099054 0 joepeck 2015-06-02 22:01:55 -0700 * SUMMARY Remove uses of delete in Sidebar related code. 1099056 1 254145 joepeck 2015-06-02 22:03:41 -0700 Created attachment 254145 [PATCH] Proposed Fix 1099073 2 254145 commit-queue 2015-06-02 22:57:57 -0700 Comment on attachment 254145 [PATCH] Proposed Fix Clearing flags on attachment: 254145 Committed r185142: <http://trac.webkit.org/changeset/185142> 1099074 3 commit-queue 2015-06-02 22:58:00 -0700 All reviewed patches have been landed. Closing bug. 1099170 4 nvasilyev 2015-06-03 09:46:55 -0700 Why? Performance optimization? 254145 2015-06-02 22:03:41 -0700 2015-06-02 22:57:57 -0700 [PATCH] Proposed Fix some-delete-removal.patch text/plain 3979 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM1Y2YzNmQuLmRmODcxZTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE1LTA2LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHVzZXMgb2YgZGVsZXRlIGluIFNpZGViYXIgcmVsYXRlZCBjb2RlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1OTIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ1NT U3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0 eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUucmVmcmVzaCk6CisgICAgICAgIENsZWFy IHZhbHVlIGluc3RlYWQgb2YgZGVsZXRpbmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL1NlYXJjaFNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TZWFyY2hT aWRlYmFyUGFuZWwucHJvdG90eXBlLnBlcmZvcm1TZWFyY2gpOgorICAgICAgICBKdXN0IGNsZWFy IHRoZSBzZWFyY2ggaWRlbnRpZmllci4gQWxzbyBhc3NlcnQgaXQgKGEgcmVxdWlyZWQgc3RyaW5n KSBpcyBhbHdheXMgbm9uLWZhbHNleS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv U2lkZWJhci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TaWRlYmFyLnByb3RvdHlwZS5yZXNp emVyRHJhZ0VuZGVkKTogRGVsZXRlZC4KKyAgICAgICAgVGhpcyBlbnRpcmUgY2FsbGJhY2sgaXMg dW5uZWNlc3NhcnkgYmVjYXVzZSB3aGVuZXZlciB3ZSBzdGFydAorICAgICAgICBhIGRyYWcgd2Ug c2F2ZSB0aGUgdmFsdWUuCisKKzIwMTUtMDYtMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaWRlYmFyIGFuZCBzb21ldGlt ZXMgQ29udGVudFZpZXcgc2Nyb2xsIHBvc2l0aW9uIGlzIGxvc3Qgd2hlbiBzd2l0Y2hpbmcgYmV0 d2VlbiB0YWJzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDU1OTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQ1NTU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpz CmluZGV4IGFhM2I1ZjcuLjIwNTcwYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURldGFp bHNTaWRlYmFyUGFuZWwuanMKQEAgLTEwMSw5ICsxMDEsOSBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5 bGVEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgQ1NTU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVs IGV4dAogCiAgICAgICAgIHRoaXMuY29udGVudEVsZW1lbnQuc2Nyb2xsVG9wID0gdGhpcy5faW5p dGlhbFNjcm9sbE9mZnNldDsKIAotICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX3Bh bmVscy5sZW5ndGg7ICsraSkgewotICAgICAgICAgICAgZGVsZXRlIHRoaXMuX3BhbmVsc1tpXS5l bGVtZW50Ll9zYXZlZFNjcm9sbFRvcDsKLSAgICAgICAgICAgIHRoaXMuX3BhbmVsc1tpXS5tYXJr QXNOZWVkc1JlZnJlc2goZG9tTm9kZSk7CisgICAgICAgIGZvciAodmFyIHBhbmVsIG9mIHRoaXMu X3BhbmVscykgeworICAgICAgICAgICAgcGFuZWwuZWxlbWVudC5fc2F2ZWRTY3JvbGxUb3AgPSB1 bmRlZmluZWQ7CisgICAgICAgICAgICBwYW5lbC5tYXJrQXNOZWVkc1JlZnJlc2goZG9tTm9kZSk7 CiAgICAgICAgIH0KIAogICAgICAgICB0aGlzLl91cGRhdGVQc2V1ZG9DbGFzc0NoZWNrYm94ZXMo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NlYXJjaFNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQYW5lbC5qcwppbmRleCA3ZmQ2MmFhLi4yODc0MTg4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFy Y2hTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzCkBAIC0yMTEsNiArMjExLDggQEAgV2ViSW5z cGVjdG9yLlNlYXJjaFNpZGViYXJQYW5lbCA9IGNsYXNzIFNlYXJjaFNpZGViYXJQYW5lbCBleHRl bmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAgICAgIGlmIChlcnJvciB8fCAhcmVzdWx0c0NvdW50 KQogICAgICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICAgICAgY29uc29sZS5hc3NlcnQo c2VhcmNoSWQpOworCiAgICAgICAgICAgICB0aGlzLl9kb21TZWFyY2hJZGVudGlmaWVyID0gc2Vh cmNoSWQ7CiAKICAgICAgICAgICAgIGZ1bmN0aW9uIGRvbVNlYXJjaFJlc3VsdHMoZXJyb3IsIG5v ZGVJZHMpCkBAIC0yNzcsOSArMjc5LDkgQEAgV2ViSW5zcGVjdG9yLlNlYXJjaFNpZGViYXJQYW5l bCA9IGNsYXNzIFNlYXJjaFNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICAg ICAgc2V0VGltZW91dChzZWFyY2hTY3JpcHRzLmJpbmQodGhpcywgV2ViSW5zcGVjdG9yLmRlYnVn Z2VyTWFuYWdlci5rbm93bk5vblJlc291cmNlU2NyaXB0cyksIDApOwogCiAgICAgICAgIGlmICh3 aW5kb3cuRE9NQWdlbnQpIHsKLSAgICAgICAgICAgIGlmICgiX2RvbVNlYXJjaElkZW50aWZpZXIi IGluIHRoaXMpIHsKKyAgICAgICAgICAgIGlmICh0aGlzLl9kb21TZWFyY2hJZGVudGlmaWVyKSB7 CiAgICAgICAgICAgICAgICAgRE9NQWdlbnQuZGlzY2FyZFNlYXJjaFJlc3VsdHModGhpcy5fZG9t U2VhcmNoSWRlbnRpZmllcik7Ci0gICAgICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2RvbVNlYXJj aElkZW50aWZpZXI7CisgICAgICAgICAgICAgICAgdGhpcy5fZG9tU2VhcmNoSWRlbnRpZmllciA9 IHVuZGVmaW5lZDsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgRE9NQWdlbnQucGVyZm9y bVNlYXJjaChzZWFyY2hRdWVyeSwgZG9tQ2FsbGJhY2suYmluZCh0aGlzKSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFyLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJhci5qcwppbmRl eCAwMDYyMjc2Li5hNjQ1ZjkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9TaWRlYmFyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1NpZGViYXIuanMKQEAgLTI4MSwxMSArMjgxLDYgQEAgV2ViSW5z cGVjdG9yLlNpZGViYXIgPSBjbGFzcyBTaWRlYmFyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVj dAogICAgICAgICB0aGlzLmNvbGxhcHNlZCA9IChuZXdXaWR0aCA8ICh0aGlzLm1pbmltdW1XaWR0 aCAvIDIpKTsKICAgICB9CiAKLSAgICByZXNpemVyRHJhZ0VuZGVkKHJlc2l6ZXIpCi0gICAgewot ICAgICAgICBkZWxldGUgdGhpcy5fd2lkdGhCZWZvcmVSZXNpemU7Ci0gICAgfQotCiAgICAgLy8g UHJpdmF0ZQogCiAgICAgX25hdmlnYXRpb25JdGVtU2VsZWN0ZWQoZXZlbnQpCg==