145591 2015-06-02 21:43:32 -0700 Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs 2015-06-03 12:19:58 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck aestes commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1099046 0 joepeck 2015-06-02 21:43:32 -0700 * SUMMARY Sidebar and sometimes ContentView scroll position is lost when switching between tabs. * STEPS TO REPRODUCE 1. Inspect <http://apple.com> 2. Show Resources Tab 3. Scroll Resources list to the bottom 4. Switch to Elements tab 5. Switch back to Resources tab => Expected Resources list to be scrolled to the bottom * NOTES - Repeat with Timeline panel (sidebar / content view are linked) - Repeat with Details sidebars (non-DOM details sidebar panels, DOM details sidebar panels have their own refresh issues) 1099047 1 joepeck 2015-06-02 21:43:52 -0700 <rdar://problem/21176592> 1099051 2 254144 joepeck 2015-06-02 21:53:20 -0700 Created attachment 254144 [PATCH] Proposed Fix 1099053 3 254144 timothy 2015-06-02 21:57:19 -0700 Comment on attachment 254144 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=254144&action=review > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs How does this fix content view scroll position? I only see sidebar code being changed. 1099068 4 254144 commit-queue 2015-06-02 22:47:20 -0700 Comment on attachment 254144 [PATCH] Proposed Fix Clearing flags on attachment: 254144 Committed r185141: <http://trac.webkit.org/changeset/185141> 1099069 5 commit-queue 2015-06-02 22:47:24 -0700 All reviewed patches have been landed. Closing bug. 1099208 6 joepeck 2015-06-03 12:19:58 -0700 (In reply to comment #3) > Comment on attachment 254144 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254144&action=review > > > Source/WebInspectorUI/ChangeLog:3 > > + Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs > > How does this fix content view scroll position? I only see sidebar code > being changed. In Timelines the sidebar / content view are linked. So scrolling the sidebar just made everything work. 254144 2015-06-02 21:53:20 -0700 2015-06-02 22:47:20 -0700 [PATCH] Proposed Fix scroll-position.patch text/plain 6278 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVkMWUyNzcuLjM1Y2YzNmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMzIEBACiAyMDE1LTA2LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2lkZWJh ciBhbmQgc29tZXRpbWVzIENvbnRlbnRWaWV3IHNjcm9sbCBwb3NpdGlvbiBpcyBsb3N0IHdoZW4g c3dpdGNoaW5nIGJldHdlZW4gdGFicworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ1NTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NpZGViYXIuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU2lkZWJhci5wcm90b3R5cGUucmVtb3ZlU2lkZWJhclBhbmVsKToKKyAg ICAgICAgV2hlbiByZW1vdmluZyBhIHNpZGViYXIgcGFuZWwsIGVuc3VyZSB3ZSBjYWxsIGhpZGRl biBpZiBpdCB3YXMgdGhlIHZpc2libGUgcGFuZWwuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TaWRlYmFyUGFu ZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNpZGViYXJQYW5lbC5wcm90b3R5cGUuc2hvd24p OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNpZGViYXJQYW5lbC5wcm90b3R5cGUuaGlkZGVuKToK KyAgICAgICAgU2F2ZSBhbmQgcmVzdG9yZSBjb250ZW50IGVsZW1lbnQgc2Nyb2xsIHBvc2l0aW9u IHdoZW4gc2lkZWJhciBwYW5lbHMgYXJlIHNob3duIC8gaGlkZGVuLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS52aXNp YmlsaXR5RGlkQ2hhbmdlKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbXB1dGVk U3R5bGVEZXRhaWxzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29tcHV0ZWRTdHls ZURldGFpbHNQYW5lbC5wcm90b3R5cGUuc2hvd24pOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvRGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZXRh aWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5zaG93bik6CisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9MYXllclRyZWVEZXRhaWxzU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkxheWVyVHJlZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLnNob3duKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5MYXllclRyZWVEZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlw ZS5oaWRkZW4pOgorICAgICAgICBDbGVhbnVwLiBTaW5jZSBzaWRlYmFyIHBhbmVscyBhcmUgdXNp bmcgRVM2IGNsYXNzZXMsIGhhdmUgc3VwZXIgY2xhc3MgY2FsbHMgdXNlIGBzdXBlcmAhCisKKzIw MTUtMDYtMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBleGNlcHRpb24gc3RhcnRpbmcgYSBOYXZpZ2F0aW9u QmFyIGRyYWcgYW5kIG1vdXNpbmcgb3ZlciBhIGRpZmZlcmVudCBOYXZpZ2F0aW9uQmFyCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1ODkKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5 bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ1NTU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzCmluZGV4IDYzYWRlMTMu LmFhM2I1ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NTU1N0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwu anMKQEAgLTExMSw3ICsxMTEsNyBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZXRhaWxzU2lkZWJh clBhbmVsID0gY2xhc3MgQ1NTU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsIGV4dAogCiAgICAgdmlz aWJpbGl0eURpZENoYW5nZSgpCiAgICAgewotICAgICAgICBXZWJJbnNwZWN0b3IuU2lkZWJhclBh bmVsLnByb3RvdHlwZS52aXNpYmlsaXR5RGlkQ2hhbmdlLmNhbGwodGhpcyk7CisgICAgICAgIHN1 cGVyLnZpc2liaWxpdHlEaWRDaGFuZ2UoKTsKIAogICAgICAgICBpZiAoIXRoaXMuX3NlbGVjdGVk UGFuZWwpCiAgICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db21wdXRlZFN0eWxlRGV0YWlsc1BhbmVsLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZURl dGFpbHNQYW5lbC5qcwppbmRleCBjZjM5OGY5Li5hYjZkZWI5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db21wdXRlZFN0eWxlRGV0YWlsc1Bh bmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nv bXB1dGVkU3R5bGVEZXRhaWxzUGFuZWwuanMKQEAgLTE1OSw3ICsxNTksNyBAQCBXZWJJbnNwZWN0 b3IuQ29tcHV0ZWRTdHlsZURldGFpbHNQYW5lbCA9IGNsYXNzIENvbXB1dGVkU3R5bGVEZXRhaWxz UGFuZWwgZXh0ZW5kcwogCiAgICAgc2hvd24oKQogICAgIHsKLSAgICAgICAgV2ViSW5zcGVjdG9y LlN0eWxlRGV0YWlsc1BhbmVsLnByb3RvdHlwZS5zaG93bi5jYWxsKHRoaXMpOworICAgICAgICBz dXBlci5zaG93bigpOwogCiAgICAgICAgIHRoaXMuX3Byb3BlcnRpZXNUZXh0RWRpdG9yLnVwZGF0 ZUxheW91dCgpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RldGFpbHNTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZXRhaWxzU2lkZWJhclBhbmVsLmpzCmluZGV4IDQ2 NzZhMmIuLjVkMTQ2MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0RldGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGV0YWlsc1NpZGViYXJQYW5lbC5qcwpAQCAtNDks OCArNDksMTAgQEAgV2ViSW5zcGVjdG9yLkRldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBEZXRh aWxzU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjdG8KIAogICAgIHNob3duKCkKICAgICB7 CisgICAgICAgIHN1cGVyLnNob3duKCk7CisKICAgICAgICAgaWYgKHRoaXMuX25lZWRzUmVmcmVz aCkgewotICAgICAgICAgICAgZGVsZXRlIHRoaXMuX25lZWRzUmVmcmVzaDsKKyAgICAgICAgICAg IHRoaXMuX25lZWRzUmVmcmVzaCA9IGZhbHNlOwogICAgICAgICAgICAgdGhpcy5yZWZyZXNoKCk7 CiAgICAgICAgIH0KICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9MYXllclRyZWVEZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5ZXJUcmVlRGV0YWlsc1NpZGVi YXJQYW5lbC5qcwppbmRleCA2NGFhMWExLi5iNGM5MWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXllclRyZWVEZXRhaWxzU2lkZWJhclBh bmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xh eWVyVHJlZURldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAgLTUyLDE0ICs1MiwxNCBAQCBXZWJJbnNw ZWN0b3IuTGF5ZXJUcmVlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIExheWVyVHJlZURldGFp bHNTaWRlYmFyUGFuZWwgZQogCiAgICAgICAgIHRoaXMubmVlZHNSZWZyZXNoKCk7CiAKLSAgICAg ICAgV2ViSW5zcGVjdG9yLkRPTURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLnNob3duLmNh bGwodGhpcyk7CisgICAgICAgIHN1cGVyLnNob3duKCk7CiAgICAgfQogCiAgICAgaGlkZGVuKCkK ICAgICB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5sYXllclRyZWVNYW5hZ2VyLnJlbW92ZUV2ZW50 TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkxheWVyVHJlZU1hbmFnZXIuRXZlbnQuTGF5ZXJUcmVlRGlk Q2hhbmdlLCB0aGlzLl9sYXllclRyZWVEaWRDaGFuZ2UsIHRoaXMpOwogCi0gICAgICAgIFdlYklu c3BlY3Rvci5ET01EZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5oaWRkZW4uY2FsbCh0aGlz KTsKKyAgICAgICAgc3VwZXIuaGlkZGVuKCk7CiAgICAgfQogCiAgICAgcmVmcmVzaCgpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFy LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJhci5q cwppbmRleCBlOTNmOWU0Li4wMDYyMjc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NpZGViYXIuanMKQEAgLTkzLDYgKzkzLDExIEBAIFdl Ykluc3BlY3Rvci5TaWRlYmFyID0gY2xhc3MgU2lkZWJhciBleHRlbmRzIFdlYkluc3BlY3Rvci5P YmplY3QKIAogICAgICAgICBzaWRlYmFyUGFuZWwud2lsbFJlbW92ZSgpOwogCisgICAgICAgIGlm IChzaWRlYmFyUGFuZWwudmlzaWJsZSkgeworICAgICAgICAgICAgc2lkZWJhclBhbmVsLmhpZGRl bigpOworICAgICAgICAgICAgc2lkZWJhclBhbmVsLnZpc2liaWxpdHlEaWRDaGFuZ2UoKTsKKyAg ICAgICAgfQorCiAgICAgICAgIHNpZGViYXJQYW5lbC5fcGFyZW50U2lkZWJhciA9IG51bGw7CiAK ICAgICAgICAgaWYgKHRoaXMuX3NlbGVjdGVkU2lkZWJhclBhbmVsID09PSBzaWRlYmFyUGFuZWwp IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NpZGViYXJQYW5lbC5qcwppbmRleCA4MDZkZDk3Li4xNmZkMDVkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFyUGFuZWwuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJhclBh bmVsLmpzCkBAIC0zMSw2ICszMSw4IEBAIFdlYkluc3BlY3Rvci5TaWRlYmFyUGFuZWwgPSBjbGFz cyBTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICAgICAgdGhp cy5faWRlbnRpZmllciA9IGlkZW50aWZpZXI7CiAKKyAgICAgICAgdGhpcy5fc2F2ZWRTY3JvbGxQ b3NpdGlvbiA9IDA7CisKICAgICAgICAgdGhpcy5fZWxlbWVudCA9IGVsZW1lbnQgfHwgZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0 LmFkZCgicGFuZWwiLCBpZGVudGlmaWVyKTsKIApAQCAtMTI5LDExICsxMzEsMTUgQEAgV2ViSW5z cGVjdG9yLlNpZGViYXJQYW5lbCA9IGNsYXNzIFNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3Bl Y3Rvci5PYmplY3QKIAogICAgIHNob3duKCkKICAgICB7CisgICAgICAgIHRoaXMuX2NvbnRlbnRF bGVtZW50LnNjcm9sbFRvcCA9IHRoaXMuX3NhdmVkU2Nyb2xsUG9zaXRpb247CisKICAgICAgICAg Ly8gSW1wbGVtZW50ZWQgYnkgc3ViY2xhc3Nlcy4KICAgICB9CiAKICAgICBoaWRkZW4oKQogICAg IHsKKyAgICAgICAgdGhpcy5fc2F2ZWRTY3JvbGxQb3NpdGlvbiA9IHRoaXMuX2NvbnRlbnRFbGVt ZW50LnNjcm9sbFRvcDsKKwogICAgICAgICAvLyBJbXBsZW1lbnRlZCBieSBzdWJjbGFzc2VzLgog ICAgIH0KIAo=