145589 2015-06-02 21:21:14 -0700 Web Inspector: Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar 2015-06-03 07:58:30 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1099036 0 joepeck 2015-06-02 21:21:14 -0700 * SUMMARY Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar * STEPS TO REPRODUCE 1. Inspect a page 2. Show "Styles" > "Rules" sidebar for a dom element (two navigation bars right next to each other) 3. Click and hold "Rules" 4. Mouse over "Computed" (all is good) 5. Mouse over "Node" in the other navigation bar => Uncaught Exceptions * EXCEPTION [Error] TypeError: null is not an object (evaluating 'this.selectedNavigationItem.active = true') _mouseMoved (anonymous function) 1099037 1 254140 joepeck 2015-06-02 21:23:23 -0700 Created attachment 254140 [PATCH] Proposed Fix 1099055 2 254140 timothy 2015-06-02 22:03:11 -0700 Comment on attachment 254140 [PATCH] Proposed Fix The mouse move on document was to allow tracking of the selected radio navigation item as you moved the mouse side to side. It might be best to just abort early in the mouse move listener. I'm not sure we use many of these radio items any more, only one I can think of is the Details sidebar / Styles sidebar panel. I assume those are the bars you saw this with? 1099058 3 timothy 2015-06-02 22:05:44 -0700 Yep, I see you said that in the description. So doing this will break the old behavior of dragging side to side then mouse up to select an item when the mouse drifts outside the bar. I think that is fine. I doubt anyone does that in practice, I was just mimicking Xcode there. 1099072 4 joepeck 2015-06-02 22:53:24 -0700 Ahh, I only made it (In reply to comment #3) > Yep, I see you said that in the description. So doing this will break the > old behavior of dragging side to side then mouse up to select an item when > the mouse drifts outside the bar. I think that is fine. I doubt anyone does > that in practice, I was just mimicking Xcode there. Oops. I should be able to keep that working. I'll investigate a better fix. 1099075 5 joepeck 2015-06-02 23:07:00 -0700 (In reply to comment #4) > Ahh, I only made it (In reply to comment #3) > > Yep, I see you said that in the description. So doing this will break the > > old behavior of dragging side to side then mouse up to select an item when > > the mouse drifts outside the bar. I think that is fine. I doubt anyone does > > that in practice, I was just mimicking Xcode there. > > Oops. I should be able to keep that working. I'll investigate a better fix. Ahah! This behavior was broken, which is why I didn't notice to preserve it! 1099077 6 254153 joepeck 2015-06-02 23:07:16 -0700 Created attachment 254153 [PATCH] Proposed Fix 1099135 7 254153 timothy 2015-06-03 07:09:32 -0700 Comment on attachment 254153 [PATCH] Proposed Fix Great! 1099147 8 254153 commit-queue 2015-06-03 07:58:26 -0700 Comment on attachment 254153 [PATCH] Proposed Fix Clearing flags on attachment: 254153 Committed r185151: <http://trac.webkit.org/changeset/185151> 1099148 9 commit-queue 2015-06-03 07:58:30 -0700 All reviewed patches have been landed. Closing bug. 254140 2015-06-02 21:23:23 -0700 2015-06-02 23:07:16 -0700 [PATCH] Proposed Fix fix-exception.patch text/plain 2412 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFlMGNmZmUuLmVkMWUyNzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTA2LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIHN0YXJ0aW5nIGEgTmF2aWdhdGlvbkJhciBkcmFnIGFuZCBtb3VzaW5nIG92 ZXIgYSBkaWZmZXJlbnQgTmF2aWdhdGlvbkJhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25CYXIu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvbkJhci5wcm90b3R5cGUuX21vdXNl RG93bik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvbkJhci5wcm90b3R5cGUuX21v dXNlVXApOgorICAgICAgICBXaGVuIG1vdXNlIG1vdmluZyBvbmx5IGxvb2sgZm9yIG5hdmlnYXRp b24gaXRlbXMgd2l0aGluIHRoaXMgbmF2aWdhdGlvbiBiYXIuCisgICAgICAgIE1vdXNlIHVwIHNo b3VsZCBzdGlsbCB3YXRjaCB0aGUgZW50aXJlIGRvY3VtZW50LgorCisyMDE1LTA2LTAyICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3Rv cjogU2hpZnQgKyBDbWQgKyBMZWZ0L1JpZ2h0IHNob3VsZG4ndCBzd2l0Y2ggdGFicyB3aGlsZSBl ZGl0aW5nIHRleHQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NTU2MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9OYXZpZ2F0aW9uQmFyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvbkJhci5qcwppbmRleCBlYzA4MDQxLi5mYTM0MmE5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZp Z2F0aW9uQmFyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL05hdmlnYXRpb25CYXIuanMKQEAgLTI5NSw4ICsyOTUsOCBAQCBXZWJJbnNwZWN0b3IuTmF2 aWdhdGlvbkJhci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX21vdXNlTW92ZWRFdmVudExp c3RlbmVyID0gdGhpcy5fbW91c2VNb3ZlZC5iaW5kKHRoaXMpOwogICAgICAgICB0aGlzLl9tb3Vz ZVVwRXZlbnRMaXN0ZW5lciA9IHRoaXMuX21vdXNlVXAuYmluZCh0aGlzKTsKIAotICAgICAgICAv LyBSZWdpc3RlciB0aGVzZSBsaXN0ZW5lcnMgb24gdGhlIGRvY3VtZW50IHNvIHdlIGNhbiB0cmFj ayB0aGUgbW91c2UgaWYgaXQgbGVhdmVzIHRoZSByZXNpemVyLgotICAgICAgICBkb2N1bWVudC5h ZGRFdmVudExpc3RlbmVyKCJtb3VzZW1vdmUiLCB0aGlzLl9tb3VzZU1vdmVkRXZlbnRMaXN0ZW5l ciwgZmFsc2UpOworICAgICAgICAvLyBSZWdpc3RlciBtb3VzZXVwIGxpc3RlbmVyIG9uIHRoZSBk b2N1bWVudCBzbyB3ZSBjYW4gZGV0ZWN0IGl0IGV2ZW4gaWYgdGhlIG1vdXNlIGxlYXZlcyB0aGUg bmF2aWdhdGlvbiBiYXIuCisgICAgICAgIHRoaXMuX2VsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigi bW91c2Vtb3ZlIiwgdGhpcy5fbW91c2VNb3ZlZEV2ZW50TGlzdGVuZXIsIGZhbHNlKTsKICAgICAg ICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2V1cCIsIHRoaXMuX21vdXNlVXBFdmVu dExpc3RlbmVyLCBmYWxzZSk7CiAKICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKQEAg LTM0Niw3ICszNDYsNyBAQCBXZWJJbnNwZWN0b3IuTmF2aWdhdGlvbkJhci5wcm90b3R5cGUgPSB7 CiAKICAgICAgICAgdGhpcy5fbW91c2VJc0Rvd24gPSBmYWxzZTsKIAotICAgICAgICBkb2N1bWVu dC5yZW1vdmVFdmVudExpc3RlbmVyKCJtb3VzZW1vdmUiLCB0aGlzLl9tb3VzZU1vdmVkRXZlbnRM aXN0ZW5lciwgZmFsc2UpOworICAgICAgICB0aGlzLl9lbGVtZW50LnJlbW92ZUV2ZW50TGlzdGVu ZXIoIm1vdXNlbW92ZSIsIHRoaXMuX21vdXNlTW92ZWRFdmVudExpc3RlbmVyLCBmYWxzZSk7CiAg ICAgICAgIGRvY3VtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoIm1vdXNldXAiLCB0aGlzLl9tb3Vz ZVVwRXZlbnRMaXN0ZW5lciwgZmFsc2UpOwogCiAgICAgICAgIGRlbGV0ZSB0aGlzLl9tb3VzZU1v dmVkRXZlbnRMaXN0ZW5lcjsK 254153 2015-06-02 23:07:16 -0700 2015-06-03 07:58:26 -0700 [PATCH] Proposed Fix fix-nav-bar.patch text/plain 3173 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAwNzMzNDcuLjVkZjAwMTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA2LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIHN0YXJ0aW5nIGEgTmF2aWdhdGlvbkJhciBkcmFnIGFuZCBtb3VzaW5nIG92 ZXIgYSBkaWZmZXJlbnQgTmF2aWdhdGlvbkJhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25CYXIu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvbkJhci5wcm90b3R5cGUuX21vdXNl RG93bik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvbkJhci5wcm90b3R5cGUuX21v dXNlVXApOgorICAgICAgICBXaGVuIG1vdXNlIGRyYWdnaW5nIGZvciBuYXZpZ2F0aW9uIGJhcnMs IG9ubHkgbWF0Y2ggYWdhaW5zdCBuYXZpZ2F0aW9uCisgICAgICAgIGJhciBpdGVtcyBpbnNpZGUg dGhpcyBuYXZpZ2F0aW9uIGJhci4gQWxzbywgZml4IGhvcml6b250YWwgZGV0ZWN0aW9uCisgICAg ICAgIG9mIG5hdmlnYXRpb24gYmFyIGl0ZW1zIGJ5IHNjYW5uaW5nIGluIHRoZSBtaWRkbGUgb2Yg dGhlIG5hdmlnYXRpb24KKyAgICAgICAgYmFyIGluc3RlYWQgb2YgdGhlIHRvcCwgd2hpY2ggbWlz c2VkIHRoZSBpdGVtcy4KKworMjAxNS0wNi0wMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERlYnVnZ2VyIFBvcG92ZXIgZm9y IE5vZGUgb2JqZWN0IHNob3VsZCBoYXZlIGdvLXRvLWFycm93IHRvIHNob3cgdGhlIG5vZGUgaW4g RE9NIHRyZWUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTU5NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9OYXZpZ2F0aW9uQmFyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvTmF2aWdhdGlvbkJhci5qcwppbmRleCBlYzA4MDQxLi4yMzY4YjRhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0 aW9uQmFyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L05hdmlnYXRpb25CYXIuanMKQEAgLTI5NSw3ICsyOTUsNyBAQCBXZWJJbnNwZWN0b3IuTmF2aWdh dGlvbkJhci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX21vdXNlTW92ZWRFdmVudExpc3Rl bmVyID0gdGhpcy5fbW91c2VNb3ZlZC5iaW5kKHRoaXMpOwogICAgICAgICB0aGlzLl9tb3VzZVVw RXZlbnRMaXN0ZW5lciA9IHRoaXMuX21vdXNlVXAuYmluZCh0aGlzKTsKIAotICAgICAgICAvLyBS ZWdpc3RlciB0aGVzZSBsaXN0ZW5lcnMgb24gdGhlIGRvY3VtZW50IHNvIHdlIGNhbiB0cmFjayB0 aGUgbW91c2UgaWYgaXQgbGVhdmVzIHRoZSByZXNpemVyLgorICAgICAgICAvLyBSZWdpc3RlciB0 aGVzZSBsaXN0ZW5lcnMgb24gdGhlIGRvY3VtZW50IHNvIHdlIGNhbiB0cmFjayB0aGUgbW91c2Ug aWYgaXQgbGVhdmVzIHRoZSBuYXZpZ2F0aW9uIGJhci4KICAgICAgICAgZG9jdW1lbnQuYWRkRXZl bnRMaXN0ZW5lcigibW91c2Vtb3ZlIiwgdGhpcy5fbW91c2VNb3ZlZEV2ZW50TGlzdGVuZXIsIGZh bHNlKTsKICAgICAgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2V1cCIsIHRoaXMu X21vdXNlVXBFdmVudExpc3RlbmVyLCBmYWxzZSk7CiAKQEAgLTMxNCwxNSArMzE0LDE1IEBAIFdl Ykluc3BlY3Rvci5OYXZpZ2F0aW9uQmFyLnByb3RvdHlwZSA9IHsKICAgICAgICAgZXZlbnQuc3Rv cFByb3BhZ2F0aW9uKCk7CiAKICAgICAgICAgdmFyIGl0ZW1FbGVtZW50ID0gZXZlbnQudGFyZ2V0 LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoQ2xhc3MoV2ViSW5zcGVjdG9yLlJhZGlvQnV0dG9uTmF2 aWdhdGlvbkl0ZW0uU3R5bGVDbGFzc05hbWUpOwotICAgICAgICBpZiAoIWl0ZW1FbGVtZW50IHx8 ICFpdGVtRWxlbWVudC5uYXZpZ2F0aW9uSXRlbSkgeworICAgICAgICBpZiAoIWl0ZW1FbGVtZW50 IHx8ICFpdGVtRWxlbWVudC5uYXZpZ2F0aW9uSXRlbSB8fCAhdGhpcy5fZWxlbWVudC5jb250YWlu cyhpdGVtRWxlbWVudCkpIHsKICAgICAgICAgICAgIC8vIEZpbmQgdGhlIGVsZW1lbnQgdGhhdCBp cyBhdCB0aGUgWCBwb3NpdGlvbiBvZiB0aGUgbW91c2UsIGV2ZW4gd2hlbiB0aGUgbW91c2UgaXMg bm8gbG9uZ2VyCiAgICAgICAgICAgICAvLyB2ZXJ0aWNhbGx5IGluIHRoZSBuYXZpZ2F0aW9uIGJh ci4KLSAgICAgICAgICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQuZWxlbWVudEZyb21Qb2ludChl dmVudC5wYWdlWCwgdGhpcy5fZWxlbWVudC50b3RhbE9mZnNldFRvcCk7CisgICAgICAgICAgICB2 YXIgZWxlbWVudCA9IGRvY3VtZW50LmVsZW1lbnRGcm9tUG9pbnQoZXZlbnQucGFnZVgsIHRoaXMu X2VsZW1lbnQudG90YWxPZmZzZXRUb3AgKyAodGhpcy5fZWxlbWVudC5vZmZzZXRIZWlnaHQgLyAy KSk7CiAgICAgICAgICAgICBpZiAoIWVsZW1lbnQpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwog CiAgICAgICAgICAgICBpdGVtRWxlbWVudCA9IGVsZW1lbnQuZW5jbG9zaW5nTm9kZU9yU2VsZldp dGhDbGFzcyhXZWJJbnNwZWN0b3IuUmFkaW9CdXR0b25OYXZpZ2F0aW9uSXRlbS5TdHlsZUNsYXNz TmFtZSk7Ci0gICAgICAgICAgICBpZiAoIWl0ZW1FbGVtZW50IHx8ICFpdGVtRWxlbWVudC5uYXZp Z2F0aW9uSXRlbSkKKyAgICAgICAgICAgIGlmICghaXRlbUVsZW1lbnQgfHwgIWl0ZW1FbGVtZW50 Lm5hdmlnYXRpb25JdGVtIHx8ICF0aGlzLl9lbGVtZW50LmNvbnRhaW5zKGl0ZW1FbGVtZW50KSkK ICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAo=