145578 2015-06-02 16:33:29 -0700 Improve test coverage for changes made in 145527 2015-06-03 11:49:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145527 1 msaboff msaboff commit-queue oldest_to_newest 1098964 0 msaboff 2015-06-02 16:33:29 -0700 When the fix for https://bugs.webkit.org/show_bug.cgi?id=145527 was being prepared, it was believed that the bug involved a race between the main thread GC'ing and a worker thread compiling a DFG replacement for a baseline function. Testing for such a case in a deterministic was considered not worth it. We should make sure that there is test coverage for most / all of the new paths added. 1098967 1 254122 msaboff 2015-06-02 16:43:42 -0700 Created attachment 254122 Patch 1099192 2 254122 ggaren 2015-06-03 10:59:40 -0700 Comment on attachment 254122 Patch r=me 1099203 3 254122 commit-queue 2015-06-03 11:49:06 -0700 Comment on attachment 254122 Patch Clearing flags on attachment: 254122 Committed r185158: <http://trac.webkit.org/changeset/185158> 1099204 4 commit-queue 2015-06-03 11:49:10 -0700 All reviewed patches have been landed. Closing bug. 254122 2015-06-02 16:43:42 -0700 2015-06-03 11:49:06 -0700 Patch 145578.patch text/plain 3452 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1MTMxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE1LTA2LTAyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEltcHJvdmUgdGVzdCBjb3ZlcmFnZSBmb3IgY2hhbmdlcyBtYWRlIGluIDE0NTUyNworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NTc4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgbW9yZSBj b21wbGV4aXR5IHRvIHBvbHktc2V0dGVyLWNvbWJvLmpzIHN0cmVzcyB0ZXN0IHRvIGNyZWF0ZSBt b3JlIHR1cm1vaWwgaW4gdGhlCisgICAgICAgIHBvbHltb3JwaGljIGdldC1ieS1pZCAvIHB1dC1i eS1pZCB3aXRoIGdldHRlcnMgYW5kIHNldHRlcnMgdG8gZXhlcmNpc2UgdGhlIGNvZGUgY2hhbmdl IGluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1 MjcuICBCeSBjaGFuZ2luZyB0aGUgb2JqZWN0cyB0aGF0IHRoZSBtYWluIHRlc3QKKyAgICAgICAg ZnVuY3Rpb24gc2Vlcywgd2UgYXJlIGFibGUgdG8gdGVzdCB0aG9zZSBwYXRocy4gIFZlcmlmaWVk IHdpdGggdGVtcG9yYXJ5IGxvZ2dpbmcgY29kZS4KKworICAgICAgICAqIHRlc3RzL3N0cmVzcy9w b2x5LXNldHRlci1jb21iby5qczoKKyAgICAgICAgKENvbnMyKToKKyAgICAgICAgKENvbnMzKToK KyAgICAgICAgKENvbnM0KToKKyAgICAgICAgKGZvbyk6CisgICAgICAgICh0ZXN0KToKKyAgICAg ICAgKHJ1blRlc3RXaXRoQ29uc3RydWN0b3JzKToKKwogMjAxNS0wNi0wMiAgTWFyayBMYW0gIDxt YXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgR2FyZGVuaW5nOiBmaXggYnJva2VuIENMb29w IGJ1aWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9wb2x5LXNl dHRlci1jb21iby5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMv c3RyZXNzL3BvbHktc2V0dGVyLWNvbWJvLmpzCShyZXZpc2lvbiAxODUwODMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3BvbHktc2V0dGVyLWNvbWJvLmpzCSh3b3JraW5n IGNvcHkpCkBAIC0zLDEzICszLDMxIEBAIGZ1bmN0aW9uIENvbnMxKCkgewogQ29uczEucHJvdG90 eXBlLmYgPSA0MjsKIAogZnVuY3Rpb24gQ29uczIoKSB7CisgICAgdGhpcy5fdmFsdWVzID0gW10K IH0KIENvbnMyLnByb3RvdHlwZS5fX2RlZmluZVNldHRlcl9fKCJmIiwgZnVuY3Rpb24odmFsdWUp IHsKICAgICBjb3VudGVyKys7CiAgICAgdGhpcy5fZiA9IHZhbHVlOworICAgIHRoaXMuX3ZhbHVl c1t2YWx1ZV0gPSAxOwogfSk7CiBDb25zMi5wcm90b3R5cGUuX19kZWZpbmVHZXR0ZXJfXygiZiIs IGZ1bmN0aW9uKCkgeyByZXR1cm4gdGhpcy5fZjsgfSk7CiAKK2Z1bmN0aW9uIENvbnMzKCkgewor fQorQ29uczMucHJvdG90eXBlLmYgPSA0MjsKK0NvbnMzLnByb3RvdHlwZS5nID0gNDM7CisKK2Z1 bmN0aW9uIENvbnM0KCkgeworICAgIHRoaXMuX3ZhbHVlcyA9IFtdCit9CitDb25zNC5wcm90b3R5 cGUuZyA9IDE2OworQ29uczQucHJvdG90eXBlLl9fZGVmaW5lU2V0dGVyX18oImYiLCBmdW5jdGlv bih2YWx1ZSkgeworICAgIGNvdW50ZXIrKzsKKyAgICB0aGlzLl9mID0gdmFsdWU7CisgICAgdGhp cy5fdmFsdWVzW3ZhbHVlXSA9IDE7Cit9KTsKK0NvbnM0LnByb3RvdHlwZS5fX2RlZmluZUdldHRl cl9fKCJmIiwgZnVuY3Rpb24oKSB7IHJldHVybiB0aGlzLl9mOyB9KTsKKwogZnVuY3Rpb24gZm9v KG8sIHZhbHVlKSB7CiAgICAgby5mID0gdmFsdWU7CiAgICAgcmV0dXJuIG8uZjsKQEAgLTI3LDE3 ICs0NSwzMyBAQCBmdW5jdGlvbiB0ZXN0KG8sIHZhbHVlLCBleHBlY3RlZENvdW50KSB7CiAgICAg ICAgIHRocm93IG5ldyBFcnJvcigiQmFkIGNvdW50ZXIgdmFsdWU6ICIgKyBjb3VudGVyKTsKIH0K IAotZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkgewotICAgIHRlc3QobmV3IENvbnMx KCksIGksIGNvdW50ZXIpOwotICAgIHRlc3QobmV3IENvbnMyKCksIGksIGNvdW50ZXIgKyAxKTsK LSAgICAKLSAgICB2YXIgbyA9IHt9OwotICAgIG8uX19kZWZpbmVTZXR0ZXJfXygiZiIsIGZ1bmN0 aW9uKHZhbHVlKSB7Ci0gICAgICAgIHRoaXMuX2YgPSB2YWx1ZTsKLSAgICAgICAgY291bnRlcisr OwotICAgIH0pOwotICAgIG8uX19kZWZpbmVHZXR0ZXJfXygiZiIsIGZ1bmN0aW9uKCkgeyByZXR1 cm4gdGhpcy5fZjsgfSk7Ci0gICAgdGVzdChvLCBpLCBjb3VudGVyICsgMSk7CitmdW5jdGlvbiBy dW5UZXN0V2l0aENvbnN0cnVjdG9ycyhjb25zdHJ1Y3RvcjEsIGNvbnN0cnVjdG9yMikgeworICAg IGZvciAodmFyIGkgPSAwOyBpIDwgNTAwMDsgKytpKSB7CisgICAgICAgIHRlc3QobmV3IGNvbnN0 cnVjdG9yMSgpLCBpLCBjb3VudGVyKTsKKyAgICAgICAgdGVzdChuZXcgY29uc3RydWN0b3IyKCks IGksIGNvdW50ZXIgKyAxKTsKKworICAgICAgICB2YXIgbyA9IHt9OworICAgICAgICBvLl9fZGVm aW5lR2V0dGVyX18oImYiLCBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIGNvdW50ZXIrKzsKKyAg ICAgICAgICAgIHJldHVybiA4NDsKKyAgICAgICAgfSk7CisgICAgICAgIHRlc3QobywgODQsIGNv dW50ZXIgKyAxKTsKKworICAgICAgICB2YXIgbyA9IHt9OworICAgICAgICBvLl9fZGVmaW5lU2V0 dGVyX18oImYiLCBmdW5jdGlvbih2YWx1ZSkgeworICAgICAgICAgICAgdGhpcy5fZiA9IHZhbHVl OworICAgICAgICAgICAgY291bnRlcisrOworICAgICAgICB9KTsKKyAgICAgICAgby5fX2RlZmlu ZUdldHRlcl9fKCJmIiwgZnVuY3Rpb24oKSB7IHJldHVybiB0aGlzLl9mOyB9KTsKKyAgICAgICAg dGVzdChvLCBpLCBjb3VudGVyICsgMSk7CisKKyAgICAgICAgdGVzdCh7ZjogNDJ9LCBpLCBjb3Vu dGVyKTsKKyAgICB9Cit9CiAKLSAgICB0ZXN0KHtmOiA0Mn0sIGksIGNvdW50ZXIpOworZm9yICh2 YXIgaSA9IDA7IGkgPCAyOyArK2kpIHsKKyAgICBydW5UZXN0V2l0aENvbnN0cnVjdG9ycyhDb25z MSwgQ29uczIpOworICAgIHJ1blRlc3RXaXRoQ29uc3RydWN0b3JzKENvbnMzLCBDb25zMik7Cisg ICAgcnVuVGVzdFdpdGhDb25zdHJ1Y3RvcnMoQ29uczEsIENvbnM0KTsKKyAgICBydW5UZXN0V2l0 aENvbnN0cnVjdG9ycyhDb25zMywgQ29uczQpOwogfQo=