145577 2015-06-02 16:17:56 -0700 [CoordinatedGraphics] Refactor TiledBackingStoreClient 2015-06-02 20:40:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cmarcelo commit-queue kondapallykalyan lucas.de.marchi luiz noam oldest_to_newest 1098959 0 ryuan.choi 2015-06-02 16:17:56 -0700 TiledBackingStoreClient has some unnecessary virtual methods. 1098961 1 254121 ryuan.choi 2015-06-02 16:23:18 -0700 Created attachment 254121 Patch 1099011 2 254121 gyuyoung.kim 2015-06-02 18:51:39 -0700 Comment on attachment 254121 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254121&action=review LGTM. However it would be nicer if you write description more detailed as I comment. > Source/WebCore/ChangeLog:13 > + (WebCore::CoordinatedGraphicsLayer::didUpdateTileBuffers): Please add "Added" for didUpdateTileBuffers(). > Source/WebCore/ChangeLog:16 > + (WebCore::CoordinatedGraphicsLayer::tiledBackingStoreBackgroundColor): Deleted. It would be good if you write that "tiledBackingStoreBackgroundColor() is not used anywhere." > Source/WebCore/ChangeLog:19 > + (WebCore::CoordinatedTile::updateBackBuffer): Please write what is changed and why do you modify. 1099027 3 ryuan.choi 2015-06-02 20:39:55 -0700 Committed r185140: <http://trac.webkit.org/changeset/185140> 1099028 4 254121 ryuan.choi 2015-06-02 20:40:49 -0700 Comment on attachment 254121 Patch clearing flags. Thanks, I added more commentes and landed manually. 254121 2015-06-02 16:23:18 -0700 2015-06-02 20:40:49 -0700 Patch bug-145577-20150603082255.patch text/plain 11067 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVkMzhmNTkwZTc3M2Uw NDhhM2IyMTNjZWViNWYwNjRkM2MzYzU3Mi4uNjhlYmM4MjJmNDI2YWI4YWMxODc5YWM2ZmQ0Mjgy OTA2MDg1ZjA0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE1LTA2LTAyICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtDb29yZGluYXRl ZEdyYXBoaWNzXSBSZWZhY3RvciBUaWxlZEJhY2tpbmdTdG9yZUNsaWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NTc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIGFu ZCBzaW1wbGlmaWVzIHVubmVjZXNzYXJ5IHZpcnR1YWwgbWV0aG9kcyBvZiBUaWxlZEJhY2tpbmdT dG9yZUNsaWVudC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZXMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRp bmF0ZWRHcmFwaGljc0xheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVkR3Jh cGhpY3NMYXllcjo6ZGlkVXBkYXRlVGlsZUJ1ZmZlcnMpOgorICAgICAgICAoV2ViQ29yZTo6Q29v cmRpbmF0ZWRHcmFwaGljc0xheWVyOjp0aWxlZEJhY2tpbmdTdG9yZVBhaW50QmVnaW4pOiBEZWxl dGVkLgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjp0aWxlZEJh Y2tpbmdTdG9yZVBhaW50RW5kKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5h dGVkR3JhcGhpY3NMYXllcjo6dGlsZWRCYWNraW5nU3RvcmVCYWNrZ3JvdW5kQ29sb3IpOiBEZWxl dGVkLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29y ZGluYXRlZEdyYXBoaWNzTGF5ZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXht YXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRUaWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNv b3JkaW5hdGVkVGlsZTo6dXBkYXRlQmFja0J1ZmZlcik6CisgICAgICAgIChXZWJDb3JlOjpDb29y ZGluYXRlZFRpbGU6OnN3YXBCYWNrQnVmZmVyVG9Gcm9udCk6IERlbGV0ZWQuCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkVGlsZS5oOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlLmg6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2lu Z1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkQmFja2luZ1N0b3JlOjp1cGRhdGVU aWxlQnVmZmVycyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5h dGVkL1RpbGVkQmFja2luZ1N0b3JlQ2xpZW50Lmg6CisKIDIwMTUtMDUtMzEgIERhbiBCZXJuc3Rl aW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgUGFudGhlciBzdXBwb3J0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRp bmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIu Y3BwCmluZGV4IDYxZTZhNjQ1NmFkZTdmMGExMGQxZDQ3YmQ3ZDg2OGE3MjcxZTdhYzIuLjYxOGQ4 YmI0M2Q0N2EwZGVmZDYyOTNlNzlkNDA1ZjdkMTZiYmM4YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdy YXBoaWNzTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCkBAIC04MjYsMTAg KzgyNiw2IEBAIHZvaWQgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpyZWxlYXNlSW1hZ2VCYWNr aW5nSWZOZWVkZWQoKQogICAgIG1fbGF5ZXJTdGF0ZS5pbWFnZUNoYW5nZWQgPSB0cnVlOwogfQog Ci12b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6dGlsZWRCYWNraW5nU3RvcmVQYWludEJl Z2luKCkKLXsKLX0KLQogQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKiBDb29yZGluYXRlZEdyYXBo aWNzTGF5ZXI6OmZpbmRGaXJzdERlc2NlbmRhbnRXaXRoQ29udGVudHNSZWN1cnNpdmVseSgpCiB7 CiAgICAgaWYgKHNob3VsZEhhdmVCYWNraW5nU3RvcmUoKSkKQEAgLTg5NCw5ICs4OTAsOSBAQCB2 b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6dGlsZWRCYWNraW5nU3RvcmVQYWludChHcmFw aGljc0NvbnRleHQqIGNvbnRleHQsCiAgICAgcGFpbnRHcmFwaGljc0xheWVyQ29udGVudHMoKmNv bnRleHQsIHJlY3QpOwogfQogCi12b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6dGlsZWRC YWNraW5nU3RvcmVQYWludEVuZChjb25zdCBWZWN0b3I8SW50UmVjdD4mIHVwZGF0ZWRSZWN0cykK K3ZvaWQgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpkaWRVcGRhdGVUaWxlQnVmZmVycygpCiB7 Ci0gICAgaWYgKCFpc1Nob3dpbmdSZXBhaW50Q291bnRlcigpIHx8IHVwZGF0ZWRSZWN0cy5pc0Vt cHR5KCkpCisgICAgaWYgKCFpc1Nob3dpbmdSZXBhaW50Q291bnRlcigpKQogICAgICAgICByZXR1 cm47CiAKICAgICBtX2xheWVyU3RhdGUucmVwYWludENvdW50ID0gaW5jcmVtZW50UmVwYWludENv dW50KCk7CkBAIC05NDIsMTEgKzkzOCw2IEBAIEludFJlY3QgQ29vcmRpbmF0ZWRHcmFwaGljc0xh eWVyOjp0aWxlZEJhY2tpbmdTdG9yZVZpc2libGVSZWN0KCkKICAgICByZXR1cm4gZW5jbG9zaW5n SW50UmVjdChyZWN0KTsKIH0KIAotQ29sb3IgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjp0aWxl ZEJhY2tpbmdTdG9yZUJhY2tncm91bmRDb2xvcigpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGNvbnRl bnRzT3BhcXVlKCkgPyBDb2xvcjo6d2hpdGUgOiBDb2xvcjo6dHJhbnNwYXJlbnQ7Ci19Ci0KIGJv b2wgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpwYWludFRvU3VyZmFjZShjb25zdCBJbnRTaXpl JiBzaXplLCB1aW50MzJfdCYgYXRsYXMsIEludFBvaW50JiBvZmZzZXQsIENvb3JkaW5hdGVkU3Vy ZmFjZTo6Q2xpZW50KiBjbGllbnQpCiB7CiAgICAgQVNTRVJUKG1fY29vcmRpbmF0b3IpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5h dGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oCmlu ZGV4IDlkYTEyYzZjZmJjMmUzYzgwOTM2Zjc1MDVmYzUyZjY3NjMxYWQzZDIuLjkxN2JhZmRiMzky MTM1MWJjNDNhMzViMWU2MWE5ZjRiMmFkMDdhOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNz TGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29v cmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmgKQEAgLTEyNywxMyArMTI3LDExIEBA IHB1YmxpYzoKICAgICBJbnRSZWN0IGNvdmVyUmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fbWFpbkJh Y2tpbmdTdG9yZSA/IG1fbWFpbkJhY2tpbmdTdG9yZS0+bWFwVG9Db250ZW50cyhtX21haW5CYWNr aW5nU3RvcmUtPmNvdmVyUmVjdCgpKSA6IEludFJlY3QoKTsgfQogCiAgICAgLy8gVGlsZWRCYWNr aW5nU3RvcmVDbGllbnQKLSAgICB2aXJ0dWFsIHZvaWQgdGlsZWRCYWNraW5nU3RvcmVQYWludEJl Z2luKCkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIHRpbGVkQmFja2luZ1N0b3JlUGFpbnQo R3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYpIG92ZXJyaWRlOwotICAgIHZpcnR1YWwg dm9pZCB0aWxlZEJhY2tpbmdTdG9yZVBhaW50RW5kKGNvbnN0IFZlY3RvcjxJbnRSZWN0PiYgcGFp bnRlZEFyZWEpIG92ZXJyaWRlOworICAgIHZpcnR1YWwgdm9pZCBkaWRVcGRhdGVUaWxlQnVmZmVy cygpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCB0aWxlZEJhY2tpbmdTdG9yZUhhc1BlbmRp bmdUaWxlQ3JlYXRpb24oKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIEludFJlY3QgdGlsZWRCYWNr aW5nU3RvcmVDb250ZW50c1JlY3QoKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIEludFJlY3QgdGls ZWRCYWNraW5nU3RvcmVWaXNpYmxlUmVjdCgpIG92ZXJyaWRlOwotICAgIHZpcnR1YWwgQ29sb3Ig dGlsZWRCYWNraW5nU3RvcmVCYWNrZ3JvdW5kQ29sb3IoKSBjb25zdCBvdmVycmlkZTsKICAgICB2 aXJ0dWFsIHZvaWQgY3JlYXRlVGlsZSh1aW50MzJfdCB0aWxlSUQsIGZsb2F0KSBvdmVycmlkZTsK ICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlVGlsZSh1aW50MzJfdCB0aWxlSUQsIGNvbnN0IFN1cmZh Y2VVcGRhdGVJbmZvJiwgY29uc3QgSW50UmVjdCYpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9p ZCByZW1vdmVUaWxlKHVpbnQzMl90IHRpbGVJRCkgb3ZlcnJpZGU7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0 ZWRUaWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29y ZGluYXRlZC9Db29yZGluYXRlZFRpbGUuY3BwCmluZGV4IGQwMWEzYzFkYmRhN2FlYTM1ZWY5NGIz NjJiZWE5YzllYjViNjViNzYuLjRiOTAyMmMzZjVhMTUwZDVkNjEyODdkMmIyOGM2ZjI2NmU2Njky OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9j b29yZGluYXRlZC9Db29yZGluYXRlZFRpbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZFRpbGUuY3BwCkBAIC03 MSwxNSArNzEsMTUgQEAgdm9pZCBDb29yZGluYXRlZFRpbGU6OmludmFsaWRhdGUoY29uc3QgSW50 UmVjdCYgZGlydHlSZWN0KQogICAgIG1fZGlydHlSZWN0LnVuaXRlKHRpbGVEaXJ0eVJlY3QpOwog fQogCi1WZWN0b3I8SW50UmVjdD4gQ29vcmRpbmF0ZWRUaWxlOjp1cGRhdGVCYWNrQnVmZmVyKCkK K2Jvb2wgQ29vcmRpbmF0ZWRUaWxlOjp1cGRhdGVCYWNrQnVmZmVyKCkKIHsKICAgICBpZiAoIWlz RGlydHkoKSkKLSAgICAgICAgcmV0dXJuIFZlY3RvcjxJbnRSZWN0PigpOworICAgICAgICByZXR1 cm4gZmFsc2U7CiAKICAgICBTdXJmYWNlVXBkYXRlSW5mbyB1cGRhdGVJbmZvOwogCiAgICAgaWYg KCFtX3RpbGVkQmFja2luZ1N0b3JlLT5jbGllbnQoKS0+cGFpbnRUb1N1cmZhY2UobV9kaXJ0eVJl Y3Quc2l6ZSgpLCB1cGRhdGVJbmZvLmF0bGFzSUQsIHVwZGF0ZUluZm8uc3VyZmFjZU9mZnNldCwg dGhpcykpCi0gICAgICAgIHJldHVybiBWZWN0b3I8SW50UmVjdD4oKTsKKyAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAgICAgdXBkYXRlSW5mby51cGRhdGVSZWN0ID0gbV9kaXJ0eVJlY3Q7CiAgICAg dXBkYXRlSW5mby51cGRhdGVSZWN0Lm1vdmUoLW1fcmVjdC54KCksIC1tX3JlY3QueSgpKTsKQEAg LTk0LDEwICs5NCw5IEBAIFZlY3RvcjxJbnRSZWN0PiBDb29yZGluYXRlZFRpbGU6OnVwZGF0ZUJh Y2tCdWZmZXIoKQogICAgIH0KICAgICBtX3RpbGVkQmFja2luZ1N0b3JlLT5jbGllbnQoKS0+dXBk YXRlVGlsZShtX0lELCB1cGRhdGVJbmZvLCBtX3JlY3QpOwogCi0gICAgVmVjdG9yPEludFJlY3Q+ IHVwZGF0ZWRSZWN0czsKLSAgICB1cGRhdGVkUmVjdHMuYXBwZW5kKG1fZGlydHlSZWN0KTsKICAg ICBtX2RpcnR5UmVjdCA9IEludFJlY3QoKTsKLSAgICByZXR1cm4gdXBkYXRlZFJlY3RzOworCisg ICAgcmV0dXJuIHRydWU7CiB9CiAKIHZvaWQgQ29vcmRpbmF0ZWRUaWxlOjpwYWludFRvU3VyZmFj ZUNvbnRleHQoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0KQpAQCAtMTA3LDExICsxMDYsNiBAQCB2 b2lkIENvb3JkaW5hdGVkVGlsZTo6cGFpbnRUb1N1cmZhY2VDb250ZXh0KEdyYXBoaWNzQ29udGV4 dCogY29udGV4dCkKICAgICBtX3RpbGVkQmFja2luZ1N0b3JlLT5jbGllbnQoKS0+dGlsZWRCYWNr aW5nU3RvcmVQYWludChjb250ZXh0LCBtX3RpbGVkQmFja2luZ1N0b3JlLT5tYXBUb0NvbnRlbnRz KG1fZGlydHlSZWN0KSk7CiB9CiAKLXZvaWQgQ29vcmRpbmF0ZWRUaWxlOjpzd2FwQmFja0J1ZmZl clRvRnJvbnQoKQotewotICAgIC8vIEhhbmRsZWQgYnkgdGlsZWRCYWNraW5nU3RvcmVQYWludEVu ZC4KLX0KLQogYm9vbCBDb29yZGluYXRlZFRpbGU6OmlzUmVhZHlUb1BhaW50KCkgY29uc3QKIHsK ICAgICByZXR1cm4gbV9JRCAhPSBJbnZhbGlkQ29vcmRpbmF0ZWRUaWxlSUQ7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29v cmRpbmF0ZWRUaWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv Y29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRUaWxlLmgKaW5kZXggYzI1MTJhMTZmNjk0MjFhODJmOGIy NDM4ZTM2MDk4N2JmN2IyNTQzOC4uOWE4MGU5YTMzYjI5MjFmY2M4YWRhZDQ0MmFhZmJlZGI3OGQ3 NmY2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkVGlsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZFRpbGUuaApAQCAtNDYs OCArNDYsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIGlzRGlydHkoKSBjb25zdDsKICAgICB2b2lk IGludmFsaWRhdGUoY29uc3QgSW50UmVjdCYpOwotICAgIFZlY3RvcjxJbnRSZWN0PiB1cGRhdGVC YWNrQnVmZmVyKCk7Ci0gICAgdm9pZCBzd2FwQmFja0J1ZmZlclRvRnJvbnQoKTsKKyAgICBib29s IHVwZGF0ZUJhY2tCdWZmZXIoKTsKICAgICBib29sIGlzUmVhZHlUb1BhaW50KCkgY29uc3Q7CiAg ICAgdm9pZCBwYWludChHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0Jik7CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRl ZC9UaWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRp bmF0ZWQvVGlsZS5oCmluZGV4IGUxYjliMGQ5Y2Q1ZGJiMWZjOGI5YmI4NWY2YmFkZjFiZmUxYWQ5 YTguLjk0ZTUxZDRiOGVjMjY3YjUwMWFhNjFjMTQyMTVjYjBlZWQ5NDIwOGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5h dGVkL1RpbGUuaApAQCAtNDAsOCArNDAsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIGJvb2wg aXNEaXJ0eSgpIGNvbnN0ID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgaW52YWxpZGF0ZShjb25zdCBJ bnRSZWN0JikgPSAwOwotICAgIHZpcnR1YWwgVmVjdG9yPEludFJlY3Q+IHVwZGF0ZUJhY2tCdWZm ZXIoKSA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIHN3YXBCYWNrQnVmZmVyVG9Gcm9udCgpID0gMDsK KyAgICB2aXJ0dWFsIGJvb2wgdXBkYXRlQmFja0J1ZmZlcigpID0gMDsKICAgICB2aXJ0dWFsIGJv b2wgaXNSZWFkeVRvUGFpbnQoKSBjb25zdCA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHBhaW50KEdy YXBoaWNzQ29udGV4dCosIGNvbnN0IEludFJlY3QmKSA9IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlZEJhY2tp bmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29v cmRpbmF0ZWQvVGlsZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4IGIxMzlmNDU1YzRjN2I1Y2EyYzY0 ZDhmZDJiZGM1YTc0MDJjMTY0YjIuLjE1NzQ5OTE3ZDcyZjlmZmJmYTZhMzZhZTA5YmM4YTY2NDQ1 OTA1YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9jb29yZGluYXRlZC9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmNw cApAQCAtOTcsMzIgKzk3LDI1IEBAIHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6OmludmFsaWRhdGUo Y29uc3QgSW50UmVjdCYgY29udGVudHNEaXJ0eVJlY3QpCiAKIHZvaWQgVGlsZWRCYWNraW5nU3Rv cmU6OnVwZGF0ZVRpbGVCdWZmZXJzKCkKIHsKLSAgICBtX2NsaWVudC0+dGlsZWRCYWNraW5nU3Rv cmVQYWludEJlZ2luKCk7Ci0KLSAgICBWZWN0b3I8SW50UmVjdD4gcGFpbnRlZEFyZWE7Ci0gICAg VmVjdG9yPFJlZlB0cjxUaWxlPiA+IGRpcnR5VGlsZXM7CisgICAgVmVjdG9yPFJlZlB0cjxUaWxl Pj4gZGlydHlUaWxlczsKICAgICBmb3IgKGF1dG8mIHRpbGUgOiBtX3RpbGVzLnZhbHVlcygpKSB7 CiAgICAgICAgIGlmICghdGlsZS0+aXNEaXJ0eSgpKQogICAgICAgICAgICAgY29udGludWU7CiAg ICAgICAgIGRpcnR5VGlsZXMuYXBwZW5kKHRpbGUpOwogICAgIH0KIAotICAgIGlmIChkaXJ0eVRp bGVzLmlzRW1wdHkoKSkgewotICAgICAgICBtX2NsaWVudC0+dGlsZWRCYWNraW5nU3RvcmVQYWlu dEVuZChwYWludGVkQXJlYSk7CisgICAgaWYgKGRpcnR5VGlsZXMuaXNFbXB0eSgpKQogICAgICAg ICByZXR1cm47Ci0gICAgfQogCiAgICAgLy8gRklYTUU6IEluIHNpbmdsZSB0aHJlYWRlZCBjYXNl LCB0aWxlIGJhY2sgYnVmZmVycyBjb3VsZCBiZSB1cGRhdGVkIGFzeW5jaHJvbm91c2x5IAogICAg IC8vIG9uZSBieSBvbmUgYW5kIHRoZW4gc3dhcHBlZCB0byBmcm9udCBpbiBvbmUgZ28uIFRoaXMg d291bGQgbWluaW1pemUgdGhlIHRpbWUgc3BlbnQKICAgICAvLyBibG9ja2luZyBvbiB0aWxlIHVw ZGF0ZXMuCi0gICAgdW5zaWduZWQgc2l6ZSA9IGRpcnR5VGlsZXMuc2l6ZSgpOwotICAgIGZvciAo dW5zaWduZWQgbiA9IDA7IG4gPCBzaXplOyArK24pIHsKLSAgICAgICAgVmVjdG9yPEludFJlY3Q+ IHBhaW50ZWRSZWN0cyA9IGRpcnR5VGlsZXNbbl0tPnVwZGF0ZUJhY2tCdWZmZXIoKTsKLSAgICAg ICAgcGFpbnRlZEFyZWEuYXBwZW5kVmVjdG9yKHBhaW50ZWRSZWN0cyk7Ci0gICAgICAgIGRpcnR5 VGlsZXNbbl0tPnN3YXBCYWNrQnVmZmVyVG9Gcm9udCgpOwotICAgIH0KKyAgICBib29sIHVwZGF0 ZWQgPSBmYWxzZTsKKyAgICBmb3IgKGF1dG8mIHRpbGUgOiBkaXJ0eVRpbGVzKQorICAgICAgICB1 cGRhdGVkIHw9IHRpbGUtPnVwZGF0ZUJhY2tCdWZmZXIoKTsKIAotICAgIG1fY2xpZW50LT50aWxl ZEJhY2tpbmdTdG9yZVBhaW50RW5kKHBhaW50ZWRBcmVhKTsKKyAgICBpZiAodXBkYXRlZCkKKyAg ICAgICAgbV9jbGllbnQtPmRpZFVwZGF0ZVRpbGVCdWZmZXJzKCk7CiB9CiAKIEludFJlY3QgVGls ZWRCYWNraW5nU3RvcmU6OnZpc2libGVSZWN0KCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlZEJhY2tpbmdT dG9yZUNsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nv b3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlQ2xpZW50LmgKaW5kZXggZDExNjE2YzMzZTM2YzFk OTQ2MjY0NjYyYzViNTNjODA5YzI1MzlmOC4uYWU5NDUxZmI2MGU5YWI4ODI3ZmM2NmFmNDgxYWNk NjliODQxOTc3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlQ2xpZW50LmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2lu Z1N0b3JlQ2xpZW50LmgKQEAgLTMzLDEzICszMywxMSBAQCBjbGFzcyBTdXJmYWNlVXBkYXRlSW5m bzsKIGNsYXNzIFRpbGVkQmFja2luZ1N0b3JlQ2xpZW50IHsKIHB1YmxpYzoKICAgICB2aXJ0dWFs IH5UaWxlZEJhY2tpbmdTdG9yZUNsaWVudCgpIHsgfQotICAgIHZpcnR1YWwgdm9pZCB0aWxlZEJh Y2tpbmdTdG9yZVBhaW50QmVnaW4oKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHRpbGVkQmFja2lu Z1N0b3JlUGFpbnQoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYpID0gMDsKLSAgICB2 aXJ0dWFsIHZvaWQgdGlsZWRCYWNraW5nU3RvcmVQYWludEVuZChjb25zdCBWZWN0b3I8SW50UmVj dD4mIHBhaW50ZWRBcmVhKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIGRpZFVwZGF0ZVRpbGVCdWZm ZXJzKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCB0aWxlZEJhY2tpbmdTdG9yZUhhc1BlbmRpbmdU aWxlQ3JlYXRpb24oKSB7IH0KICAgICB2aXJ0dWFsIEludFJlY3QgdGlsZWRCYWNraW5nU3RvcmVD b250ZW50c1JlY3QoKSA9IDA7CiAgICAgdmlydHVhbCBJbnRSZWN0IHRpbGVkQmFja2luZ1N0b3Jl VmlzaWJsZVJlY3QoKSA9IDA7Ci0gICAgdmlydHVhbCBDb2xvciB0aWxlZEJhY2tpbmdTdG9yZUJh Y2tncm91bmRDb2xvcigpIGNvbnN0ID0gMDsKIAogICAgIHZpcnR1YWwgdm9pZCBjcmVhdGVUaWxl KHVpbnQzMl90IHRpbGVJRCwgZmxvYXQpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlVGls ZSh1aW50MzJfdCB0aWxlSUQsIGNvbnN0IFN1cmZhY2VVcGRhdGVJbmZvJiwgY29uc3QgSW50UmVj dCYpID0gMDsK