145575 2015-06-02 15:18:48 -0700 MediaSessions should keep track of their current state 2015-06-02 17:45:29 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned commit-queue conrad_shultz eric.carlson jer.noble mrajca webkit-bug-importer oldest_to_newest 1098932 0 mrajca 2015-06-02 15:18:48 -0700 Per the Media Session spec, each Media Session has a current state, which is 'Idle' at the time of construction. 1098935 1 webkit-bug-importer 2015-06-02 15:19:28 -0700 <rdar://problem/21210114> 1098939 2 254113 mrajca 2015-06-02 15:33:19 -0700 Created attachment 254113 Patch 1098945 3 254113 conrad_shultz 2015-06-02 15:41:39 -0700 Comment on attachment 254113 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254113&action=review > Source/WebCore/Modules/mediasession/MediaSession.h:55 > + }; Will this state eventually be exposed publicly? If so, should this start out outside the private section? 1098949 4 254113 mrajca 2015-06-02 15:44:21 -0700 Comment on attachment 254113 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254113&action=review >> Source/WebCore/Modules/mediasession/MediaSession.h:55 >> + }; > > Will this state eventually be exposed publicly? If so, should this start out outside the private section? This state is not exposed in the MediaSession IDL "interface" file, so we should keep it private until we actually need to access it outside of the Media Session itself. 1098958 5 254113 achristensen 2015-06-02 16:03:19 -0700 Comment on attachment 254113 Patch This is good, but I think it should be included with some changes that actually use it. 1098986 6 254113 commit-queue 2015-06-02 17:45:25 -0700 Comment on attachment 254113 Patch Clearing flags on attachment: 254113 Committed r185136: <http://trac.webkit.org/changeset/185136> 1098987 7 commit-queue 2015-06-02 17:45:29 -0700 All reviewed patches have been landed. Closing bug. 254113 2015-06-02 15:33:19 -0700 2015-06-02 17:45:25 -0700 Patch bug-145575-20150602153259.patch text/plain 1370 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJlNWI0NTM2OTJhZDdi MDAyYWY4YTFjMDhhMjk2ZGNiOTkzYTI2Ni4uODE3ZmNlNDU3MmUzY2ZiMGU0NTVjYjgxNDhkNTVk Mzk1YjQ4MGRhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA2LTAyICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYVNlc3Npb25zIHNob3Vs ZCBrZWVwIHRyYWNrIG9mIHRoZWlyIGN1cnJlbnQgc3RhdGUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1NzUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlh U2Vzc2lvbi5oOiBQZXIgdGhlIE1lZGlhIFNlc3Npb24gc3BlYywgdGhlIHN0YXRlIGNhbiBiZSAn SWRsZScsICdBY3RpdmUnLCBvcgorICAgICAgICAgICdJbnRlcnJ1cHRlZCcuIFNlc3Npb25zIGFy ZSBjcmVhdGVkIGluIGFuICdJZGxlJyBzdGF0ZS4KKwogMjAxNS0wNi0wMiAgRGVhbiBKYWNrc29u ICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gR3JhcGhpY3NDb250ZXh0M0Q6 OmdldEludGVybmFsRnJhbWVidWZmZXJTaXplCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oCmluZGV4IDQ0MDE3OGMyOGQ4ZWY0ZjIxMTlk NGIxNTRiMTM5NmNiMzViMjNmYjYuLmJmZDE0MGRhMTRhYjA0NDBhNzNkOWUzOTU4ZGZlZmE1NmE3 NzYzYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01l ZGlhU2Vzc2lvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01l ZGlhU2Vzc2lvbi5oCkBAIC00OCw2ICs0OCwxNCBAQCBwdWJsaWM6CiAgICAgdm9pZCByZWxlYXNl U2Vzc2lvbigpOwogCiBwcml2YXRlOgorICAgIGVudW0gY2xhc3MgU3RhdGUgeworICAgICAgICBJ ZGxlLAorICAgICAgICBBY3RpdmUsCisgICAgICAgIEludGVycnVwdGVkCisgICAgfTsKKworICAg IFN0YXRlIG1fY3VycmVudFN0YXRlIHsgU3RhdGU6OklkbGUgfTsKKwogICAgIGNvbnN0IFN0cmlu ZyBtX2tpbmQ7CiAgICAgUmVmUHRyPE1lZGlhUmVtb3RlQ29udHJvbHM+IG1fY29udHJvbHM7CiB9 Owo=