145573 2015-06-02 15:15:40 -0700 No need to guard the sizes attribute against PICTURE_SIZES 2015-06-12 09:39:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino commit-queue darin dino esprehn+autocc gyuyoung.kim mmaxfield ossy webkit-bug-importer yoav zalan oldest_to_newest 1098925 0 dino 2015-06-02 15:15:40 -0700 No need to guard the sizes attribute against PICTURE_SIZES 1098927 1 webkit-bug-importer 2015-06-02 15:16:45 -0700 <rdar://problem/21210038> 1098931 2 254111 dino 2015-06-02 15:18:09 -0700 Created attachment 254111 Patch 1098937 3 dino 2015-06-02 15:31:31 -0700 Committed r185130: <http://trac.webkit.org/changeset/185130> 1098938 4 254111 mmaxfield 2015-06-02 15:31:44 -0700 Comment on attachment 254111 Patch rs=me 1099248 5 254111 darin 2015-06-03 13:34:59 -0700 Comment on attachment 254111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254111&action=review > Source/WebCore/ChangeLog:10 > + The PICTURE_SIZES feature flag doesn't need to be used to > + guard preloading of the sizes attribute. I guess this should be obvious to me, but why? 1099254 6 yoav 2015-06-03 13:42:10 -0700 The PICTURE_SIZES guard was put back in just on the currentSrc attribute implementation, due to https://bugs.webkit.org/show_bug.cgi?id=144095 and the fact that we'd have to remove currentSrc support unless the high-profile sites that use the old polyfill will update it soon. Since the issue only involves the currentSrc attribute, the flag should only guard its implementation, and not the sizes attribute (despite the flag's name - it retained the name of the old flag, that guarded the entire feature). 1099257 7 darin 2015-06-03 13:48:03 -0700 OK. We should rename the flag unless it’s going away soon. 1101554 8 ossy 2015-06-12 04:53:39 -0700 (In reply to comment #3) > Committed r185130: <http://trac.webkit.org/changeset/185130> This change broke the !ENABLE(PICTURE_SIZES) build: ./../Source/WebCore/html/parser/HTMLPreloadScanner.cpp: In member function 'void WebCore::TokenPreloadScanner::StartTagScanner::processAttributes(const AttributeList&, WebCore::Document&)': ../../Source/WebCore/html/parser/HTMLPreloadScanner.cpp:115:46: error: 'm_sizesAttribute' was not declared in this scope ../../Source/WebCore/html/parser/HTMLPreloadScanner.cpp: In member function 'void WebCore::TokenPreloadScanner::StartTagScanner::processAttribute(const NameType&, const WTF::String&)': ../../Source/WebCore/html/parser/HTMLPreloadScanner.cpp:154:57: error: 'm_sizesAttribute' was not declared in this scope Could you check and fix the build? 1101560 9 yoav 2015-06-12 05:14:58 -0700 Took also the m_sizesAttribute definition from behind the guard at https://bugs.webkit.org/show_bug.cgi?id=145926 I believe it should do the trick. 1101562 10 ossy 2015-06-12 05:17:29 -0700 (In reply to comment #9) > Took also the m_sizesAttribute definition from behind the guard at > https://bugs.webkit.org/show_bug.cgi?id=145926 > > I believe it should do the trick. Thanks, I'll check it soon. 1101608 11 zalan 2015-06-12 09:39:08 -0700 Build fix: http://trac.webkit.org/changeset/185501 254111 2015-06-02 15:18:09 -0700 2015-06-02 15:32:00 -0700 Patch bug-145573-20150602151750.patch text/plain 2626 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJlNWI0NTM2OTJhZDdi MDAyYWY4YTFjMDhhMjk2ZGNiOTkzYTI2Ni4uN2I3OTdiMGI3NjBjOGNlOWRhZTgyZGFmY2NiZjM3 YjU5ZTJhODMwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA2LTAyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICBObyBuZWVkIHRvIGd1YXJkIHRo ZSBzaXplcyBhdHRyaWJ1dGUgYWdhaW5zdCBQSUNUVVJFX1NJWkVTIGluIHByZWxvYWQgc2Nhbm5l ci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTU3 MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjEyMTAwMzg+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFBJQ1RVUkVfU0laRVMgZmVhdHVyZSBm bGFnIGRvZXNuJ3QgbmVlZCB0byBiZSB1c2VkIHRvCisgICAgICAgIGd1YXJkIHByZWxvYWRpbmcg b2YgdGhlIHNpemVzIGF0dHJpYnV0ZS4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxQcmVs b2FkU2Nhbm5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUb2tlblByZWxvYWRTY2FubmVyOjpT dGFydFRhZ1NjYW5uZXI6OnByb2Nlc3NBdHRyaWJ1dGVzKTogRGVsZXRlZC4KKyAgICAgICAgKFdl YkNvcmU6OlRva2VuUHJlbG9hZFNjYW5uZXI6OlN0YXJ0VGFnU2Nhbm5lcjo6cHJvY2Vzc0F0dHJp YnV0ZSk6IERlbGV0ZWQuCisKKzIwMTUtMDYtMDIgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUu Y29tPgorCiAgICAgICAgIENyYXNoIGluIEdyYXBoaWNzQ29udGV4dDNEOjpnZXRJbnRlcm5hbEZy YW1lYnVmZmVyU2l6ZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ1NDc5CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjQ2MTA0OD4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxQcmVsb2FkU2Nhbm5lci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MUHJlbG9hZFNjYW5uZXIuY3BwCmluZGV4IGUz ZjFkYTU4ZmI1OGE3NzJhMDBiMGExM2RkN2VmMDNiZDRkNjgzY2MuLjI3NWE5ZDNjNGM3ZTlhNmUz YzEyNzNmNmJlMGNmNTYwMDljMWNkYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv cGFyc2VyL0hUTUxQcmVsb2FkU2Nhbm5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9w YXJzZXIvSFRNTFByZWxvYWRTY2FubmVyLmNwcApAQCAtMTEyLDExICsxMTIsNyBAQCBwdWJsaWM6 CiAgICAgICAgIC8vIFJlc29sdmUgYmV0d2VlbiBzcmMgYW5kIHNyY1NldCBpZiB3ZSBoYXZlIHRo ZW0gYW5kIHRoZSB0YWcgaXMgaW1nLgogICAgICAgICBpZiAobV90YWdJZCA9PSBUYWdJZDo6SW1n ICYmICFtX3NyY1NldEF0dHJpYnV0ZS5pc0VtcHR5KCkpIHsKICAgICAgICAgICAgIGZsb2F0IHNv dXJjZVNpemUgPSAwOwotI2lmIEVOQUJMRShQSUNUVVJFX1NJWkVTKQogICAgICAgICAgICAgc291 cmNlU2l6ZSA9IHBhcnNlU2l6ZXNBdHRyaWJ1dGUobV9zaXplc0F0dHJpYnV0ZSwgZG9jdW1lbnQu cmVuZGVyVmlldygpLCBkb2N1bWVudC5mcmFtZSgpKTsKLSNlbHNlCi0gICAgICAgICAgICBVTlVT RURfUEFSQU0oZG9jdW1lbnQpOwotI2VuZGlmCiAgICAgICAgICAgICBJbWFnZUNhbmRpZGF0ZSBp bWFnZUNhbmRpZGF0ZSA9IGJlc3RGaXRTb3VyY2VGb3JJbWFnZUF0dHJpYnV0ZXMobV9kZXZpY2VT Y2FsZUZhY3RvciwgbV91cmxUb0xvYWQsIG1fc3JjU2V0QXR0cmlidXRlLCBzb3VyY2VTaXplKTsK ICAgICAgICAgICAgIHNldFVybFRvTG9hZChpbWFnZUNhbmRpZGF0ZS5zdHJpbmcudG9TdHJpbmco KSwgdHJ1ZSk7CiAgICAgICAgIH0KQEAgLTE1NSwxMCArMTUxLDggQEAgcHJpdmF0ZToKICAgICAg ICAgICAgICAgICBzZXRVcmxUb0xvYWQoYXR0cmlidXRlVmFsdWUpOwogICAgICAgICAgICAgZWxz ZSBpZiAobWF0Y2goYXR0cmlidXRlTmFtZSwgc3Jjc2V0QXR0cikgJiYgbV9zcmNTZXRBdHRyaWJ1 dGUuaXNOdWxsKCkpCiAgICAgICAgICAgICAgICAgbV9zcmNTZXRBdHRyaWJ1dGUgPSBhdHRyaWJ1 dGVWYWx1ZTsKLSNpZiBFTkFCTEUoUElDVFVSRV9TSVpFUykKICAgICAgICAgICAgIGVsc2UgaWYg KG1hdGNoKGF0dHJpYnV0ZU5hbWUsIHNpemVzQXR0cikgJiYgbV9zaXplc0F0dHJpYnV0ZS5pc051 bGwoKSkKICAgICAgICAgICAgICAgICBtX3NpemVzQXR0cmlidXRlID0gYXR0cmlidXRlVmFsdWU7 Ci0jZW5kaWYKICAgICAgICAgICAgIGVsc2UgaWYgKG1hdGNoKGF0dHJpYnV0ZU5hbWUsIGNyb3Nz b3JpZ2luQXR0cikgJiYgIWF0dHJpYnV0ZVZhbHVlLmlzTnVsbCgpKQogICAgICAgICAgICAgICAg IG1fY3Jvc3NPcmlnaW5Nb2RlID0gc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVE1MU3BhY2VzKGF0 dHJpYnV0ZVZhbHVlKTsKICAgICAgICAgfSBlbHNlIGlmIChtX3RhZ0lkID09IFRhZ0lkOjpMaW5r KSB7Cg==