145562 2015-06-02 13:06:03 -0700 Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text 2015-06-02 16:56:42 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1098850 0 mattbaker 2015-06-02 13:06:03 -0700 * SUMMARY Shift + Cmd + Left/Right shouldn't switch tabs while editing text. * STEPS TO REPRODUCE 1. Open multiple Inspector tabs 2. Enter some text in any Inspector text field (Search, filter bar, etc) 3. Make sure text field has the focus, hit shift + cmd + left/right to select text. => Tab switch occurs instead of text selection. 1098851 1 webkit-bug-importer 2015-06-02 13:06:26 -0700 <rdar://problem/21207109> 1098884 2 joepeck 2015-06-02 13:48:27 -0700 Ahh, this wasn't reproducing for me in CodeMirror editors, like the quick console, but I failed to test in a generic textfield, like the filter bars and search fields. 1098889 3 254099 joepeck 2015-06-02 14:10:26 -0700 Created attachment 254099 [PATCH] Proposed Fix 1098970 4 254099 commit-queue 2015-06-02 16:56:37 -0700 Comment on attachment 254099 [PATCH] Proposed Fix Clearing flags on attachment: 254099 Committed r185134: <http://trac.webkit.org/changeset/185134> 1098971 5 commit-queue 2015-06-02 16:56:42 -0700 All reviewed patches have been landed. Closing bug. 254099 2015-06-02 14:10:26 -0700 2015-06-02 16:56:37 -0700 [PATCH] Proposed Fix editable.patch text/plain 4240 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBmYjg1NGIuLjFlMGNmZmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE1LTA2LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2hpZnQg KyBDbWQgKyBMZWZ0L1JpZ2h0IHNob3VsZG4ndCBzd2l0Y2ggdGFicyB3aGlsZSBlZGl0aW5nIHRl eHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTU2 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9UYWJCcm93c2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRh YkJyb3dzZXIpOgorICAgICAgICBPbmx5IHRoZXNlIGtleWJvYXJkIHNob3J0Y3V0cyBzaG91bGQg Y2hlY2sgaWYgd2UgYXJlIGluIGFuIGVkaXRhYmxlIGZpZWxkLgorICAgICAgICBSZW1vdmUgdGhl IGltcGxpY2l0IHByZXZlbnQgZGVmYXVsdCBzbyB0aGV5IGNhbiBmYWxsIGJhY2sgdG8gc3lzdGVt IGJlaGF2aW9yCisgICAgICAgIGlmIG5lY2Vzc2FyeS4KKworICAgICAgICAoV2ViSW5zcGVjdG9y LlRhYkJyb3dzZXIucHJvdG90eXBlLl9zaG93TmV4dFRhYkNoZWNraW5nRm9yRWRpdGFibGVGaWVs ZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiQnJvd3Nlci5wcm90b3R5cGUuX3Nob3dQcmV2 aW91c1RhYkNoZWNraW5nRm9yRWRpdGFibGVGaWVsZCk6CisgICAgICAgIEJhaWwgaWYgd2UgYXJl IGluIGFuIGVkaXRhYmxlIGZpZWxkLiBPdGhlcndpc2UgcGVyZm9ybSB0aGUgYWN0aW9uIGFuZCBw cmV2ZW50IGRlZmF1bHQuCisKKzIwMTUtMDYtMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiDijJhGIG5vIGxvbmdlciBicmlu Z3MgdXAgdGhlIGZpbmQtaW4tcGFnZSBiYXIgYWZ0ZXIgdHlwaW5nIGluIHRoZSBxdWljayBjb25z b2xlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1 NDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGFiQnJvd3Nlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RhYkJyb3dzZXIuanMKaW5kZXggNDNkZjY0My4uMjhiYTkzOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQnJvd3Nlci5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCcm93c2VyLmpz CkBAIC01Nyw4ICs1NywxMSBAQCBXZWJJbnNwZWN0b3IuVGFiQnJvd3NlciA9IGNsYXNzIFRhYkJy b3dzZXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgICAgIHRoaXMuX3Nob3dQcmV2 aW91c1RhYktleWJvYXJkU2hvcnRjdXQxID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRy b2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgV2ViSW5z cGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5LkxlZnRDdXJseUJyYWNlLCBzaG93UHJldmlvdXNU YWIpOwogICAgICAgICB0aGlzLl9zaG93TmV4dFRhYktleWJvYXJkU2hvcnRjdXQyID0gbmV3IFdl Ykluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0 Lk1vZGlmaWVyLkNvbnRyb2wsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleS5UYWIs IHNob3dOZXh0VGFiKTsKICAgICAgICAgdGhpcy5fc2hvd1ByZXZpb3VzVGFiS2V5Ym9hcmRTaG9y dGN1dDIgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktl eWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29udHJvbCB8IFdlYkluc3BlY3Rvci5LZXlib2FyZFNo b3J0Y3V0Lk1vZGlmaWVyLlNoaWZ0LCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5LZXku VGFiLCBzaG93UHJldmlvdXNUYWIpOwotICAgICAgICB0aGlzLl9zaG93TmV4dFRhYktleWJvYXJk U2hvcnRjdXQzID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rv ci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wgfCBXZWJJbnNwZWN0 b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQuS2V5LlJpZ2h0LCBzaG93TmV4dFRhYik7Ci0gICAgICAgIHRoaXMuX3Nob3dQcmV2 aW91c1RhYktleWJvYXJkU2hvcnRjdXQzID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRy b2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgV2ViSW5z cGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5LkxlZnQsIHNob3dQcmV2aW91c1RhYik7CisKKyAg ICAgICAgdGhpcy5fc2hvd05leHRUYWJLZXlib2FyZFNob3J0Y3V0MyA9IG5ldyBXZWJJbnNwZWN0 b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmll ci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZp ZXIuU2hpZnQsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleS5SaWdodCwgdGhpcy5f c2hvd05leHRUYWJDaGVja2luZ0ZvckVkaXRhYmxlRmllbGQuYmluZCh0aGlzKSk7CisgICAgICAg IHRoaXMuX3Nob3dOZXh0VGFiS2V5Ym9hcmRTaG9ydGN1dDMuaW1wbGljaXRseVByZXZlbnRzRGVm YXVsdCA9IGZhbHNlOworICAgICAgICB0aGlzLl9zaG93UHJldmlvdXNUYWJLZXlib2FyZFNob3J0 Y3V0MyA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5 Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktl eWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuU2hpZnQsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0LktleS5MZWZ0LCB0aGlzLl9zaG93UHJldmlvdXNUYWJDaGVja2luZ0ZvckVkaXRhYmxlRmll bGQuYmluZCh0aGlzKSk7CisgICAgICAgIHRoaXMuX3Nob3dQcmV2aW91c1RhYktleWJvYXJkU2hv cnRjdXQzLmltcGxpY2l0bHlQcmV2ZW50c0RlZmF1bHQgPSBmYWxzZTsKIAogICAgICAgICB0aGlz Ll90YWJCYXIubmV3VGFiSXRlbSA9IG5ldyBXZWJJbnNwZWN0b3IuVGFiQmFySXRlbSgiSW1hZ2Vz L05ld1RhYlBsdXMuc3ZnIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDcmVhdGUgYSBuZXcgdGFi IiksIHRydWUpOwogCkBAIC0zNTEsNiArMzU0LDI2IEBAIFdlYkluc3BlY3Rvci5UYWJCcm93c2Vy ID0gY2xhc3MgVGFiQnJvd3NlciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICB7CiAg ICAgICAgIHRoaXMuX3RhYkJhci5zZWxlY3ROZXh0VGFiKCk7CiAgICAgfQorCisgICAgX3Nob3dO ZXh0VGFiQ2hlY2tpbmdGb3JFZGl0YWJsZUZpZWxkKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYg KFdlYkluc3BlY3Rvci5pc0V2ZW50VGFyZ2V0QW5FZGl0YWJsZUZpZWxkKGV2ZW50KSkKKyAgICAg ICAgICAgIHJldHVybjsKKworICAgICAgICB0aGlzLl9zaG93TmV4dFRhYihldmVudCk7CisKKyAg ICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAgICB9CisKKyAgICBfc2hvd1ByZXZpb3Vz VGFiQ2hlY2tpbmdGb3JFZGl0YWJsZUZpZWxkKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKFdl Ykluc3BlY3Rvci5pc0V2ZW50VGFyZ2V0QW5FZGl0YWJsZUZpZWxkKGV2ZW50KSkKKyAgICAgICAg ICAgIHJldHVybjsKKworICAgICAgICB0aGlzLl9zaG93UHJldmlvdXNUYWIoZXZlbnQpOworCisg ICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAgfQogfTsKIAogV2ViSW5zcGVjdG9y LlRhYkJyb3dzZXIuRXZlbnQgPSB7Cg==