145559 2015-06-02 12:18:25 -0700 [Mac] occasional crash in Document::playbackTargetAvailabilityDidChange 2015-06-03 09:16:32 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson ap commit-queue webkit-bug-importer oldest_to_newest 1098823 0 eric.carlson 2015-06-02 12:18:25 -0700 media/track/media-element-enqueue-event-crash.html sometimes crashes in Document::playbackTargetAvailabilityDidChange when GuardMalloc is enabled. 1098824 1 eric.carlson 2015-06-02 12:18:52 -0700 rdar://problem/21106044 1098838 2 254082 eric.carlson 2015-06-02 12:44:30 -0700 Created attachment 254082 Proposed patch. 1098840 3 commit-queue 2015-06-02 12:46:48 -0700 Attachment 254082 did not pass style-queue: ERROR: Source/WebCore/html/MediaElementSession.h:47: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/MediaElementSession.h:48: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1098878 4 254082 darin 2015-06-02 13:37:09 -0700 Comment on attachment 254082 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=254082&action=review > Source/WebCore/html/MediaElementSession.h:48 > + void registerWithDocument(Document& document); > + void unregisterWithDocument(Document& document); Argument names don’t add anything here. 1098888 5 eric.carlson 2015-06-02 14:05:59 -0700 Committed r185120: https://trac.webkit.org/r185120 254082 2015-06-02 12:44:30 -0700 2015-06-03 09:16:32 -0700 Proposed patch. wrong_document_patch_1.txt text/plain 4772 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTExMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA2LTAyICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIG9jY2FzaW9u YWwgY3Jhc2ggaW4gRG9jdW1lbnQ6OnBsYXliYWNrVGFyZ2V0QXZhaWxhYmlsaXR5RGlkQ2hhbmdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1NTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cmVn aXN0ZXJXaXRoRG9jdW1lbnQpOiBQYXNzIGRvY3VtZW50IHRvIG1fbWVkaWFTZXNzaW9uLT5yZWdp c3RlcldpdGhEb2N1bWVudC4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnVu cmVnaXN0ZXJXaXRoRG9jdW1lbnQpOiBQYXNzIGRvY3VtZW50IHRvIG1fbWVkaWFTZXNzaW9uLT51 blJlZ2lzdGVyV2l0aERvY3VtZW50LgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6ZG9jdW1lbnRXaWxsU3VzcGVuZEZvclBhZ2VDYWNoZSk6IERpdHRvLgorICAgICAgICAoV2Vi Q29yZTo6SFRNTE1lZGlhRWxlbWVudDo6ZG9jdW1lbnREaWRSZXN1bWVGcm9tUGFnZUNhY2hlKTog RGl0dG8uCisKKyAgICAgICAgKiBodG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFFbGVtZW50U2Vzc2lvbjo6cmVnaXN0ZXJXaXRoRG9jdW1lbnQpOiBU YWtlIGEgZG9jdW1lbnQuCisgICAgICAgIChXZWJDb3JlOjpNZWRpYUVsZW1lbnRTZXNzaW9uOjp1 bnJlZ2lzdGVyV2l0aERvY3VtZW50KTogRGl0dG8uCisgICAgICAgICogaHRtbC9NZWRpYUVsZW1l bnRTZXNzaW9uLmg6CisKIDIwMTUtMDYtMDIgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29t PgogCiAgICAgICAgIFtNYWNdIFJFR1JFU1NJT04gKHIxNzU5NDEpOiBNYXguYXBwIGNyYXNoZXMg d2hlbiBhZGRpbmcgYSBzb3VuZCBmaWxlIHRvIGEgcGF0Y2ggZHVlIHRvIHJlbW92aW5nIGN1cnNv ciByZXNvdXJjZXMgZnJvbSBXZWJDb3JlLmZyYW1ld29yawpJbmRleDogU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxODUxMDcpCisrKyBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NjAsNyAr NDYwLDcgQEAgSFRNTE1lZGlhRWxlbWVudDo6fkhUTUxNZWRpYUVsZW1lbnQoKQogCiB2b2lkIEhU TUxNZWRpYUVsZW1lbnQ6OnJlZ2lzdGVyV2l0aERvY3VtZW50KERvY3VtZW50JiBkb2N1bWVudCkK IHsKLSAgICBtX21lZGlhU2Vzc2lvbi0+cmVnaXN0ZXJXaXRoRG9jdW1lbnQoKnRoaXMpOworICAg IG1fbWVkaWFTZXNzaW9uLT5yZWdpc3RlcldpdGhEb2N1bWVudChkb2N1bWVudCk7CiAKICAgICBp ZiAobV9pc1dhaXRpbmdVbnRpbE1lZGlhQ2FuU3RhcnQpCiAgICAgICAgIGRvY3VtZW50LmFkZE1l ZGlhQ2FuU3RhcnRMaXN0ZW5lcih0aGlzKTsKQEAgLTQ5Miw3ICs0OTIsNyBAQCB2b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OnJlZ2lzdGVyV2l0aERvY3VtCiAKIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6 dW5yZWdpc3RlcldpdGhEb2N1bWVudChEb2N1bWVudCYgZG9jdW1lbnQpCiB7Ci0gICAgbV9tZWRp YVNlc3Npb24tPnVucmVnaXN0ZXJXaXRoRG9jdW1lbnQoKnRoaXMpOworICAgIG1fbWVkaWFTZXNz aW9uLT51bnJlZ2lzdGVyV2l0aERvY3VtZW50KGRvY3VtZW50KTsKIAogICAgIGlmIChtX2lzV2Fp dGluZ1VudGlsTWVkaWFDYW5TdGFydCkKICAgICAgICAgZG9jdW1lbnQucmVtb3ZlTWVkaWFDYW5T dGFydExpc3RlbmVyKHRoaXMpOwpAQCAtNTMwLDkgKzUzMCw4IEBAIHZvaWQgSFRNTE1lZGlhRWxl bWVudDo6ZGlkTW92ZVRvTmV3RG9jdW0KICAgICAgICAgZG9jdW1lbnQoKS5pbmNyZW1lbnRMb2Fk RXZlbnREZWxheUNvdW50KCk7CiAgICAgfQogCi0gICAgaWYgKG9sZERvY3VtZW50KSB7CisgICAg aWYgKG9sZERvY3VtZW50KQogICAgICAgICB1bnJlZ2lzdGVyV2l0aERvY3VtZW50KCpvbGREb2N1 bWVudCk7Ci0gICAgfQogCiAgICAgcmVnaXN0ZXJXaXRoRG9jdW1lbnQoZG9jdW1lbnQoKSk7CiAK QEAgLTU0MiwxMiArNTQxLDEyIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6ZGlkTW92ZVRvTmV3 RG9jdW0KICNpZiBFTkFCTEUoV0lSRUxFU1NfUExBWUJBQ0tfVEFSR0VUKQogdm9pZCBIVE1MTWVk aWFFbGVtZW50Ojpkb2N1bWVudFdpbGxTdXNwZW5kRm9yUGFnZUNhY2hlKCkKIHsKLSAgICBtX21l ZGlhU2Vzc2lvbi0+dW5yZWdpc3RlcldpdGhEb2N1bWVudCgqdGhpcyk7CisgICAgbV9tZWRpYVNl c3Npb24tPnVucmVnaXN0ZXJXaXRoRG9jdW1lbnQoZG9jdW1lbnQoKSk7CiB9CiAKIHZvaWQgSFRN TE1lZGlhRWxlbWVudDo6ZG9jdW1lbnREaWRSZXN1bWVGcm9tUGFnZUNhY2hlKCkKIHsKLSAgICBt X21lZGlhU2Vzc2lvbi0+cmVnaXN0ZXJXaXRoRG9jdW1lbnQoKnRoaXMpOworICAgIG1fbWVkaWFT ZXNzaW9uLT5yZWdpc3RlcldpdGhEb2N1bWVudChkb2N1bWVudCgpKTsKIH0KICNlbmRpZgogCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAJKHJldmlz aW9uIDE4NTEwNykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTg3LDIxICs4NywyMSBAQCBNZWRpYUVsZW1lbnRTZXNzaW9u OjpNZWRpYUVsZW1lbnRTZXNzaW9uCiB7CiB9CiAKLXZvaWQgTWVkaWFFbGVtZW50U2Vzc2lvbjo6 cmVnaXN0ZXJXaXRoRG9jdW1lbnQoY29uc3QgSFRNTE1lZGlhRWxlbWVudCYgZWxlbWVudCkKK3Zv aWQgTWVkaWFFbGVtZW50U2Vzc2lvbjo6cmVnaXN0ZXJXaXRoRG9jdW1lbnQoRG9jdW1lbnQmIGRv Y3VtZW50KQogewogI2lmIEVOQUJMRShXSVJFTEVTU19QTEFZQkFDS19UQVJHRVQpCi0gICAgZWxl bWVudC5kb2N1bWVudCgpLmFkZFBsYXliYWNrVGFyZ2V0UGlja2VyQ2xpZW50KCp0aGlzKTsKKyAg ICBkb2N1bWVudC5hZGRQbGF5YmFja1RhcmdldFBpY2tlckNsaWVudCgqdGhpcyk7CiAjZWxzZQot ICAgIFVOVVNFRF9QQVJBTShlbGVtZW50KTsKKyAgICBVTlVTRURfUEFSQU0oZG9jdW1lbnQpOwog I2VuZGlmCiB9CiAKLXZvaWQgTWVkaWFFbGVtZW50U2Vzc2lvbjo6dW5yZWdpc3RlcldpdGhEb2N1 bWVudChjb25zdCBIVE1MTWVkaWFFbGVtZW50JiBlbGVtZW50KQordm9pZCBNZWRpYUVsZW1lbnRT ZXNzaW9uOjp1bnJlZ2lzdGVyV2l0aERvY3VtZW50KERvY3VtZW50JiBkb2N1bWVudCkKIHsKICNp ZiBFTkFCTEUoV0lSRUxFU1NfUExBWUJBQ0tfVEFSR0VUKQotICAgIGVsZW1lbnQuZG9jdW1lbnQo KS5yZW1vdmVQbGF5YmFja1RhcmdldFBpY2tlckNsaWVudCgqdGhpcyk7CisgICAgZG9jdW1lbnQu cmVtb3ZlUGxheWJhY2tUYXJnZXRQaWNrZXJDbGllbnQoKnRoaXMpOwogI2Vsc2UKLSAgICBVTlVT RURfUEFSQU0oZWxlbWVudCk7CisgICAgVU5VU0VEX1BBUkFNKGRvY3VtZW50KTsKICNlbmRpZgog fQogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uaAkocmV2 aXNpb24gMTg1MTA3KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9u LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDggKzQ0LDggQEAgcHVibGljOgogICAgIGV4cGxpY2l0 IE1lZGlhRWxlbWVudFNlc3Npb24oUGxhdGZvcm1NZWRpYVNlc3Npb25DbGllbnQmKTsKICAgICB2 aXJ0dWFsIH5NZWRpYUVsZW1lbnRTZXNzaW9uKCkgeyB9CiAKLSAgICB2b2lkIHJlZ2lzdGVyV2l0 aERvY3VtZW50KGNvbnN0IEhUTUxNZWRpYUVsZW1lbnQmKTsKLSAgICB2b2lkIHVucmVnaXN0ZXJX aXRoRG9jdW1lbnQoY29uc3QgSFRNTE1lZGlhRWxlbWVudCYpOworICAgIHZvaWQgcmVnaXN0ZXJX aXRoRG9jdW1lbnQoRG9jdW1lbnQmIGRvY3VtZW50KTsKKyAgICB2b2lkIHVucmVnaXN0ZXJXaXRo RG9jdW1lbnQoRG9jdW1lbnQmIGRvY3VtZW50KTsKIAogICAgIGJvb2wgcGxheWJhY2tQZXJtaXR0 ZWQoY29uc3QgSFRNTE1lZGlhRWxlbWVudCYpIGNvbnN0OwogICAgIGJvb2wgZGF0YUxvYWRpbmdQ ZXJtaXR0ZWQoY29uc3QgSFRNTE1lZGlhRWxlbWVudCYpIGNvbnN0Owo=