145558 2015-06-02 12:13:14 -0700 Add more tests for "should open external urls" flag 2015-06-02 12:40:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson ggaren mitz sam oldest_to_newest 1098819 0 beidson 2015-06-02 12:13:14 -0700 Add more tests for "should open external urls" flag Suggested in https://bugs.webkit.org/show_bug.cgi?id=145280 1098826 1 beidson 2015-06-02 12:22:57 -0700 In the other bug, Geoff Garen suggested: --- Other interesting test cases: (1) Do a top-level (Safari-like) navigation that sets the flag to true, then another that sets it to false. Flag should be false. (2) Do a top-level (Safari-like) navigation that sets the flag to false, then another that sets it to true. Flag should be true. (3) Do a top-level (Safari-like) navigation that sets the flag to false, then a programmatic click event on a link. Flag should be false. 1098835 2 254081 beidson 2015-06-02 12:37:15 -0700 Created attachment 254081 Patch v1 1098836 3 254081 beidson 2015-06-02 12:38:36 -0700 Comment on attachment 254081 Patch v1 Geoff rubber-stamped these in person 1098837 4 beidson 2015-06-02 12:40:49 -0700 http://trac.webkit.org/changeset/185115 254081 2015-06-02 12:37:15 -0700 2015-06-02 12:38:36 -0700 Patch v1 patch text/plain 6787 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1YjNjNzkyLi41OWE4NzQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTUtMDYt MDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBtb3Jl IHRlc3RzIGZvciAic2hvdWxkIG9wZW4gZXh0ZXJuYWwgdXJscyIgZmxhZy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTU1OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL25hdmlnYXRpb24t cG9saWN5L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvYXBpLWZhbHNlLWZvbGxvd2VkLWJ5LWFw aS10cnVlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbG9hZGVyL25hdmlnYXRpb24t cG9saWN5L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvYXBpLWZhbHNlLWZvbGxvd2VkLWJ5LWFw aS10cnVlLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGxvYWRlci9uYXZpZ2F0aW9uLXBvbGljeS9z aG91bGQtb3Blbi1leHRlcm5hbC11cmxzL2FwaS10cnVlLWZvbGxvd2VkLWJ5LWFwaS1mYWxzZS1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGxvYWRlci9uYXZpZ2F0aW9uLXBvbGljeS9z aG91bGQtb3Blbi1leHRlcm5hbC11cmxzL2FwaS10cnVlLWZvbGxvd2VkLWJ5LWFwaS1mYWxzZS5o dG1sOiBBZGRlZC4KKyAgICAgICAgKiBsb2FkZXIvbmF2aWdhdGlvbi1wb2xpY3kvc2hvdWxkLW9w ZW4tZXh0ZXJuYWwtdXJscy9kaXNwYXRjaC1ldmVudC1jbGljay1pcy1ub3QtdXNlci1nZXN0dXJl LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbG9hZGVyL25hdmlnYXRpb24tcG9saWN5 L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvZGlzcGF0Y2gtZXZlbnQtY2xpY2staXMtbm90LXVz ZXItZ2VzdHVyZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBsb2FkZXIvbmF2aWdhdGlvbi1wb2xp Y3kvc2hvdWxkLW9wZW4tZXh0ZXJuYWwtdXJscy9yZXNvdXJjZXMvZG8tbm90aGluZy5odG1sOiBB ZGRlZC4KKworMjAxNS0wNi0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisK ICAgICAgICAgV2ViS2l0IHBvbGljeSBkZWxlZ2F0ZSBzaG91bGQgc3VnZ2VzdCBpZiBhIG5hdmln YXRpb24gc2hvdWxkIGJlIGFsbG93ZWQgdG8gb3BlbiBVUkxzIGV4dGVybmFsbHkuCiAgICAgICAg IHJkYXI6Ly9wcm9ibGVtLzIxMDI1MzAxIGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ1MjgwCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2xvYWRlci9uYXZp Z2F0aW9uLXBvbGljeS9zaG91bGQtb3Blbi1leHRlcm5hbC11cmxzL2FwaS1mYWxzZS1mb2xsb3dl ZC1ieS1hcGktdHJ1ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9sb2FkZXIvbmF2aWdhdGlv bi1wb2xpY3kvc2hvdWxkLW9wZW4tZXh0ZXJuYWwtdXJscy9hcGktZmFsc2UtZm9sbG93ZWQtYnkt YXBpLXRydWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LjdlODYwYzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9sb2FkZXIvbmF2aWdhdGlv bi1wb2xpY3kvc2hvdWxkLW9wZW4tZXh0ZXJuYWwtdXJscy9hcGktZmFsc2UtZm9sbG93ZWQtYnkt YXBpLXRydWUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorIC0gZGVjaWRlUG9saWN5Rm9y TmF2aWdhdGlvbkFjdGlvbiAKKzxOU1VSTFJlcXVlc3QgVVJMIHJlc291cmNlcy9kby1ub3RoaW5n LCBtYWluIGRvY3VtZW50IFVSTCByZXNvdXJjZXMvZG8tbm90aGluZywgaHR0cCBtZXRob2QgR0VU PiBpcyBtYWluIGZyYW1lIC0geWVzIHNob3VsZCBvcGVuIFVSTHMgZXh0ZXJuYWxseSAtIG5vCisg LSBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uIAorPE5TVVJMUmVxdWVzdCBVUkwgcmVz b3VyY2VzL25vdGlmeS1kb25lLmh0bWwsIG1haW4gZG9jdW1lbnQgVVJMIHJlc291cmNlcy9ub3Rp ZnktZG9uZS5odG1sLCBodHRwIG1ldGhvZCBHRVQ+IGlzIG1haW4gZnJhbWUgLSB5ZXMgc2hvdWxk IG9wZW4gVVJMcyBleHRlcm5hbGx5IC0geWVzCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2xv YWRlci9uYXZpZ2F0aW9uLXBvbGljeS9zaG91bGQtb3Blbi1leHRlcm5hbC11cmxzL2FwaS1mYWxz ZS1mb2xsb3dlZC1ieS1hcGktdHJ1ZS5odG1sIGIvTGF5b3V0VGVzdHMvbG9hZGVyL25hdmlnYXRp b24tcG9saWN5L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvYXBpLWZhbHNlLWZvbGxvd2VkLWJ5 LWFwaS10cnVlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYTMzMTU5 YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2xvYWRlci9uYXZpZ2F0aW9uLXBvbGlj eS9zaG91bGQtb3Blbi1leHRlcm5hbC11cmxzL2FwaS1mYWxzZS1mb2xsb3dlZC1ieS1hcGktdHJ1 ZS5odG1sCkBAIC0wLDAgKzEsMTEgQEAKKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICB0ZXN0UnVubmVyLmR1bXBQb2xp Y3lEZWxlZ2F0ZUNhbGxiYWNrcygpOworICAgIHRlc3RSdW5uZXIucXVldWVMb2FkKCJyZXNvdXJj ZXMvZG8tbm90aGluZyIpOworICAgIHRlc3RSdW5uZXIucXVldWVMb2FkKCJyZXNvdXJjZXMvbm90 aWZ5LWRvbmUuaHRtbCIsICIiLCB0cnVlKTsKK30KKzwvc2NyaXB0PgorVGhpcyB0ZXN0IGxvYWRz IGEgcGFnZSB2aWEgQVBJIHdpdGggdGhlIGZsYWcgbm90IHNldC48YnI+CitJdCB0aGVuIGxvYWRz IGEgcGFnZSB2aWEgQVBJIHdpdGggdGhlIGZsYWcgc2V0IHRvIHRydWUuPGJyPgorVGhlIGZpcnN0 IGxvYWQgc2hvdWxkIGhhdmUgdGhlIGZsYWcgZGVmYXVsdGVkIHRvIGZhbHNlLCB0aGUgc2Vjb25k IGxvYWQgc2hvdWxkIGhhdmUgaXQgYmUgdHJ1ZS48YnI+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9sb2FkZXIvbmF2aWdhdGlvbi1wb2xpY3kvc2hvdWxkLW9wZW4tZXh0ZXJuYWwtdXJscy9hcGkt dHJ1ZS1mb2xsb3dlZC1ieS1hcGktZmFsc2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbG9h ZGVyL25hdmlnYXRpb24tcG9saWN5L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvYXBpLXRydWUt Zm9sbG93ZWQtYnktYXBpLWZhbHNlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi5jY2RiYzY0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbG9h ZGVyL25hdmlnYXRpb24tcG9saWN5L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvYXBpLXRydWUt Zm9sbG93ZWQtYnktYXBpLWZhbHNlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKKyAtIGRl Y2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24gCis8TlNVUkxSZXF1ZXN0IFVSTCByZXNvdXJj ZXMvZG8tbm90aGluZywgbWFpbiBkb2N1bWVudCBVUkwgcmVzb3VyY2VzL2RvLW5vdGhpbmcsIGh0 dHAgbWV0aG9kIEdFVD4gaXMgbWFpbiBmcmFtZSAtIHllcyBzaG91bGQgb3BlbiBVUkxzIGV4dGVy bmFsbHkgLSB5ZXMKKyAtIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24gCis8TlNVUkxS ZXF1ZXN0IFVSTCByZXNvdXJjZXMvbm90aWZ5LWRvbmUuaHRtbCwgbWFpbiBkb2N1bWVudCBVUkwg cmVzb3VyY2VzL25vdGlmeS1kb25lLmh0bWwsIGh0dHAgbWV0aG9kIEdFVD4gaXMgbWFpbiBmcmFt ZSAtIHllcyBzaG91bGQgb3BlbiBVUkxzIGV4dGVybmFsbHkgLSBubworCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9sb2FkZXIvbmF2aWdhdGlvbi1wb2xpY3kvc2hvdWxkLW9wZW4tZXh0ZXJuYWwt dXJscy9hcGktdHJ1ZS1mb2xsb3dlZC1ieS1hcGktZmFsc2UuaHRtbCBiL0xheW91dFRlc3RzL2xv YWRlci9uYXZpZ2F0aW9uLXBvbGljeS9zaG91bGQtb3Blbi1leHRlcm5hbC11cmxzL2FwaS10cnVl LWZvbGxvd2VkLWJ5LWFwaS1mYWxzZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLjRkMzFhMDIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9sb2FkZXIvbmF2 aWdhdGlvbi1wb2xpY3kvc2hvdWxkLW9wZW4tZXh0ZXJuYWwtdXJscy9hcGktdHJ1ZS1mb2xsb3dl ZC1ieS1hcGktZmFsc2UuaHRtbApAQCAtMCwwICsxLDExIEBACis8c2NyaXB0PgoraWYgKHdpbmRv dy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1 bm5lci5kdW1wUG9saWN5RGVsZWdhdGVDYWxsYmFja3MoKTsKKyAgICB0ZXN0UnVubmVyLnF1ZXVl TG9hZCgicmVzb3VyY2VzL2RvLW5vdGhpbmciLCAiIiwgdHJ1ZSk7CisgICAgdGVzdFJ1bm5lci5x dWV1ZUxvYWQoInJlc291cmNlcy9ub3RpZnktZG9uZS5odG1sIik7Cit9Cis8L3NjcmlwdD4KK1Ro aXMgdGVzdCBsb2FkcyBhIHBhZ2UgdmlhIEFQSSB3aXRoIHRoZSBmbGFnIHNldCB0byB0cnVlLjxi cj4KK0l0IHRoZW4gbG9hZHMgYSBwYWdlIHZpYSBBUEkgd2l0aCB0aGUgZmxhZyBub3Qgc2V0Ljxi cj4KK1RoZSBzZWNvbmQgbG9hZCBzaG91bGQgaGF2ZSB0aGUgZmxhZyBkZWZhdWx0ZWQgdG8gZmFs c2UuPGJyPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbG9hZGVyL25hdmlnYXRpb24tcG9saWN5 L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvZGlzcGF0Y2gtZXZlbnQtY2xpY2staXMtbm90LXVz ZXItZ2VzdHVyZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9sb2FkZXIvbmF2aWdhdGlvbi1w b2xpY3kvc2hvdWxkLW9wZW4tZXh0ZXJuYWwtdXJscy9kaXNwYXRjaC1ldmVudC1jbGljay1pcy1u b3QtdXNlci1nZXN0dXJlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi45YjEyMDljCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbG9hZGVyL25h dmlnYXRpb24tcG9saWN5L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvZGlzcGF0Y2gtZXZlbnQt Y2xpY2staXMtbm90LXVzZXItZ2VzdHVyZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACisg LSBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uIAorPE5TVVJMUmVxdWVzdCBVUkwgcmVz b3VyY2VzL25vdGlmeS1kb25lLmh0bWwsIG1haW4gZG9jdW1lbnQgVVJMIHJlc291cmNlcy9ub3Rp ZnktZG9uZS5odG1sLCBodHRwIG1ldGhvZCBHRVQ+IGlzIG1haW4gZnJhbWUgLSB5ZXMgc2hvdWxk IG9wZW4gVVJMcyBleHRlcm5hbGx5IC0gbm8KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbG9h ZGVyL25hdmlnYXRpb24tcG9saWN5L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvZGlzcGF0Y2gt ZXZlbnQtY2xpY2staXMtbm90LXVzZXItZ2VzdHVyZS5odG1sIGIvTGF5b3V0VGVzdHMvbG9hZGVy L25hdmlnYXRpb24tcG9saWN5L3Nob3VsZC1vcGVuLWV4dGVybmFsLXVybHMvZGlzcGF0Y2gtZXZl bnQtY2xpY2staXMtbm90LXVzZXItZ2VzdHVyZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLjIwNmQ4NGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9sb2Fk ZXIvbmF2aWdhdGlvbi1wb2xpY3kvc2hvdWxkLW9wZW4tZXh0ZXJuYWwtdXJscy9kaXNwYXRjaC1l dmVudC1jbGljay1pcy1ub3QtdXNlci1nZXN0dXJlLmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPHNj cmlwdD4KKworaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNU ZXh0KCk7CisgICAgdGVzdFJ1bm5lci5kdW1wUG9saWN5RGVsZWdhdGVDYWxsYmFja3MoKTsKKyAg ICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK30KKworZnVuY3Rpb24gcnVuVGVzdCgpCit7 CisgICAgdmFyIGV2ZW50ID0gdG9wLmRvY3VtZW50LmNyZWF0ZUV2ZW50KCdNb3VzZUV2ZW50Jyk7 CisgICAgZXZlbnQuaW5pdEV2ZW50KCdjbGljaycsIHRydWUsIHRydWUpOworICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdhJykuZGlzcGF0Y2hFdmVudChldmVudCk7Cit9CisKKzwvc2NyaXB0 PgorCis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKTsiPgorVGhpcyB0ZXN0ICJjbGlja3MiIGEgbGlu ayB1c2luZyBkaXNwYXRjaEV2ZW50IGFuZCBjaGVja3MgdGhlICJzaG91bGQgb3BlbiBleHRlcm5h bCBVUkxzIiBmbGFnLjxicj4KK1NpbmNlIHRoZSBmYWtlIGNsaWNrIGlzIG5vdCBhIHVzZXIgZ2Vz dHVyZSwgdGhlIGZsYWcgc2hvdWxkIGJlIGZhbHNlLjxicj4KKzxhIGlkPSJhIiBocmVmPSJyZXNv dXJjZXMvbm90aWZ5LWRvbmUuaHRtbCI+Q2xpY2sgbWUgdG8gZmluaXNoPC9hPgorPC9ib2R5Pgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbG9hZGVyL25hdmlnYXRpb24tcG9saWN5L3Nob3VsZC1v cGVuLWV4dGVybmFsLXVybHMvcmVzb3VyY2VzL2RvLW5vdGhpbmcuaHRtbCBiL0xheW91dFRlc3Rz L2xvYWRlci9uYXZpZ2F0aW9uLXBvbGljeS9zaG91bGQtb3Blbi1leHRlcm5hbC11cmxzL3Jlc291 cmNlcy9kby1ub3RoaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u MDlkNjViNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2xvYWRlci9uYXZpZ2F0aW9u LXBvbGljeS9zaG91bGQtb3Blbi1leHRlcm5hbC11cmxzL3Jlc291cmNlcy9kby1ub3RoaW5nLmh0 bWwKQEAgLTAsMCArMSwzIEBACis8Ym9keT4KK1RoaXMgcGFnZSBkb2VzIG5vdGhpbmcuCis8L2Jv ZHk+Cg==