145551 2015-06-02 02:07:29 -0700 [Streams API] ReadableStreamReader::closed() should be called once by binding code 2015-06-03 00:35:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf calvaris commit-queue darin oldest_to_newest 1098758 0 youennf 2015-06-02 02:07:29 -0700 ReadableStreamReader.closed JS attribute is just an accessor to the promise. We should only call ReadableStreamReader::closed() when we create the actual promise to set the callbacks properly. 1098761 1 254061 youennf 2015-06-02 02:10:05 -0700 Created attachment 254061 Patch 1098802 2 254061 darin 2015-06-02 11:28:47 -0700 Comment on attachment 254061 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254061&action=review > Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp:70 > + return m_closedPromiseDeferred.get()->promise(); Is the call to .get() really needed? 1099098 3 254158 youennf 2015-06-02 23:39:15 -0700 Created attachment 254158 Patch for landing 1099100 4 youennf 2015-06-02 23:40:52 -0700 Thanks for the review. > > Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp:70 > > + return m_closedPromiseDeferred.get()->promise(); > > Is the call to .get() really needed? Right, I removed it in the landing patch. 1099107 5 254158 commit-queue 2015-06-03 00:35:28 -0700 Comment on attachment 254158 Patch for landing Clearing flags on attachment: 254158 Committed r185149: <http://trac.webkit.org/changeset/185149> 1099108 6 commit-queue 2015-06-03 00:35:32 -0700 All reviewed patches have been landed. Closing bug. 254061 2015-06-02 02:10:05 -0700 2015-06-02 23:39:10 -0700 Patch bug-145551-20150602110946.patch text/plain 2094 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZiZmNjMmY5NjRmMDRk NDlhZTYzYmJjZTMwYTQ2NTlhNTZhYjIzYy4uZmIyZGY4YWMyOWIxMzRkZjVjOTZhY2VmMmM0YTZk NTk4ZmEwNDVmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTA2LTAyICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+IGFuZCBZb3Vlbm4gRmFi bGV0IDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAorICAgICAgICBbU3RyZWFtcyBBUEld IFJlYWRhYmxlU3RyZWFtUmVhZGVyOjpjbG9zZWQoKSBzaG91bGQgYmUgY2FsbGVkIG9uY2UgYnkg YmluZGluZyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDU1NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3MvanMv SlNSZWFkYWJsZVN0cmVhbVJlYWRlckN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU1Jl YWRhYmxlU3RyZWFtUmVhZGVyOjpjbG9zZWQpOiBDYWxsaW5nIFJlYWRhYmxlU3RyZWFtUmVhZGVy OjpjbG9zZWQgb25seSBhdCBjcmVhdGlvbiBvZiB0aGUgcHJvbWlzZS4KKworMjAxNS0wNi0wMiAg WGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPiBhbmQgWW91ZW5u IEZhYmxldCA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKICAgICAgICAgW1N0cmVhbXMg QVBJXSBJbXBsZW1lbnQgUmVhZGFibGVTdHJlYW1SZWFkZXIgcmVhZCBtZXRob2QgaW4gY2xvc2Vk IGFuZCBlcnJvcmVkIHN0YXRlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDQ3OTAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNSZWFkYWJsZVN0cmVhbVJlYWRlckN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU1JlYWRhYmxlU3RyZWFtUmVhZGVyQ3VzdG9tLmNwcAppbmRleCA1ZDVjMzQ0MWI5 MzRlZmUzN2Q5NDQ0YjNjNWNkZjMxOTFhYmM4YTQyLi40MWJjNzhhNGMzM2E3YWExMThhNjEyZDU0 YTA2MDEyY2RiOWQ3Yzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U1JlYWRhYmxlU3RyZWFtUmVhZGVyQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU1JlYWRhYmxlU3RyZWFtUmVhZGVyQ3VzdG9tLmNwcApAQCAtNjYsOCArNjYsMTAg QEAgSlNWYWx1ZSBKU1JlYWRhYmxlU3RyZWFtUmVhZGVyOjpyZWFkKEV4ZWNTdGF0ZSogZXhlYykK IAogSlNWYWx1ZSBKU1JlYWRhYmxlU3RyZWFtUmVhZGVyOjpjbG9zZWQoRXhlY1N0YXRlKiBleGVj KSBjb25zdAogewotICAgIGlmICghbV9jbG9zZWRQcm9taXNlRGVmZXJyZWQpCi0gICAgICAgIGNv bnN0X2Nhc3Q8SlNSZWFkYWJsZVN0cmVhbVJlYWRlcio+KHRoaXMpLT5tX2Nsb3NlZFByb21pc2VE ZWZlcnJlZC5zZXQoZXhlYy0+dm0oKSwgSlNQcm9taXNlRGVmZXJyZWQ6OmNyZWF0ZShleGVjLCBn bG9iYWxPYmplY3QoKSkpOworICAgIGlmIChtX2Nsb3NlZFByb21pc2VEZWZlcnJlZCkKKyAgICAg ICAgcmV0dXJuIG1fY2xvc2VkUHJvbWlzZURlZmVycmVkLmdldCgpLT5wcm9taXNlKCk7CisKKyAg ICBjb25zdF9jYXN0PEpTUmVhZGFibGVTdHJlYW1SZWFkZXIqPih0aGlzKS0+bV9jbG9zZWRQcm9t aXNlRGVmZXJyZWQuc2V0KGV4ZWMtPnZtKCksIEpTUHJvbWlzZURlZmVycmVkOjpjcmVhdGUoZXhl YywgZ2xvYmFsT2JqZWN0KCkpKTsKICAgICBEZWZlcnJlZFdyYXBwZXIgd3JhcHBlcihleGVjLCBn bG9iYWxPYmplY3QoKSwgbV9jbG9zZWRQcm9taXNlRGVmZXJyZWQuZ2V0KCkpOwogCiAgICAgYXV0 byBzdWNjZXNzQ2FsbGJhY2sgPSBbd3JhcHBlcl0oKSBtdXRhYmxlIHsK 254158 2015-06-02 23:39:15 -0700 2015-06-03 00:35:28 -0700 Patch for landing bug-145551-20150603083855.patch text/plain 2027 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZiZmNjMmY5NjRmMDRk NDlhZTYzYmJjZTMwYTQ2NTlhNTZhYjIzYy4uODkzMjhjYmMyNjZjMzM0ZGZiZmVjZDU5MzA0Nzc2 YjI3YzYzNTE1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTAzICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+IGFuZCBZb3Vlbm4gRmFi bGV0IDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KKworICAgICAgICBbU3RyZWFtcyBBUEld IFJlYWRhYmxlU3RyZWFtUmVhZGVyOjpjbG9zZWQoKSBzaG91bGQgYmUgY2FsbGVkIG9uY2UgYnkg YmluZGluZyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDU1NTEKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNS ZWFkYWJsZVN0cmVhbVJlYWRlckN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU1JlYWRh YmxlU3RyZWFtUmVhZGVyOjpjbG9zZWQpOiBDYWxsaW5nIFJlYWRhYmxlU3RyZWFtUmVhZGVyOjpj bG9zZWQgb25seSBhdCBjcmVhdGlvbiBvZiB0aGUgcHJvbWlzZS4KKwogMjAxNS0wNi0wMiAgWGFi aWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPiBhbmQgWW91ZW5uIEZh YmxldCA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgW1N0cmVhbXMgQVBJ XSBJbXBsZW1lbnQgUmVhZGFibGVTdHJlYW1SZWFkZXIgcmVhZCBtZXRob2QgaW4gY2xvc2VkIGFu ZCBlcnJvcmVkIHN0YXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U1JlYWRhYmxlU3RyZWFtUmVhZGVyQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTUmVhZGFibGVTdHJlYW1SZWFkZXJDdXN0b20uY3BwCmluZGV4IDVkNWMzNDQxYjkzNGVm ZTM3ZDk0NDRiM2M1Y2RmMzE5MWFiYzhhNDIuLjUxYzBjZmE2MDcyZTBmN2U5MjkwNjJmYjdiM2Y3 OTY3YTY3ZjMxZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTUmVh ZGFibGVTdHJlYW1SZWFkZXJDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTUmVhZGFibGVTdHJlYW1SZWFkZXJDdXN0b20uY3BwCkBAIC02Niw4ICs2NiwxMCBAQCBK U1ZhbHVlIEpTUmVhZGFibGVTdHJlYW1SZWFkZXI6OnJlYWQoRXhlY1N0YXRlKiBleGVjKQogCiBK U1ZhbHVlIEpTUmVhZGFibGVTdHJlYW1SZWFkZXI6OmNsb3NlZChFeGVjU3RhdGUqIGV4ZWMpIGNv bnN0CiB7Ci0gICAgaWYgKCFtX2Nsb3NlZFByb21pc2VEZWZlcnJlZCkKLSAgICAgICAgY29uc3Rf Y2FzdDxKU1JlYWRhYmxlU3RyZWFtUmVhZGVyKj4odGhpcyktPm1fY2xvc2VkUHJvbWlzZURlZmVy cmVkLnNldChleGVjLT52bSgpLCBKU1Byb21pc2VEZWZlcnJlZDo6Y3JlYXRlKGV4ZWMsIGdsb2Jh bE9iamVjdCgpKSk7CisgICAgaWYgKG1fY2xvc2VkUHJvbWlzZURlZmVycmVkKQorICAgICAgICBy ZXR1cm4gbV9jbG9zZWRQcm9taXNlRGVmZXJyZWQtPnByb21pc2UoKTsKKworICAgIGNvbnN0X2Nh c3Q8SlNSZWFkYWJsZVN0cmVhbVJlYWRlcio+KHRoaXMpLT5tX2Nsb3NlZFByb21pc2VEZWZlcnJl ZC5zZXQoZXhlYy0+dm0oKSwgSlNQcm9taXNlRGVmZXJyZWQ6OmNyZWF0ZShleGVjLCBnbG9iYWxP YmplY3QoKSkpOwogICAgIERlZmVycmVkV3JhcHBlciB3cmFwcGVyKGV4ZWMsIGdsb2JhbE9iamVj dCgpLCBtX2Nsb3NlZFByb21pc2VEZWZlcnJlZC5nZXQoKSk7CiAKICAgICBhdXRvIHN1Y2Nlc3ND YWxsYmFjayA9IFt3cmFwcGVyXSgpIG11dGFibGUgewo=