145535 2015-06-01 17:05:53 -0700 Use xpc_connection_set_oneshot_instance where possible 2015-06-02 10:10:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 1098655 0 andersca 2015-06-01 17:05:53 -0700 Use xpc_connection_set_oneshot_instance where possible 1098657 1 254029 andersca 2015-06-01 17:07:22 -0700 Created attachment 254029 Patch 1098661 2 andersca 2015-06-01 17:26:56 -0700 Committed r185090: <http://trac.webkit.org/changeset/185090> 1098676 3 254029 darin 2015-06-01 18:07:15 -0700 Comment on attachment 254029 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254029&action=review > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:222 > +#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 Is this right for older iOS? I know we try to compile back at least one major release version. 1098788 4 andersca 2015-06-02 10:10:54 -0700 (In reply to comment #3) > Comment on attachment 254029 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254029&action=review > > > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:222 > > +#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 > > Is this right for older iOS? I know we try to compile back at least one > major release version. Yes, this is supported on older iOS. 254029 2015-06-01 17:07:22 -0700 2015-06-01 17:24:38 -0700 Patch bug-145535-20150601170704.patch text/plain 4300 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGFmYzE1ZWZjZWJmMTE1MGVlMmM4YzU1 NTYwZmEyMjk5MTgyNjc0YWEuLmU5M2M5YmQwM2U1N2Q0Mzk0NmFlMDA4MzZkMzQxNDA4YTQ1NzUz MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDYtMDEgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgeHBjX2Nvbm5lY3Rpb25fc2V0X29uZXNo b3RfaW5zdGFuY2Ugd2hlcmUgcG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NTUzNQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMTEwOTk5 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBT UEkgZGVjbGFyYXRpb24uCisKKyAgICAgICAgKiB3dGYvc3BpL2Rhcndpbi9YUENTUEkuaDoKKwog MjAxNS0wNS0yOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIE1pc3NpbmcgI2ltcG9ydCBvZiBQbGF0Zm9ybS5oIGluIHNldmVyYWwgV1RGIGhlYWRlcnMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwYTNlZDUwMzdlNTc5NGM5ZDYyYWU1NjYxNTU3ZmJkZGVmMDA2MGIyLi5h OGIwN2U4NGI1MTM0OWFiYjQ1YjYxY2QzNjQ0ZjAyNGU3ZTA3ZmQ4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTUtMDYtMDEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KKworICAgICAgICBVc2UgeHBjX2Nvbm5lY3Rpb25fc2V0X29uZXNob3RfaW5zdGFuY2Ug d2hlcmUgcG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NTUzNQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMTEwOTk5NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB4cGNfY29ubmVjdGlv bl9zZXRfb25lc2hvdF9pbnN0YW5jZSB3aGVyZSBwb3NzaWJsZTsgdGhpcyB3aWxsIG1ha2Ugc3Vy ZSB0aGF0IHRoZSAKKyAgICAgICAgd2ViIHByb2Nlc3MgaW5zdGFuY2VzIGdvIGF3YXkgd2hlbiB0 aGUgd2ViIHByb2Nlc3MgZXhpdHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvbWFj L1Byb2Nlc3NMYXVuY2hlck1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6Y29ubmVjdFRvU2Vydmlj ZSk6CisgICAgICAgIChXZWJLaXQ6OmNvbm5lY3RUb1JlRXhlY1NlcnZpY2UpOgorCiAyMDE1LTA2 LTAxICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgV0tU UiBzdXBwb3J0IGZvciAic2hvdWxkIG9wZW4gZXh0ZXJuYWwgVVJMcyIuCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9zcGkvZGFyd2luL1hQQ1NQSS5oIGIvU291cmNlL1dURi93dGYvc3BpL2Rh cndpbi9YUENTUEkuaAppbmRleCBmYzA1NTAxMTg4NGJjYTgwMjU4NWZhMzc4YzFmMmUxMzE3YTQ3 Zjg3Li4wODljMjUwNTYwYTdmNzRhODI4NTkwZTlhZDJlMWNlNWVhODFlNjkzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9zcGkvZGFyd2luL1hQQ1NQSS5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L3NwaS9kYXJ3aW4vWFBDU1BJLmgKQEAgLTE0Myw2ICsxNDMsNyBAQCBFWFRFUk5fQyB2b2lkIHhw Y19kaWN0aW9uYXJ5X3NldF9tYWNoX3NlbmQoeHBjX29iamVjdF90LCBjb25zdCBjaGFyKiwgbWFj aF9wb3J0XwogI2lmIFBMQVRGT1JNKElPUykgfHwgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMDEwMDAKIEVYVEVSTl9DIHZvaWQgeHBjX2Nvbm5lY3Rpb25fc2V0X2Jvb3RzdHJh cCh4cGNfY29ubmVjdGlvbl90LCB4cGNfb2JqZWN0X3QgYm9vdHN0cmFwKTsKIEVYVEVSTl9DIHhw Y19vYmplY3RfdCB4cGNfY29weV9ib290c3RyYXAodm9pZCk7CitFWFRFUk5fQyB2b2lkIHhwY19j b25uZWN0aW9uX3NldF9vbmVzaG90X2luc3RhbmNlKHhwY19jb25uZWN0aW9uX3QsIHV1aWRfdCBp bnN0YW5jZSk7CiAjZW5kaWYKIAogI2lmIE9TX09CSkVDVF9VU0VfT0JKQ19SRVRBSU5fUkVMRUFT RQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9j ZXNzTGF1bmNoZXJNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFj L1Byb2Nlc3NMYXVuY2hlck1hYy5tbQppbmRleCBhY2U5NWM1MzM3ZDIwYjI3ODdmZjYwOTQyYzQ2 MGRiYzFlOTlhOTliLi5lYWE5Y2NmYjE3ZTUwNzRmYTVlMDcwMjEzMTViMGQwMmJjZmU5NmZiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NM YXVuY2hlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFj L1Byb2Nlc3NMYXVuY2hlck1hYy5tbQpAQCAtMjE5LDcgKzIxOSwxMSBAQCBzdGF0aWMgdm9pZCBj b25uZWN0VG9TZXJ2aWNlKGNvbnN0IFByb2Nlc3NMYXVuY2hlcjo6TGF1bmNoT3B0aW9ucyYgbGF1 bmNoT3B0aW9ucwogewogICAgIC8vIENyZWF0ZSBhIGNvbm5lY3Rpb24gdG8gdGhlIFdlYktpdCBY UEMgc2VydmljZS4KICAgICBhdXRvIGNvbm5lY3Rpb24gPSBhZG9wdE9TT2JqZWN0KHhwY19jb25u ZWN0aW9uX2NyZWF0ZShzZXJ2aWNlTmFtZShsYXVuY2hPcHRpb25zLCBmb3JEZXZlbG9wbWVudCks IDApKTsKKyNpZiBQTEFURk9STShJT1MpIHx8IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTAxMDAwCisgICAgeHBjX2Nvbm5lY3Rpb25fc2V0X29uZXNob3RfaW5zdGFuY2UoY29u bmVjdGlvbi5nZXQoKSwgaW5zdGFuY2VVVUlELT51dWlkKTsKKyNlbHNlCiAgICAgeHBjX2Nvbm5l Y3Rpb25fc2V0X2luc3RhbmNlKGNvbm5lY3Rpb24uZ2V0KCksIGluc3RhbmNlVVVJRC0+dXVpZCk7 CisjZW5kaWYKIAogI2lmIFBMQVRGT1JNKElPUykgfHwgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMDEwMDAKICAgICAvLyBJbmhlcml0IFVJIHByb2Nlc3MgbG9jYWxpemF0aW9u LiBJdCBjYW4gYmUgZGlmZmVyZW50IGZyb20gY2hpbGQgcHJvY2VzcyBkZWZhdWx0IGxvY2FsaXph dGlvbjoKQEAgLTMzMCwxNCArMzM0LDE3IEBAIHN0YXRpYyB2b2lkIGNvbm5lY3RUb1JlRXhlY1Nl cnZpY2UoY29uc3QgUHJvY2Vzc0xhdW5jaGVyOjpMYXVuY2hPcHRpb25zJiBsYXVuY2hPCiAgICAg fQogI2VuZGlmCiAKLSAgICAvLyBHZW5lcmF0ZSB0aGUgdXVpZCBmb3IgdGhlIHNlcnZpY2UgaW5z dGFuY2Ugd2UgYXJlIGFib3V0IHRvIGNyZWF0ZS4KICAgICAvLyBGSVhNRTogVGhpcyBVVUlEIHNo b3VsZCBiZSBzdG9yZWQgb24gdGhlIENoaWxkUHJvY2Vzc1Byb3h5LgogICAgIFJlZlB0cjxVVUlE SG9sZGVyPiBpbnN0YW5jZVVVSUQgPSBVVUlESG9sZGVyOjpjcmVhdGUoKTsKIAogICAgIC8vIEZJ WE1FOiBJdCB3b3VsZCBiZSBuaWNlIGlmIHdlIGNvdWxkIHVzZSBPU09iamVjdFB0ciBmb3IgdGhp cyBjb25uZWN0aW9uIGFzIHdlbGwsIGJ1dCB3ZSdkIGhhdmUgdG8gYmUgY2FyZWZ1bAogICAgIC8v IG5vdCB0byBpbnRyb2R1Y2UgYW55IHJldGFpbiBjeWNsZXMgaW4gdGhlIGNhbGwgdG8geHBjX2Nv bm5lY3Rpb25fc2V0X2V2ZW50X2hhbmRsZXIgYmVsb3cuCiAgICAgeHBjX2Nvbm5lY3Rpb25fdCBy ZUV4ZWNDb25uZWN0aW9uID0geHBjX2Nvbm5lY3Rpb25fY3JlYXRlKHNlcnZpY2VOYW1lKGxhdW5j aE9wdGlvbnMsIHRydWUpLCAwKTsKKyNpZiBQTEFURk9STShJT1MpIHx8IF9fTUFDX09TX1hfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMDAwCisgICAgeHBjX2Nvbm5lY3Rpb25fc2V0X29uZXNo b3RfaW5zdGFuY2UocmVFeGVjQ29ubmVjdGlvbiwgaW5zdGFuY2VVVUlELT51dWlkKTsKKyNlbHNl CiAgICAgeHBjX2Nvbm5lY3Rpb25fc2V0X2luc3RhbmNlKHJlRXhlY0Nvbm5lY3Rpb24sIGluc3Rh bmNlVVVJRC0+dXVpZCk7CisjZW5kaWYKIAogICAgIC8vIEtlZXAgdGhlIFByb2Nlc3NMYXVuY2hl ciBhbGl2ZSB3aGlsZSB3ZSBkbyB0aGUgcmUtZXhlY2luZyAoYmFsYW5jZWQgaW4gZXZlbnQgaGFu ZGxlcikuCiAgICAgdGhhdC0+cmVmKCk7Cg==