145516 2015-06-01 09:59:41 -0700 build-jsc’s —cloop option is broken 2015-06-03 23:56:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145515 145543 145636 1 mark.lam mark.lam commit-queue fpizlo ossy oldest_to_newest 1098513 0 mark.lam 2015-06-01 09:59:41 -0700 After r183516, build-jsc --cloop no longer builds the CLOOP interpreter. This is because it did not explicitly disable the JIT when --cloop is specified. 1098517 1 mark.lam 2015-06-01 10:03:03 -0700 We cannot land this fix until https://bugs.webkit.org/show_bug.cgi?id=145515 is resolved. Otherwise, we’ll have a red CLoop bot. In reality, we do have a red CLoop bot. We just have not been building the CLoop and seeing it. 1098519 2 254005 mark.lam 2015-06-01 10:09:43 -0700 Created attachment 254005 the patch. 1098521 3 254006 mark.lam 2015-06-01 10:12:11 -0700 Created attachment 254006 patch 2: fixed non-ascii chars. 1098547 4 254006 commit-queue 2015-06-01 11:18:04 -0700 Comment on attachment 254006 patch 2: fixed non-ascii chars. Clearing flags on attachment: 254006 Committed r185066: <http://trac.webkit.org/changeset/185066> 1098548 5 commit-queue 2015-06-01 11:18:06 -0700 All reviewed patches have been landed. Closing bug. 1098704 6 fpizlo 2015-06-01 20:17:18 -0700 This broke the FTL JIT build. It's no longer possible to build with LLVM checked out into a local directory after this change. I will roll this out unless you have a quick fix, since this prevents me from doing any work. 1098707 7 commit-queue 2015-06-01 20:25:53 -0700 Re-opened since this is blocked by bug 145543 1098791 8 mark.lam 2015-06-02 10:34:20 -0700 (In reply to comment #6) > This broke the FTL JIT build. It's no longer possible to build with LLVM > checked out into a local directory after this change. > > I will roll this out unless you have a quick fix, since this prevents me > from doing any work. As far as I can tell, this might be the issue: 1. Configurations/LLVMForJSC.xcconfig defines OTHER_LDFLAGS_LLVM = $(OTHER_LDFLAGS_LLVM_$(ENABLE_FTL_JIT)_$(CURRENT_ARCH)); 2. This in turn is used to map to OTHER_LDFLAGS_LLVM_ENABLE_FTL_JIT_x86_64 which provides the list of libs to link against. With the patch, the $ftlJIT case specifies ENABLE_FTL_JIT=ENABLE_FTL_JIT=1 to get the compiler option -DENABLE_FTL_JIT=1. I suspect that this throws a monkey wrench into configuration setup above. Once I change it to ENABLE_FTL_JIT=ENABLE_FTL_JIT, the issue is resolved. I’ll move forward with this as the fix since -DENABLE_FTL_JIT implicitly defines the symbol to 1 anyway i.e. it’s the same as -DENABLE_FTL_JIT=1. 1098793 9 254072 mark.lam 2015-06-02 10:44:27 -0700 Created attachment 254072 patch for re-landing. 1098795 10 mark.lam 2015-06-02 10:49:49 -0700 Patch re-landed in r185110: <http://trac.webkit.org/r185110>. 254005 2015-06-01 10:09:43 -0700 2015-06-01 10:12:11 -0700 the patch. bug-145516.patch text/plain 1937 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTA1OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTA2LTAxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBidWlsZC1qc2PigJlzIOKAlGNsb29wIG9wdGlvbiBpcyBicm9rZW4uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1MTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQt anNjOgorICAgICAgICAtIE1ha2Ugc3VyZSB0byBkaXNhYmxlIHRoZSBKSVQgd2hlbiAtLWNsb29w IGlzIHNwZWNpZmllZC4KKyAgICAgICAgICBEaWQgYW5hbG9nb3VzIGZpeCBmb3IgLS1mdGxqaXQu CisKIDIwMTUtMDYtMDEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAog ICAgICAgICBbY21ha2VdIFN1cHByZXNzIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZ3MgaW4gV2Vi S2l0MiBhbmQgVGVzdE5ldHNjYXBlUGx1Z0luCkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLWpz Ywo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLWpzYwkocmV2aXNpb24gMTg1MDU3 KQorKysgVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MJKHdvcmtpbmcgY29weSkKQEAgLTk1LDggKzk1 LDggQEAgaWYgKCRmb3JjZUNMb29wKSB7CiB9CiAKIGlmIChjbWFrZUJhc2VkUG9ydE5hbWUoKSkg ewotICAgICRjbWFrZUFyZ3MgLj0gJGZvcmNlQ0xvb3AgPyAiIC1ERU5BQkxFX0pJVD1PRkYiIDog IiAtREVOQUJMRV9KSVQ9T04iOwotICAgICRjbWFrZUFyZ3MgLj0gJGZ0bEpJVCA/ICIgLURFTkFC TEVfRlRMX0pJVD1PTiIgOiAiIC1ERU5BQkxFX0ZUTF9KSVQ9T0ZGIjsKKyAgICAkY21ha2VBcmdz IC49ICRmb3JjZUNMb29wID8gIiAtREVOQUJMRV9KSVQ9MCIgOiAiIC1ERU5BQkxFX0pJVD0xIjsK KyAgICAkY21ha2VBcmdzIC49ICRmdGxKSVQgPyAiIC1ERU5BQkxFX0ZUTF9KSVQ9MSIgOiAiIC1E RU5BQkxFX0ZUTF9KSVQ9MCI7CiAgICAgIyBCeSBkZWZhdWx0IHdlIGJ1aWxkIHVzaW5nIGFsbCBv ZiB0aGUgYXZhaWxhYmxlIENQVXMKICAgICAkbWFrZUFyZ3MgLj0gKCRtYWtlQXJncyA/ICIgIiA6 ICIiKSAuICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAkbWFrZUFyZ3MgIX4gLy1qXHMqXGQrLzsK IApAQCAtMTA3LDggKzEwNyw4IEBAIGlmIChjbWFrZUJhc2VkUG9ydE5hbWUoKSkgewogfQogCiBp ZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7Ci0gICAgcHVzaCBAb3B0aW9ucywgKCRmb3JjZUNMb29w ID8gIkVOQUJMRV9KSVQ9IiA6ICJFTkFCTEVfSklUPUVOQUJMRV9KSVQiKTsKLSAgICBwdXNoIEBv cHRpb25zLCAoJGZ0bEpJVCA/ICJFTkFCTEVfRlRMX0pJVD1FTkFCTEVfRlRMX0pJVCIgOiAiRU5B QkxFX0ZUTF9KSVQ9Iik7CisgICAgcHVzaCBAb3B0aW9ucywgKCRmb3JjZUNMb29wID8gIkVOQUJM RV9KSVQ9RU5BQkxFX0pJVD0wIiA6ICJFTkFCTEVfSklUPUVOQUJMRV9KSVQ9MSIpOworICAgIHB1 c2ggQG9wdGlvbnMsICgkZnRsSklUID8gIkVOQUJMRV9GVExfSklUPUVOQUJMRV9GVExfSklUPTEi IDogIkVOQUJMRV9GVExfSklUPUVOQUJMRV9GVExfSklUPTAiKTsKIAogICAgIGlmICgkY29weUxp YnJhcmllcykgewogICAgICAgICBteSBAY29weUxpYnJhcmllc0FyZ3MgPSAoInBlcmwiLCAiVG9v bHMvU2NyaXB0cy9jb3B5LXdlYmtpdGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeSIpOwo= 254006 2015-06-01 10:12:11 -0700 2015-06-02 10:44:27 -0700 patch 2: fixed non-ascii chars. bug-145516.patch text/plain 1934 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTA1OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTA2LTAxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBidWlsZC1qc2MncyAtLWNsb29wIG9wdGlvbiBpcyBicm9rZW4uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1MTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNj OgorICAgICAgICAtIE1ha2Ugc3VyZSB0byBkaXNhYmxlIHRoZSBKSVQgd2hlbiAtLWNsb29wIGlz IHNwZWNpZmllZC4KKyAgICAgICAgICBEaWQgYW5hbG9nb3VzIGZpeCBmb3IgLS1mdGxqaXQuCisK IDIwMTUtMDYtMDEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAg ICAgICBbY21ha2VdIFN1cHByZXNzIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZ3MgaW4gV2ViS2l0 MiBhbmQgVGVzdE5ldHNjYXBlUGx1Z0luCkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLWpzYwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLWpzYwkocmV2aXNpb24gMTg1MDU3KQor KysgVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MJKHdvcmtpbmcgY29weSkKQEAgLTk1LDggKzk1LDgg QEAgaWYgKCRmb3JjZUNMb29wKSB7CiB9CiAKIGlmIChjbWFrZUJhc2VkUG9ydE5hbWUoKSkgewot ICAgICRjbWFrZUFyZ3MgLj0gJGZvcmNlQ0xvb3AgPyAiIC1ERU5BQkxFX0pJVD1PRkYiIDogIiAt REVOQUJMRV9KSVQ9T04iOwotICAgICRjbWFrZUFyZ3MgLj0gJGZ0bEpJVCA/ICIgLURFTkFCTEVf RlRMX0pJVD1PTiIgOiAiIC1ERU5BQkxFX0ZUTF9KSVQ9T0ZGIjsKKyAgICAkY21ha2VBcmdzIC49 ICRmb3JjZUNMb29wID8gIiAtREVOQUJMRV9KSVQ9MCIgOiAiIC1ERU5BQkxFX0pJVD0xIjsKKyAg ICAkY21ha2VBcmdzIC49ICRmdGxKSVQgPyAiIC1ERU5BQkxFX0ZUTF9KSVQ9MSIgOiAiIC1ERU5B QkxFX0ZUTF9KSVQ9MCI7CiAgICAgIyBCeSBkZWZhdWx0IHdlIGJ1aWxkIHVzaW5nIGFsbCBvZiB0 aGUgYXZhaWxhYmxlIENQVXMKICAgICAkbWFrZUFyZ3MgLj0gKCRtYWtlQXJncyA/ICIgIiA6ICIi KSAuICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAkbWFrZUFyZ3MgIX4gLy1qXHMqXGQrLzsKIApA QCAtMTA3LDggKzEwNyw4IEBAIGlmIChjbWFrZUJhc2VkUG9ydE5hbWUoKSkgewogfQogCiBpZiAo aXNBcHBsZU1hY1dlYktpdCgpKSB7Ci0gICAgcHVzaCBAb3B0aW9ucywgKCRmb3JjZUNMb29wID8g IkVOQUJMRV9KSVQ9IiA6ICJFTkFCTEVfSklUPUVOQUJMRV9KSVQiKTsKLSAgICBwdXNoIEBvcHRp b25zLCAoJGZ0bEpJVCA/ICJFTkFCTEVfRlRMX0pJVD1FTkFCTEVfRlRMX0pJVCIgOiAiRU5BQkxF X0ZUTF9KSVQ9Iik7CisgICAgcHVzaCBAb3B0aW9ucywgKCRmb3JjZUNMb29wID8gIkVOQUJMRV9K SVQ9RU5BQkxFX0pJVD0wIiA6ICJFTkFCTEVfSklUPUVOQUJMRV9KSVQ9MSIpOworICAgIHB1c2gg QG9wdGlvbnMsICgkZnRsSklUID8gIkVOQUJMRV9GVExfSklUPUVOQUJMRV9GVExfSklUPTEiIDog IkVOQUJMRV9GVExfSklUPUVOQUJMRV9GVExfSklUPTAiKTsKIAogICAgIGlmICgkY29weUxpYnJh cmllcykgewogICAgICAgICBteSBAY29weUxpYnJhcmllc0FyZ3MgPSAoInBlcmwiLCAiVG9vbHMv U2NyaXB0cy9jb3B5LXdlYmtpdGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeSIpOwo= 254072 2015-06-02 10:44:27 -0700 2015-06-02 10:44:27 -0700 patch for re-landing. bug-145516.patch text/plain 1902 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTEwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTA2LTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBidWlsZC1qc2MncyAtLWNsb29wIG9wdGlvbiBpcyBicm9rZW4uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1MTYKKworICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOgor ICAgICAgICAtIE1ha2Ugc3VyZSB0byBkaXNhYmxlIHRoZSBKSVQgd2hlbiAtLWNsb29wIGlzIHNw ZWNpZmllZC4KKyAgICAgICAgICBEaWQgYW5hbG9nb3VzIGZpeCBmb3IgLS1mdGxqaXQuCisKIDIw MTUtMDYtMDIgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFVw ZGF0ZSBBVFMga2V5cyB1c2VkIGluIE1pbmlCcm93c2VyIGFuZCBXZWJLaXRUZXN0UnVubmVyQXBw CkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLWpzYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL2J1aWxkLWpzYwkocmV2aXNpb24gMTg1MTA1KQorKysgVG9vbHMvU2NyaXB0cy9idWlsZC1q c2MJKHdvcmtpbmcgY29weSkKQEAgLTk1LDggKzk1LDggQEAgaWYgKCRmb3JjZUNMb29wKSB7CiB9 CiAKIGlmIChjbWFrZUJhc2VkUG9ydE5hbWUoKSkgewotICAgICRjbWFrZUFyZ3MgLj0gJGZvcmNl Q0xvb3AgPyAiIC1ERU5BQkxFX0pJVD1PRkYiIDogIiAtREVOQUJMRV9KSVQ9T04iOwotICAgICRj bWFrZUFyZ3MgLj0gJGZ0bEpJVCA/ICIgLURFTkFCTEVfRlRMX0pJVD1PTiIgOiAiIC1ERU5BQkxF X0ZUTF9KSVQ9T0ZGIjsKKyAgICAkY21ha2VBcmdzIC49ICRmb3JjZUNMb29wID8gIiAtREVOQUJM RV9KSVQ9MCIgOiAiIC1ERU5BQkxFX0pJVCI7CisgICAgJGNtYWtlQXJncyAuPSAkZnRsSklUID8g IiAtREVOQUJMRV9GVExfSklUIiA6ICIgLURFTkFCTEVfRlRMX0pJVD0wIjsKICAgICAjIEJ5IGRl ZmF1bHQgd2UgYnVpbGQgdXNpbmcgYWxsIG9mIHRoZSBhdmFpbGFibGUgQ1BVcwogICAgICRtYWtl QXJncyAuPSAoJG1ha2VBcmdzID8gIiAiIDogIiIpIC4gIi1qIiAuIG51bWJlck9mQ1BVcygpIGlm ICRtYWtlQXJncyAhfiAvLWpccypcZCsvOwogCkBAIC0xMDcsOCArMTA3LDggQEAgaWYgKGNtYWtl QmFzZWRQb3J0TmFtZSgpKSB7CiB9CiAKIGlmIChpc0FwcGxlTWFjV2ViS2l0KCkpIHsKLSAgICBw dXNoIEBvcHRpb25zLCAoJGZvcmNlQ0xvb3AgPyAiRU5BQkxFX0pJVD0iIDogIkVOQUJMRV9KSVQ9 RU5BQkxFX0pJVCIpOwotICAgIHB1c2ggQG9wdGlvbnMsICgkZnRsSklUID8gIkVOQUJMRV9GVExf SklUPUVOQUJMRV9GVExfSklUIiA6ICJFTkFCTEVfRlRMX0pJVD0iKTsKKyAgICBwdXNoIEBvcHRp b25zLCAoJGZvcmNlQ0xvb3AgPyAiRU5BQkxFX0pJVD1FTkFCTEVfSklUPTAiIDogIkVOQUJMRV9K SVQ9RU5BQkxFX0pJVCIpOworICAgIHB1c2ggQG9wdGlvbnMsICgkZnRsSklUID8gIkVOQUJMRV9G VExfSklUPUVOQUJMRV9GVExfSklUIiA6ICJFTkFCTEVfRlRMX0pJVD1FTkFCTEVfRlRMX0pJVD0w Iik7CiAKICAgICBpZiAoJGNvcHlMaWJyYXJpZXMpIHsKICAgICAgICAgbXkgQGNvcHlMaWJyYXJp ZXNBcmdzID0gKCJwZXJsIiwgIlRvb2xzL1NjcmlwdHMvY29weS13ZWJraXRsaWJyYXJpZXMtdG8t cHJvZHVjdC1kaXJlY3RvcnkiKTsK