145511 2015-06-01 05:46:06 -0700 Fix the webkitpy scm unittests after r174051 2015-07-08 05:07:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137166 143967 1 ossy ossy commit-queue darin glenn mcatanzaro mmaxfield ossy oldest_to_newest 1098482 0 ossy 2015-06-01 05:46:06 -0700 http://trac.webkit.org/changeset/174051 broke the SCM tests ( Tools/Scripts/test-webkitpy -a ) [119/1563] webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch erred: Traceback (most recent call last): File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1569, in test_create_patch scm = self.make_scm(logging_executive=True) File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem()) TypeError: __init__() takes exactly 3 arguments (2 given) ... r174051 added one more argument to Git.__init__ , but didn't add it to the unittest. 1098483 1 253995 ossy 2015-06-01 05:47:37 -0700 Created attachment 253995 Patch 1098537 2 253995 commit-queue 2015-06-01 11:00:28 -0700 Comment on attachment 253995 Patch Clearing flags on attachment: 253995 Committed r185064: <http://trac.webkit.org/changeset/185064> 1098538 3 commit-queue 2015-06-01 11:00:33 -0700 All reviewed patches have been landed. Closing bug. 1098557 4 mcatanzaro 2015-06-01 11:45:20 -0700 Were those the only failures you're seeing? I reported a bunch of failures in bug #143967; maybe the others have been fixed somehow. 1107729 5 ossy 2015-07-08 05:07:58 -0700 (In reply to comment #4) > Were those the only failures you're seeing? I reported a bunch of failures > in bug #143967; maybe the others have been fixed somehow. Yes, I have no failure now on Ubuntu 14.04. 253995 2015-06-01 05:47:37 -0700 2015-06-01 11:00:28 -0700 Patch bug-145511-20150601054719.patch text/plain 1673 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGQ4YTMxNzlkZWU3YThiNmU1OWFhNWM0NThlNjQ2YTA2 MzljMjNiYS4uOTk3NDY0YThkMWM2MmU1ZDRkNjBjYTk1NTlmMzkzNzk2NWM2YTNkOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1 IEBACiAyMDE1LTA2LTAxICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgRml4IHRoZSB3ZWJraXRweSBzY20gdW5pdHRlc3RzIGFmdGVyIHIxNzQwNTEKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTUxMQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3NjbV91bml0dGVzdC5weToKKyAgICAgICAgKEdp dFRlc3RXaXRoTW9jay5tYWtlX3NjbSk6CisKKzIwMTUtMDYtMDEgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KKwogICAgICAgICBbY21ha2VdIFN1cHByZXNzIHVudXNlZCBw YXJhbWV0ZXIgd2FybmluZ3MgaW4gV2ViS2l0MiBhbmQgVGVzdE5ldHNjYXBlUGx1Z0luCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUyNjQKIApkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3NjbV91 bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9z Y21fdW5pdHRlc3QucHkKaW5kZXggZWRmMjJiMTU3MDIwMWNlYThkNTc4YzZiM2U5NDMxYzYyZGZj MzkxMi4uZDc3MmQ3OWYwNTg4N2YwYTcxZGZjNGQ3Y2Q3YTQxODEwOGFmOTViNyAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3NjbV91bml0dGVz dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc2Nt X3VuaXR0ZXN0LnB5CkBAIC0xNTYwLDcgKzE1NjAsNyBAQCBjbGFzcyBHaXRUZXN0V2l0aE1vY2so dW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgZGVmIG1ha2Vfc2NtKHNlbGYsIGxvZ2dpbmdfZXhl Y3V0aXZlPUZhbHNlKToKICAgICAgICAgIyBXZSBkbyB0aGlzIHNob3VsZF9sb2cgZGFuY2UgdG8g YXZvaWQgbG9nZ2luZyB3aGVuIEdpdC5fX2luaXRfXyBydW5zIHN5c2N0bCBvbiBtYWMgdG8gY2hl Y2sgZm9yIDY0LWJpdCBzdXBwb3J0LgotICAgICAgICBzY20gPSBHaXQoY3dkPSIuIiwgZXhlY3V0 aXZlPU1vY2tFeGVjdXRpdmUoKSwgZmlsZXN5c3RlbT1Nb2NrRmlsZVN5c3RlbSgpKQorICAgICAg ICBzY20gPSBHaXQoY3dkPSIuIiwgcGF0Y2hfZGlyZWN0b3JpZXM9Tm9uZSwgZXhlY3V0aXZlPU1v Y2tFeGVjdXRpdmUoKSwgZmlsZXN5c3RlbT1Nb2NrRmlsZVN5c3RlbSgpKQogICAgICAgICBzY20u cmVhZF9naXRfY29uZmlnID0gbGFtYmRhICphcmdzLCAqKmt3OiAiTU9DS0tFWTpNT0NLVkFMVUUi CiAgICAgICAgIHNjbS5fZXhlY3V0aXZlLl9zaG91bGRfbG9nID0gbG9nZ2luZ19leGVjdXRpdmUK ICAgICAgICAgcmV0dXJuIHNjbQo=