145502 2015-05-31 10:59:34 -0700 CallLinkStatus should return takesSlowPath if the GC often cleared the IC 2015-06-03 13:08:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin commit-queue ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1098415 0 fpizlo 2015-05-31 10:59:34 -0700 ... 1098952 1 254119 fpizlo 2015-06-02 15:47:08 -0700 Created attachment 254119 the patch 1098953 2 commit-queue 2015-06-02 15:48:37 -0700 Attachment 254119 did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:61: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1099186 3 254119 ggaren 2015-06-03 10:38:41 -0700 Comment on attachment 254119 the patch r=me 1099233 4 fpizlo 2015-06-03 13:08:49 -0700 Landed in http://trac.webkit.org/changeset/185161 254119 2015-06-02 15:47:08 -0700 2015-06-03 10:38:41 -0700 the patch blah.patch text/plain 6183 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1MTMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE1LTA2LTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q2FsbExpbmtTdGF0dXMgc2hvdWxkIHJldHVybiB0YWtlc1Nsb3dQYXRoIGlmIHRoZSBHQyBvZnRl biBjbGVhcmVkIHRoZSBJQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ1NTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIAorICAgICAgICBDYWxsTGlua0luZm8gbm93IHJlbWVtYmVycyB3aGVuIGl0IGhhcyBi ZWVuIGNsZWFyZWQgYnkgR0MuIFRoaXMgaGFzIHNvbWUgc2FmZWd1YXJkcyBmb3Igd2hlbgorICAg ICAgICBhIGNhbGwgZ2V0cyBjbGVhcmVkIGJ5IEdDIG9ubHkgYmVjYXVzZSB3ZSBoYWRuJ3QgY29u dmVydGVkIGl0IGludG8gYSBjbG9zdXJlIGNhbGw7IGluIHRoYXQKKyAgICAgICAgY2FzZSB0aGUg R0Mgd2lsbCBqdXN0IHRlbGwgdXMgdGhhdCBpdCBzaG91bGQgYmUgYSBjbG9zdXJlIGNhbGwuIFRo ZSBERkcgd2lsbCBub3Qgb3B0aW1pemUKKyAgICAgICAgYSBjYWxsIHRoYXQgd2FzIGNsZWFyZWQg YnkgR0MsIGFuZCB0aGUgREZHIHdpbGwgYWx3YXlzIHByZWZlciBhIGNsb3N1cmUgY2FsbCBpZiB0 aGUgR0MgdG9sZAorICAgICAgICB1cyB0aGF0IHRoZSBzcGVjaWZpYyBjYWxsZWUgd2FzIGRlYWQg YnV0IHRoZSBleGVjdXRhYmxlIHdhc24ndC4KKyAgICAgICAgCisgICAgICAgIFRoaXMgZ3VhcmRz IHVzIGZyb20gc29tZSBzY2VuYXJpb3MgdGhhdCBjYW1lIHVwIGluIFNwZWVkb21ldGVyLiBJdCdz IG5ldXRyYWwgb24gdGhlIHB1cmUgSlMKKyAgICAgICAgYmVuY2htYXJrcywgbW9zdCBsaWtlbHkg anVzdCBiZWNhdXNlIHRob3NlIGJlbmNobWFya3MgYXJlbid0IHJlYWwgZW5vdWdoIHRvIGhhdmUg aW50ZXJlc3RpbmcKKyAgICAgICAgR0Mgb2YgY29kZS4KKworICAgICAgICAqIGJ5dGVjb2RlL0Nh bGxMaW5rSW5mby5jcHA6CisgICAgICAgIChKU0M6OkNhbGxMaW5rSW5mbzo6dmlzaXRXZWFrKToK KyAgICAgICAgKEpTQzo6Q2FsbExpbmtJbmZvOjpkdW1teSk6CisgICAgICAgICogYnl0ZWNvZGUv Q2FsbExpbmtJbmZvLmg6CisgICAgICAgIChKU0M6OkNhbGxMaW5rSW5mbzo6Q2FsbExpbmtJbmZv KToKKyAgICAgICAgKiBieXRlY29kZS9DYWxsTGlua1N0YXR1cy5jcHA6CisgICAgICAgIChKU0M6 OkNhbGxMaW5rU3RhdHVzOjpjb21wdXRlRnJvbUNhbGxMaW5rSW5mbyk6CisKIDIwMTUtMDYtMDIg IEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgSmF2YVNj cmlwdENvcmU6IEpTRXhwb3J0IHByb3RvY29sIHdpdGggYW4gTlNJbnRlZ2VyIHByb3BlcnR5IGNv bnZlcnRzIG5lZ2F0aXZlIHZhbHVlcyB0byAxODQ0Njc0NDA3MzcwOTU1MjAwMApJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NhbGxMaW5rSW5mby5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NhbGxMaW5rSW5mby5jcHAJKHJldmlz aW9uIDE4NTEwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9DYWxsTGlua0lu Zm8uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCw2ICs1OCwxMyBAQCB2b2lkIENhbGxMaW5rSW5m bzo6dW5saW5rKFJlcGF0Y2hCdWZmZXImCiAKIHZvaWQgQ2FsbExpbmtJbmZvOjp2aXNpdFdlYWso UmVwYXRjaEJ1ZmZlciYgcmVwYXRjaEJ1ZmZlcikKIHsKKyAgICBhdXRvIGhhbmRsZVNwZWNpZmlj Q2FsbGVlID0gWyZdIChKU0Z1bmN0aW9uKiBjYWxsZWUpIHsKKyAgICAgICAgaWYgKEhlYXA6Omlz TWFya2VkKGNhbGxlZS0+ZXhlY3V0YWJsZSgpKSkKKyAgICAgICAgICAgIGhhc1NlZW5DbG9zdXJl ID0gdHJ1ZTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgY2xlYXJlZEJ5R0MgPSB0cnVlOwor ICAgIH07CisgICAgCiAgICAgaWYgKGlzTGlua2VkKCkpIHsKICAgICAgICAgaWYgKHN0dWIpIHsK ICAgICAgICAgICAgIGlmICghc3R1Yi0+dmlzaXRXZWFrKHJlcGF0Y2hCdWZmZXIpKSB7CkBAIC02 OCw2ICs3NSw3IEBAIHZvaWQgQ2FsbExpbmtJbmZvOjp2aXNpdFdlYWsoUmVwYXRjaEJ1ZmYKICAg ICAgICAgICAgICAgICAgICAgICAgICIuXG4iKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAg ICAgICAgICAgdW5saW5rKHJlcGF0Y2hCdWZmZXIpOworICAgICAgICAgICAgICAgIGNsZWFyZWRC eUdDID0gdHJ1ZTsKICAgICAgICAgICAgIH0KICAgICAgICAgfSBlbHNlIGlmICghSGVhcDo6aXNN YXJrZWQoY2FsbGVlLmdldCgpKSkgewogICAgICAgICAgICAgaWYgKE9wdGlvbnM6OnZlcmJvc2VP U1IoKSkgewpAQCAtNzcsMTEgKzg1LDE0IEBAIHZvaWQgQ2FsbExpbmtJbmZvOjp2aXNpdFdlYWso UmVwYXRjaEJ1ZmYKICAgICAgICAgICAgICAgICAgICAgY2FsbGVlLmdldCgpLT5leGVjdXRhYmxl KCktPmhhc2hGb3Ioc3BlY2lhbGl6YXRpb25LaW5kKCkpLAogICAgICAgICAgICAgICAgICAgICAi KS5cbiIpOwogICAgICAgICAgICAgfQorICAgICAgICAgICAgaGFuZGxlU3BlY2lmaWNDYWxsZWUo Y2FsbGVlLmdldCgpKTsKICAgICAgICAgICAgIHVubGluayhyZXBhdGNoQnVmZmVyKTsKICAgICAg ICAgfQogICAgIH0KLSAgICBpZiAoISFsYXN0U2VlbkNhbGxlZSAmJiAhSGVhcDo6aXNNYXJrZWQo bGFzdFNlZW5DYWxsZWUuZ2V0KCkpKQorICAgIGlmICghIWxhc3RTZWVuQ2FsbGVlICYmICFIZWFw Ojppc01hcmtlZChsYXN0U2VlbkNhbGxlZS5nZXQoKSkpIHsKKyAgICAgICAgaGFuZGxlU3BlY2lm aWNDYWxsZWUobGFzdFNlZW5DYWxsZWUuZ2V0KCkpOwogICAgICAgICBsYXN0U2VlbkNhbGxlZS5j bGVhcigpOworICAgIH0KIH0KIAogQ2FsbExpbmtJbmZvJiBDYWxsTGlua0luZm86OmR1bW15KCkK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9DYWxsTGlua0luZm8uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ2FsbExpbmtJbmZvLmgJ KHJldmlzaW9uIDE4NTEwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9DYWxs TGlua0luZm8uaAkod29ya2luZyBjb3B5KQpAQCAtNTksNiArNTksNyBAQCBzdHJ1Y3QgQ2FsbExp bmtJbmZvIDogcHVibGljIEJhc2ljUmF3U2VuCiAgICAgICAgIDogaXNGVEwoZmFsc2UpCiAgICAg ICAgICwgaGFzU2VlblNob3VsZFJlcGF0Y2goZmFsc2UpCiAgICAgICAgICwgaGFzU2VlbkNsb3N1 cmUoZmFsc2UpCisgICAgICAgICwgY2xlYXJlZEJ5R0MoZmFsc2UpCiAgICAgICAgICwgY2FsbFR5 cGUoTm9uZSkKICAgICAgICAgLCBtYXhOdW1Bcmd1bWVudHMoMCkKICAgICAgICAgLCBzbG93UGF0 aENvdW50KDApCkBAIC05Miw3ICs5Myw4IEBAIHN0cnVjdCBDYWxsTGlua0luZm8gOiBwdWJsaWMg QmFzaWNSYXdTZW4KICAgICBib29sIGlzRlRMIDogMTsKICAgICBib29sIGhhc1NlZW5TaG91bGRS ZXBhdGNoIDogMTsKICAgICBib29sIGhhc1NlZW5DbG9zdXJlIDogMTsKLSAgICB1bnNpZ25lZCBj YWxsVHlwZSA6IDU7IC8vIENhbGxUeXBlCisgICAgYm9vbCBjbGVhcmVkQnlHQyA6IDE7CisgICAg dW5zaWduZWQgY2FsbFR5cGUgOiA0OyAvLyBDYWxsVHlwZQogICAgIHVuc2lnbmVkIGNhbGxlZUdQ UiA6IDg7CiAgICAgdWludDhfdCBtYXhOdW1Bcmd1bWVudHM7IC8vIE9ubHkgdXNlZCBmb3IgdmFy YXJncyBjYWxscy4KICAgICB1aW50MzJfdCBzbG93UGF0aENvdW50OwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NhbGxMaW5rU3RhdHVzLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ2FsbExpbmtTdGF0dXMuY3BwCShyZXZpc2lv biAxODUxMDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ2FsbExpbmtTdGF0 dXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzYsNiArMTM2LDkgQEAgQ2FsbExpbmtTdGF0dXMg Q2FsbExpbmtTdGF0dXM6OmNvbXB1dGVGbwogQ2FsbExpbmtTdGF0dXMgQ2FsbExpbmtTdGF0dXM6 OmNvbXB1dGVGcm9tQ2FsbExpbmtJbmZvKAogICAgIGNvbnN0IENvbmN1cnJlbnRKSVRMb2NrZXIm LCBDYWxsTGlua0luZm8mIGNhbGxMaW5rSW5mbykKIHsKKyAgICBpZiAoY2FsbExpbmtJbmZvLmNs ZWFyZWRCeUdDKQorICAgICAgICByZXR1cm4gdGFrZXNTbG93UGF0aCgpOworICAgIAogICAgIC8v IE5vdGUgdGhhdCBkZXNwaXRlIHJlcXVpcmluZyB0aGF0IHRoZSBsb2NrZXIgaXMgaGVsZCwgdGhp cyBjb2RlIGlzIHJhY3kgd2l0aCByZXNwZWN0CiAgICAgLy8gdG8gdGhlIENhbGxMaW5rSW5mbzog aXQgbWF5IGdldCBjbGVhcmVkIHdoaWxlIHRoaXMgY29kZSBydW5zISBUaGlzIGlzIGJlY2F1c2UK ICAgICAvLyBDYWxsTGlua0luZm86OnVubGluaygpIG1heSBiZSBjYWxsZWQgZnJvbSBhIGRpZmZl cmVudCBDb2RlQmxvY2sgdGhhbiB0aGUgb25lIHRoYXQgb3ducwpAQCAtMTQ5LDExICsxNTIsNiBA QCBDYWxsTGlua1N0YXR1cyBDYWxsTGlua1N0YXR1czo6Y29tcHV0ZUZyCiAgICAgLy8gdGhhdCBp cyBzdGlsbCBtYXJnaW5hbGx5IHZhbGlkIChpLmUuIHRoZSBwb2ludGVycyBhaW4ndCBzdGFsZSku IFRoaXMga2luZCBvZiByYWNpbmVzcwogICAgIC8vIGlzIHByb2JhYmx5IE9LIGZvciBub3cuCiAg ICAgCi0gICAgLy8gRklYTUU6IElmIHRoZSBHQyBvZnRlbiBjbGVhcnMgdGhpcyBjYWxsLCB3ZSBz aG91bGQgcHJvYmFibHkgdHJlYXQgaXQgbGlrZSBpdCBhbHdheXMgdGFrZXMgdGhlCi0gICAgLy8g c2xvdyBwYXRoLiBXZSBjb3VsZCBiZSBzbWFydCBhYm91dCB0aGlzOyBmb3IgZXhhbXBsZSBpZiB3 ZSBjbGVhcmVkIGEgc3BlY2lmaWMgY2FsbGVlIGJ1dCB0aGUKLSAgICAvLyBkZXNwZWNpZmllZCBl eGVjdXRhYmxlIHdhcyBhbGl2ZSB0aGVuIHdlIGNvdWxkIG5vdGUgdGhhdCBzZXBhcmF0ZWx5Lgot ICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU1MDIKLSAg ICAKICAgICAvLyBQb2x5bW9ycGhpY0NhbGxTdHViUm91dGluZSBpcyBhIEdDQXdhcmVKSVRTdHVi Um91dGluZSwgc28gaWYgbm9uLW51bGwsIGl0IHdpbGwgc3RheSBhbGl2ZQogICAgIC8vIHVudGls IG5leHQgR0MgZXZlbiBpZiB0aGUgQ2FsbExpbmtJbmZvIGlzIGNvbmN1cnJlbnRseSBjbGVhcmVk LiBBbHNvLCB0aGUgdmFyaWFudHMgbGlzdCBpcwogICAgIC8vIG5ldmVyIG11dGF0ZWQgYWZ0ZXIg dGhlIFBvbHltb3JwaGljQ2FsbFN0dWJSb3V0aW5lIGlzIGluc3RhbnRpYXRlZC4gV2UgaGF2ZSBz b21lIGNvbnNlcnZhdGl2ZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNo LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3Bw CShyZXZpc2lvbiAxODUxMDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2gu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzQ1LDYgKzE3NDUsOSBAQCB2b2lkIGxpbmtQb2x5bW9y cGhpY0NhbGwoCiAgICAgICAgIH0KICAgICB9CiAgICAgCisgICAgaWYgKGlzQ2xvc3VyZUNhbGwp CisgICAgICAgIGNhbGxMaW5rSW5mby5oYXNTZWVuQ2xvc3VyZSA9IHRydWU7CisgICAgCiAgICAg VmVjdG9yPFBvbHltb3JwaGljQ2FsbENhc2U+IGNhbGxDYXNlczsKICAgICAKICAgICAvLyBGaWd1 cmUgb3V0IHdoYXQgb3VyIGNhc2VzIGFyZS4K