145499 2015-05-31 06:49:19 -0700 SharedBuffer::copy should return a Ref<SharedBuffer> 2015-06-02 02:09:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue darin japhet oldest_to_newest 1098403 0 youennf 2015-05-31 06:49:19 -0700 Following on bug 138506, SharedBufer::copy should return a Ref, not a PassRefPtr 1098404 1 253978 youennf 2015-05-31 07:07:52 -0700 Created attachment 253978 Patch 1098420 2 253978 kling 2015-05-31 12:13:37 -0700 Comment on attachment 253978 Patch r=me 1098759 3 253978 commit-queue 2015-06-02 02:09:16 -0700 Comment on attachment 253978 Patch Clearing flags on attachment: 253978 Committed r185106: <http://trac.webkit.org/changeset/185106> 1098760 4 commit-queue 2015-06-02 02:09:19 -0700 All reviewed patches have been landed. Closing bug. 253978 2015-05-31 07:07:52 -0700 2015-06-02 02:09:16 -0700 Patch bug-145499-20150531160730.patch text/plain 4624 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRjZjA1NmEzOGU5ZjQ2 ODgzMzBiMzkzNDc5YWM2ZWFjNjg2NTAzNy4uM2RlOTdjMzg1ZWJlNzU5ZjlmYWY4MjBjN2FiN2U4 OTZkZDczY2NmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA1LTMxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgU2hhcmVk QnVmZmVyOjpjb3B5IHNob3VsZCByZXR1cm4gYSBSZWY8U2hhcmVkQnVmZmVyPgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NDk5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdpbmcgU2hhcmVkQnVm ZmVyOjpjb3B5IHRvIHJldHVybiBhIFJlZjw+IGFuZCBhZGFwdGluZyBzb21lIGNvZGUgYWNjb3Jk aW5nbHkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAq IGxvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdWJyZXNv dXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKyAgICAgICAgKiBsb2FkZXIvYXBwY2Fj aGUvQXBwbGljYXRpb25DYWNoZVJlc291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGxp Y2F0aW9uQ2FjaGVSZXNvdXJjZTo6ZGVsaXZlcik6CisgICAgICAgICogcGxhdGZvcm0vU2hhcmVk QnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6Y29weSk6CisgICAg ICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmg6CisKIDIwMTUtMDUtMzAgIFlvdWVubiBGYWJs ZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBBc3luYyBYTUxIdHRw UmVxdWVzdCBzaG91bGQgZ2V0IGFjY2VzcyB0byBBcHBDYWNoZSByZXNvdXJjZXMgc3RvcmVkIGFz IGZsYXQgZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJj ZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3Bw CmluZGV4IGJiZjE1OTNiODgyZTQ3MTk5NjRkYjNhN2E5MjgyNmFkZDU0ZGVhMmYuLjA4MDgzMTY3 MDc1Mjg0Y2E0NDRjZTU0MzE1MjllYTAzNjc3MjRlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcApAQCAtMjUxLDcgKzI1MSw3IEBAIHZvaWQgU3VicmVz b3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiBy ZXNwb25zZSkKICAgICBhdXRvKiBidWZmZXIgPSByZXNvdXJjZURhdGEoKTsKICAgICBpZiAobV9s b2FkaW5nTXVsdGlwYXJ0Q29udGVudCAmJiBidWZmZXIgJiYgYnVmZmVyLT5zaXplKCkpIHsKICAg ICAgICAgLy8gVGhlIHJlc291cmNlIGRhdGEgd2lsbCBjaGFuZ2UgYXMgdGhlIG5leHQgcGFydCBp cyBsb2FkZWQsIHNvIHdlIG5lZWQgdG8gbWFrZSBhIGNvcHkuCi0gICAgICAgIG1fcmVzb3VyY2Ut PmZpbmlzaExvYWRpbmcoYnVmZmVyLT5jb3B5KCkuZ2V0KCkpOworICAgICAgICBtX3Jlc291cmNl LT5maW5pc2hMb2FkaW5nKGJ1ZmZlci0+Y29weSgpLnB0cigpKTsKICAgICAgICAgY2xlYXJSZXNv dXJjZURhdGEoKTsKICAgICAgICAgLy8gU2luY2UgYSBzdWJyZXNvdXJjZSBsb2FkZXIgZG9lcyBu b3QgbG9hZCBtdWx0aXBhcnQgc2VjdGlvbnMgcHJvZ3Jlc3NpdmVseSwgZGF0YSB3YXMgZGVsaXZl cmVkIHRvIHRoZSBsb2FkZXIgYWxsIGF0IG9uY2UuICAgICAgICAKICAgICAgICAgLy8gQWZ0ZXIg dGhlIGZpcnN0IG11bHRpcGFydCBzZWN0aW9uIGlzIGNvbXBsZXRlLCBzaWduYWwgdG8gZGVsZWdh dGVzIHRoYXQgdGhpcyBsb2FkIGlzICJmaW5pc2hlZCIgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZVJlc291cmNlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2UuY3BwCmlu ZGV4IDhlYzU2ZGYyYTlmMzYxZmU3YTMzNGYxYTNkMDRjN2NiMjU0MjVjNmQuLmJmMDY0MDgzMDQ3 NDA1NzNhMTZjOWJjNWQ2MTZjYTJmNWQ0Y2MyNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2UuY3BwCkBA IC00MCwxMiArNDAsNyBAQCBBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2U6OkFwcGxpY2F0aW9uQ2Fj aGVSZXNvdXJjZShjb25zdCBVUkwmIHVybCwgY29uc3QgUmVzb3VyYwogCiB2b2lkIEFwcGxpY2F0 aW9uQ2FjaGVSZXNvdXJjZTo6ZGVsaXZlcihSZXNvdXJjZUxvYWRlciYgbG9hZGVyKQogewotICAg IFJlZlB0cjxTaGFyZWRCdWZmZXI+IGJ1ZmZlcjsKLSAgICBpZiAobV9wYXRoLmlzRW1wdHkoKSkK LSAgICAgICAgYnVmZmVyID0gZGF0YSgpLT5jb3B5KCk7Ci0gICAgZWxzZQotICAgICAgICBidWZm ZXIgPSBTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhDb250ZW50c09mRmlsZShtX3BhdGgpOwotICAg IGxvYWRlci5kZWxpdmVyUmVzcG9uc2VBbmREYXRhKHJlc3BvbnNlKCksIFdURjo6bW92ZShidWZm ZXIpKTsKKyAgICBsb2FkZXIuZGVsaXZlclJlc3BvbnNlQW5kRGF0YShyZXNwb25zZSgpLCBtX3Bh dGguaXNFbXB0eSgpID8gZGF0YSgpLT5jb3B5KCkgOiBTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhD b250ZW50c09mRmlsZShtX3BhdGgpKTsKIH0KIAogdm9pZCBBcHBsaWNhdGlvbkNhY2hlUmVzb3Vy Y2U6OmFkZFR5cGUodW5zaWduZWQgdHlwZSkgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVk QnVmZmVyLmNwcAppbmRleCA2NDZlMmFjNjQwYjliNjAwYTkxNGNiMWRjZjRhNjllZjc4ZTEyMGM5 Li41MzM5NjFmYTBkMWQzMDk1ODVmYWM4NWM0YzljYWE2MDcyNDdiMDM0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAKQEAgLTI1MCwxMyArMjUwLDEzIEBAIHZvaWQg U2hhcmVkQnVmZmVyOjpjbGVhcigpCiAgICAgY2xlYXJEYXRhQnVmZmVyKCk7CiB9CiAKLVBhc3NS ZWZQdHI8U2hhcmVkQnVmZmVyPiBTaGFyZWRCdWZmZXI6OmNvcHkoKSBjb25zdAorUmVmPFNoYXJl ZEJ1ZmZlcj4gU2hhcmVkQnVmZmVyOjpjb3B5KCkgY29uc3QKIHsKLSAgICBSZWZQdHI8U2hhcmVk QnVmZmVyPiBjbG9uZSB7IGFkb3B0UmVmKCpuZXcgU2hhcmVkQnVmZmVyKSB9OworICAgIFJlZjxT aGFyZWRCdWZmZXI+IGNsb25lIHsgYWRvcHRSZWYoKm5ldyBTaGFyZWRCdWZmZXIpIH07CiAKICAg ICBpZiAoaGFzUGxhdGZvcm1EYXRhKCkgfHwgbV9maWxlRGF0YSkgewogICAgICAgICBjbG9uZS0+ YXBwZW5kKGRhdGEoKSwgc2l6ZSgpKTsKLSAgICAgICAgcmV0dXJuIGNsb25lLnJlbGVhc2UoKTsK KyAgICAgICAgcmV0dXJuIGNsb25lOwogICAgIH0KIAogICAgIGNsb25lLT5tX3NpemUgPSBtX3Np emU7CkBAIC0yNzIsNyArMjcyLDcgQEAgUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IFNoYXJlZEJ1 ZmZlcjo6Y29weSgpIGNvbnN0CiAjZW5kaWYKICAgICBBU1NFUlQoY2xvbmUtPnNpemUoKSA9PSBz aXplKCkpOwogCi0gICAgcmV0dXJuIGNsb25lLnJlbGVhc2UoKTsKKyAgICByZXR1cm4gY2xvbmU7 CiB9CiAKIHZvaWQgU2hhcmVkQnVmZmVyOjpkdXBsaWNhdGVEYXRhQnVmZmVySWZOZWNlc3Nhcnko KSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVy LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuaAppbmRleCA0NGFhODE4 MjFkZTUxNjg4MWQ0NWFiZDM4NzQwYmE4OGQ4NmVlOTI5Li4wNTJhMmFlOWY1ZDA2ODNiZDkyZTY0 N2RhYmUwMTcwNDczODExMWYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T aGFyZWRCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIu aApAQCAtMTAyLDcgKzEwMiw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGFwcGVuZChDRkRhdGFSZWYp OwogI2VuZGlmCiAKLSAgICBXRUJDT1JFX0VYUE9SVCBQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4g Y29weSgpIGNvbnN0OworICAgIFdFQkNPUkVfRVhQT1JUIFJlZjxTaGFyZWRCdWZmZXI+IGNvcHko KSBjb25zdDsKICAgICAKICAgICAvLyBSZXR1cm4gdGhlIG51bWJlciBvZiBjb25zZWN1dGl2ZSBi eXRlcyBhZnRlciAicG9zaXRpb24iLiAiZGF0YSIKICAgICAvLyBwb2ludHMgdG8gdGhlIGZpcnN0 IGJ5dGUuCg==