145489 2015-05-29 23:08:55 -0700 [ES6] Drop WeakMap#clear 2015-05-31 08:10:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue darin fpizlo ggaren mark.lam oliver oldest_to_newest 1098317 0 ysuzuki 2015-05-29 23:08:55 -0700 ES6 spec intentionally drops the WeakMap#clear to allow engine to implement WeakMap as a per-object table. 1098389 1 253973 ysuzuki 2015-05-31 03:22:54 -0700 Created attachment 253973 Patch 1098402 2 mark.lam 2015-05-31 06:43:22 -0700 For reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap/clear indicates that clear() "part of the ECMAScript 6 draft specification until revision 28 (version of October 14, 2014), but has been removed in later versions of the draft. It will not be part of the final standard.” Firefox 38.0.1 still supports it. Chrome 43.0.2357.81 has removed it. 1098406 3 253973 ysuzuki 2015-05-31 07:21:35 -0700 Comment on attachment 253973 Patch Thank you for your review and reference. 1098407 4 253973 commit-queue 2015-05-31 08:10:31 -0700 Comment on attachment 253973 Patch Clearing flags on attachment: 253973 Committed r185041: <http://trac.webkit.org/changeset/185041> 1098408 5 commit-queue 2015-05-31 08:10:35 -0700 All reviewed patches have been landed. Closing bug. 253973 2015-05-31 03:22:54 -0700 2015-05-31 08:10:31 -0700 Patch bug-145489-20150531192238.patch text/plain 2741 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 ZTZjMjgyNWJmMzIwN2NmNjQzZGYwNWI5NmJhMTQ5YmIyMDI5MDQ0Li4yYWNjMjE1NWY2MTE0MmMw NjIyMjg4NmNiYWUxZTZlYmJjMjA0YTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0wNS0zMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbRVM2XSBEcm9wIFdlYWtNYXAjY2xlYXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTQ4OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVTNiBzcGVjIGludGVudGlvbmFsbHkg ZHJvcHMgdGhlIFdlYWtNYXAjY2xlYXIKKyAgICAgICAgdG8gYWxsb3cgZW5naW5lIHRvIGltcGxl bWVudCBXZWFrTWFwIGFzIGEgcGVyLW9iamVjdCB0YWJsZS4KKworICAgICAgICBUaGlzIHBhdGNo IGRyb3BzIFdlYWtNYXAucHJvdG90eXBlLmNsZWFyLgorCisgICAgICAgICogcnVudGltZS9XZWFr TWFwUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6V2Vha01hcFByb3RvdHlwZTo6ZmluaXNo Q3JlYXRpb24pOiBEZWxldGVkLgorICAgICAgICAoSlNDOjpwcm90b0Z1bmNXZWFrTWFwQ2xlYXIp OiBEZWxldGVkLgorCiAyMDE1LTA1LTMxICBKb3JkYW4gSGFyYmFuZCAgPGxqaGFyYkBnbWFpbC5j b20+CiAKICAgICAgICAgQXJyYXkjcmVkdWNlIGFuZCByZWR1Y2VSaWdodCBkb24ndCBmb2xsb3cg VG9MZW5ndGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dlYWtN YXBQcm90b3R5cGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha01hcFBy b3RvdHlwZS5jcHAKaW5kZXggY2VlNzg1MGViMTg4ZDAwZjVlYTU5OTU3MTg2NjY3NThiZjllYjAw Yi4uNzFjNGM0MDU1MzdhNTA0OTgyMTY0NDBkYTk5NzMwYWNlMDU1MDc4YyAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha01hcFByb3RvdHlwZS5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha01hcFByb3RvdHlwZS5jcHAKQEAgLTM1 LDcgKzM1LDYgQEAKIAogY29uc3QgQ2xhc3NJbmZvIFdlYWtNYXBQcm90b3R5cGU6OnNfaW5mbyA9 IHsgIldlYWtNYXAiLCAmQmFzZTo6c19pbmZvLCAwLCBDUkVBVEVfTUVUSE9EX1RBQkxFKFdlYWtN YXBQcm90b3R5cGUpIH07CiAKLXN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIHBy b3RvRnVuY1dlYWtNYXBDbGVhcihFeGVjU3RhdGUqKTsKIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIHByb3RvRnVuY1dlYWtNYXBEZWxldGUoRXhlY1N0YXRlKik7CiBzdGF0aWMg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBwcm90b0Z1bmNXZWFrTWFwR2V0KEV4ZWNTdGF0 ZSopOwogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgcHJvdG9GdW5jV2Vha01h cEhhcyhFeGVjU3RhdGUqKTsKQEAgLTQ3LDcgKzQ2LDYgQEAgdm9pZCBXZWFrTWFwUHJvdG90eXBl OjpmaW5pc2hDcmVhdGlvbihWTSYgdm0sIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCiAg ICAgQVNTRVJUKGluaGVyaXRzKGluZm8oKSkpOwogICAgIHZtLnByb3RvdHlwZU1hcC5hZGRQcm90 b3R5cGUodGhpcyk7CiAKLSAgICBKU0NfTkFUSVZFX0ZVTkNUSU9OKHZtLnByb3BlcnR5TmFtZXMt PmNsZWFyLCBwcm90b0Z1bmNXZWFrTWFwQ2xlYXIsIERvbnRFbnVtLCAwKTsKICAgICBKU0NfTkFU SVZFX0ZVTkNUSU9OKHZtLnByb3BlcnR5TmFtZXMtPmRlbGV0ZUtleXdvcmQsIHByb3RvRnVuY1dl YWtNYXBEZWxldGUsIERvbnRFbnVtLCAxKTsKICAgICBKU0NfTkFUSVZFX0ZVTkNUSU9OKHZtLnBy b3BlcnR5TmFtZXMtPmdldCwgcHJvdG9GdW5jV2Vha01hcEdldCwgRG9udEVudW0sIDEpOwogICAg IEpTQ19OQVRJVkVfRlVOQ1RJT04odm0ucHJvcGVydHlOYW1lcy0+aGFzLCBwcm90b0Z1bmNXZWFr TWFwSGFzLCBEb250RW51bSwgMSk7CkBAIC02OCwxNSArNjYsNiBAQCBzdGF0aWMgV2Vha01hcERh dGEqIGdldFdlYWtNYXBEYXRhKENhbGxGcmFtZSogY2FsbEZyYW1lLCBKU1ZhbHVlIHZhbHVlKQog ICAgIHJldHVybiBudWxscHRyOwogfQogCi1FbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIHBy b3RvRnVuY1dlYWtNYXBDbGVhcihDYWxsRnJhbWUqIGNhbGxGcmFtZSkKLXsKLSAgICBXZWFrTWFw RGF0YSogbWFwID0gZ2V0V2Vha01hcERhdGEoY2FsbEZyYW1lLCBjYWxsRnJhbWUtPnRoaXNWYWx1 ZSgpKTsKLSAgICBpZiAoIW1hcCkKLSAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1Vu ZGVmaW5lZCgpKTsKLSAgICBtYXAtPmNsZWFyKCk7Ci0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29k ZShqc1VuZGVmaW5lZCgpKTsKLX0KLQogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBwcm90 b0Z1bmNXZWFrTWFwRGVsZXRlKENhbGxGcmFtZSogY2FsbEZyYW1lKQogewogICAgIFdlYWtNYXBE YXRhKiBtYXAgPSBnZXRXZWFrTWFwRGF0YShjYWxsRnJhbWUsIGNhbGxGcmFtZS0+dGhpc1ZhbHVl KCkpOwo=