145476 2015-05-29 15:25:30 -0700 WebResourceLoadDelegatePrivate.h cannot be imported standalone (missing WebNSInteger type) 2017-02-09 17:18:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168096 P2 Normal --- 1 andersca andersca andersca darin oldest_to_newest 1098216 0 andersca 2015-05-29 15:25:30 -0700 WebResourceLoadDelegatePrivate.h cannot be imported standalone (missing WebNSInteger type) 1098217 1 253925 andersca 2015-05-29 15:26:09 -0700 Created attachment 253925 Patch 1098219 2 andersca 2015-05-29 15:33:24 -0700 Committed r185010: <http://trac.webkit.org/changeset/185010> 1098220 3 darin 2015-05-29 15:36:27 -0700 So the NSInteger typedef comes from the <TargetAvailability.h> header? Seriously? 1098224 4 andersca 2015-05-29 15:44:46 -0700 (In reply to comment #3) > So the NSInteger typedef comes from the <TargetAvailability.h> header? > Seriously? No, there is no WebNSInteger typedef. The reason this builds is that nobody ends up defining TARGET_OS_IPHONE (It's actually quite possible that nobody even imports WebResourceLoadDelegatePrivate.h at all) 1098361 5 darin 2015-05-30 16:11:10 -0700 I was asking about NSInteger, not WebNSInteger, but I guess the include is for TARGET_OS_IPHONE? 1098525 6 andersca 2015-06-01 10:14:18 -0700 (In reply to comment #5) > I was asking about NSInteger, not WebNSInteger, but I guess the include is > for TARGET_OS_IPHONE? Ah, yes it is. (I didn't want to mess with the includes more than necessary). 253925 2015-05-29 15:26:09 -0700 2015-05-29 15:31:59 -0700 Patch bug-145476-20150529152555.patch text/plain 2967 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNGI2Yzc3MjJj ZWVlNzNlYThkNjQ4NjU5OTAzYmZmYzJmODdlYTFlYS4uODgyNWEwNDY5MDBjYTNlNTRjZjY5NzI2 NDkwZTE0YTE5YzViZjA3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1 LTA1LTI5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg V2ViUmVzb3VyY2VMb2FkRGVsZWdhdGVQcml2YXRlLmggY2Fubm90IGJlIGltcG9ydGVkIHN0YW5k YWxvbmUgKG1pc3NpbmcgV2ViTlNJbnRlZ2VyIHR5cGUpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU0NzYKKyAgICAgICAgcmRhcjovL3Byb2JsZW0v MjExNjI0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDaGFuZ2UgV2ViTlNJbnRlZ2VyIHRvIE5TSW50ZWdlci4KKworICAgICAgICAqIFdlYlZpZXcv V2ViUmVzb3VyY2VMb2FkRGVsZWdhdGVQcml2YXRlLmg6CisKKzIwMTUtMDUtMjkgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWJLaXQuZnJhbWV3b3Jr IGluc3RhbGxzIG9yIHJlZmVyZW5jZXMgTWFjLW9ubHkgaGVhZGVycyBvbiBpT1MKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTQ3MQogICAgICAgICBy ZGFyOi8vcHJvYmxlbS8yMTE2MTQ1OQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJSZXNvdXJjZUxvYWREZWxlZ2F0ZVByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViUmVzb3VyY2VMb2FkRGVsZWdhdGVQcml2YXRlLmgKaW5kZXggZWE3ZTYwMzJl MGEyMDYyMjQ1MmIzYWI2ZGYzNWYxMzExNWVjZjMyYi4uOTVhZWQ4ZjAwYTEyYTJiMTI2YzI4OTE3 MTY3NWExNmY1MDdmMmFkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJSZXNvdXJjZUxvYWREZWxlZ2F0ZVByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYlJlc291cmNlTG9hZERlbGVnYXRlUHJpdmF0ZS5oCkBAIC01Niw5ICs1Niw5IEBA CiAjaWYgVEFSR0VUX09TX0lQSE9ORQogLSAoaWQpd2ViVGhyZWFkV2ViVmlldzooV2ViVmlldyAq KXNlbmRlciBpZGVudGlmaWVyRm9ySW5pdGlhbFJlcXVlc3Q6KE5TVVJMUmVxdWVzdCAqKXJlcXVl c3QgZnJvbURhdGFTb3VyY2U6KFdlYkRhdGFTb3VyY2UgKilkYXRhU291cmNlOwogLSAoTlNVUkxS ZXF1ZXN0ICopd2ViVGhyZWFkV2ViVmlldzooV2ViVmlldyAqKXNlbmRlciByZXNvdXJjZTooaWQp aWRlbnRpZmllciB3aWxsU2VuZFJlcXVlc3Q6KE5TVVJMUmVxdWVzdCAqKXJlcXVlc3QgcmVkaXJl Y3RSZXNwb25zZTooTlNVUkxSZXNwb25zZSAqKXJlZGlyZWN0UmVzcG9uc2UgZnJvbURhdGFTb3Vy Y2U6KFdlYkRhdGFTb3VyY2UgKilkYXRhU291cmNlOwotLSAodm9pZCl3ZWJUaHJlYWRXZWJWaWV3 OihXZWJWaWV3ICopc2VuZGVyIHJlc291cmNlOihpZClpZGVudGlmaWVyIGRpZFJlY2VpdmVDb250 ZW50TGVuZ3RoOihXZWJOU0ludGVnZXIpbGVuZ3RoIGZyb21EYXRhU291cmNlOihXZWJEYXRhU291 cmNlICopZGF0YVNvdXJjZTsKKy0gKHZvaWQpd2ViVGhyZWFkV2ViVmlldzooV2ViVmlldyAqKXNl bmRlciByZXNvdXJjZTooaWQpaWRlbnRpZmllciBkaWRSZWNlaXZlQ29udGVudExlbmd0aDooTlNJ bnRlZ2VyKWxlbmd0aCBmcm9tRGF0YVNvdXJjZTooV2ViRGF0YVNvdXJjZSAqKWRhdGFTb3VyY2U7 CiAtICh2b2lkKXdlYlRocmVhZFdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIgcmVzb3VyY2U6KGlk KWlkZW50aWZpZXIgZGlkUmVjZWl2ZVJlc3BvbnNlOihOU1VSTFJlc3BvbnNlICopcmVzcG9uc2Ug ZnJvbURhdGFTb3VyY2U6KFdlYkRhdGFTb3VyY2UgKilkYXRhU291cmNlOwotLSAodm9pZCl3ZWJU aHJlYWRXZWJWaWV3OihXZWJWaWV3ICopd2ViVmlldyBkaWRMb2FkUmVzb3VyY2VGcm9tTWVtb3J5 Q2FjaGU6KE5TVVJMUmVxdWVzdCAqKXJlcXVlc3QgcmVzcG9uc2U6KE5TVVJMUmVzcG9uc2UgKily ZXNwb25zZSBsZW5ndGg6KFdlYk5TSW50ZWdlcilsZW5ndGggZnJvbURhdGFTb3VyY2U6KFdlYkRh dGFTb3VyY2UgKilkYXRhU291cmNlOworLSAodm9pZCl3ZWJUaHJlYWRXZWJWaWV3OihXZWJWaWV3 ICopd2ViVmlldyBkaWRMb2FkUmVzb3VyY2VGcm9tTWVtb3J5Q2FjaGU6KE5TVVJMUmVxdWVzdCAq KXJlcXVlc3QgcmVzcG9uc2U6KE5TVVJMUmVzcG9uc2UgKilyZXNwb25zZSBsZW5ndGg6KE5TSW50 ZWdlcilsZW5ndGggZnJvbURhdGFTb3VyY2U6KFdlYkRhdGFTb3VyY2UgKilkYXRhU291cmNlOwog LSAodm9pZCl3ZWJUaHJlYWRXZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIHJlc291cmNlOihpZClp ZGVudGlmaWVyIGRpZEZpbmlzaExvYWRpbmdGcm9tRGF0YVNvdXJjZTooV2ViRGF0YVNvdXJjZSAq KWRhdGFTb3VyY2U7CiAtICh2b2lkKXdlYlRocmVhZFdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIg cmVzb3VyY2U6KGlkKWlkZW50aWZpZXIgZGlkRmFpbExvYWRpbmdXaXRoRXJyb3I6KE5TRXJyb3Ig KillcnJvciBmcm9tRGF0YVNvdXJjZTooV2ViRGF0YVNvdXJjZSAqKWRhdGFTb3VyY2U7CiAtIChO U0NhY2hlZFVSTFJlc3BvbnNlICopd2ViVGhyZWFkV2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBy ZXNvdXJjZTooaWQpaWRlbnRpZmllciB3aWxsQ2FjaGVSZXNwb25zZTooTlNDYWNoZWRVUkxSZXNw b25zZSAqKXJlc3BvbnNlIGZyb21EYXRhU291cmNlOihXZWJEYXRhU291cmNlICopZGF0YVNvdXJj ZTsK