145469 2015-05-29 13:42:05 -0700 FTL codegen for MultiGetByOffset and MultiPutByOffset where the structure set is already proved should have an unreachable default case instead of an exit 2015-05-30 14:52:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1098172 0 fpizlo 2015-05-29 13:42:05 -0700 LLVM doesn't always do this transformation for us. 1098301 1 253947 fpizlo 2015-05-29 19:42:40 -0700 Created attachment 253947 the patch 1098343 2 253947 ggaren 2015-05-30 13:56:35 -0700 Comment on attachment 253947 the patch r=me 1098353 3 fpizlo 2015-05-30 14:52:43 -0700 Landed in http://trac.webkit.org/changeset/185032 253947 2015-05-29 19:42:40 -0700 2015-05-30 13:56:35 -0700 the patch blah.patch text/plain 4031 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1MDI2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE1LTA1LTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIGNvZGVnZW4gZm9yIE11bHRpR2V0QnlPZmZzZXQgYW5kIE11bHRpUHV0QnlPZmZzZXQgd2hl cmUgdGhlIHN0cnVjdHVyZSBzZXQgaXMgYWxyZWFkeSBwcm92ZWQgc2hvdWxkIGhhdmUgYW4gdW5y ZWFjaGFibGUgZGVmYXVsdCBjYXNlIGluc3RlYWQgb2YgYW4gZXhpdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NDY5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBPbWl0dGluZyB0aGUgc3Bl Y3VsYXRpb24gb24gdGhlIGZhaWwgcGF0aCB3aGVuIHRoZSBzcGVjdWxhdGlvbiBpcyBndWFyYW50 ZWVkIG5vdCB0byBiZQorICAgICAgICB0YWtlbiBoaW50cyB0byBMTFZNIHRoYXQgdGhlIGRlZmF1 bHQgY2FzZSBpcyBpbXBvc3NpYmxlLiBUaGlzIGVuYWJsZXMgc29tZSB1c2VmdWwKKyAgICAgICAg b3B0aW1pemF0aW9ucy4KKworICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvTExWTS5jcHA6Cisg ICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmNvbXBpbGVNdWx0aUdldEJ5T2Zmc2V0 KToKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZU11bHRpUHV0QnlP ZmZzZXQpOgorCiAyMDE1LTA1LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZWZhY3RvcmluZyBIYW5kbGVySW5mbyBhbmQgVW5saW5rZWRIYW5kbGVySW5mby4K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0u Y3BwCShyZXZpc2lvbiAxODUwMjQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExv d2VyREZHVG9MTFZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc3OCwxMSArMzc3OCwxMyBAQCBw cml2YXRlOgogICAgICAgICBMQmFzaWNCbG9jayBjb250aW51YXRpb24gPSBGVExfTkVXX0JMT0NL KG1fb3V0LCAoIk11bHRpR2V0QnlPZmZzZXQgY29udGludWF0aW9uIikpOwogICAgICAgICAKICAg ICAgICAgVmVjdG9yPFN3aXRjaENhc2UsIDI+IGNhc2VzOworICAgICAgICBTdHJ1Y3R1cmVTZXQg YmFzZVNldDsKICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gZGF0YS52YXJpYW50cy5zaXplKCk7 IGktLTspIHsKICAgICAgICAgICAgIEdldEJ5SWRWYXJpYW50IHZhcmlhbnQgPSBkYXRhLnZhcmlh bnRzW2ldOwogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBqID0gdmFyaWFudC5zdHJ1Y3R1cmVT ZXQoKS5zaXplKCk7IGotLTspIHsKLSAgICAgICAgICAgICAgICBjYXNlcy5hcHBlbmQoU3dpdGNo Q2FzZSgKLSAgICAgICAgICAgICAgICAgICAgd2Vha1N0cnVjdHVyZUlEKHZhcmlhbnQuc3RydWN0 dXJlU2V0KClbal0pLCBibG9ja3NbaV0sIFdlaWdodCgxKSkpOworICAgICAgICAgICAgICAgIFN0 cnVjdHVyZSogc3RydWN0dXJlID0gdmFyaWFudC5zdHJ1Y3R1cmVTZXQoKVtqXTsKKyAgICAgICAg ICAgICAgICBiYXNlU2V0LmFkZChzdHJ1Y3R1cmUpOworICAgICAgICAgICAgICAgIGNhc2VzLmFw cGVuZChTd2l0Y2hDYXNlKHdlYWtTdHJ1Y3R1cmVJRChzdHJ1Y3R1cmUpLCBibG9ja3NbaV0sIFdl aWdodCgxKSkpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgICAgIG1fb3V0LnN3aXRj aEluc3RydWN0aW9uKApAQCAtMzc5NSw2ICszNzk3LDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAg IG1fb3V0LmFwcGVuZFRvKGJsb2Nrc1tpXSwgaSArIDEgPCBkYXRhLnZhcmlhbnRzLnNpemUoKSA/ IGJsb2Nrc1tpICsgMV0gOiBleGl0KTsKICAgICAgICAgICAgIAogICAgICAgICAgICAgR2V0QnlJ ZFZhcmlhbnQgdmFyaWFudCA9IGRhdGEudmFyaWFudHNbaV07CisgICAgICAgICAgICBiYXNlU2V0 Lm1lcmdlKHZhcmlhbnQuc3RydWN0dXJlU2V0KCkpOwogICAgICAgICAgICAgTFZhbHVlIHJlc3Vs dDsKICAgICAgICAgICAgIEpTVmFsdWUgY29uc3RhbnRSZXN1bHQ7CiAgICAgICAgICAgICBpZiAo dmFyaWFudC5hbHRlcm5hdGVCYXNlKCkpIHsKQEAgLTM4MTksNyArMzgyMiw4IEBAIHByaXZhdGU6 CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIG1fb3V0LmFwcGVuZFRvKGV4aXQsIGNvbnRp bnVhdGlvbik7Ci0gICAgICAgIHNwZWN1bGF0ZShCYWRDYWNoZSwgbm9WYWx1ZSgpLCBudWxscHRy LCBtX291dC5ib29sZWFuVHJ1ZSk7CisgICAgICAgIGlmICghbV9pbnRlcnByZXRlci5mb3JOb2Rl KG1fbm9kZS0+Y2hpbGQxKCkpLm1fc3RydWN0dXJlLmlzU3Vic2V0T2YoYmFzZVNldCkpCisgICAg ICAgICAgICBzcGVjdWxhdGUoQmFkQ2FjaGUsIG5vVmFsdWUoKSwgbnVsbHB0ciwgbV9vdXQuYm9v bGVhblRydWUpOwogICAgICAgICBtX291dC51bnJlYWNoYWJsZSgpOwogICAgICAgICAKICAgICAg ICAgbV9vdXQuYXBwZW5kVG8oY29udGludWF0aW9uLCBsYXN0TmV4dCk7CkBAIC0zODQ5LDExICsz ODUzLDEzIEBAIHByaXZhdGU6CiAgICAgICAgIExCYXNpY0Jsb2NrIGNvbnRpbnVhdGlvbiA9IEZU TF9ORVdfQkxPQ0sobV9vdXQsICgiTXVsdGlQdXRCeU9mZnNldCBjb250aW51YXRpb24iKSk7CiAg ICAgICAgIAogICAgICAgICBWZWN0b3I8U3dpdGNoQ2FzZSwgMj4gY2FzZXM7CisgICAgICAgIFN0 cnVjdHVyZVNldCBiYXNlU2V0OwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBkYXRhLnZhcmlh bnRzLnNpemUoKTsgaS0tOykgewogICAgICAgICAgICAgUHV0QnlJZFZhcmlhbnQgdmFyaWFudCA9 IGRhdGEudmFyaWFudHNbaV07CiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGogPSB2YXJpYW50 Lm9sZFN0cnVjdHVyZSgpLnNpemUoKTsgai0tOykgewotICAgICAgICAgICAgICAgIGNhc2VzLmFw cGVuZCgKLSAgICAgICAgICAgICAgICAgICAgU3dpdGNoQ2FzZSh3ZWFrU3RydWN0dXJlSUQodmFy aWFudC5vbGRTdHJ1Y3R1cmUoKVtqXSksIGJsb2Nrc1tpXSwgV2VpZ2h0KDEpKSk7CisgICAgICAg ICAgICAgICAgU3RydWN0dXJlKiBzdHJ1Y3R1cmUgPSB2YXJpYW50Lm9sZFN0cnVjdHVyZSgpW2pd OworICAgICAgICAgICAgICAgIGJhc2VTZXQuYWRkKHN0cnVjdHVyZSk7CisgICAgICAgICAgICAg ICAgY2FzZXMuYXBwZW5kKFN3aXRjaENhc2Uod2Vha1N0cnVjdHVyZUlEKHN0cnVjdHVyZSksIGJs b2Nrc1tpXSwgV2VpZ2h0KDEpKSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAg bV9vdXQuc3dpdGNoSW5zdHJ1Y3Rpb24oCkBAIC0zODkzLDcgKzM4OTksOCBAQCBwcml2YXRlOgog ICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBtX291dC5hcHBlbmRUbyhleGl0LCBjb250aW51 YXRpb24pOwotICAgICAgICBzcGVjdWxhdGUoQmFkQ2FjaGUsIG5vVmFsdWUoKSwgbnVsbHB0ciwg bV9vdXQuYm9vbGVhblRydWUpOworICAgICAgICBpZiAoIW1faW50ZXJwcmV0ZXIuZm9yTm9kZSht X25vZGUtPmNoaWxkMSgpKS5tX3N0cnVjdHVyZS5pc1N1YnNldE9mKGJhc2VTZXQpKQorICAgICAg ICAgICAgc3BlY3VsYXRlKEJhZENhY2hlLCBub1ZhbHVlKCksIG51bGxwdHIsIG1fb3V0LmJvb2xl YW5UcnVlKTsKICAgICAgICAgbV9vdXQudW5yZWFjaGFibGUoKTsKICAgICAgICAgCiAgICAgICAg IG1fb3V0LmFwcGVuZFRvKGNvbnRpbnVhdGlvbiwgbGFzdE5leHQpOwo=