145453 2015-05-28 20:54:15 -0700 Only show volume controls when audio tracks are found. 2015-05-28 21:49:59 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 roger_fong webkit-unassigned dino roger_fong oldest_to_newest 1098057 0 roger_fong 2015-05-28 20:54:15 -0700 rdar://problem/21153927 Some of the layout tests test that a video with no audio track should have no volume control. Right now our volume control starts off visible. It should only become visible was audio tracks have been found. This must have regressed at some point seeing as we have a test for it. Maybe a line of code that was accidentally removed. 1098058 1 253891 roger_fong 2015-05-28 20:57:14 -0700 Created attachment 253891 patch 1098068 2 roger_fong 2015-05-28 21:49:38 -0700 (In reply to comment #0) > rdar://problem/21153927 > > Some of the layout tests test that a video with no audio track should have > no volume control. > Right now our volume control starts off visible. > It should only become visible was audio tracks have been found. > > This must have regressed at some point seeing as we have a test for it. > Maybe a line of code that was accidentally removed. Correction: we do do this above correctly, it's actually that if the video has an error and doesn't load we used to only show the buttons to the left of the timeline (rewind and play). This decision seems arbitrary though so I'm not actually sure this fix matters at all... 253891 2015-05-28 20:57:14 -0700 2015-05-28 21:49:59 -0700 patch patch.patch text/plain 1626 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDk3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1LTI4ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgT25seSBzaG93IHZvbHVtZSBj b250cm9scyB3aGVuIGF1ZGlvIHRyYWNrcyBhcmUgZm91bmQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU0NTMuCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yMTE1MzkyNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanM6Cisg ICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5jb25maWd1cmVJbmxpbmVDb250cm9scyk6CisK IDIwMTUtMDUtMjggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBT dWJwaXhlbCByZW5kZXJpbmc6IFBpeGVsIGNyYWNrIGluIHRleHQgc2VsZWN0aW9uIG9mIHNpbXBs ZSB0ZXh0IGluIDx0ZXh0YXJlYT4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh Y29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHJldmlzaW9u IDE4NDkyNikKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNv bnRyb2xzQXBwbGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTU2MSw2ICs1NjEsOCBAQCBDb250cm9s bGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5jb250cm9scy52b2x1bWVCb3guYXBwZW5k Q2hpbGQodGhpcy5jb250cm9scy52b2x1bWVCb3hUaW50KTsKICAgICAgICAgdGhpcy5jb250cm9s cy52b2x1bWVCb3guYXBwZW5kQ2hpbGQodGhpcy5jb250cm9scy52b2x1bWUpOwogICAgICAgICB0 aGlzLmNvbnRyb2xzLm11dGVCb3guYXBwZW5kQ2hpbGQodGhpcy5jb250cm9scy5tdXRlQnV0dG9u KTsKKyAgICAgICAgLy8gVm9sdW1lIGNvbnRyb2xzIHNob3VsZCBzdGFydCBoaWRkZW4gYW5kIGJl IHJldmVhbGVkIHdoZW4gYW4gYXVkaW8gdHJhY2sgaGFzIGJlZW4gZm91bmQuIFNlZSB1cGRhdGVI YXNBdWRpby4KKyAgICAgICAgdGhpcy5jb250cm9scy5tdXRlQm94LmNsYXNzTGlzdC5hZGQodGhp cy5DbGFzc05hbWVzLmhpZGRlbik7CiAgICAgICAgIHRoaXMuY29udHJvbHMucGFuZWwuYXBwZW5k Q2hpbGQodGhpcy5jb250cm9scy53aXJlbGVzc1RhcmdldFBpY2tlcik7CiAgICAgICAgIHRoaXMu Y29udHJvbHMucGFuZWwuYXBwZW5kQ2hpbGQodGhpcy5jb250cm9scy5jYXB0aW9uQnV0dG9uKTsK ICAgICAgICAgaWYgKCF0aGlzLmlzQXVkaW8oKSkK