145441 2015-05-28 11:00:50 -0700 Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo 2015-05-28 12:14:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 basile_clement basile_clement fpizlo ggaren mark.lam msaboff oldest_to_newest 1097911 0 basile_clement 2015-05-28 11:00:50 -0700 Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo 1097912 1 253850 basile_clement 2015-05-28 11:02:36 -0700 Created attachment 253850 Patch 1097914 2 253850 mark.lam 2015-05-28 11:13:58 -0700 Comment on attachment 253850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253850&action=review > Source/JavaScriptCore/dfg/DFGNode.h:2008 > { Did you intend to add an ASSERT(hasTypeLocation()) here? 1097917 3 basile_clement 2015-05-28 11:20:46 -0700 (In reply to comment #2) > Comment on attachment 253850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253850&action=review > > > Source/JavaScriptCore/dfg/DFGNode.h:2008 > > { > > Did you intend to add an ASSERT(hasTypeLocation()) here? Oops, indeed. Updating the patch. 1097918 4 253852 basile_clement 2015-05-28 11:21:33 -0700 Created attachment 253852 Patch 1097926 5 basile_clement 2015-05-28 12:14:46 -0700 Committed r184958: <http://trac.webkit.org/changeset/184958> 253850 2015-05-28 11:02:36 -0700 2015-05-28 11:21:30 -0700 Patch bug-145441-20150528110223.patch text/plain 2893 basile_clement U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NjNjODBjMmU2NzI3ZDg2NGJjYWJlY2VhYjllZTJlMjRlMzQ3NWQ1Li45YmU0MzZiODA2NWI1Y2M4 MDEyYzMwMjYzNTIyNzc0YTNiNWU3Zjc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNS0wNS0yOCAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBh cHBsZS5jb20+CisKKyAgICAgICAgQWRkIGRlYnVnIG1vZGUgYXNzZXJ0aW9ucyBmb3IgYWNjZXNz b3JzIGNhc3RpbmcgSlNDOjpERkc6Ok5vZGUubV9vcEluZm8KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTQ0MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vc3QgYWNjZXNzb3IgZnVuY3Rpb25zIGNhc3Rp bmcgbV9vcEluZm8gaW4gSlNDOjpERkc6Ok5vZGUgYXJlCisgICAgICAgIHBlcmZvcm1pbmcgZGVi dWcgY2hlY2tzIHRoYXQgdGhleSBhcmUgb25seSBhY2Nlc3NlZCBmb3Igbm9kZSB0eXBlcyB0aGF0 CisgICAgICAgIHNob3VsZCBoYXZlIHRoZW0uIFRoaXMgcGF0Y2ggYWRkcyBzaW1pbGFyIGNoZWNr cyBmb3IgdGhlIGFjY2Vzc29ycyB0aGF0CisgICAgICAgIHdlcmUgbWlzc2luZyB0aGVtLgorCisg ICAgICAgICogZGZnL0RGR05vZGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpOb2RlOjp3YXRjaHBv aW50U2V0KToKKyAgICAgICAgKEpTQzo6REZHOjpOb2RlOjpzdG9yYWdlUG9pbnRlcik6CisgICAg ICAgIChKU0M6OkRGRzo6Tm9kZTo6bXVsdGlHZXRCeU9mZnNldERhdGEpOgorICAgICAgICAoSlND OjpERkc6Ok5vZGU6Om11bHRpUHV0QnlPZmZzZXREYXRhKToKKyAgICAgICAgKEpTQzo6REZHOjpO b2RlOjpoYXNUeXBlTG9jYXRpb24pOgorICAgICAgICAoSlNDOjpERkc6Ok5vZGU6Omhhc0Jhc2lj QmxvY2tMb2NhdGlvbik6CisgICAgICAgIChKU0M6OkRGRzo6Tm9kZTo6YmFzaWNCbG9ja0xvY2F0 aW9uKToKKwogMjAxNS0wNS0yNyAgSm9yZGFuIEhhcmJhbmQgIDxsamhhcmJAZ21haWwuY29tPgog CiAgICAgICAgIEFycmF5Lm9mIHNob3VsZCB3b3JrIHdpdGggb3RoZXIgY29uc3RydWN0b3JzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCmluZGV4IDJjZDYzNDBjNjY3MTgwZWVhNWM1Y2Q0 ZDc2NzRiZTBjNDBiODlkZGQuLjQ2OTllNTgxZTA3ZGQ2OGEzMTI2ZTg0YzU3YjY2ZWJjM2IxMDU5 MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCkBAIC0xMzIxLDYgKzEzMjEsNyBA QCBzdHJ1Y3QgTm9kZSB7CiAgICAgCiAgICAgV2F0Y2hwb2ludFNldCogd2F0Y2hwb2ludFNldCgp CiAgICAgeworICAgICAgICBBU1NFUlQoaGFzV2F0Y2hwb2ludFNldCgpKTsKICAgICAgICAgcmV0 dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8V2F0Y2hwb2ludFNldCo+KG1fb3BJbmZvKTsKICAgICB9CiAg ICAgCkBAIC0xMzMxLDYgKzEzMzIsNyBAQCBzdHJ1Y3QgTm9kZSB7CiAgICAgCiAgICAgdm9pZCog c3RvcmFnZVBvaW50ZXIoKQogICAgIHsKKyAgICAgICAgQVNTRVJUKGhhc1N0b3JhZ2VQb2ludGVy KCkpOwogICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4obV9vcEluZm8pOwog ICAgIH0KIApAQCAtMTQxMiw2ICsxNDE0LDcgQEAgc3RydWN0IE5vZGUgewogICAgIAogICAgIE11 bHRpR2V0QnlPZmZzZXREYXRhJiBtdWx0aUdldEJ5T2Zmc2V0RGF0YSgpCiAgICAgeworICAgICAg ICBBU1NFUlQoaGFzTXVsdGlHZXRCeU9mZnNldERhdGEoKSk7CiAgICAgICAgIHJldHVybiAqcmVp bnRlcnByZXRfY2FzdDxNdWx0aUdldEJ5T2Zmc2V0RGF0YSo+KG1fb3BJbmZvKTsKICAgICB9CiAg ICAgCkBAIC0xNDIyLDYgKzE0MjUsNyBAQCBzdHJ1Y3QgTm9kZSB7CiAgICAgCiAgICAgTXVsdGlQ dXRCeU9mZnNldERhdGEmIG11bHRpUHV0QnlPZmZzZXREYXRhKCkKICAgICB7CisgICAgICAgIEFT U0VSVChoYXNNdWx0aVB1dEJ5T2Zmc2V0RGF0YSgpKTsKICAgICAgICAgcmV0dXJuICpyZWludGVy cHJldF9jYXN0PE11bHRpUHV0QnlPZmZzZXREYXRhKj4obV9vcEluZm8pOwogICAgIH0KICAgICAK QEAgLTE5OTUsMTMgKzE5OTksMjQgQEAgc3RydWN0IE5vZGUgewogICAgICAgICByZXR1cm4gY2Fu U3BlY3VsYXRlSW50NTIoc291cmNlRm9yKHBhc3MpKTsKICAgICB9CiAKKyAgICBib29sIGhhc1R5 cGVMb2NhdGlvbigpCisgICAgeworICAgICAgICByZXR1cm4gb3AoKSA9PSBQcm9maWxlVHlwZTsK KyAgICB9CisKICAgICBUeXBlTG9jYXRpb24qIHR5cGVMb2NhdGlvbigpCiAgICAgewogICAgICAg ICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxUeXBlTG9jYXRpb24qPihtX29wSW5mbyk7CiAgICAg fQogCisgICAgYm9vbCBoYXNCYXNpY0Jsb2NrTG9jYXRpb24oKQorICAgIHsKKyAgICAgICAgcmV0 dXJuIG9wKCkgPT0gUHJvZmlsZUNvbnRyb2xGbG93OworICAgIH0KKwogICAgIEJhc2ljQmxvY2tM b2NhdGlvbiogYmFzaWNCbG9ja0xvY2F0aW9uKCkKICAgICB7CisgICAgICAgIEFTU0VSVChoYXNC YXNpY0Jsb2NrTG9jYXRpb24oKSk7CiAgICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PEJh c2ljQmxvY2tMb2NhdGlvbio+KG1fb3BJbmZvKTsKICAgICB9CiAgICAgCg== 253852 2015-05-28 11:21:33 -0700 2015-05-28 11:59:49 -0700 Patch bug-145441-20150528112120.patch text/plain 2970 basile_clement U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NjNjODBjMmU2NzI3ZDg2NGJjYWJlY2VhYjllZTJlMjRlMzQ3NWQ1Li45NThjYzRhMzZhYmE1NjNj NzM0ZmVlYzUyMDhkY2Q5NzUwMzZkMzA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNS0wNS0yOCAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBh cHBsZS5jb20+CisKKyAgICAgICAgQWRkIGRlYnVnIG1vZGUgYXNzZXJ0aW9ucyBmb3IgYWNjZXNz b3JzIGNhc3RpbmcgSlNDOjpERkc6Ok5vZGUubV9vcEluZm8KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTQ0MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vc3QgYWNjZXNzb3IgZnVuY3Rpb25zIGNhc3Rp bmcgbV9vcEluZm8gaW4gSlNDOjpERkc6Ok5vZGUgYXJlCisgICAgICAgIHBlcmZvcm1pbmcgZGVi dWcgY2hlY2tzIHRoYXQgdGhleSBhcmUgb25seSBhY2Nlc3NlZCBmb3Igbm9kZSB0eXBlcyB0aGF0 CisgICAgICAgIHNob3VsZCBoYXZlIHRoZW0uIFRoaXMgcGF0Y2ggYWRkcyBzaW1pbGFyIGNoZWNr cyBmb3IgdGhlIGFjY2Vzc29ycyB0aGF0CisgICAgICAgIHdlcmUgbWlzc2luZyB0aGVtLgorCisg ICAgICAgICogZGZnL0RGR05vZGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpOb2RlOjp3YXRjaHBv aW50U2V0KToKKyAgICAgICAgKEpTQzo6REZHOjpOb2RlOjpzdG9yYWdlUG9pbnRlcik6CisgICAg ICAgIChKU0M6OkRGRzo6Tm9kZTo6bXVsdGlHZXRCeU9mZnNldERhdGEpOgorICAgICAgICAoSlND OjpERkc6Ok5vZGU6Om11bHRpUHV0QnlPZmZzZXREYXRhKToKKyAgICAgICAgKEpTQzo6REZHOjpO b2RlOjpoYXNUeXBlTG9jYXRpb24pOgorICAgICAgICAoSlNDOjpERkc6Ok5vZGU6OnR5cGVMb2Nh dGlvbik6CisgICAgICAgIChKU0M6OkRGRzo6Tm9kZTo6aGFzQmFzaWNCbG9ja0xvY2F0aW9uKToK KyAgICAgICAgKEpTQzo6REZHOjpOb2RlOjpiYXNpY0Jsb2NrTG9jYXRpb24pOgorCiAyMDE1LTA1 LTI3ICBKb3JkYW4gSGFyYmFuZCAgPGxqaGFyYkBnbWFpbC5jb20+CiAKICAgICAgICAgQXJyYXku b2Ygc2hvdWxkIHdvcmsgd2l0aCBvdGhlciBjb25zdHJ1Y3RvcnMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdOb2RlLmgKaW5kZXggMmNkNjM0MGM2NjcxODBlZWE1YzVjZDRkNzY3NGJlMGM0MGI4OWRk ZC4uYjdjNjg5NTJmMjIwMTA4OWUwNmNhZDI4YmUyN2IzNTcwYzg3ZTQ1NyAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdOb2RlLmgKQEAgLTEzMjEsNiArMTMyMSw3IEBAIHN0cnVjdCBOb2RlIHsK ICAgICAKICAgICBXYXRjaHBvaW50U2V0KiB3YXRjaHBvaW50U2V0KCkKICAgICB7CisgICAgICAg IEFTU0VSVChoYXNXYXRjaHBvaW50U2V0KCkpOwogICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRf Y2FzdDxXYXRjaHBvaW50U2V0Kj4obV9vcEluZm8pOwogICAgIH0KICAgICAKQEAgLTEzMzEsNiAr MTMzMiw3IEBAIHN0cnVjdCBOb2RlIHsKICAgICAKICAgICB2b2lkKiBzdG9yYWdlUG9pbnRlcigp CiAgICAgeworICAgICAgICBBU1NFUlQoaGFzU3RvcmFnZVBvaW50ZXIoKSk7CiAgICAgICAgIHJl dHVybiByZWludGVycHJldF9jYXN0PHZvaWQqPihtX29wSW5mbyk7CiAgICAgfQogCkBAIC0xNDEy LDYgKzE0MTQsNyBAQCBzdHJ1Y3QgTm9kZSB7CiAgICAgCiAgICAgTXVsdGlHZXRCeU9mZnNldERh dGEmIG11bHRpR2V0QnlPZmZzZXREYXRhKCkKICAgICB7CisgICAgICAgIEFTU0VSVChoYXNNdWx0 aUdldEJ5T2Zmc2V0RGF0YSgpKTsKICAgICAgICAgcmV0dXJuICpyZWludGVycHJldF9jYXN0PE11 bHRpR2V0QnlPZmZzZXREYXRhKj4obV9vcEluZm8pOwogICAgIH0KICAgICAKQEAgLTE0MjIsNiAr MTQyNSw3IEBAIHN0cnVjdCBOb2RlIHsKICAgICAKICAgICBNdWx0aVB1dEJ5T2Zmc2V0RGF0YSYg bXVsdGlQdXRCeU9mZnNldERhdGEoKQogICAgIHsKKyAgICAgICAgQVNTRVJUKGhhc011bHRpUHV0 QnlPZmZzZXREYXRhKCkpOwogICAgICAgICByZXR1cm4gKnJlaW50ZXJwcmV0X2Nhc3Q8TXVsdGlQ dXRCeU9mZnNldERhdGEqPihtX29wSW5mbyk7CiAgICAgfQogICAgIApAQCAtMTk5NSwxMyArMTk5 OSwyNSBAQCBzdHJ1Y3QgTm9kZSB7CiAgICAgICAgIHJldHVybiBjYW5TcGVjdWxhdGVJbnQ1Mihz b3VyY2VGb3IocGFzcykpOwogICAgIH0KIAorICAgIGJvb2wgaGFzVHlwZUxvY2F0aW9uKCkKKyAg ICB7CisgICAgICAgIHJldHVybiBvcCgpID09IFByb2ZpbGVUeXBlOworICAgIH0KKwogICAgIFR5 cGVMb2NhdGlvbiogdHlwZUxvY2F0aW9uKCkKICAgICB7CisgICAgICAgIEFTU0VSVChoYXNUeXBl TG9jYXRpb24oKSk7CiAgICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PFR5cGVMb2NhdGlv bio+KG1fb3BJbmZvKTsKICAgICB9CiAKKyAgICBib29sIGhhc0Jhc2ljQmxvY2tMb2NhdGlvbigp CisgICAgeworICAgICAgICByZXR1cm4gb3AoKSA9PSBQcm9maWxlQ29udHJvbEZsb3c7CisgICAg fQorCiAgICAgQmFzaWNCbG9ja0xvY2F0aW9uKiBiYXNpY0Jsb2NrTG9jYXRpb24oKQogICAgIHsK KyAgICAgICAgQVNTRVJUKGhhc0Jhc2ljQmxvY2tMb2NhdGlvbigpKTsKICAgICAgICAgcmV0dXJu IHJlaW50ZXJwcmV0X2Nhc3Q8QmFzaWNCbG9ja0xvY2F0aW9uKj4obV9vcEluZm8pOwogICAgIH0K ICAgICAK