145416 2015-05-27 15:16:48 -0700 Web Inspector: Toggling an inherited property sometimes stops working 2015-05-27 18:52:02 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1097734 0 joepeck 2015-05-27 15:16:48 -0700 * SUMMARY Toggling an inherited property sometimes stops working. * TEST <!DOCTYPE html> <html> <head> <style> body { color: blue; } p { color: red; } </style> </head> <body> <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit.</p> </body> </html> * STEPS TO REPRODUCE 1. Inspect <p> 2. Show Styles > Rules 3. Click checkbox to toggle the inherited "color: blue" to a comment 4. Click checkbox to try to untoggle the comment => doesn't work, and occasionally this editor will revert back to uncommented but not match the page * NOTES - Inherited CSSStyleProperty is not getting updated properly despite good matchedCSSRules data 1097735 1 joepeck 2015-05-27 15:17:25 -0700 <rdar://problem/20892784> 1097736 2 253803 joepeck 2015-05-27 15:19:20 -0700 Created attachment 253803 [PATCH] Proposed Fix 1097802 3 253803 commit-queue 2015-05-27 18:51:59 -0700 Comment on attachment 253803 [PATCH] Proposed Fix Clearing flags on attachment: 253803 Committed r184934: <http://trac.webkit.org/changeset/184934> 1097803 4 commit-queue 2015-05-27 18:52:02 -0700 All reviewed patches have been landed. Closing bug. 253803 2015-05-27 15:19:20 -0700 2015-05-27 18:51:59 -0700 [PATCH] Proposed Fix inherited.patch text/plain 2110 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU5ODczMjguLmRlYzEzZjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTA1LTI3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVG9nZ2xp bmcgYW4gaW5oZXJpdGVkIHByb3BlcnR5IHNvbWV0aW1lcyBzdG9wcyB3b3JraW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU0MTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv TW9kZWxzL0RPTU5vZGVTdHlsZXMuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NTm9kZVN0 eWxlcy5wcm90b3R5cGUuX3BhcnNlU3R5bGVEZWNsYXJhdGlvblBheWxvYWQpOgorICAgICAgICBF bnN1cmUgd2UgdXBkYXRlIHRoZSBleGlzdGluZyBtb2RlbCBvYmplY3RzIHdpdGggdGhlIG5ldyBz dGF0ZSBpbmZvcm1hdGlvbgorICAgICAgICBiZWZvcmUgcG9zc2libHkgYmFpbGluZy4gVGhpcyBt YXkgcHJvZHVjZSBjaGFuZ2VkIGV2ZW50cyB0aGF0IHVwZGF0ZQorICAgICAgICBwYXJ0cyBvZiB0 aGUgaW5zcGVjdG9yIGFwcHJvcHJpYXRlbHkuCisKKzIwMTUtMDUtMjcgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNT SU9OKHIxNzkyODYpIEVkaXRpbmcgU3R5bGUgTWV0cmljcyBWYWx1ZXMgbm8gbG9uZ2VyIHdvcmtz CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMxNjQK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L0RPTU5vZGVTdHlsZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvRE9NTm9kZVN0eWxlcy5qcwppbmRleCBkNDVmZWUwLi42ZGEyYWNmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0eWxl cy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9N Tm9kZVN0eWxlcy5qcwpAQCAtNjQ0LDkgKzY0NCw2IEBAIFdlYkluc3BlY3Rvci5ET01Ob2RlU3R5 bGVzID0gY2xhc3MgRE9NTm9kZVN0eWxlcyBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAg ICAgICAgICAgIHByb3BlcnRpZXMucHVzaChwcm9wZXJ0eSk7CiAgICAgICAgIH0KIAotICAgICAg ICBpZiAoaW5oZXJpdGVkICYmICFpbmhlcml0ZWRQcm9wZXJ0eUNvdW50KQotICAgICAgICAgICAg cmV0dXJuIG51bGw7Ci0KICAgICAgICAgdmFyIHN0eWxlU2hlZXRUZXh0UmFuZ2UgPSB0aGlzLl9w YXJzZVNvdXJjZVJhbmdlUGF5bG9hZChwYXlsb2FkLnJhbmdlKTsKIAogICAgICAgICBpZiAoc3R5 bGVEZWNsYXJhdGlvbikgewpAQCAtNjYxLDYgKzY1OCw5IEBAIFdlYkluc3BlY3Rvci5ET01Ob2Rl U3R5bGVzID0gY2xhc3MgRE9NTm9kZVN0eWxlcyBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QK ICAgICAgICAgICAgIHN0eWxlU2hlZXQuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuQ1NT U3R5bGVTaGVldC5FdmVudC5Db250ZW50RGlkQ2hhbmdlLCB0aGlzLl9zdHlsZVNoZWV0Q29udGVu dERpZENoYW5nZSwgdGhpcyk7CiAgICAgICAgIH0KIAorICAgICAgICBpZiAoaW5oZXJpdGVkICYm ICFpbmhlcml0ZWRQcm9wZXJ0eUNvdW50KQorICAgICAgICAgICAgcmV0dXJuIG51bGw7CisKICAg ICAgICAgc3R5bGVEZWNsYXJhdGlvbiA9IG5ldyBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJh dGlvbih0aGlzLCBzdHlsZVNoZWV0LCBpZCwgdHlwZSwgbm9kZSwgaW5oZXJpdGVkLCB0ZXh0LCBw cm9wZXJ0aWVzLCBzdHlsZVNoZWV0VGV4dFJhbmdlKTsKIAogICAgICAgICBpZiAobWFwS2V5KSB7 Cg==