145413 2015-05-27 14:11:38 -0700 Assertion hit in WebPage::didChangeSelection() 2015-05-27 14:51:40 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez rniwa oldest_to_newest 1097712 0 cdumez 2015-05-27 14:11:38 -0700 We sometimes hit the "ASSERT(layoutCount == view->layoutCount())" assertion in WebPage::didChangeSelection(). We manage to prevent synchronous layouts in most cases when calling editorState() however, it seems it can still happening. Crashing in this case seems overkill and can be annoying to other developers, especially considering the implications are only performance-related. We should drop the assertion. Radar: <rdar://problem/21001129> 1097713 1 253800 cdumez 2015-05-27 14:14:58 -0700 Created attachment 253800 Patch 1097724 2 253800 cdumez 2015-05-27 14:51:36 -0700 Comment on attachment 253800 Patch Clearing flags on attachment: 253800 Committed r184923: <http://trac.webkit.org/changeset/184923> 1097725 3 cdumez 2015-05-27 14:51:40 -0700 All reviewed patches have been landed. Closing bug. 253800 2015-05-27 14:14:58 -0700 2015-05-27 14:51:36 -0700 Patch bug-145413-20150527141446.patch text/plain 2587 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQzMDZkMjRkZDQ5NzRk ZDUxOTNhMTQ4YThjZjVjOGZlY2MyYjhiNy4uNTdkMzkzOGNlOWM0Zjg0Yzk0Yzc4YWY0Y2NkZjc5 YWYwOTU4MDc5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA1LTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGhpdCBpbiBX ZWJQYWdlOjpkaWRDaGFuZ2VTZWxlY3Rpb24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NDEzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMTAw MTEyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX ZSBzb21ldGltZXMgaGl0IHRoZSAiQVNTRVJUKGxheW91dENvdW50ID09IHZpZXctPmxheW91dENv dW50KCkpIgorICAgICAgICBhc3NlcnRpb24gaW4gV2ViUGFnZTo6ZGlkQ2hhbmdlU2VsZWN0aW9u KCkuIFdlIG1hbmFnZSB0byBwcmV2ZW50CisgICAgICAgIHN5bmNocm9ub3VzIGxheW91dHMgaW4g bW9zdCBjYXNlcyB3aGVuIGNhbGxpbmcgZWRpdG9yU3RhdGUoKS4gSG93ZXZlciwKKyAgICAgICAg aXQgc2VlbXMgaXQgY2FuIHN0aWxsIGhhcHBlbiBpbiBzb21lIGNhc2VzLiBDcmFzaGluZyBpbiB0 aGlzIGNhc2Ugc2VlbXMKKyAgICAgICAgb3ZlcmtpbGwgYW5kIGNhbiBiZSBhbm5veWluZyB0byBv dGhlciBkZXZlbG9wZXJzLCBlc3BlY2lhbGx5CisgICAgICAgIGNvbnNpZGVyaW5nIHRoZSBpbXBs aWNhdGlvbnMgYXJlIG9ubHkgb24gcGVyZm9ybWFuY2UuCisKKyAgICAgICAgVGhpcyBwYXRjaCBk cm9wcyB0aGUgYXNzZXJ0aW9uLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpkaWRDaGFuZ2VTZWxlY3Rpb24pOiBE ZWxldGVkLgorCiAyMDE1LTA1LTI3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkcmVzcyBhIGZvbGxvdy11cCByZXZpZXcgY29tbWVudCBmcm9tIERh cmluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmlu ZGV4IDg5NDU5YmQ0Y2MxYzEyZmZiYThjYmFlZmUwY2Q3MzcwZjYyZTU5YTkuLmViNTAxYWNkYTk5 MDFmYzIyYzBmNzFhZjNiNWM0MDhkYjgzMzc1YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTQ0MzAsMTggKzQ0MzAsMTEgQEAgdm9pZCBX ZWJQYWdlOjpkaWRDaGFuZ2VTZWxlY3Rpb24oKQogewogICAgIEZyYW1lJiBmcmFtZSA9IG1fcGFn ZS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZE9yTWFpbkZyYW1lKCk7CiAgICAgRnJhbWVWaWV3 KiB2aWV3ID0gZnJhbWUudmlldygpOwotI2lmIFBMQVRGT1JNKENPQ09BKSAmJiAhZGVmaW5lZChO REVCVUcpCi0gICAgaW50IGxheW91dENvdW50ID0gdmlldyA/IHZpZXctPmxheW91dENvdW50KCkg OiAwOwotI2VuZGlmCiAKICAgICAvLyBJZiB0aGVyZSBpcyBhIGxheW91dCBwZW5kaW5nLCB3ZSBz aG91bGQgYXZvaWQgcG9wdWxhdGluZyBFZGl0b3JTdGF0ZSB0aGF0IHJlcXVpcmUgbGF5b3V0IHRv IGJlIGRvbmUgb3IgaXQgd2lsbAogICAgIC8vIHRyaWdnZXIgYSBzeW5jaHJvbm91cyBsYXlvdXQg ZXZlcnkgdGltZSB0aGUgc2VsZWN0aW9uIGNoYW5nZXMuIHNlbmRQb3N0TGF5b3V0RWRpdG9yU3Rh dGVJZk5lZWRlZCgpIHdpbGwgYmUgY2FsbGVkCiAgICAgLy8gdG8gc2VuZCB0aGUgZnVsbCBlZGl0 b3Igc3RhdGUgYWZ0ZXIgbGF5b3V0IGlzIGRvbmUgaWYgd2Ugc2VuZCBhIHBhcnRpYWwgZWRpdG9y IHN0YXRlIGhlcmUuCiAgICAgYXV0byBlZGl0b3JTdGF0ZSA9IHRoaXMtPmVkaXRvclN0YXRlKHZp ZXcgJiYgdmlldy0+bmVlZHNMYXlvdXQoKSA/IEluY2x1ZGVQb3N0TGF5b3V0RGF0YUhpbnQ6Ok5v IDogSW5jbHVkZVBvc3RMYXlvdXREYXRhSGludDo6WWVzKTsKLSNpZiBQTEFURk9STShDT0NPQSkg JiYgIWRlZmluZWQoTkRFQlVHKQotICAgIGlmICh2aWV3KQotICAgICAgICBBU1NFUlRfV0lUSF9N RVNTQUdFKGxheW91dENvdW50ID09IHZpZXctPmxheW91dENvdW50KCksICJDYWxsaW5nIGVkaXRv clN0YXRlKCkgc2hvdWxkIG5vdCBjYXVzZSBhIHN5bmNocm9ub3VzIGxheW91dC4iKTsKLSNlbmRp ZgogICAgIG1faXNFZGl0b3JTdGF0ZU1pc3NpbmdQb3N0TGF5b3V0RGF0YSA9IGVkaXRvclN0YXRl LmlzTWlzc2luZ1Bvc3RMYXlvdXREYXRhOwogCiAjaWYgUExBVEZPUk0oTUFDKSAmJiBVU0UoQVNZ TkNfTlNURVhUSU5QVVRDTElFTlQpCg==