145379 2015-05-26 08:50:08 -0700 Try to use StringView when comparing JSStrings for equality. 2015-05-29 00:43:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified REOPENED Performance P2 Normal --- 145456 1 kling kling commit-queue darin ysuzuki oldest_to_newest 1097311 0 kling 2015-05-26 08:50:08 -0700 Checking two JSStrings for equality should use StringView to avoid reifying substrings. 1097312 1 253705 kling 2015-05-26 08:50:32 -0700 Created attachment 253705 Patch 1097333 2 253705 commit-queue 2015-05-26 10:28:47 -0700 Comment on attachment 253705 Patch Clearing flags on attachment: 253705 Committed r184860: <http://trac.webkit.org/changeset/184860> 1097334 3 commit-queue 2015-05-26 10:28:51 -0700 All reviewed patches have been landed. Closing bug. 1098092 4 ysuzuki 2015-05-29 00:38:40 -0700 Hi, kling. What do you think about it? https://bugs.webkit.org/show_bug.cgi?id=145360 1098094 5 commit-queue 2015-05-29 00:43:54 -0700 Re-opened since this is blocked by bug 145456 253705 2015-05-26 08:50:32 -0700 2015-05-26 10:28:47 -0700 Patch bug-145379.diff text/plain 2799 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM2NjUxYmQuLmEzMmQ4NTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA1LTI2ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBUcnkgdG8gdXNlIFN0cmluZ1ZpZXcgd2hl biBjb21wYXJpbmcgSlNTdHJpbmdzIGZvciBlcXVhbGl0eS4KKyAgICAgICAgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE0NTM3OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBVc2UgSlNTdHJpbmc6OnZpZXcoKSB3aGVuIHNlbmRpbmcgdHdvIEpTU3RyaW5n cyB0byBXVEY6OmVxdWFsKCkKKyAgICAgICAgZm9yIGNvbXBhcmlzb24uIFRoaXMgYXZvaWRzIGNy ZWF0aW5nIG5ldyBvYmplY3RzIGluIHRoZSBjYXNlIHdoZXJlCisgICAgICAgIHRoZSBzdHJpbmdz IGFyZSBhY3R1YWxseSBzdWJzdHJpbmdzLgorCisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMu Y3BwOgorICAgICAgICAqIHJ1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaDoKKyAgICAgICAgKEpT Qzo6SlNWYWx1ZTo6ZXF1YWxTbG93Q2FzZUlubGluZSk6CisgICAgICAgIChKU0M6OkpTVmFsdWU6 OnN0cmljdEVxdWFsU2xvd0Nhc2VJbmxpbmUpOgorCiAyMDE1LTA1LTIzICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHJpbmcucHJvdG90eXBlLmNoYXJDb2Rl QXQoKSBzaG91bGQgdXNlIFN0cmluZ1ZpZXcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRPcGVyYXRpb25zLmNwcAppbmRleCBkYWU1MmY2Li43N2MwZDYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKQEAgLTkyMyw3ICs5MjMsNyBAQCBzaXpl X3QgSklUX09QRVJBVElPTiBvcGVyYXRpb25Db21wYXJlU3RyaW5nRXEoRXhlY1N0YXRlKiBleGVj LCBKU0NlbGwqIGxlZnQsIEpTQwogICAgIFZNKiB2bSA9ICZleGVjLT52bSgpOwogICAgIE5hdGl2 ZUNhbGxGcmFtZVRyYWNlciB0cmFjZXIodm0sIGV4ZWMpOwogCi0gICAgYm9vbCByZXN1bHQgPSBX VEY6OmVxdWFsKCphc1N0cmluZyhsZWZ0KS0+dmFsdWUoZXhlYykuaW1wbCgpLCAqYXNTdHJpbmco cmlnaHQpLT52YWx1ZShleGVjKS5pbXBsKCkpOworICAgIGJvb2wgcmVzdWx0ID0gV1RGOjplcXVh bChhc1N0cmluZyhsZWZ0KS0+dmlldyhleGVjKSwgYXNTdHJpbmcocmlnaHQpLT52aWV3KGV4ZWMp KTsKICNpZiBVU0UoSlNWQUxVRTY0KQogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNCb29s ZWFuKHJlc3VsdCkpOwogI2Vsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTQ0pTVmFsdWVJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0NKU1ZhbHVlSW5saW5lcy5oCmluZGV4IDcyYzBjZDkuLmRhNTQ2ZTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWVJbmxpbmVzLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaApAQCAtNzg2 LDcgKzc4Niw3IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBKU1ZhbHVlOjplcXVhbFNsb3dDYXNlSW5s aW5lKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2MSwgSlNWCiAgICAgICAgIGJvb2wgczEgPSB2 MS5pc1N0cmluZygpOwogICAgICAgICBib29sIHMyID0gdjIuaXNTdHJpbmcoKTsKICAgICAgICAg aWYgKHMxICYmIHMyKQotICAgICAgICAgICAgcmV0dXJuIFdURjo6ZXF1YWwoKmFzU3RyaW5nKHYx KS0+dmFsdWUoZXhlYykuaW1wbCgpLCAqYXNTdHJpbmcodjIpLT52YWx1ZShleGVjKS5pbXBsKCkp OworICAgICAgICAgICAgcmV0dXJuIFdURjo6ZXF1YWwoYXNTdHJpbmcodjEpLT52aWV3KGV4ZWMp LCBhc1N0cmluZyh2MiktPnZpZXcoZXhlYykpOwogCiAgICAgICAgIGlmICh2MS5pc1VuZGVmaW5l ZE9yTnVsbCgpKSB7CiAgICAgICAgICAgICBpZiAodjIuaXNVbmRlZmluZWRPck51bGwoKSkKQEAg LTg1Niw3ICs4NTYsNyBAQCBBTFdBWVNfSU5MSU5FIGJvb2wgSlNWYWx1ZTo6c3RyaWN0RXF1YWxT bG93Q2FzZUlubGluZShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdgogICAgIEFTU0VSVCh2MS5p c0NlbGwoKSAmJiB2Mi5pc0NlbGwoKSk7CiAKICAgICBpZiAodjEuYXNDZWxsKCktPmlzU3RyaW5n KCkgJiYgdjIuYXNDZWxsKCktPmlzU3RyaW5nKCkpCi0gICAgICAgIHJldHVybiBXVEY6OmVxdWFs KCphc1N0cmluZyh2MSktPnZhbHVlKGV4ZWMpLmltcGwoKSwgKmFzU3RyaW5nKHYyKS0+dmFsdWUo ZXhlYykuaW1wbCgpKTsKKyAgICAgICAgcmV0dXJuIFdURjo6ZXF1YWwoYXNTdHJpbmcodjEpLT52 aWV3KGV4ZWMpLCBhc1N0cmluZyh2MiktPnZpZXcoZXhlYykpOwogICAgIGlmICh2MS5hc0NlbGwo KS0+aXNTeW1ib2woKSAmJiB2Mi5hc0NlbGwoKS0+aXNTeW1ib2woKSkKICAgICAgICAgcmV0dXJu IGFzU3ltYm9sKHYxKS0+cHJpdmF0ZU5hbWUoKSA9PSBhc1N5bWJvbCh2MiktPnByaXZhdGVOYW1l KCk7CiAK