145377 2015-05-26 03:41:39 -0700 [ARM] Build SVGPathElement.cpp with -O2 due to a GCC bug 2017-05-10 01:20:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 ossy ossy cgarcia clopez ossy silvio.frischi oldest_to_newest 1097298 0 ossy 2015-05-26 03:41:39 -0700 log from GTK ARM buildbot: --------------------------- In file included from ../../Source/WebCore/svg/SVGPathElement.cpp:22:0: ../../Source/WebCore/svg/SVGPathElement.h: In member function ‘virtual WebCore::FloatRect WebCore::SVGPathElement::_ZTv0_n24_N7WebCore14SVGPathElement7getBBoxENS_12SVGLocatable19StyleUpdateStrategyE(WebCore::SVGLocatable::StyleUpdateStrategy)’: ../../Source/WebCore/svg/SVGPathElement.h:94:23: internal compiler error: in expand_expr_addr_expr_1, at expr.c:7671 virtual FloatRect getBBox(StyleUpdateStrategy = AllowStyleUpdate) override; ^ Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-4.9/README.Bugs> for instructions. Preprocessed source stored into /tmp/cc8TnIRO.out file, please attach this to your bugreport. It is a known GCC bug - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64896 - which is already fixed in GCC trunk and 4.9 branch. But unfortunately the bug was fixed after 4.9.2 release, so we need to build this source with O2 until bumping to 4.9.3 (not yet released) or 5.1. Patch is coming soon. 1097299 1 253703 ossy 2015-05-26 04:14:37 -0700 Created attachment 253703 Patch -O2 fixed this issue for me long long time ago - https://bugs.webkit.org/show_bug.cgi?id=140162#c94 , but I haven't tested it now. I tested the cmake version check, it adds the O2 flag for all 4.9 version older than the not yet released 4.9.3. There is only one possible issue ... Linaro has released GCC versions with the 4.9.3 version number which conatain this bug, but their latest 4.9.3 (15.03) release already contains the upstream fix. But I don't think if we can/should check the non official GCC version numbers. 1097302 2 253703 cgarcia 2015-05-26 04:50:11 -0700 Comment on attachment 253703 Patch Ok, let's try with this. Thanks Ossy! 1097303 3 253703 ossy 2015-05-26 04:53:32 -0700 Comment on attachment 253703 Patch Clearing flags on attachment: 253703 Committed r184857: <http://trac.webkit.org/changeset/184857> 1097304 4 ossy 2015-05-26 04:53:39 -0700 All reviewed patches have been landed. Closing bug. 1306764 5 silvio.frischi 2017-05-10 01:20:24 -0700 This patch does not work for allinone builds, in which case svg/SVGAllInOne.cpp is still compiled with -O3 and fails. 253703 2015-05-26 04:14:37 -0700 2015-05-26 04:53:32 -0700 Patch bug-145377-20150526041426.patch text/plain 1458 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0ODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTEzNTUyZjNkYjhmYjFm OGQzMjdjYzRmNDc5ZmE3ZDg4YTNmYWZlZS4uMjYxNDdkZjlkNDk3YzVhMjA0MzhhN2QyNjdmODRk OTNmN2E3N2QzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA1LTI2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0FSTV0gQnVpbGQg U1ZHUGF0aEVsZW1lbnQuY3BwIHdpdGggLU8yIGR1ZSB0byBhIEdDQyBidWcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTM3NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisK IDIwMTUtMDUtMjUgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBG aXhlZCBhIGZhaWxpbmcgYmluZGluZ3MgdGVzdCBhZnRlciByMTg0ODUzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz LnR4dAppbmRleCA4NjI0ZDkxNjA5MjhkZWJkYWRmNTE0Mzc5YzhmYmVmZmM3OGNhYTVlLi45N2Ez ZDIwNjk2MmMyMTc0NmI1OGU2Y2ViY2I5YTJkNGZjMzFjZTE3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4 dApAQCAtMzU3MywzICszNTczLDkgQEAgaWYgKFNIQVJFRF9DT1JFKQogICAgIHNldF90YXJnZXRf cHJvcGVydGllcyhXZWJDb3JlIFBST1BFUlRJRVMgVkVSU0lPTiAke1BST0pFQ1RfVkVSU0lPTn0g U09WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfSkKICAgICBpbnN0YWxsKFRBUkdFVFMg V2ViQ29yZSBERVNUSU5BVElPTiAiJHtMSUJfSU5TVEFMTF9ESVJ9IikKIGVuZGlmICgpCisKKyMg W0FSTV0gQnVpbGQgU1ZHUGF0aEVsZW1lbnQuY3BwIHdpdGggLU8yIGR1ZSB0byBhIEdDQyBidWcK KyMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTM3NworaWYgKChD TUFLRV9DWFhfQ09NUElMRVJfSUQgU1RSRVFVQUwgIkdOVSIpIEFORCBXVEZfQ1BVX0FSTSBBTkQg KENNQUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OIFZFUlNJT05fR1JFQVRFUiAiNC45IikgQU5EIChD TUFLRV9DWFhfQ09NUElMRVJfVkVSU0lPTiBWRVJTSU9OX0xFU1MgIjQuOS4zIikpCisgICAgc2V0 X3NvdXJjZV9maWxlc19wcm9wZXJ0aWVzKHN2Zy9TVkdQYXRoRWxlbWVudC5jcHAgUFJPUEVSVElF UyBDT01QSUxFX0ZMQUdTICItTzIiKQorZW5kaWYgKCkK