145363 2015-05-24 16:34:07 -0700 Web Inspector: Uncaught exception when using Inspect tool on SVG elements 2015-05-24 19:38:38 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED http://cse512-15s.github.io/a3-adityas-burg-aburner/dashboard/pipeline.html InRadar P2 Normal --- 1 burg burg graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1097190 0 burg 2015-05-24 16:34:07 -0700 Steps to repro: 1. Go to the URL. 2. Inspect any SVG element with the "Inspect" picker. The numbered circles are an easy target. At this point, the 1st level inspector debugger pauses, with message: Exception with thrown value: TypeError: node.className.trim is not a function. (In 'node.className.trim()', 'node.className.trim' is undefined) It seems that InjectedScript.prototype._nodeDescription is blowing up because SVG*Element.className will return an SVGAnimatedString instead of a DOMString. 1097191 1 webkit-bug-importer 2015-05-24 16:34:27 -0700 <rdar://problem/21092210> 1097193 2 253670 burg 2015-05-24 16:45:31 -0700 Created attachment 253670 Patch 1097194 3 253670 joepeck 2015-05-24 18:41:42 -0700 Comment on attachment 253670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253670&action=review r=me. Good find! > Source/JavaScriptCore/inspector/InjectedScriptSource.js:768 > + if (node.hasAttribute("class")) > + // Using .getAttribute() is a workaround for SVG*Element.className returning SVGAnimatedString, > + // which doesn't have any useful String methods. See <https://webkit.org/b/145363/>. > + description += "." + node.getAttribute("class").trim().replace(/\s+/g, "."); Style: This block need braces now. 1097198 4 burg 2015-05-24 19:38:38 -0700 Committed r184847: <http://trac.webkit.org/changeset/184847> 253670 2015-05-24 16:45:31 -0700 2015-05-24 18:41:42 -0700 Patch bug-145363-20150524164522.patch text/plain 2148 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0ODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 NDI4MWEwOWU1YzZjZjUyYjU1NTkzZTE1YjhhZjUwZjU4ODAzNjk5Li5kNmU1ZGRhMTgyOGMwYTY4 ZGNlYTIxN2I4ZDU4ZDY0MWQ3MzA4ZGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wNS0yNCAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rv bi5lZHU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVnaHQgZXhjZXB0aW9uIGluIHdo ZW4gdXNpbmcgSW5zcGVjdCB0b29sIG9uIFNWRyBlbGVtZW50cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MzYzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGluamVjdGVkIHNjcmlwdCBmYWlsZWQg YnkgY2hhaW5pbmcgYSBjYWxsIHRvIFN0cmluZy5wcm90b3R5cGUudHJpbSB0byB0aGUgcmVzdWx0 IG9mCisgICAgICAgIFNWRypFbGVtZW50LmNsYXNzTmFtZSwgd2hpY2ggaXMgYW4gU1ZHQW5pbWF0 ZWRTdHJpbmcgYW5kIGxhY2tzIHVzZWZ1bCBtZXRob2RzLiBTbywgb2J0YWluCisgICAgICAgIHRo ZSBjbGFzcyBuYW1lIHVzaW5nIE5vZGUuZ2V0QXR0cmlidXRlLCB3aGljaCBhbHdheXMgcmV0dXJu cyBhIERPTVN0cmluZy4KKworICAgICAgICAqIGluc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJj ZS5qczoKKyAgICAgICAgKEluamVjdGVkU2NyaXB0U291cmNlLnByb3RvdHlwZS5fZ2V0RGVzY3Jp cHRpb24pOiB1c2UgZ2V0QXR0cmlidXRlIGluc3RlYWQgb2YgY2xhc3NOYW1lLgorCiAyMDE1LTA1 LTIzICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIElu dHJvZHVjZSBVbmlxdWVkU3RyaW5nSW1wbCBhbmQgU3ltYm9sSW1wbCB0byBzZXBhcmF0ZSBzeW1i b2xpYyBzdHJpbmdzIGZyb20gQXRvbWljU3RyaW5nSW1wbApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKaW5kZXggMTU0 MzY5MzBkOGQwODIyY2Y2NDkzZjQwYWU1ZTVkN2ZmYzg4ODA2OS4uZjdhMGM5Nzc2NjczYmQ0Y2Jm ZjVmMDIxODAxNjdkZDdmZThiZTkyOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcworKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCkBAIC03NjIsOCArNzYyLDEw IEBAIEluamVjdGVkU2NyaXB0LnByb3RvdHlwZSA9IHsKICAgICAgICAgY2FzZSAxOiAvLyBOb2Rl LkVMRU1FTlRfTk9ERQogICAgICAgICAgICAgaWYgKG5vZGUuaWQpCiAgICAgICAgICAgICAgICAg ZGVzY3JpcHRpb24gKz0gIiMiICsgbm9kZS5pZDsKLSAgICAgICAgICAgIGlmIChub2RlLmNsYXNz TmFtZSkKLSAgICAgICAgICAgICAgICBkZXNjcmlwdGlvbiArPSAiLiIgKyBub2RlLmNsYXNzTmFt ZS50cmltKCkucmVwbGFjZSgvXHMrL2csICIuIik7CisgICAgICAgICAgICBpZiAobm9kZS5oYXNB dHRyaWJ1dGUoImNsYXNzIikpCisgICAgICAgICAgICAgICAgLy8gVXNpbmcgLmdldEF0dHJpYnV0 ZSgpIGlzIGEgd29ya2Fyb3VuZCBmb3IgU1ZHKkVsZW1lbnQuY2xhc3NOYW1lIHJldHVybmluZyBT VkdBbmltYXRlZFN0cmluZywKKyAgICAgICAgICAgICAgICAvLyB3aGljaCBkb2Vzbid0IGhhdmUg YW55IHVzZWZ1bCBTdHJpbmcgbWV0aG9kcy4gU2VlIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDUz NjMvPi4KKyAgICAgICAgICAgICAgICBkZXNjcmlwdGlvbiArPSAiLiIgKyBub2RlLmdldEF0dHJp YnV0ZSgiY2xhc3MiKS50cmltKCkucmVwbGFjZSgvXHMrL2csICIuIik7CiAgICAgICAgICAgICBy ZXR1cm4gZGVzY3JpcHRpb247CiAKICAgICAgICAgZGVmYXVsdDoK