145353 2015-05-23 16:27:02 -0700 String.prototype.charCodeAt() should use StringView. 2015-05-26 11:57:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue darin oldest_to_newest 1097125 0 kling 2015-05-23 16:27:02 -0700 String.prototype.charCodeAt() will currently reify substring JSStrings. Let's avoid that if we can. 1097126 1 253653 kling 2015-05-23 16:29:01 -0700 Created attachment 253653 Patch 1097364 2 253653 commit-queue 2015-05-26 11:56:58 -0700 Comment on attachment 253653 Patch Clearing flags on attachment: 253653 Committed r184866: <http://trac.webkit.org/changeset/184866> 1097365 3 commit-queue 2015-05-26 11:57:02 -0700 All reviewed patches have been landed. Closing bug. 253653 2015-05-23 16:29:01 -0700 2015-05-26 11:56:58 -0700 Patch bug-145353.diff text/plain 2199 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDZkMjE2ZTUuLjM2NjUxYmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTA1LTIzICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBTdHJpbmcucHJvdG90eXBlLmNoYXJDb2Rl QXQoKSBzaG91bGQgdXNlIFN0cmluZ1ZpZXcuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcv Yi8xNDUzNTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVXNlIEpTU3RyaW5nOjp2aWV3KCkgaW4gY2hhckNvZGVBdCgpIHRvIGF2b2lkIHJlaWZ5aW5n IHRoZSBKU1N0cmluZyBpZiBpdCdzCisgICAgICAgIGEgc3Vic3RyaW5nLiBUaGlzIGF2b2lkcyBT dHJpbmdJbXBsIGFsbG9jYXRpb24gaW4gc29tZSBjYXNlcyBhbmQgcmVmIGNodXJuCisgICAgICAg IGluIGFsbCBjYXNlcy4KKworICAgICAgICAqIHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoK KyAgICAgICAgKEpTQzo6c3RyaW5nUHJvdG9GdW5jQ2hhckNvZGVBdCk6CisKKzIwMTUtMDUtMjMg IEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIFN0cmluZy5wcm90 b3R5cGUuY2hhckF0KCkgc2hvdWxkIHVzZSBTdHJpbmdWaWV3LgogICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTQ1MzUyPgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU3RyaW5nUHJvdG90eXBlLmNwcAppbmRleCAzYTIxMGRkLi45ZTJmYWEyIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKQEAgLTgw NCwyMSArODA0LDE3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgc3RyaW5nUHJvdG9G dW5jQ2hhckNvZGVBdChFeGVjU3RhdGUqIGV4ZWMpCiAgICAgSlNWYWx1ZSB0aGlzVmFsdWUgPSBl eGVjLT50aGlzVmFsdWUoKTsKICAgICBpZiAoIWNoZWNrT2JqZWN0Q29lcmNpYmxlKHRoaXNWYWx1 ZSkpCiAgICAgICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGV4ZWMpOwotICAgIFN0cmluZyBz ID0gdGhpc1ZhbHVlLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKTsKLSAgICB1bnNpZ25lZCBs ZW4gPSBzLmxlbmd0aCgpOworICAgIFN0cmluZ1ZpZXcgc3RyaW5nID0gdGhpc1ZhbHVlLnRvU3Ry aW5nKGV4ZWMpLT52aWV3KGV4ZWMpOwogICAgIEpTVmFsdWUgYTAgPSBleGVjLT5hcmd1bWVudCgw KTsKICAgICBpZiAoYTAuaXNVSW50MzIoKSkgewogICAgICAgICB1aW50MzJfdCBpID0gYTAuYXNV SW50MzIoKTsKLSAgICAgICAgaWYgKGkgPCBsZW4pIHsKLSAgICAgICAgICAgIGlmIChzLmlzOEJp dCgpKQotICAgICAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIocy5j aGFyYWN0ZXJzOCgpW2ldKSk7Ci0gICAgICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpz TnVtYmVyKHMuY2hhcmFjdGVyczE2KClbaV0pKTsKLSAgICAgICAgfQorICAgICAgICBpZiAoaSA8 IHN0cmluZy5sZW5ndGgoKSkKKyAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNO dW1iZXIoc3RyaW5nW2ldKSk7CiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOYU4o KSk7CiAgICAgfQogICAgIGRvdWJsZSBkcG9zID0gYTAudG9JbnRlZ2VyKGV4ZWMpOwotICAgIGlm IChkcG9zID49IDAgJiYgZHBvcyA8IGxlbikKLSAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29k ZShqc051bWJlcihzW3N0YXRpY19jYXN0PGludD4oZHBvcyldKSk7CisgICAgaWYgKGRwb3MgPj0g MCAmJiBkcG9zIDwgc3RyaW5nLmxlbmd0aCgpKQorICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKGpzTnVtYmVyKHN0cmluZ1tzdGF0aWNfY2FzdDxpbnQ+KGRwb3MpXSkpOwogICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoanNOYU4oKSk7CiB9CiAK