145338 2015-05-22 21:45:28 -0700 Web Inspector: Improve native parameter lists a bit 2015-05-23 08:03:59 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1097051 0 joepeck 2015-05-22 21:45:28 -0700 * SUMMARY Improve native parameter lists a bit. - A few new built-in methods and DOM methods. - Better handling for dir(Math) / dir(JSON) 1097052 1 253634 joepeck 2015-05-22 21:46:07 -0700 Created attachment 253634 [PATCH] Proposed Fix 1097092 2 253634 commit-queue 2015-05-23 08:03:55 -0700 Comment on attachment 253634 [PATCH] Proposed Fix Clearing flags on attachment: 253634 Committed r184823: <http://trac.webkit.org/changeset/184823> 1097093 3 commit-queue 2015-05-23 08:03:59 -0700 All reviewed patches have been landed. Closing bug. 253634 2015-05-22 21:46:07 -0700 2015-05-23 08:03:55 -0700 [PATCH] Proposed Fix better-native-parameter-lists.patch text/plain 5658 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMwZTViOTY5OC4uZDBlNjlmMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTUtMDUtMjIgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXBy b3ZlIG5hdGl2ZSBwYXJhbWV0ZXIgbGlzdHMgYSBiaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvTmF0aXZlRnVu Y3Rpb25QYXJhbWV0ZXJzLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0 VHJlZVByb3BlcnR5VHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuT2JqZWN0 VHJlZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlLl9mdW5jdGlvblBhcmFtZXRlclN0cmlu Zyk6CisKKzIwMTUtMDUtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K KwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZG9wdCBPYmplY3Quc2V0UHJvdG90eXBlT2YKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTMzNQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvTmF0 aXZlRnVuY3Rpb25QYXJhbWV0ZXJzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL05hdGl2ZUZ1bmN0aW9uUGFyYW1ldGVycy5qcwppbmRleCAzODk0ZjI1Li4x OGQ3N2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvTmF0aXZlRnVuY3Rpb25QYXJhbWV0ZXJzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9OYXRpdmVGdW5jdGlvblBhcmFtZXRlcnMuanMKQEAg LTMwLDE5ICszMCwyMSBAQCBXZWJJbnNwZWN0b3IuTmF0aXZlQ29uc3RydWN0b3JGdW5jdGlvblBh cmFtZXRlcnMgPSB7CiAgICAgT2JqZWN0OiB7CiAgICAgICAgIGFzc2lnbjogInRhcmdldCwgLi4u c291cmNlcyIsCiAgICAgICAgIGNyZWF0ZTogInByb3RvdHlwZSwgW3Byb3BlcnRpZXNPYmplY3Rd IiwKLSAgICAgICAgZGVmaW5lUHJvcGVydHk6ICJvYmplY3QsIHByb3BlcnR5TmFtZSwgZGVzY3Jp cHRvciIsCiAgICAgICAgIGRlZmluZVByb3BlcnRpZXM6ICJvYmplY3QsIHByb3BlcnRpZXMiLAor ICAgICAgICBkZWZpbmVQcm9wZXJ0eTogIm9iamVjdCwgcHJvcGVydHlOYW1lLCBkZXNjcmlwdG9y IiwKICAgICAgICAgZnJlZXplOiAib2JqZWN0IiwKICAgICAgICAgZ2V0T3duUHJvcGVydHlEZXNj cmlwdG9yOiAib2JqZWN0LCBwcm9wZXJ0eU5hbWUiLAogICAgICAgICBnZXRPd25Qcm9wZXJ0eU5h bWVzOiAib2JqZWN0IiwKICAgICAgICAgZ2V0T3duUHJvcGVydHlTeW1ib2xzOiAib2JqZWN0IiwK ICAgICAgICAgZ2V0UHJvdG90eXBlT2Y6ICJvYmplY3QiLAorICAgICAgICBpczogInZhbHVlMSwg dmFsdWUyIiwKICAgICAgICAgaXNFeHRlbnNpYmxlOiAib2JqZWN0IiwKICAgICAgICAgaXNGcm96 ZW46ICJvYmplY3QiLAogICAgICAgICBpc1NlYWxlZDogIm9iamVjdCIsCiAgICAgICAgIGtleXM6 ICJvYmplY3QiLAogICAgICAgICBwcmV2ZW50RXh0ZW5zaW9uczogIm9iamVjdCIsCiAgICAgICAg IHNlYWw6ICJvYmplY3QiLAorICAgICAgICBzZXRQcm90b3R5cGVPZjogIm9iamVjdCwgcHJvdG90 eXBlIiwKICAgICAgICAgX19wcm90b19fOiBudWxsLAogICAgIH0sCiAKQEAgLTc1LDExICs3Nywx MiBAQCBXZWJJbnNwZWN0b3IuTmF0aXZlQ29uc3RydWN0b3JGdW5jdGlvblBhcmFtZXRlcnMgPSB7 CiAgICAgICAgIGFjb3NoOiAieCIsCiAgICAgICAgIGFzaW46ICJ4IiwKICAgICAgICAgYXNpbmg6 ICJ4IiwKLSAgICAgICAgYXRhbjogIngiLAogICAgICAgICBhdGFuMjogInksIHgiLAorICAgICAg ICBhdGFuOiAieCIsCiAgICAgICAgIGF0YW5oOiAieCIsCiAgICAgICAgIGNicnQ6ICJ4IiwKICAg ICAgICAgY2VpbDogIngiLAorICAgICAgICBjbHozMjogIngiLAogICAgICAgICBjb3M6ICJ4IiwK ICAgICAgICAgY29zaDogIngiLAogICAgICAgICBleHA6ICJ4IiwKQEAgLTk2LDYgKzk5LDcgQEAg V2ViSW5zcGVjdG9yLk5hdGl2ZUNvbnN0cnVjdG9yRnVuY3Rpb25QYXJhbWV0ZXJzID0gewogICAg ICAgICBtaW46ICJbLi4ueF0iLAogICAgICAgICBwb3c6ICJ4LCB5IiwKICAgICAgICAgcm91bmQ6 ICJ4IiwKKyAgICAgICAgc2lnbjogIngiLAogICAgICAgICBzaW46ICJ4IiwKICAgICAgICAgc2lu aDogIngiLAogICAgICAgICBzcXJ0OiAieCIsCkBAIC0xMjYsNyArMTMwLDkgQEAgV2ViSW5zcGVj dG9yLk5hdGl2ZUNvbnN0cnVjdG9yRnVuY3Rpb25QYXJhbWV0ZXJzID0gewogICAgIH0sCiAKICAg ICBTdHJpbmc6IHsKLSAgICAgICAgZnJvbUNoYXJDb2RlOiAiY29kZSwgWy4uLmNvZGVzXSIsCisg ICAgICAgIGZyb21DaGFyQ29kZTogIi4uLmNvZGVVbml0cyIsCisgICAgICAgIGZyb21Db2RlUG9p bnQ6ICIuLi5jb2RlUG9pbnRzIiwKKyAgICAgICAgcmF3OiAidGVtcGxhdGUsIC4uLnN1YnN0aXR1 dGlvbnMiLAogICAgICAgICBfX3Byb3RvX186IG51bGwsCiAgICAgfSwKIApAQCAtMzAwLDEyICsz MDYsMTQgQEAgV2ViSW5zcGVjdG9yLk5hdGl2ZVByb3RvdHlwZUZ1bmN0aW9uUGFyYW1ldGVycyA9 IHsKICAgICBTdHJpbmc6IHsKICAgICAgICAgY2hhckF0OiAiaW5kZXgiLAogICAgICAgICBjaGFy Q29kZUF0OiAiaW5kZXgiLAorICAgICAgICBjb2RlUG9pbnRzOiAiaW5kZXgiLAogICAgICAgICBj b25jYXQ6ICJzdHJpbmcsIC4uLiIsCiAgICAgICAgIGluY2x1ZGVzOiAic2VhcmNoVmFsdWUsIFtz dGFydEluZGV4PTBdIiwKICAgICAgICAgaW5kZXhPZjogInNlYXJjaFZhbHVlLCBbc3RhcnRJbmRl eD0wXSIsCiAgICAgICAgIGxhc3RJbmRleE9mOiAic2VhcmNoVmFsdWUsIFtzdGFydEluZGV4PWxl bmd0aF0iLAogICAgICAgICBsb2NhbGVDb21wYXJlOiAic3RyaW5nIiwKICAgICAgICAgbWF0Y2g6 ICJyZWdleCIsCisgICAgICAgIHJlcGVhdDogImNvdW50IiwKICAgICAgICAgcmVwbGFjZTogInJl Z2V4fHN0cmluZywgcmVwbGFjZVN0cmluZ3xyZXBsYWNlSGFuZGxlciwgW2ZsYWdzXSIsCiAgICAg ICAgIHNlYXJjaDogInJlZ2V4IiwKICAgICAgICAgc2xpY2U6ICJzdGFydEluZGV4LCBbZW5kSW5k ZXg9bGVuZ3RoXSIsCkBAIC03MzMsNiArNzQxLDcgQEAgV2ViSW5zcGVjdG9yLk5hdGl2ZVByb3Rv dHlwZUZ1bmN0aW9uUGFyYW1ldGVycyA9IHsKICAgICB9LAogCiAgICAgRG9jdW1lbnRGcmFnbWVu dDogeworICAgICAgICBnZXRFbGVtZW50QnlJZDogImlkIiwKICAgICAgICAgcXVlcnlTZWxlY3Rv cjogInNlbGVjdG9ycyIsCiAgICAgICAgIHF1ZXJ5U2VsZWN0b3JBbGw6ICJzZWxlY3RvcnMiLAog ICAgICAgICBfX3Byb3RvX186IG51bGwsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlUHJvcGVydHlUcmVlRWxlbWVudC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQcm9w ZXJ0eVRyZWVFbGVtZW50LmpzCmluZGV4IDg4ZTZiNzguLjdlMWNiMTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQcm9wZXJ0 eVRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL09iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50LmpzCkBAIC0yNTcsOSArMjU3LDEx IEBAIFdlYkluc3BlY3Rvci5PYmplY3RUcmVlUHJvcGVydHlUcmVlRWxlbWVudCA9IGNsYXNzIE9i amVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAg ICAgfQogCisgICAgICAgICAgICB2YXIgcGFyZW50RGVzY3JpcHRpb24gPSB0aGlzLl9wcm9wZXJ0 eVBhdGgub2JqZWN0LmRlc2NyaXB0aW9uOworCiAgICAgICAgICAgICAvLyBOYXRpdmUgZnVuY3Rp b24gcHJvcGVydHkgb24gYSBuYXRpdmUgZnVuY3Rpb24gaXMgbGlrZWx5IGEgIkZvby5tZXRob2Qi LgotICAgICAgICAgICAgaWYgKGlzRnVuY3Rpb25TdHJpbmdOYXRpdmVDb2RlKHRoaXMuX3Byb3Bl cnR5UGF0aC5vYmplY3QuZGVzY3JpcHRpb24pKSB7Ci0gICAgICAgICAgICAgICAgdmFyIG1hdGNo ID0gdGhpcy5fcHJvcGVydHlQYXRoLm9iamVjdC5kZXNjcmlwdGlvbi5tYXRjaCgvXmZ1bmN0aW9u XHMrKFteKV0rPylcKC8pOworICAgICAgICAgICAgaWYgKGlzRnVuY3Rpb25TdHJpbmdOYXRpdmVD b2RlKHBhcmVudERlc2NyaXB0aW9uKSkgeworICAgICAgICAgICAgICAgIHZhciBtYXRjaCA9IHBh cmVudERlc2NyaXB0aW9uLm1hdGNoKC9eZnVuY3Rpb25ccysoW14pXSs/KVwoLyk7CiAgICAgICAg ICAgICAgICAgaWYgKG1hdGNoKSB7CiAgICAgICAgICAgICAgICAgICAgIHZhciBuYW1lID0gbWF0 Y2hbMV07CiAgICAgICAgICAgICAgICAgICAgIGlmIChXZWJJbnNwZWN0b3IuTmF0aXZlQ29uc3Ry dWN0b3JGdW5jdGlvblBhcmFtZXRlcnNbbmFtZV0pIHsKQEAgLTI2OSw5ICsyNzEsOSBAQCBXZWJJ bnNwZWN0b3IuT2JqZWN0VHJlZVByb3BlcnR5VHJlZUVsZW1lbnQgPSBjbGFzcyBPYmplY3RUcmVl UHJvcGVydHlUcmVlRWxlbWVudAogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KIAot ICAgICAgICAgICAgLy8gTmF0aXZlIERPTSBjb25zdHJ1Y3Rvci4KLSAgICAgICAgICAgIGlmICh0 aGlzLl9wcm9wZXJ0eVBhdGgub2JqZWN0LmRlc2NyaXB0aW9uLmVuZHNXaXRoKCJDb25zdHJ1Y3Rv ciIpKSB7Ci0gICAgICAgICAgICAgICAgdmFyIG5hbWUgPSB0aGlzLl9wcm9wZXJ0eVBhdGgub2Jq ZWN0LmRlc2NyaXB0aW9uOworICAgICAgICAgICAgLy8gTmF0aXZlIERPTSBjb25zdHJ1Y3RvciBv ciBvbiBuYXRpdmUgb2JqZWN0cyB0aGF0IGFyZSBub3QgZnVuY3Rpb25zLgorICAgICAgICAgICAg aWYgKHBhcmVudERlc2NyaXB0aW9uLmVuZHNXaXRoKCJDb25zdHJ1Y3RvciIpIHx8IHBhcmVudERl c2NyaXB0aW9uID09PSAiTWF0aCIgfHwgcGFyZW50RGVzY3JpcHRpb24gPT09ICJKU09OIikgewor ICAgICAgICAgICAgICAgIHZhciBuYW1lID0gcGFyZW50RGVzY3JpcHRpb247CiAgICAgICAgICAg ICAgICAgaWYgKFdlYkluc3BlY3Rvci5OYXRpdmVDb25zdHJ1Y3RvckZ1bmN0aW9uUGFyYW1ldGVy c1tuYW1lXSkgewogICAgICAgICAgICAgICAgICAgICB2YXIgcGFyYW1zID0gV2ViSW5zcGVjdG9y Lk5hdGl2ZUNvbnN0cnVjdG9yRnVuY3Rpb25QYXJhbWV0ZXJzW25hbWVdW3RoaXMuX3Byb3BlcnR5 Lm5hbWVdOwogICAgICAgICAgICAgICAgICAgICByZXR1cm4gcGFyYW1zID8gIigiICsgcGFyYW1z ICsgIikiIDogIigpIjsK