145335 2015-05-22 20:48:28 -0700 Web Inspector: Adopt Object.setPrototypeOf 2015-05-22 23:31:19 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1097040 0 joepeck 2015-05-22 20:48:28 -0700 * SUMMARY Adopt Object.setPrototypeOf and provide better API view for it. Just implemented in JavaScriptCore. For the one place where we set __proto__ that won't easily be converted to ES6 classes, we can use the method. And remember to improve the parameter list for the API view. 1097041 1 253630 joepeck 2015-05-22 20:49:30 -0700 Created attachment 253630 [PATCH] Proposed Fix 1097045 2 joepeck 2015-05-22 21:04:41 -0700 I'm going to update Native parameter lists separately. Just focus on adoption here. 1097046 3 253631 joepeck 2015-05-22 21:06:00 -0700 Created attachment 253631 [PATCH] Proposed Fix 1097072 4 253631 commit-queue 2015-05-22 23:31:15 -0700 Comment on attachment 253631 [PATCH] Proposed Fix Clearing flags on attachment: 253631 Committed r184820: <http://trac.webkit.org/changeset/184820> 1097073 5 commit-queue 2015-05-22 23:31:19 -0700 All reviewed patches have been landed. Closing bug. 253630 2015-05-22 20:49:30 -0700 2015-05-22 21:06:00 -0700 [PATCH] Proposed Fix adopt-setPrototypeOf.patch text/plain 2007 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVjMzJiNWQuLjk1OWY4YzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE1LTA1LTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRvcHQg T2JqZWN0LnNldFByb3RvdHlwZU9mIGFuZCBwcm92aWRlIGJldHRlciBBUEkgdmlldyBmb3IgaXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTMzNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Nb2RlbHMvTmF0aXZlRnVuY3Rpb25QYXJhbWV0ZXJzLmpzOgorICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yQmFja2VuZC5qczoKKyAgICAgICAgKEluc3Bl Y3RvckJhY2tlbmQuQ29tbWFuZC5jcmVhdGUpOgorCisyMDE1LTA1LTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5saW5l IHVzZSBvbmNlIGNsYXNzIG5hbWVzIGFuZCByZW1vdmUgc29tZSB1bnVzZWQgY2xhc3MgbmFtZXMK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTMzNAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv TmF0aXZlRnVuY3Rpb25QYXJhbWV0ZXJzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL05hdGl2ZUZ1bmN0aW9uUGFyYW1ldGVycy5qcwppbmRleCAzODk0ZjI1 Li5hODY1ODZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvTmF0aXZlRnVuY3Rpb25QYXJhbWV0ZXJzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9OYXRpdmVGdW5jdGlvblBhcmFtZXRlcnMuanMK QEAgLTQzLDYgKzQzLDcgQEAgV2ViSW5zcGVjdG9yLk5hdGl2ZUNvbnN0cnVjdG9yRnVuY3Rpb25Q YXJhbWV0ZXJzID0gewogICAgICAgICBrZXlzOiAib2JqZWN0IiwKICAgICAgICAgcHJldmVudEV4 dGVuc2lvbnM6ICJvYmplY3QiLAogICAgICAgICBzZWFsOiAib2JqZWN0IiwKKyAgICAgICAgc2V0 UHJvdG90eXBlT2Y6ICJvYmplY3QsIHByb3RvdHlwZSIsCiAgICAgICAgIF9fcHJvdG9fXzogbnVs bCwKICAgICB9LAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yQmFja2VuZC5qcwppbmRleCA3YzU1OTRi Li40ZGU2MmU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Qcm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJhY2tlbmQuanMKQEAgLTM4NSw3ICsz ODUsNyBAQCBJbnNwZWN0b3JCYWNrZW5kLkNvbW1hbmQuY3JlYXRlID0gZnVuY3Rpb24oYmFja2Vu ZCwgY29tbWFuZE5hbWUsIGNhbGxTaWduYXR1cmUsCiAgICAgfQogCiAgICAgY2FsbGFibGUuX2lu c3RhbmNlID0gaW5zdGFuY2U7Ci0gICAgY2FsbGFibGUuX19wcm90b19fID0gSW5zcGVjdG9yQmFj a2VuZC5Db21tYW5kLnByb3RvdHlwZTsKKyAgICBPYmplY3Quc2V0UHJvdG90eXBlT2YoY2FsbGFi bGUsIEluc3BlY3RvckJhY2tlbmQuQ29tbWFuZC5wcm90b3R5cGUpOwogCiAgICAgcmV0dXJuIGNh bGxhYmxlOwogfTsK 253631 2015-05-22 21:06:00 -0700 2015-05-22 23:31:15 -0700 [PATCH] Proposed Fix better.patch text/plain 1418 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVjMzJiNWQuLjMwZTViOTY5OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTUtMDUtMjIgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZG9w dCBPYmplY3Quc2V0UHJvdG90eXBlT2YKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NTMzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZvciBhIGNhc2UgdGhhdCB3b24ndCBlYXNpbHkgbW92ZSB0byBFUzYg Y2xhc3NlcyB1c2UgT2JqZWN0LnNldFByb3RvdHlwZU9mLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kLmpzOgorICAgICAgICAoSW5zcGVjdG9yQmFj a2VuZC5Db21tYW5kLmNyZWF0ZSk6CisKKzIwMTUtMDUtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbmxpbmUgdXNlIG9u Y2UgY2xhc3MgbmFtZXMgYW5kIHJlbW92ZSBzb21lIHVudXNlZCBjbGFzcyBuYW1lcwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MzM0CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3Bl Y3RvckJhY2tlbmQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90 b2NvbC9JbnNwZWN0b3JCYWNrZW5kLmpzCmluZGV4IDdjNTU5NGIuLjRkZTYyZTQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3Rv ckJhY2tlbmQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJv dG9jb2wvSW5zcGVjdG9yQmFja2VuZC5qcwpAQCAtMzg1LDcgKzM4NSw3IEBAIEluc3BlY3RvckJh Y2tlbmQuQ29tbWFuZC5jcmVhdGUgPSBmdW5jdGlvbihiYWNrZW5kLCBjb21tYW5kTmFtZSwgY2Fs bFNpZ25hdHVyZSwKICAgICB9CiAKICAgICBjYWxsYWJsZS5faW5zdGFuY2UgPSBpbnN0YW5jZTsK LSAgICBjYWxsYWJsZS5fX3Byb3RvX18gPSBJbnNwZWN0b3JCYWNrZW5kLkNvbW1hbmQucHJvdG90 eXBlOworICAgIE9iamVjdC5zZXRQcm90b3R5cGVPZihjYWxsYWJsZSwgSW5zcGVjdG9yQmFja2Vu ZC5Db21tYW5kLnByb3RvdHlwZSk7CiAKICAgICByZXR1cm4gY2FsbGFibGU7CiB9Owo=