145320 2015-05-22 14:40:35 -0700 Image link doesn't create a preview view controller. 2015-05-22 15:52:36 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned bdakin commit-queue mitz sam webkit-bug-importer oldest_to_newest 1096953 0 yongjun_zhang 2015-05-22 14:40:35 -0700 It looks like we are skipping images links when creating preview view controller. 1096954 1 yongjun_zhang 2015-05-22 14:41:57 -0700 <rdar://problem/20749900> 1096958 2 253608 yongjun_zhang 2015-05-22 14:47:45 -0700 Created attachment 253608 Patch. 1096982 3 253608 commit-queue 2015-05-22 15:52:32 -0700 Comment on attachment 253608 Patch. Clearing flags on attachment: 253608 Committed r184798: <http://trac.webkit.org/changeset/184798> 1096983 4 commit-queue 2015-05-22 15:52:36 -0700 All reviewed patches have been landed. Closing bug. 253608 2015-05-22 14:47:45 -0700 2015-05-22 15:52:32 -0700 Patch. image_link_preview.patch text/plain 2140 yongjun_zhang Y29tbWl0IDVlNGNmNmZiM2QwMmU4ODg4M2JlZGFiNWMxMWJlOWNiOWM1MDQ1NDIKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBGcmkgTWF5IDIy IDE0OjQzOjExIDIwMTUgLTA3MDAKCiAgICBJbWFnZSBsaW5rIGRvZXNuJ3QgY3JlYXRlIGEgcHJl dmlldyB2aWV3IGNvbnRyb2xsZXIuCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDgxYzA2ODcuLmRmYzU5OTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNS0wNS0yMiAgWW9uZ2p1biBaaGFuZyAgPHlv bmdqdW5femhhbmdAYXBwbGUuY29tPgorCisgICAgICAgIEltYWdlIGxpbmsgZG9lc24ndCBjcmVh dGUgYSBwcmV2aWV3IHZpZXcgY29udHJvbGxlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTMyMAorCisgICAgICAgIEFsc28gdHJ5IHRvIGNyZWF0 ZSB0aGUgcHJldmlldyB2aWV3IGNvbnRyb2xsZXIgaWYgdGhlIGhpdC10ZXN0ZWQgbm9kZQorICAg ICAgICBpcyBhIGltYWdlIGxpbmsuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBnZXN0dXJlUmVjb2duaXplclNob3VsZEJlZ2lu Ol0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHByZXZpZXdWaWV3Q29udHJvbGxlckZvclBv c2l0aW9uOmluU291cmNlVmlldzpdKToKKwogMjAxNS0wNS0yMiAgQnJhZHkgRWlkc29uICA8YmVp ZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV3b3JrIGhvdyB0aGUgUmVzb3VyY2VSZXF1ZXN0 IHVzZXIgaW5pdGlhdGVkIHByb3BlcnR5IGtleSBpcyB1c2VkLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRl eCA2NmU3OWIyLi5kYmVkNTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtOTUzLDcgKzk1Myw3IEBA IHN0YXRpYyBpbmxpbmUgYm9vbCBpc1NhbWVQYWlyKFVJR2VzdHVyZVJlY29nbml6ZXIgKmEsIFVJ R2VzdHVyZVJlY29nbml6ZXIgKmIsIFVJCiAKICAgICBpZiAoZ2VzdHVyZVJlY29nbml6ZXIgPT0g X3ByZXZpZXdHZXN0dXJlUmVjb2duaXplcikgewogICAgICAgICBbc2VsZiBlbnN1cmVQb3NpdGlv bkluZm9ybWF0aW9uSXNVcFRvRGF0ZTpwb2ludF07Ci0gICAgICAgIGlmIChfcG9zaXRpb25JbmZv cm1hdGlvbi5jbGlja2FibGVFbGVtZW50TmFtZSAhPSAiQSIpCisgICAgICAgIGlmIChfcG9zaXRp b25JbmZvcm1hdGlvbi5jbGlja2FibGVFbGVtZW50TmFtZSAhPSAiQSIgJiYgX3Bvc2l0aW9uSW5m b3JtYXRpb24uY2xpY2thYmxlRWxlbWVudE5hbWUgIT0gIklNRyIpCiAgICAgICAgICAgICByZXR1 cm4gTk87CiAKICAgICAgICAgU3RyaW5nIGFic29sdXRlTGlua1VSTCA9IF9wb3NpdGlvbkluZm9y bWF0aW9uLnVybDsKQEAgLTMxMTcsNyArMzExNyw3IEBAIHN0YXRpYyBib29sIGlzQXNzaXN0YWJs ZUlucHV0VHlwZShJbnB1dFR5cGUgdHlwZSkKIHsKICAgICBBU1NFUlQoc2VsZiA9PSBzb3VyY2VW aWV3KTsKIAotICAgIGlmIChfcG9zaXRpb25JbmZvcm1hdGlvbi5jbGlja2FibGVFbGVtZW50TmFt ZSAhPSAiQSIpCisgICAgaWYgKF9wb3NpdGlvbkluZm9ybWF0aW9uLmNsaWNrYWJsZUVsZW1lbnRO YW1lICE9ICJBIiAmJiBfcG9zaXRpb25JbmZvcm1hdGlvbi5jbGlja2FibGVFbGVtZW50TmFtZSAh PSAiSU1HIikKICAgICAgICAgcmV0dXJuIG5pbDsKIAogICAgIFN0cmluZyBhYnNvbHV0ZUxpbmtV UkwgPSBfcG9zaXRpb25JbmZvcm1hdGlvbi51cmw7Cg==