145312 2015-05-22 12:22:32 -0700 Yellow highlight and DD popover don't go away when scrolling an iframe 2015-05-22 13:24:31 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1096919 0 bdakin 2015-05-22 12:22:32 -0700 Yellow highlight and DD popover don't go away when scrolling an iframe rdar://problem/19692334 1096921 1 253600 bdakin 2015-05-22 12:31:58 -0700 Created attachment 253600 Patch 1096924 2 253600 thorton 2015-05-22 13:03:49 -0700 Comment on attachment 253600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253600&action=review > Source/WebKit2/ChangeLog:11 > + Match what Lookup already does for their popover and dismiss our popovers on > + scroll. We could probably get rid of the other way they're dismissed on scroll, now, if we want. > Source/WebKit2/UIProcess/API/mac/WKView.mm:1351 > + [self _dismissContentRelativeChildWindowsWithAnimation:NO]; You should make sure this isn't too expensive. I think everything checks and short-circuits if there isn't currently anything installed, but ... double check? 1096928 3 253603 bdakin 2015-05-22 13:15:53 -0700 Created attachment 253603 Patch 1096929 4 253603 thorton 2015-05-22 13:17:09 -0700 Comment on attachment 253603 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253603&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:-3689 > - m_pageClient.dismissContentRelativeChildWindows(false); Are there other callers of this page client method? (there probably are, just checking) 1096931 5 bdakin 2015-05-22 13:24:31 -0700 (In reply to comment #4) > Comment on attachment 253603 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253603&action=review > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:-3689 > > - m_pageClient.dismissContentRelativeChildWindows(false); > > Are there other callers of this page client method? (there probably are, > just checking) There are other callers, but good thought! http://trac.webkit.org/changeset/184790 253600 2015-05-22 12:31:58 -0700 2015-05-22 13:15:53 -0700 Patch for-review.txt text/plain 1358 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDc4OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTIyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBZZWxsb3cgaGlnaGxpZ2h0IGFuZCBE RCBwb3BvdmVyIGRvbid0IGdvIGF3YXkgd2hlbiBzY3JvbGxpbmcgYW4gaWZyYW1lCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUzMTIKKyAgICAgICAg LWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xOTY5MjMzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hdGNoIHdoYXQg TG9va3VwIGFscmVhZHkgZG9lcyBmb3IgdGhlaXIgcG9wb3ZlciBhbmQgZGlzbWlzcyBvdXIgcG9w b3ZlcnMgb24gCisgICAgICAgIHNjcm9sbC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBzY3JvbGxXaGVlbDpdKToKKwogMjAxNS0wNS0y MiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1v dmUgYWN0aW9uIG1lbnUgc3VwcG9ydApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gMTg0MzA2KQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQ4LDYgKzEzNDgs OCBAQCAtICh2b2lkKXNjcm9sbFdoZWVsOihOU0V2ZW50ICopZXZlbnQKICAgICBpZiAoX2RhdGEt Pl9pZ25vcmVzQWxsRXZlbnRzKQogICAgICAgICByZXR1cm47CiAKKyAgICBbc2VsZiBfZGlzbWlz c0NvbnRlbnRSZWxhdGl2ZUNoaWxkV2luZG93c1dpdGhBbmltYXRpb246Tk9dOworCiAgICAgaWYg KF9kYXRhLT5fYWxsb3dzQmFja0ZvcndhcmROYXZpZ2F0aW9uR2VzdHVyZXMpIHsKICAgICAgICAg W3NlbGYgX2Vuc3VyZUdlc3R1cmVDb250cm9sbGVyXTsKICAgICAgICAgaWYgKF9kYXRhLT5fZ2Vz dHVyZUNvbnRyb2xsZXItPmhhbmRsZVNjcm9sbFdoZWVsRXZlbnQoZXZlbnQpKQo= 253603 2015-05-22 13:15:53 -0700 2015-05-22 13:17:09 -0700 Patch for-review-2.txt text/plain 2101 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDc4OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA1LTIyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBZZWxsb3cgaGlnaGxpZ2h0IGFuZCBE RCBwb3BvdmVyIGRvbid0IGdvIGF3YXkgd2hlbiBzY3JvbGxpbmcgYW4gaWZyYW1lCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUzMTIKKyAgICAgICAg LWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xOTY5MjMzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hdGNoIHdoYXQg TG9va3VwIGFscmVhZHkgZG9lcyBmb3IgdGhlaXIgcG9wb3ZlciBhbmQgZGlzbWlzcyBvdXIgcG9w b3ZlcnMgb24gCisgICAgICAgIHNjcm9sbC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBzY3JvbGxXaGVlbDpdKToKKworICAgICAgICBU aGlzIHNob3VsZCBub3QgYmUgbmVlZGVkIGFueW1vcmUuCisgICAgICAgICogVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cGFnZURpZFNj cm9sbCk6CisKIDIwMTUtMDUtMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIGFjdGlvbiBtZW51IHN1cHBvcnQKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAxODQzMDYpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzY4NSw5ICszNjg1LDYgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpZENoYW5nZVZpZXdwb3J0 UHJvcAogdm9pZCBXZWJQYWdlUHJveHk6OnBhZ2VEaWRTY3JvbGwoKQogewogICAgIG1fdWlDbGll bnQtPnBhZ2VEaWRTY3JvbGwodGhpcyk7Ci0jaWYgUExBVEZPUk0oTUFDKQotICAgIG1fcGFnZUNs aWVudC5kaXNtaXNzQ29udGVudFJlbGF0aXZlQ2hpbGRXaW5kb3dzKGZhbHNlKTsKLSNlbmRpZgog fQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6cnVuT3BlblBhbmVsKHVpbnQ2NF90IGZyYW1lSUQsIGNv bnN0IEZpbGVDaG9vc2VyU2V0dGluZ3MmIHNldHRpbmdzKQpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gMTg0MzA2KQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0x MzQ4LDYgKzEzNDgsOSBAQCAtICh2b2lkKXNjcm9sbFdoZWVsOihOU0V2ZW50ICopZXZlbnQKICAg ICBpZiAoX2RhdGEtPl9pZ25vcmVzQWxsRXZlbnRzKQogICAgICAgICByZXR1cm47CiAKKyAgICBp ZiAoZXZlbnQucGhhc2UgPT0gTlNFdmVudFBoYXNlQmVnYW4pCisgICAgICAgIFtzZWxmIF9kaXNt aXNzQ29udGVudFJlbGF0aXZlQ2hpbGRXaW5kb3dzV2l0aEFuaW1hdGlvbjpOT107CisKICAgICBp ZiAoX2RhdGEtPl9hbGxvd3NCYWNrRm9yd2FyZE5hdmlnYXRpb25HZXN0dXJlcykgewogICAgICAg ICBbc2VsZiBfZW5zdXJlR2VzdHVyZUNvbnRyb2xsZXJdOwogICAgICAgICBpZiAoX2RhdGEtPl9n ZXN0dXJlQ29udHJvbGxlci0+aGFuZGxlU2Nyb2xsV2hlZWxFdmVudChldmVudCkpCg==