145307 2015-05-22 04:54:32 -0700 EWS provides misleading information for not applyable patches 2015-06-01 10:13:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy ap commit-queue dbates ddkilzer ossy rniwa oldest_to_newest 1096849 0 ossy 2015-05-22 04:54:32 -0700 style checker says the following: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. ---- and other bubbles are green, because they didn't apply anything for example: https://bugs.webkit.org/show_bug.cgi?id=145247 https://bugs.webkit.org/show_bug.cgi?id=126433 https://bugs.webkit.org/show_bug.cgi?id=138332 https://bugs.webkit.org/show_bug.cgi?id=126022 https://bugs.webkit.org/show_bug.cgi?id=70610 1096857 1 ap 2015-05-22 07:58:09 -0700 That would be a very recent regression. What changed? 1096918 2 ap 2015-05-22 12:22:16 -0700 This just worked correctly in <https://webkit-queues.appspot.com/patch/253595> - windows bubble is red. 1096920 3 ap 2015-05-22 12:29:20 -0700 Style checker is clearly wrong, but how did you determine that other bubbles in <https://bugs.webkit.org/show_bug.cgi?id=145247> are green for a wrong reason? 1098480 4 ossy 2015-06-01 05:19:07 -0700 (In reply to comment #3) > Style checker is clearly wrong, but how did you determine that other bubbles > in <https://bugs.webkit.org/show_bug.cgi?id=145247> are green for a wrong > reason? The problem is that webkit-patch tries to apply the patch, but there is no appliable diff in the patch. In this case the green GTK/Mac/EFL bubbles mean that the trunk is buildable, nothing else. It is very misleading. I think the best fix would be to make svn-apply not to return 0 in this case. 1098481 5 253994 ossy 2015-06-01 05:40:52 -0700 Created attachment 253994 Patch 1098507 6 ap 2015-06-01 09:27:23 -0700 To summarize, this happens when a patch tries to update non-existent files. When a patch doesn't apply to existent files, we already get the correct behavior. Given that, I suspect that a more targeted fix is possible. However, adding a catch-all like this is fine too. 1098523 7 253994 commit-queue 2015-06-01 10:13:49 -0700 Comment on attachment 253994 Patch Clearing flags on attachment: 253994 Committed r185062: <http://trac.webkit.org/changeset/185062> 1098524 8 commit-queue 2015-06-01 10:13:54 -0700 All reviewed patches have been landed. Closing bug. 253994 2015-06-01 05:40:52 -0700 2015-06-01 10:13:49 -0700 Patch bug-145307-20150601054034.patch text/plain 1217 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGQ4YTMxNzlkZWU3YThiNmU1OWFhNWM0NThlNjQ2YTA2 MzljMjNiYS4uZjI3MGU1MzFlODMyODY0M2ViZjJjMTFiMzQ0NTFhZDlhNDEwYjk1NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0 IEBACiAyMDE1LTA2LTAxICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgRVdTIHByb3ZpZGVzIG1pc2xlYWRpbmcgaW5mb3JtYXRpb24gZm9yIG5vdCBhcHBs eWFibGUgcGF0Y2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ1MzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3N2bi1hcHBseTogRGllIGlmIHRoZXJlIGlzIG5vIGFwcGx5YWJsZSBk aWZmIGluIHRoZSBwYXRjaC4KKworMjAxNS0wNi0wMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgorCiAgICAgICAgIFtjbWFrZV0gU3VwcHJlc3MgdW51c2VkIHBhcmFtZXRl ciB3YXJuaW5ncyBpbiBXZWJLaXQyIGFuZCBUZXN0TmV0c2NhcGVQbHVnSW4KICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTI2NAogCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3N2bi1hcHBseSBiL1Rvb2xzL1NjcmlwdHMvc3ZuLWFwcGx5CmluZGV4 IGQ2MmY0NDYyYzc3NTIyNTNlMWI2OWZlZWIwZmFmYTFmM2EwMzFjNTQuLjQ0OTNkMTI2NDJhZTVk Y2Y3MzMzMjQ0YTk5YmRmODYxMGI4NTI3YjUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvc3Zu LWFwcGx5CisrKyBiL1Rvb2xzL1NjcmlwdHMvc3ZuLWFwcGx5CkBAIC0xMjMsNiArMTIzLDcgQEAg bXkgJWNoZWNrZWREaXJlY3RvcmllczsKIG15IEBkaWZmSGFzaFJlZnMgPSBwYXJzZVBhdGNoKCpB UkdWKTsKIAogcHJpbnQgIlBhcnNlZCAiIC4gQGRpZmZIYXNoUmVmcyAuICIgZGlmZnMgZnJvbSBw YXRjaCBmaWxlKHMpLlxuIjsKK2RpZSAiTm8gZGlmZiBmb3VuZC4iIHVubGVzcyBAZGlmZkhhc2hS ZWZzOwogCiBteSAkcHJlcGFyZWRQYXRjaEhhc2ggPSBwcmVwYXJlUGFyc2VkUGF0Y2goJGZvcmNl LCBAZGlmZkhhc2hSZWZzKTsKIAo=