145294 2015-05-21 20:28:40 -0700 Web Inspector: Unable to get cursor in new Rule section after creating multiple New Rules 2015-05-22 13:32:02 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1096768 0 joepeck 2015-05-21 20:28:40 -0700 * SUMMARY Unable to get cursor in new Rule section after creating multiple New Rules. * STEPS TO REPRODUCE 1. Inspect <body> on about:blank 2. Show Styles Rules sidebar 3. Click "New Rule" => creates a new "body" section with cursor in editor 4. Click "New Rule" again => cannot focus the textfield in either new section 1096769 1 webkit-bug-importer 2015-05-21 20:29:21 -0700 <rdar://problem/21070246> 1096770 2 joepeck 2015-05-21 20:32:24 -0700 It appears as if the sections are "readOnly". Because they are getting the readonly placeholder string and not the editable placeholder string. 1096774 3 joepeck 2015-05-21 20:58:25 -0700 CSSStyleDeclarationTextEditor's _resetContent sets things readonly if: // Only allow editing if we have a style, it is editable and we have text range in the stylesheet. var readOnly = !this._style || !this._style.editable || !this._style.styleSheetTextRange; In this case, the styleSheetTextRange is null... 1096777 4 joepeck 2015-05-21 21:30:24 -0700 I have a feeling this happened with the InspectorStyleSheet::styleSheetMutated changes. I'm going to try allowing InspectorStyleSheet parsed data always for the inspector style sheet, since we control modifications to it. Building now. 1096916 5 253599 joepeck 2015-05-22 12:11:09 -0700 Created attachment 253599 [PATCH] Proposed Fix 1096937 6 253599 commit-queue 2015-05-22 13:31:58 -0700 Comment on attachment 253599 [PATCH] Proposed Fix Clearing flags on attachment: 253599 Committed r184792: <http://trac.webkit.org/changeset/184792> 1096938 7 commit-queue 2015-05-22 13:32:02 -0700 All reviewed patches have been landed. Closing bug. 253599 2015-05-22 12:11:09 -0700 2015-05-22 13:31:58 -0700 [PATCH] Proposed Fix inspector-styles.patch text/plain 1458 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYWExMTE2Li44OWQyYmNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTUtMDUtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBVbmFibGUgdG8gZ2V0IGN1cnNvciBpbiBuZXcgUnVsZSBz ZWN0aW9uIGFmdGVyIGNyZWF0aW5nIG11bHRpcGxlIE5ldyBSdWxlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1Mjk0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3R5 bGVTaGVldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTdHlsZVNoZWV0OjplbnN1 cmVQYXJzZWREYXRhUmVhZHkpOgorICAgICAgICBBbGxvdyBzdHlsZXNoZWV0cyB3aXRoIG11dGF0 aW9ucyBmb3IgdGhlIGluc3BlY3RvciBzdHlsZXNoZWV0CisgICAgICAgIHdoaWNoIHdlIGNvbnRy b2wgbXV0YXRpb25zIG9mLgorCiAyMDE1LTA1LTIxICBKYWtlIE5pZWxzZW4gIDxqYWNvYl9uaWVs c2VuQGFwcGxlLmNvbT4KIAogICAgICAgICByMTg0NzE4IGFuZCByMTg0NzI1IGNhdXNlZCBmb3Vy IHRlc3RzIHRvIGJlZ2luIGNyYXNoaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKaW5kZXggY2JmMGJhYi4uYjQ3YzY1NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcApAQCAtMTA3 Nyw3ICsxMDc3LDggQEAgYm9vbCBJbnNwZWN0b3JTdHlsZVNoZWV0OjpzdHlsZVNoZWV0TXV0YXRl ZCgpIGNvbnN0CiAKIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6ZW5zdXJlUGFyc2VkRGF0YVJl YWR5KCkKIHsKLSAgICByZXR1cm4gIXN0eWxlU2hlZXRNdXRhdGVkKCkgJiYgZW5zdXJlVGV4dCgp ICYmIGVuc3VyZVNvdXJjZURhdGEoKTsKKyAgICBib29sIGFsbG93UGFyc2VkRGF0YSA9IG1fb3Jp Z2luID09IEluc3BlY3Rvcjo6UHJvdG9jb2w6OkNTUzo6U3R5bGVTaGVldE9yaWdpbjo6SW5zcGVj dG9yIHx8ICFzdHlsZVNoZWV0TXV0YXRlZCgpOworICAgIHJldHVybiBhbGxvd1BhcnNlZERhdGEg JiYgZW5zdXJlVGV4dCgpICYmIGVuc3VyZVNvdXJjZURhdGEoKTsKIH0KIAogYm9vbCBJbnNwZWN0 b3JTdHlsZVNoZWV0OjplbnN1cmVUZXh0KCkgY29uc3QK