145290 2015-05-21 18:45:23 -0700 CPS rethreading should really get rid of GetLocals 2015-05-21 23:33:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin commit-queue ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1096746 0 fpizlo 2015-05-21 18:45:23 -0700 This is benign right now because CSE gets rid of redundant GetLocals already. But, the idea is that CSE should not be mandatory. CPS rethreading should do it right. 1096747 1 253572 fpizlo 2015-05-21 18:49:38 -0700 Created attachment 253572 the patch 1096749 2 commit-queue 2015-05-21 18:52:09 -0700 Attachment 253572 did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1055: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1096794 3 fpizlo 2015-05-21 23:33:03 -0700 Landed in http://trac.webkit.org/changeset/184755 253572 2015-05-21 18:49:38 -0700 2015-05-21 21:44:01 -0700 the patch blah.patch text/plain 4880 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0NzQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE1LTA1LTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q1BTIHJldGhyZWFkaW5nIHNob3VsZCByZWFsbHkgZ2V0IHJpZCBvZiBHZXRMb2NhbHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTI5MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQ1BTIHJl dGhyZWFkaW5nIGlzIGludGVuZGVkIHRvIGdldCByaWQgb2YgcmVkdW5kYW50IEdldExvY2Fscy4g Q1NFIGNhbiBhbHNvIGRvIGl0LCBidXQKKyAgICAgICAgdGhlIGlkZWEgaXMgdGhhdCB5b3Ugc2hv dWxkIGJlIGFibGUgdG8gZGlzYWJsZSBDU0UgYW5kIGV2ZXJ5dGhpbmcgd291bGQgc3RpbGwgd29y ay4gVGhpcworICAgICAgICBmaXhlcyBhIGJ1ZyBpbiBDUFMgcmV0aHJlYWRpbmcncyBHZXRMb2Nh bCBlbGltaW5hdGlvbjogd2Ugc2hvdWxkIGJlIGNhbGxpbmcgcmVwbGFjZVdpdGgKKyAgICAgICAg cmF0aGVyIHRoYW4gc2V0UmVwbGFjZW1lbnQsIHNpbmNlIHNldFJlcGxhY2VtZW50IHN0aWxsIGxl YXZlcyB0aGUgb3JpZ2luYWwgbm9kZS4KKworICAgICAgICAqIGRmZy9ERkdDUFNSZXRocmVhZGlu Z1BoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpDUFNSZXRocmVhZGluZ1BoYXNlOjpjYW5v bmljYWxpemVHZXRMb2NhbEZvcik6IEZpeCB0aGUgYnVnLgorICAgICAgICAqIGRmZy9ERkdGaXh1 cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBoYXNlOjpmaXh1cE5vZGUpOiBF bGltaW5hdGluZyBHZXRMb2NhbHMgbWVhbnMgdGhhdCB0aGV5IHR1cm4gaW50byBDaGVjay4gV2Ug c2hvdWxkIGhhbmRsZSBDaGVja3MgdGhhdCBoYXZlIHplcm8gaW5wdXRzLgorICAgICAgICAqIGRm Zy9ERkdWYWxpZGF0ZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6VmFsaWRhdGU6OnZhbGlkYXRl Q1BTKTogQWRkIGEgdmFsaWRhdGlvbiBmb3Igd2hhdCBhIEdldExvY2FsIHNob3VsZCBsb29rIGxp a2UgaW4gVGhyZWFkZWRDUFMuCisgICAgICAgICogdGVzdHMvc3RyZXNzL2dldC1sb2NhbC1lbGlt aW5hdGlvbi5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorCiAyMDE1LTA1LTIxICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KIAogICAgICAgICBNU1ZDIGludGVybmFsIGNv bXBpbGVyIGVycm9yIHdoZW4gY29tcGlsaW5nIFRlbXBsYXRlUmVnaXN0cnlLZXkgY2xhc3MuCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NQU1JldGhyZWFkaW5nUGhhc2UuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ1BTUmV0aHJlYWRp bmdQaGFzZS5jcHAJKHJldmlzaW9uIDE4NDczMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQ1BTUmV0aHJlYWRpbmdQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4OSwxMiAr MTg5LDEyIEBAIHByaXZhdGU6CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGlmIChvdGhlck5v ZGUtPm9wKCkgPT0gR2V0TG9jYWwpIHsKICAgICAgICAgICAgICAgICAvLyBSZXBsYWNlIGFsbCBy ZWZlcmVuY2VzIHRvIHRoaXMgR2V0TG9jYWwgd2l0aCBvdGhlck5vZGUuCi0gICAgICAgICAgICAg ICAgbm9kZS0+c2V0UmVwbGFjZW1lbnQob3RoZXJOb2RlKTsKKyAgICAgICAgICAgICAgICBub2Rl LT5yZXBsYWNlV2l0aChvdGhlck5vZGUpOwogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgICAgIH0KICAgICAgICAgICAgIAogICAgICAgICAgICAgQVNTRVJUKG90aGVyTm9kZS0+b3Ao KSA9PSBTZXRMb2NhbCk7Ci0gICAgICAgICAgICBub2RlLT5zZXRSZXBsYWNlbWVudChvdGhlck5v ZGUtPmNoaWxkMSgpLm5vZGUoKSk7CisgICAgICAgICAgICBub2RlLT5yZXBsYWNlV2l0aChvdGhl ck5vZGUtPmNoaWxkMSgpLm5vZGUoKSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K ICAgICAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFz ZS5jcHAJKHJldmlzaW9uIDE4NDczMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Rml4dXBQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNTAsMTUgKzEwNTAsMTkgQEAgcHJp dmF0ZToKICAgICAgICAgfQogCiAgICAgICAgIGNhc2UgQ2hlY2s6IHsKLSAgICAgICAgICAgIHN3 aXRjaCAobm9kZS0+Y2hpbGQxKCkudXNlS2luZCgpKSB7Ci0gICAgICAgICAgICBjYXNlIE51bWJl clVzZToKLSAgICAgICAgICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCktPnNob3VsZFNwZWN1bGF0 ZUludDMyRm9yQXJpdGhtZXRpYygpKQotICAgICAgICAgICAgICAgICAgICBub2RlLT5jaGlsZDEo KS5zZXRVc2VLaW5kKEludDMyVXNlKTsKLSAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAg ICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICB9Ci0gICAg ICAgICAgICBvYnNlcnZlVXNlS2luZE9uRWRnZShub2RlLT5jaGlsZDEoKSk7CisgICAgICAgICAg ICBtX2dyYXBoLmRvVG9DaGlsZHJlbigKKyAgICAgICAgICAgICAgICBub2RlLAorICAgICAgICAg ICAgICAgIFsmXSAoRWRnZSYgZWRnZSkgeworICAgICAgICAgICAgICAgICAgICBzd2l0Y2ggKGVk Z2UudXNlS2luZCgpKSB7CisgICAgICAgICAgICAgICAgICAgIGNhc2UgTnVtYmVyVXNlOgorICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKGVkZ2UtPnNob3VsZFNwZWN1bGF0ZUludDMyRm9yQXJp dGhtZXRpYygpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVkZ2Uuc2V0VXNlS2luZChJ bnQzMlVzZSk7CisgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAg ICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAg ICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgICAgIG9ic2VydmVVc2VLaW5kT25FZGdlKGVk Z2UpOworICAgICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K IApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdWYWxpZGF0ZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdWYWxpZGF0ZS5jcHAJKHJldmlz aW9uIDE4NDczMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHVmFsaWRhdGUuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00NTIsOCArNDUyLDEwIEBAIHByaXZhdGU6CiAgICAgICAgICAg ICAgICAgICAgIC8vIGRvZXNuJ3QgeWV0IGtub3cgdG8gYmUgZGVhZC4KICAgICAgICAgICAgICAg ICAgICAgaWYgKCFtX215UmVmQ291bnRzLmdldChub2RlKSkKICAgICAgICAgICAgICAgICAgICAg ICAgIGJyZWFrOwotICAgICAgICAgICAgICAgICAgICBpZiAobV9ncmFwaC5tX2Zvcm0gPT0gVGhy ZWFkZWRDUFMpCisgICAgICAgICAgICAgICAgICAgIGlmIChtX2dyYXBoLm1fZm9ybSA9PSBUaHJl YWRlZENQUykgewogICAgICAgICAgICAgICAgICAgICAgICAgVkFMSURBVEUoKG5vZGUsIGJsb2Nr KSwgZ2V0TG9jYWxQb3NpdGlvbnMub3BlcmFuZChub2RlLT5sb2NhbCgpKSA9PSBub3RTZXQpOwor ICAgICAgICAgICAgICAgICAgICAgICAgVkFMSURBVEUoKG5vZGUsIGJsb2NrKSwgISFub2RlLT5j aGlsZDEoKSk7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgZ2V0 TG9jYWxQb3NpdGlvbnMub3BlcmFuZChub2RlLT5sb2NhbCgpKSA9IGk7CiAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIGNhc2UgU2V0TG9jYWw6CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2dldC1sb2NhbC1lbGltaW5hdGlvbi5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2dldC1sb2Nh bC1lbGltaW5hdGlvbi5qcwkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90 ZXN0cy9zdHJlc3MvZ2V0LWxvY2FsLWVsaW1pbmF0aW9uLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMTUgQEAKK3ZhciBUcnVlID0gdHJ1ZTsKKworZnVuY3Rpb24gZm9vKGEpIHsKKyAgICB2 YXIgeCA9IGE7CisgICAgaWYgKFRydWUpCisgICAgICAgIHJldHVybiBhICsgeDsKK30KKworbm9J bmxpbmUoZm9vKTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDsgKytpKSB7CisgICAgdmFy IHJlc3VsdCA9IGZvbyg0Mik7CisgICAgaWYgKHJlc3VsdCAhPSA4NCkKKyAgICAgICAgdGhyb3cg IkVycm9yOiBiYWQgcmVzdWx0OiAiICsgcmVzdWx0OworfQo=