145286 2015-05-21 17:01:20 -0700 [iOS] Crash when taking a snapshot of a large PDF 2015-05-21 17:31:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica thorton oldest_to_newest 1096701 0 enrica 2015-05-21 17:01:20 -0700 Safari crashes when opening a large PDF in the snapshot code. rdar://problem/20892362 1096704 1 253555 enrica 2015-05-21 17:06:06 -0700 Created attachment 253555 Patch 1096711 2 253555 thorton 2015-05-21 17:21:32 -0700 Comment on attachment 253555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253555&action=review > Source/WebKit2/ChangeLog:11 > + an image context when we are not. Maybe a note here about the giant allocations too? 1096717 3 enrica 2015-05-21 17:31:27 -0700 Committed revision 184739. 253555 2015-05-21 17:06:06 -0700 2015-05-21 17:21:32 -0700 Patch snapshotcrash.txt text/plain 5185 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDczNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA1LTIxICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQ3Jhc2ggd2hlbiB0 YWtpbmcgYSBzbmFwc2hvdCBvZiBhIGxhcmdlIFBERi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTI4NgorICAgICAgICByZGFyOi8vcHJvYmxlbS8y MDg5MjM2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoZSBjb2RlIGZvciB0aGUgUERGIGNhc2Ugd2FzIGluY29ycmVjdCBhbmQgbm8gbG9uZ2VyIG5l ZWRlZC4KKyAgICAgICAgV2UgYXJlIG5vdyBhbHdheXMgdXNpbmcgdGhlIElPU3VyZmFjZSBpZiB3 ZSBhcmUgcGFyZW50ZWQgb3IKKyAgICAgICAgYW4gaW1hZ2UgY29udGV4dCB3aGVuIHdlIGFyZSBu b3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAg ICAgKC1bV0tXZWJWaWV3IF9zbmFwc2hvdFJlY3Q6aW50b0ltYWdlT2ZXaWR0aDpjb21wbGV0aW9u SGFuZGxlcjpdKToKKwogMjAxNS0wNS0yMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIFdLV2Vic2l0ZURhdGFTdG9yZSBkb2Vzbid0IHRyYWNrIGFuZCBy ZW1vdmUgaU9TIFNhZmFyaSdzIG9mZmxpbmUgYXBwbGljYXRpb24gY2FjaGUgZW50cmllcwpJbmRl eDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0J KHJldmlzaW9uIDE4NDczNikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNzE4LDYgKzI3MTgsMjAgQEAgLSAodm9p ZClfc25hcHNob3RSZWN0OihDR1JlY3QpcmVjdEluVmlldwogICAgIENHRmxvYXQgaW1hZ2VIZWln aHQgPSBpbWFnZVNjYWxlICogc25hcHNob3RSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMuc2l6ZS5o ZWlnaHQ7CiAgICAgQ0dTaXplIGltYWdlU2l6ZSA9IENHU2l6ZU1ha2UoaW1hZ2VXaWR0aCwgaW1h Z2VIZWlnaHQpOwogCisjaWYgVVNFKElPU1VSRkFDRSkKKyAgICAvLyBJZiB3ZSBhcmUgcGFyZW50 ZWQgYW5kIHRodXMgd29uJ3QgaW5jdXIgYSBzaWduaWZpY2FudCBwZW5hbHR5IGZyb20gcGFnaW5n IGluIHRpbGVzLCBzbmFwc2hvdCB0aGUgdmlldyBoaWVyYXJjaHkgZGlyZWN0bHkuCisgICAgaWYg KHNlbGYud2luZG93KSB7CisgICAgICAgIGF1dG8gc3VyZmFjZSA9IFdlYkNvcmU6OklPU3VyZmFj ZTo6Y3JlYXRlKFdlYkNvcmU6OmV4cGFuZGVkSW50U2l6ZShXZWJDb3JlOjpGbG9hdFNpemUoaW1h Z2VTaXplKSksIFdlYkNvcmU6OkNvbG9yU3BhY2VEZXZpY2VSR0IpOworICAgICAgICBDR0Zsb2F0 IGltYWdlU2NhbGVJblZpZXdDb29yZGluYXRlcyA9IGltYWdlV2lkdGggLyByZWN0SW5WaWV3Q29v cmRpbmF0ZXMuc2l6ZS53aWR0aDsKKyAgICAgICAgQ0FUcmFuc2Zvcm0zRCB0cmFuc2Zvcm0gPSBD QVRyYW5zZm9ybTNETWFrZVNjYWxlKGltYWdlU2NhbGVJblZpZXdDb29yZGluYXRlcywgaW1hZ2VT Y2FsZUluVmlld0Nvb3JkaW5hdGVzLCAxKTsKKyAgICAgICAgdHJhbnNmb3JtID0gQ0FUcmFuc2Zv cm0zRFRyYW5zbGF0ZSh0cmFuc2Zvcm0sIC1yZWN0SW5WaWV3Q29vcmRpbmF0ZXMub3JpZ2luLngs IC1yZWN0SW5WaWV3Q29vcmRpbmF0ZXMub3JpZ2luLnksIDApOworICAgICAgICBDQVJlbmRlclNl cnZlclJlbmRlckxheWVyV2l0aFRyYW5zZm9ybShNQUNIX1BPUlRfTlVMTCwgc2VsZi5sYXllci5j b250ZXh0LmNvbnRleHRJZCwgcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdD4oc2VsZi5sYXllciks IHN1cmZhY2UtPnN1cmZhY2UoKSwgMCwgMCwgJnRyYW5zZm9ybSk7CisgICAgICAgIGNvbXBsZXRp b25IYW5kbGVyKHN1cmZhY2UtPmNyZWF0ZUltYWdlKCkuZ2V0KCkpOworCisgICAgICAgIHJldHVy bjsKKyAgICB9CisjZW5kaWYKKyAgICAKICAgICBpZiAoX2N1c3RvbUNvbnRlbnRWaWV3KSB7CiAg ICAgICAgIFVJR3JhcGhpY3NCZWdpbkltYWdlQ29udGV4dFdpdGhPcHRpb25zKGltYWdlU2l6ZSwg WUVTLCAxKTsKIApAQCAtMjcyNSwyMCArMjczOSwxMCBAQCAtICh2b2lkKV9zbmFwc2hvdFJlY3Q6 KENHUmVjdClyZWN0SW5WaWV3CiAgICAgICAgIFtjdXN0b21Db250ZW50Vmlldy5iYWNrZ3JvdW5k Q29sb3Igc2V0XTsKICAgICAgICAgVUlSZWN0RmlsbChDR1JlY3RNYWtlKDAsIDAsIGltYWdlV2lk dGgsIGltYWdlSGVpZ2h0KSk7CiAKLSAgICAgICAgQ0dSZWN0IGRlc3RpbmF0aW9uUmVjdCA9IGN1 c3RvbUNvbnRlbnRWaWV3LmJvdW5kczsKLSAgICAgICAgZGVzdGluYXRpb25SZWN0Lm9yaWdpbi54 ID0gLXNuYXBzaG90UmVjdEluQ29udGVudENvb3JkaW5hdGVzLm9yaWdpbi54ICogaW1hZ2VTY2Fs ZTsKLSAgICAgICAgZGVzdGluYXRpb25SZWN0Lm9yaWdpbi55ID0gLXNuYXBzaG90UmVjdEluQ29u dGVudENvb3JkaW5hdGVzLm9yaWdpbi55ICogaW1hZ2VTY2FsZTsKLSAgICAgICAgZGVzdGluYXRp b25SZWN0LnNpemUud2lkdGggKj0gaW1hZ2VTY2FsZTsKLSAgICAgICAgZGVzdGluYXRpb25SZWN0 LnNpemUuaGVpZ2h0ICo9IGltYWdlU2NhbGU7Ci0KLSAgICAgICAgaWYgKFtfY3VzdG9tQ29udGVu dFZpZXcgd2luZG93XSkKLSAgICAgICAgICAgIFtjdXN0b21Db250ZW50VmlldyBkcmF3Vmlld0hp ZXJhcmNoeUluUmVjdDpkZXN0aW5hdGlvblJlY3QgYWZ0ZXJTY3JlZW5VcGRhdGVzOk5PXTsKLSAg ICAgICAgZWxzZSB7Ci0gICAgICAgICAgICBDR0NvbnRleHRSZWYgY29udGV4dCA9IFVJR3JhcGhp Y3NHZXRDdXJyZW50Q29udGV4dCgpOwotICAgICAgICAgICAgQ0dDb250ZXh0VHJhbnNsYXRlQ1RN KGNvbnRleHQsIGRlc3RpbmF0aW9uUmVjdC5vcmlnaW4ueCwgZGVzdGluYXRpb25SZWN0Lm9yaWdp bi55KTsKLSAgICAgICAgICAgIENHQ29udGV4dFNjYWxlQ1RNKGNvbnRleHQsIGltYWdlU2NhbGUs IGltYWdlU2NhbGUpOwotICAgICAgICAgICAgW2N1c3RvbUNvbnRlbnRWaWV3LmxheWVyIHJlbmRl ckluQ29udGV4dDpjb250ZXh0XTsKLSAgICAgICAgfQorICAgICAgICBDR0NvbnRleHRSZWYgY29u dGV4dCA9IFVJR3JhcGhpY3NHZXRDdXJyZW50Q29udGV4dCgpOworICAgICAgICBDR0NvbnRleHRU cmFuc2xhdGVDVE0oY29udGV4dCwgLXNuYXBzaG90UmVjdEluQ29udGVudENvb3JkaW5hdGVzLm9y aWdpbi54ICogaW1hZ2VTY2FsZSwgLXNuYXBzaG90UmVjdEluQ29udGVudENvb3JkaW5hdGVzLm9y aWdpbi55ICogaW1hZ2VTY2FsZSk7CisgICAgICAgIENHQ29udGV4dFNjYWxlQ1RNKGNvbnRleHQs IGltYWdlU2NhbGUsIGltYWdlU2NhbGUpOworICAgICAgICBbY3VzdG9tQ29udGVudFZpZXcubGF5 ZXIgcmVuZGVySW5Db250ZXh0OmNvbnRleHRdOwogCiAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVy KFtVSUdyYXBoaWNzR2V0SW1hZ2VGcm9tQ3VycmVudEltYWdlQ29udGV4dCgpIENHSW1hZ2VdKTsK IApAQCAtMjc0NiwxOSArMjc1MCw2IEBAIC0gKHZvaWQpX3NuYXBzaG90UmVjdDooQ0dSZWN0KXJl Y3RJblZpZXcKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotI2lmIFVTRShJT1NVUkZBQ0UpCi0g ICAgLy8gSWYgd2UgYXJlIHBhcmVudGVkIGFuZCB0aHVzIHdvbid0IGluY3VyIGEgc2lnbmlmaWNh bnQgcGVuYWx0eSBmcm9tIHBhZ2luZyBpbiB0aWxlcywgc25hcHNob3QgdGhlIHZpZXcgaGllcmFy Y2h5IGRpcmVjdGx5LgotICAgIGlmIChzZWxmLndpbmRvdykgewotICAgICAgICBhdXRvIHN1cmZh Y2UgPSBXZWJDb3JlOjpJT1N1cmZhY2U6OmNyZWF0ZShXZWJDb3JlOjpleHBhbmRlZEludFNpemUo V2ViQ29yZTo6RmxvYXRTaXplKGltYWdlU2l6ZSkpLCBXZWJDb3JlOjpDb2xvclNwYWNlRGV2aWNl UkdCKTsKLSAgICAgICAgQ0dGbG9hdCBpbWFnZVNjYWxlSW5WaWV3Q29vcmRpbmF0ZXMgPSBpbWFn ZVdpZHRoIC8gcmVjdEluVmlld0Nvb3JkaW5hdGVzLnNpemUud2lkdGg7Ci0gICAgICAgIENBVHJh bnNmb3JtM0QgdHJhbnNmb3JtID0gQ0FUcmFuc2Zvcm0zRE1ha2VTY2FsZShpbWFnZVNjYWxlSW5W aWV3Q29vcmRpbmF0ZXMsIGltYWdlU2NhbGVJblZpZXdDb29yZGluYXRlcywgMSk7Ci0gICAgICAg IHRyYW5zZm9ybSA9IENBVHJhbnNmb3JtM0RUcmFuc2xhdGUodHJhbnNmb3JtLCAtcmVjdEluVmll d0Nvb3JkaW5hdGVzLm9yaWdpbi54LCAtcmVjdEluVmlld0Nvb3JkaW5hdGVzLm9yaWdpbi55LCAw KTsKLSAgICAgICAgQ0FSZW5kZXJTZXJ2ZXJSZW5kZXJMYXllcldpdGhUcmFuc2Zvcm0oTUFDSF9Q T1JUX05VTEwsIHNlbGYubGF5ZXIuY29udGV4dC5jb250ZXh0SWQsIHJlaW50ZXJwcmV0X2Nhc3Q8 dWludDY0X3Q+KHNlbGYubGF5ZXIpLCBzdXJmYWNlLT5zdXJmYWNlKCksIDAsIDAsICZ0cmFuc2Zv cm0pOwotICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihzdXJmYWNlLT5jcmVhdGVJbWFnZSgpLmdl dCgpKTsKLQotICAgICAgICByZXR1cm47Ci0gICAgfQotI2VuZGlmCiAKICAgICB2b2lkKF5jb3Bp ZWRDb21wbGV0aW9uSGFuZGxlcikoQ0dJbWFnZVJlZikgPSBbY29tcGxldGlvbkhhbmRsZXIgY29w eV07CiAgICAgX3BhZ2UtPnRha2VTbmFwc2hvdChXZWJDb3JlOjplbmNsb3NpbmdJbnRSZWN0KHNu YXBzaG90UmVjdEluQ29udGVudENvb3JkaW5hdGVzKSwgV2ViQ29yZTo6ZXhwYW5kZWRJbnRTaXpl KFdlYkNvcmU6OkZsb2F0U2l6ZShpbWFnZVNpemUpKSwgV2ViS2l0OjpTbmFwc2hvdE9wdGlvbnNF eGNsdWRlRGV2aWNlU2NhbGVGYWN0b3IsIFs9XShjb25zdCBXZWJLaXQ6OlNoYXJlYWJsZUJpdG1h cDo6SGFuZGxlJiBpbWFnZUhhbmRsZSwgV2ViS2l0OjpDYWxsYmFja0Jhc2U6OkVycm9yKSB7Cg==