145273 2015-05-21 10:42:30 -0700 AX: Figure out why list-detection2.html test fails on GTK 2015-05-22 16:44:36 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach jdiggs aboxhall apinheiro chavarria1991 commit-queue dmazzoni jake.nielsen.webkit jcraig jdiggs mario mattbaker samuel_white webkit-bug-importer oldest_to_newest 1096613 0 cfleizach 2015-05-21 10:42:30 -0700 It looks like list-detection2.html fails on GTK I'm adding a failure entry to TestExpectations, but someone should check this out and figure out what we need here to make it work 1096615 1 webkit-bug-importer 2015-05-21 10:42:54 -0700 <rdar://problem/21059377> 1096632 2 jdiggs 2015-05-21 11:10:15 -0700 Probably due to AccessibilityUIElement::computedRoleString() not being implemented in ATK. I'll do that this evening or tomorrow. 1096753 3 jdiggs 2015-05-21 19:05:40 -0700 *** Bug 145255 has been marked as a duplicate of this bug. *** 1096755 4 jdiggs 2015-05-21 19:24:46 -0700 In addition to implementing computedRoleString() it looks like there's an issue with some pseudo elements: FAIL: ul w/ bullet content on ::before -> group. Expected: list. FAIL: ul w/ bullet content on inline ::before -> group. Expected: list. FAIL: ol w/ counter content on ::before -> group. Expected: list. FAIL: ol w/ counter content on inline ::before -> group. Expected: list. 1096760 5 jdiggs 2015-05-21 19:52:20 -0700 Ugh, there's additional problems with the heuristics. In the non-list cases, the list gets mapped to a more generic (but incorrect for my platform) role. They should be ATK_ROLE_SECTION; not ATK_ROLE_PANEL. But even worse, the list items still have role list item. 1096801 6 253581 jdiggs 2015-05-22 00:01:53 -0700 Created attachment 253581 Patch 1096805 7 jdiggs 2015-05-22 00:26:20 -0700 (In reply to comment #5) > Ugh, there's additional problems with the heuristics. In the non-list cases, > the list gets mapped to a more generic (but incorrect for my platform) role. > They should be ATK_ROLE_SECTION; not ATK_ROLE_PANEL. But even worse, the > list items still have role list item. Opened bug 145300 for the above. 1096812 8 253581 commit-queue 2015-05-22 01:03:45 -0700 Comment on attachment 253581 Patch Clearing flags on attachment: 253581 Committed r184765: <http://trac.webkit.org/changeset/184765> 1096813 9 commit-queue 2015-05-22 01:03:52 -0700 All reviewed patches have been landed. Closing bug. 1096964 10 ap 2015-05-22 14:53:17 -0700 This change made accessibility/list-detection2.html crash on Windows. 1096970 11 jdiggs 2015-05-22 15:15:49 -0700 (In reply to comment #10) > This change made accessibility/list-detection2.html crash on Windows. You have a backtrace? When I look at https://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r184783%20(66325)/accessibility/list-detection2-crash-log.txt I see No crash log found for DumpRenderTree:3340. 1096971 12 jdiggs 2015-05-22 15:35:30 -0700 Reopening to deal with the crash on Win. 1096976 13 253612 jdiggs 2015-05-22 15:40:39 -0700 Created attachment 253612 Patch 1096977 14 253612 jdiggs 2015-05-22 15:42:59 -0700 Comment on attachment 253612 Patch Chris: Since your platform didn't need this check and since it crashes on Windows, I've added platform checks so I can fix the crash now. (It's Friday, holiday weekend, etc. ;)) Alexey: If you can get me a backtrace and open a new bug, I'll add it to my list of things to look into. 1096996 15 253612 commit-queue 2015-05-22 16:44:30 -0700 Comment on attachment 253612 Patch Clearing flags on attachment: 253612 Committed r184801: <http://trac.webkit.org/changeset/184801> 1096997 16 commit-queue 2015-05-22 16:44:36 -0700 All reviewed patches have been landed. Closing bug. 253581 2015-05-22 00:01:53 -0700 2015-05-22 15:41:06 -0700 Patch bug-145273-20150522030147.patch text/plain 3576 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmRhYmMwNWMwOGIzYjAy Y2MwNWM3MmU0OWExMjM4NzhmNGExYmE0My4uOTQxN2Y5ZmNjZThlOWU4NzBjMjBmODI0MjJjMjQ1 NzBiZGExZGRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTA1LTIxICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBBWDogRmlndXJlIG91 dCB3aHkgbGlzdC1kZXRlY3Rpb24yLmh0bWwgdGVzdCBmYWlscyBvbiBHVEsKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTI3MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBsYXRmb3JtcyB3aGljaCBleHBv c2UgcmVuZGVyZWQgdGV4dCBjb250ZW50IHRocm91Z2ggdGhlIHBhcmVudCBlbGVtZW50ICJpZ25v cmUiIHRoZQorICAgICAgICBjaGlsZCByZW5kZXJlcnMuIFRoaXMgd2FzIGNhdXNpbmcgQWNjZXNz aWJpbGl0eUxpc3Q6OmNoaWxkSGFzUHNldWRvVmlzaWJsZUxpc3RJdGVtTWFya2VyCisgICAgICAg IHRvIGZhaWwsIHdoaWNoIGluIHR1cm4gY2F1c2VkIHRoZSBsaXN0IGRldGVjdGlvbiBoZXVyaXN0 aWMgdG8gZmFpbC4gVGhlcmVmb3JlIGFkZCBvbmUKKyAgICAgICAgZmluYWwgY2hlY2sgdG8gdGhp cyBtZXRob2QgdG8gbG9vayBmb3Igbm9uLWVtcHR5LCBub24td2hpdGVzcGFjZSB0ZXh0IHVuZGVy IHRoZSA6OmJlZm9yZQorICAgICAgICBwc2V1ZG8gZWxlbWVudC4KKworICAgICAgICBObyBuZXcg dGVzdHM7IGxpc3QtZGV0ZWN0aW9uMi5odG1sIG5vdyBwYXNzZXMgb24gR1RLLgorCisgICAgICAg ICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBY2Nlc3NpYmlsaXR5TGlzdDo6Y2hpbGRIYXNQc2V1ZG9WaXNpYmxlTGlzdEl0ZW1NYXJrZXJz KToKKworMjAxNS0wNS0yMSAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CisK ICAgICAgICAgQVg6IFtHVEtdIEltcGxlbWVudCBjb21wdXRlZFJvbGVTdHJpbmcgaW4gQWNjZXNz aWJpbGl0eVVJRWxlbWVudAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI4NDIwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eUxpc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5TGlzdC5jcHAKaW5kZXggMmFhNTQ2OTY5NWE2MTMxNzA3Y2VkNWJjZTYxNWQz NzE1NjgxYjIzMi4uOTA0ZTFkMzFlYjk5ZjcyM2UxMjMwYmFjOTE2YWViY2Y1ZWRmYmJlMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5j cHAKQEAgLTExNyw3ICsxMTcsMTAgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5TGlzdDo6Y2hpbGRIYXNQ c2V1ZG9WaXNpYmxlTGlzdEl0ZW1NYXJrZXJzKFJlbmRlck9iamVjdCogbGlzdEkKICAgICAgICAg ICAgIHJldHVybiB0cnVlOwogICAgIH0KICAgICAKLSAgICByZXR1cm4gZmFsc2U7CisgICAgLy8g UGxhdGZvcm1zIHdoaWNoIGV4cG9zZSByZW5kZXJlZCB0ZXh0IGNvbnRlbnQgdGhyb3VnaCB0aGUg cGFyZW50IGVsZW1lbnQgd2lsbCB0cmVhdAorICAgIC8vIHRob3NlIHJlbmRlcmVycyBhcyAiaWdu b3JlZCIgb2JqZWN0cy4KKyAgICBTdHJpbmcgdGV4dCA9IGF4T2JqLT50ZXh0VW5kZXJFbGVtZW50 KCk7CisgICAgcmV0dXJuICF0ZXh0LmlzRW1wdHkoKSAmJiAhdGV4dC5jb250YWluc09ubHlXaGl0 ZXNwYWNlKCk7CiB9CiAgICAgCiBBY2Nlc3NpYmlsaXR5Um9sZSBBY2Nlc3NpYmlsaXR5TGlzdDo6 ZGV0ZXJtaW5lQWNjZXNzaWJpbGl0eVJvbGUoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDdjZTk0Yjk0YzE1YTkxNDJkZTI2 ZGEwNDYzOGQ1NGZhZGJjOGUwNGYuLmU1MGI0NmEwMjJjMGE1MGY1MzhjNWJmM2M3MTBjYzhhMGI3 N2MxNjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNS0wNS0yMSAgSm9hbm1hcmllIERpZ2dz ICA8amRpZ2dzQGlnYWxpYS5jb20+CiAKKyAgICAgICAgQVg6IEZpZ3VyZSBvdXQgd2h5IGxpc3Qt ZGV0ZWN0aW9uMi5odG1sIHRlc3QgZmFpbHMgb24gR1RLCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUyNzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z OiBSZW1vdmVkIGxpc3QtZGV0ZWN0aW9uMi5odG1sIGZyb20gdGhlIGxpc3Qgb2YgZXhwZWN0ZWQg ZmFpbHVyZXMuCisKKzIwMTUtMDUtMjEgIEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEu Y29tPgorCiAgICAgICAgIEFYOiBbR1RLXSBJbXBsZW1lbnQgY29tcHV0ZWRSb2xlU3RyaW5nIGlu IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyODQyMAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IGYyMjlmYTU0Y2E5MzJhNTkxMTZkZmUwNjYzYThlMzcyNmU1MjJkOTcu LmMwYzJkMDVhZmFhOWFiYzkzNTQyZGE2ZDg1NTFlYjA2NzU0ODIxMDMgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC00OTEsNyArNDkxLDYgQEAgd2Via2l0 Lm9yZy9iLzEzMzgwNiBzdmcvbWFza2luZy9tYXNrLXRyYW5zZm9ybWVkLXRleHQtbWlzc2luZy5z dmcgWyBJbWFnZU9ubHlGYWkKIEJ1ZyhHVEspIGNzczMvZmlsdGVycy9iYWNrZHJvcCBbIFNraXAg XQogCiB3ZWJraXQub3JnL2IvMTQxMDcyIGFjY2Vzc2liaWxpdHkvZnJhbWUtZGlzY29ubmVjdC10 ZXh0bWFya2VyLWNhY2hlLWNyYXNoLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNDUy NzMgYWNjZXNzaWJpbGl0eS9saXN0LWRldGVjdGlvbjIuaHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJr aXQub3JnL2IvMTQxNDIzIGNzczMvY2FsYy9saW5lLWhlaWdodC5odG1sIFsgRmFpbHVyZSBdCiB3 ZWJraXQub3JnL2IvMTQxNDIzIGVkaXRpbmcvcGFzdGVib2FyZC9zaW1wbGZpeWluZy1tYXJrdXAt c2hvdWxkLW5vdC1zdHJpcC1jb250ZW50Lmh0bWwgWyBGYWlsdXJlIF0K 253612 2015-05-22 15:40:39 -0700 2015-05-22 16:44:30 -0700 Patch bug-145273-20150522184032.patch text/plain 1967 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0Nzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVkOTk0MzU5MGYwNDhm ZTg2ODFjMjM0ODU4MmJkYzBhZTBhYjAxMS4uMzc1NjBhODJkYzM0N2U3NWVhZjBmZGViMjQ0M2Nh ODg1YTE5NWFkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA1LTIyICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogRmlndXJlIG91 dCB3aHkgbGlzdC1kZXRlY3Rpb24yLmh0bWwgdGVzdCBmYWlscyBvbiBHVEsKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTI3MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgY29uc2lkZXIgdGhlIHRl eHQgdW5kZXIgdGhlIHBzZXVkbyBlbGVtZW50IGZvciBHVEsgYW5kIEVGTC4KKyAgICAgICAgVGhl IG90aGVyIHBsYXRmb3JtcyBleHBvc2UgcmVuZGVyZWQgdGV4dCBjb250ZW50IHRocm91Z2ggdGhl aXIKKyAgICAgICAgb3duIGFjY2Vzc2libGUgb2JqZWN0cy4gVGhpcyB3aWxsIGZpeCB0aGUgY3Jh c2ggb24gV2luZG93cyB1bnRpbAorICAgICAgICBpdCBjYW4gYmUgbG9va2VkIGludG8gcHJvcGVy bHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHNob3VsZCBzdG9wIGxpc3QtZGV0ZWN0 aW9uMi5odG1sIHRvIHN0b3AgY3Jhc2hpbmcgb24gV2luZG93cy4KKworICAgICAgICAqIGFjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNz aWJpbGl0eUxpc3Q6OmNoaWxkSGFzUHNldWRvVmlzaWJsZUxpc3RJdGVtTWFya2Vycyk6CisKIDIw MTUtMDUtMjIgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAg ICAgICBbQ29jb2FdIFVzZSBDVEZvbnREcmF3R2x5cGhzKCkgaW5zdGVhZCBvZiBDR0NvbnRleHRT aG93R2x5cGhzV2l0aEFkdmFuY2VzKCkvQ0dDb250ZXh0U2hvd0dseXBoc0F0UG9zaXRpb25zKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxp c3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5j cHAKaW5kZXggOTA0ZTFkMzFlYjk5ZjcyM2UxMjMwYmFjOTE2YWViY2Y1ZWRmYmJlMS4uYzc4ZDM2 NDg2N2VlODRiNjZiYTg3YmJmM2I0OThlNTE4NmM5YjIxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5jcHAKQEAgLTExOSw4ICsxMTks MTIgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5TGlzdDo6Y2hpbGRIYXNQc2V1ZG9WaXNpYmxlTGlzdEl0 ZW1NYXJrZXJzKFJlbmRlck9iamVjdCogbGlzdEkKICAgICAKICAgICAvLyBQbGF0Zm9ybXMgd2hp Y2ggZXhwb3NlIHJlbmRlcmVkIHRleHQgY29udGVudCB0aHJvdWdoIHRoZSBwYXJlbnQgZWxlbWVu dCB3aWxsIHRyZWF0CiAgICAgLy8gdGhvc2UgcmVuZGVyZXJzIGFzICJpZ25vcmVkIiBvYmplY3Rz LgorI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oRUZMKQogICAgIFN0cmluZyB0ZXh0ID0g YXhPYmotPnRleHRVbmRlckVsZW1lbnQoKTsKICAgICByZXR1cm4gIXRleHQuaXNFbXB0eSgpICYm ICF0ZXh0LmNvbnRhaW5zT25seVdoaXRlc3BhY2UoKTsKKyNlbHNlCisgICAgcmV0dXJuIGZhbHNl OworI2VuZGlmCiB9CiAgICAgCiBBY2Nlc3NpYmlsaXR5Um9sZSBBY2Nlc3NpYmlsaXR5TGlzdDo6 ZGV0ZXJtaW5lQWNjZXNzaWJpbGl0eVJvbGUoKQo=