145270 2015-05-21 10:25:42 -0700 Regression(r179293): We no longer call destroyDecodedData() on CachedResources on memory pressure 2015-05-21 10:45:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 140964 1 cdumez cdumez barraclough kling koivisto oldest_to_newest 1096600 0 cdumez 2015-05-21 10:25:42 -0700 We no longer call destroyDecodedData() on CachedResources on memory pressure after r179293. In r179293, we started calling MemoryCache::evictResources() on memory pressure instead of MemoryCache::pruneToPercentage(0). However, unlike MemoryCache::pruneToPercentage(), it appears MemoryCache::evictResources() removes the CachedResources from the memory cache without calling destroyDecodedData() on them. This caused a regression on Membuster. Radar: <rdar://problem/20734901> 1096609 1 253530 cdumez 2015-05-21 10:39:39 -0700 Created attachment 253530 Patch 1096614 2 253530 kling 2015-05-21 10:42:38 -0700 Comment on attachment 253530 Patch Fantastic job hunting this down!! r=me 1096616 3 253530 cdumez 2015-05-21 10:45:29 -0700 Comment on attachment 253530 Patch Clearing flags on attachment: 253530 Committed r184720: <http://trac.webkit.org/changeset/184720> 1096617 4 cdumez 2015-05-21 10:45:34 -0700 All reviewed patches have been landed. Closing bug. 253530 2015-05-21 10:39:39 -0700 2015-05-21 10:45:29 -0700 Patch bug-145270-20150521103937.patch text/plain 2783 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWE5NDA0NTUyNmIxMTQ1 NDYyM2UzZTdhMGM3MDllMmQ4NDE3YjIzNi4uZjJjMjYxMmNjYTFkMDQxNGFlNDg1ZmNlODY1ZmJk OTU5ZDkwZTY4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE1LTA1LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMTc5Mjkz KTogV2Ugbm8gbG9uZ2VyIGNhbGwgZGVzdHJveURlY29kZWREYXRhKCkgb24gQ2FjaGVkUmVzb3Vy Y2VzIG9uIG1lbW9yeSBwcmVzc3VyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ1MjcwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDczNDkwMT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBubyBs b25nZXIgY2FsbCBkZXN0cm95RGVjb2RlZERhdGEoKSBvbiBDYWNoZWRSZXNvdXJjZXMgb24gbWVt b3J5CisgICAgICAgIHByZXNzdXJlIGFmdGVyIHIxNzkyOTMuIEluIHIxNzkyOTMsIHdlIHN0YXJ0 ZWQgY2FsbGluZworICAgICAgICBNZW1vcnlDYWNoZTo6ZXZpY3RSZXNvdXJjZXMoKSBvbiBtZW1v cnkgcHJlc3N1cmUgaW5zdGVhZCBvZgorICAgICAgICBNZW1vcnlDYWNoZTo6cHJ1bmVUb1BlcmNl bnRhZ2UoMCkuIEhvd2V2ZXIsIHVubGlrZQorICAgICAgICBNZW1vcnlDYWNoZTo6cHJ1bmVUb1Bl cmNlbnRhZ2UoKSwgaXQgYXBwZWFycworICAgICAgICBNZW1vcnlDYWNoZTo6ZXZpY3RSZXNvdXJj ZXMoKSByZW1vdmVzIHRoZSBDYWNoZWRSZXNvdXJjZXMgZnJvbSB0aGUKKyAgICAgICAgbWVtb3J5 IGNhY2hlIHdpdGhvdXQgY2FsbGluZyBkZXN0cm95RGVjb2RlZERhdGEoKSBvbiB0aGVtLgorICAg ICAgICBUaGlzIGNhdXNlZCBhIHJlZ3Jlc3Npb24gb24gTWVtYnVzdGVyLgorCisgICAgICAgIFRo aXMgcGF0Y2ggbm93IGNhbGxzIE1lbW9yeUNhY2hlOjpwcnVuZUxpdmVSZXNvdXJjZXNUb1NpemUo MCkgb24KKyAgICAgICAgY3JpdGljYWwgbWVtb3J5IHByZXNzdXJlLCBpbnN0ZWFkIG9mIGV2aWN0 UmVzb3VyY2VzKCkuIFdlIGRvbid0IG5lZWQgdG8KKyAgICAgICAgY2FsbCBwcnVuZURlYWRSZXNv dXJjZXNUb1NpemUoMCkgaGVyZSBiZWNhdXNlIHRoZSBub24tY3JpdGljYWwgbWVtb3J5CisgICAg ICAgIHByZXNzdXJlIGhhbmRsZXIgYWxyZWFkeSB0YWtlcyBjYXJlIG9mIHRoaXMuCisKKyAgICAg ICAgRHVyaW5nIGxvY2FsIHRlc3RpbmcsIHRoaXMgY2hhbmdlIHNlZW1lZCB0byBkZWNyZWFzZSB0 aGUgb3ZlcmFsbCBtZW1vcnkKKyAgICAgICAgdXNhZ2Ugb2YgV2ViUHJvY2Vzc2VzIGJ5IH4xME1C IG9uIE1lbWJ1c3RlciAodGVzdGVkIG9uIFlvc2VtaXRlKS4KKworICAgICAgICAqIHBsYXRmb3Jt L01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZW1vcnlQcmVz c3VyZUhhbmRsZXI6OnJlbGVhc2VOb25jcml0aWNhbE1lbW9yeSk6CisgICAgICAgIChXZWJDb3Jl OjpNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnJlbGVhc2VDcml0aWNhbE1lbW9yeSk6CisKIDIwMTUt MDUtMjAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBbQ29udGVudEV4dGVuc2lvbnNdIFByb3Blcmx5IGluaXRpYWxpemUgQWN0aW9uS2V5LnN0 YXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NZW1vcnlQcmVzc3VyZUhh bmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5UHJlc3N1cmVIYW5kbGVy LmNwcAppbmRleCA4YjI4MDFlNzIzMzcyZmVmZmU3YTFiMDEyZTgwMzc3MTFiZmVhNjA1Li43ZjNh MjFkNmMzMjkwN2JlODM0YzlkOTY3YmJlODliNWMxMzgwMWY3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9NZW1vcnlQcmVzc3VyZUhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAKQEAgLTk1LDcgKzk1LDcg QEAgdm9pZCBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnJlbGVhc2VOb25jcml0aWNhbE1lbW9yeSgp CiAgICAgfQogCiAgICAgewotICAgICAgICBSZWxpZWZMb2dnZXIgbG9nKCJFdmljdCBNZW1vcnlD YWNoZSBkZWFkIHJlc291cmNlcyIpOworICAgICAgICBSZWxpZWZMb2dnZXIgbG9nKCJQcnVuZSBN ZW1vcnlDYWNoZSBkZWFkIHJlc291cmNlcyIpOwogICAgICAgICBNZW1vcnlDYWNoZTo6c2luZ2xl dG9uKCkucHJ1bmVEZWFkUmVzb3VyY2VzVG9TaXplKDApOwogICAgIH0KIH0KQEAgLTExMCw4ICsx MTAsOCBAQCB2b2lkIE1lbW9yeVByZXNzdXJlSGFuZGxlcjo6cmVsZWFzZUNyaXRpY2FsTWVtb3J5 KCkKICAgICB9CiAKICAgICB7Ci0gICAgICAgIFJlbGllZkxvZ2dlciBsb2coIkV2aWN0IGFsbCBN ZW1vcnlDYWNoZSByZXNvdXJjZXMiKTsKLSAgICAgICAgTWVtb3J5Q2FjaGU6OnNpbmdsZXRvbigp LmV2aWN0UmVzb3VyY2VzKCk7CisgICAgICAgIFJlbGllZkxvZ2dlciBsb2coIlBydW5lIE1lbW9y eUNhY2hlIGxpdmUgcmVzb3VyY2VzIik7CisgICAgICAgIE1lbW9yeUNhY2hlOjpzaW5nbGV0b24o KS5wcnVuZUxpdmVSZXNvdXJjZXNUb1NpemUoMCk7CiAgICAgfQogCiAgICAgewo=