145259 2015-05-21 04:23:52 -0700 MSVC internal compiler error when compiling TemplateRegistryKey class. 2015-05-22 10:58:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue ggaren oldest_to_newest 1096555 0 peavo 2015-05-21 04:23:52 -0700 I get an internal compiler error when compiling TemplateRegistryKey.h with MSVC (Visual Studio Express). 1096558 1 253520 peavo 2015-05-21 04:33:43 -0700 Created attachment 253520 Patch 1096588 2 253520 achristensen 2015-05-21 09:38:20 -0700 Comment on attachment 253520 Patch Strange. This should call Vector(std::initializer_list<String>), but I don't think it's a big deal to remove the explicit initialization to an empty Vector when that is the default behavior anyway. 1096593 3 peavo 2015-05-21 09:49:05 -0700 (In reply to comment #2) > Comment on attachment 253520 [details] > Patch > > Strange. This should call Vector(std::initializer_list<String>), but I > don't think it's a big deal to remove the explicit initialization to an > empty Vector when that is the default behavior anyway. Yes, I'm also a bit surprised that the WinCairo bot doesn't seem to have a problem, maybe we have slightly different versions of MSVC. Thanks for reviewing :) 1096601 4 253520 commit-queue 2015-05-21 10:27:57 -0700 Comment on attachment 253520 Patch Clearing flags on attachment: 253520 Committed r184717: <http://trac.webkit.org/changeset/184717> 1096602 5 commit-queue 2015-05-21 10:28:00 -0700 All reviewed patches have been landed. Closing bug. 1096865 6 bfulgham 2015-05-22 09:03:21 -0700 You should make sure you are running "Update 4" of Visual Studio. It fixes a number of compiler bugs. It does not show up automatically when you do a "check for updates", you have to go to the MSDN site and locate the download link. :-( 1096892 7 peavo 2015-05-22 10:58:09 -0700 (In reply to comment #6) > You should make sure you are running "Update 4" of Visual Studio. It fixes a > number of compiler bugs. It does not show up automatically when you do a > "check for updates", you have to go to the MSDN site and locate the download > link. :-( Ah, ok, thanks :) 253520 2015-05-21 04:33:43 -0700 2015-05-21 10:27:57 -0700 Patch bug-145259-20150521133327.patch text/plain 1224 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0NzExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTA1LTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBNU1ZDIGludGVybmFsIGNvbXBpbGVyIGVycm9yIHdoZW4gY29tcGlsaW5nIFRlbXBsYXRl UmVnaXN0cnlLZXkgY2xhc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDUyNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBNU1ZDIGlzIG5vdCBhYmxlIHRvIGhhbmRsZSB0aGUgYnJhY2UgaW5pdGlhbGl6 YXRpb24gb2YgYSBjbGFzcyBtZW1iZXIgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogcnVudGlt ZS9UZW1wbGF0ZVJlZ2lzdHJ5S2V5Lmg6CisKIDIwMTUtMDUtMjAgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhcnJheSBwcmV2 aWV3cyBzaG91bGQgaGF2ZSBhIG11Y2ggc21hbGxlciBjYXAgb24gdmFsdWVzCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UZW1wbGF0ZVJlZ2lzdHJ5S2V5LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVGVtcGxhdGVSZWdpc3RyeUtleS5o CShyZXZpc2lvbiAxODQ3MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UZW1w bGF0ZVJlZ2lzdHJ5S2V5LmgJKHdvcmtpbmcgY29weSkKQEAgLTYyLDggKzYyLDggQEAgcHVibGlj OgogICAgIH07CiAKIHByaXZhdGU6Ci0gICAgU3RyaW5nVmVjdG9yIG1fcmF3U3RyaW5ncyB7IH07 Ci0gICAgU3RyaW5nVmVjdG9yIG1fY29va2VkU3RyaW5ncyB7IH07CisgICAgU3RyaW5nVmVjdG9y IG1fcmF3U3RyaW5nczsKKyAgICBTdHJpbmdWZWN0b3IgbV9jb29rZWRTdHJpbmdzOwogICAgIHVu c2lnbmVkIG1faGFzaCB7IDAgfTsKIH07CiAK