145257 2015-05-21 04:10:45 -0700 Layout Test http/tests/media/media-document-referer.html is flaky 2015-09-16 08:49:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 chavarria1991 ap cdumez commit-queue eric.carlson jer.noble oldest_to_newest 1096550 0 chavarria1991 2015-05-21 04:10:45 -0700 The http/tests/media/media-document-referer.html layout test is flaky on GTK+. It fails sometimes. The diff is the following: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/media/media-document-referer-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/media/media-document-referer-actual.txt @@ -1,5 +1,5 @@ Tests that a media document has correct referer header. -video loaded, referer was correct! OK +TIMEOUT: video failed to load without an error. FAIL END OF TEST 1125893 1 ap 2015-09-14 22:30:26 -0700 This test started to be (very) flaky on Mac, too. It doesn't seem like there was any specific change, my guess is that it's timing. The test expects that the video will load within a second - that doesn't seem like a reasonable expectation for a regression test, which operate under huge CPU load. 1125894 2 261176 ap 2015-09-14 22:33:33 -0700 Created attachment 261176 proposed fix 1125904 3 261176 commit-queue 2015-09-14 23:47:02 -0700 Comment on attachment 261176 proposed fix Clearing flags on attachment: 261176 Committed r189778: <http://trac.webkit.org/changeset/189778> 1125905 4 commit-queue 2015-09-14 23:47:08 -0700 All reviewed patches have been landed. Closing bug. 1126343 5 ap 2015-09-16 08:49:14 -0700 This fixed it. 261176 2015-09-14 22:33:33 -0700 2015-09-14 23:47:02 -0700 proposed fix OneSecondTimeout.txt text/plain 2014 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4OTc3NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA5LTE0ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IGh0dHAvdGVzdHMvbWVk aWEvbWVkaWEtZG9jdW1lbnQtcmVmZXJlci5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUyNTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvbWVkaWEvbWVkaWEt ZG9jdW1lbnQtcmVmZXJlci5odG1sOiBJbmNyZWFzZSB0aGUgdGltZW91dCwgb25lIHNlY29uZCBp cyBub3QgbXVjaC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOiBG aW5nZXJzIGNyb3NzZWQsIHRoaXMgd2lsbCBoZWxwIEd0ayBhcyB3ZWxsLgorCiAyMDE1LTA5LTE0 ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIGZhc3QvZXZl bnRzL2ZyYW1lLXNjcm9sbC1mYWtlLW1vdXNlLW1vdmUuaHRtbCBpcyBmbGFreQpJbmRleDogTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS9tZWRpYS1kb2N1bWVudC1yZWZlcmVyLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS9tZWRpYS1kb2N1bWVudC1y ZWZlcmVyLmh0bWwJKHJldmlzaW9uIDE4OTc3NSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMv bWVkaWEvbWVkaWEtZG9jdW1lbnQtcmVmZXJlci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMSw3 ICsyMSw3IEBACiAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICB9 CiAKLSAgICAgICAgICAgICAgICBpZiAoKytjb3VudGVyID49IDEwKSB7CisgICAgICAgICAgICAg ICAgaWYgKCsrY291bnRlciA+PSAxMDApIHsKICAgICAgICAgICAgICAgICAgICAgZmFpbFRlc3Qo IlRJTUVPVVQ6IHZpZGVvIGZhaWxlZCB0byBsb2FkIHdpdGhvdXQgYW4gZXJyb3IuIik7CiAgICAg ICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICB9CkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTg5Nzc1KQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkK QEAgLTExNTcsNyArMTE1Nyw2IEBAIHdlYmtpdC5vcmcvYi8xNDUxNzAgZmFzdC9ldmVudHMvd2hl ZWxldmUKIHdlYmtpdC5vcmcvYi8xNDUxNzAgZmFzdC9ldmVudHMvd2hlZWxldmVudC1pbi12ZXJ0 aWNhbC1zY3JvbGxiYXItaW4tcnRsLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogCiB3ZWJraXQub3Jn L2IvMTQ1MjU2IG1lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY2hpbGQtcmF0ZS5odG1sIFsgRmFpbHVy ZSBQYXNzIF0KLXdlYmtpdC5vcmcvYi8xNDUyNTcgaHR0cC90ZXN0cy9tZWRpYS9tZWRpYS1kb2N1 bWVudC1yZWZlcmVyLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzE0NTI1OCBt ZWRpYS92aWRlby1jb250cm9sbGVyLWNoaWxkLXJhdGUuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiAK IHdlYmtpdC5vcmcvYi8xNDUyNjEgZmFzdC93b3JrZXJzL3N0cmVzcy1qcy1leGVjdXRpb24uaHRt bCBbIEZhaWx1cmUgUGFzcyBdCg==