145247 2015-05-21 02:00:54 -0700 [MIPS] webkitgtk fails to build for MIPS platform 2016-01-18 19:31:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED DUPLICATE 152785 P2 Normal --- 1 Jeffrey.li webkit-unassigned commit-queue guijemont jbriance mcatanzaro ossy oldest_to_newest 1096526 0 Jeffrey.li 2015-05-21 02:00:54 -0700 Build fails on MIPS because the following function is missing from MacroAssemblerMIPS.h: Jump branchAdd32(ResultCondition cond, Address src, RegisterID dest) 1096527 1 253510 Jeffrey.li 2015-05-21 02:11:55 -0700 Created attachment 253510 Patch for MIPS platform build error! 1096845 2 253510 ossy 2015-05-22 04:46:29 -0700 Comment on attachment 253510 Patch for MIPS platform build error! I assume you would like to ask review for it, so set r? and patch flag too. 1096846 3 commit-queue 2015-05-22 04:48:16 -0700 Attachment 253510 did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 1097196 4 Jeffrey.li 2015-05-24 19:24:52 -0700 Made a mistake to resolve the issue. 1151638 5 mcatanzaro 2015-12-30 15:21:46 -0800 Guillaume, this look OK? You didn't run into this issue...? 1156156 6 jbriance 2016-01-16 03:25:21 -0800 *** This bug has been marked as a duplicate of bug 152785 *** 1156508 7 guijemont 2016-01-18 18:43:14 -0800 (In reply to comment #5) > Guillaume, this look OK? You didn't run into this issue...? Yes I ran into this issue and had made a fix I hadn't submitted yet (wasn't certain it was correct yet). I think we are 3 people who have solved it the same way independently. Anyway, it's fixed in trunk now with Julien's patch. 1156526 8 253510 mcatanzaro 2016-01-18 19:31:51 -0800 Comment on attachment 253510 Patch for MIPS platform build error! Unsetting the flags then (stupid WebKit Bugzilla shows the patch in request-queue forever if you forget to do this). 253510 2015-05-21 02:11:55 -0700 2016-01-18 19:31:51 -0800 Patch for MIPS platform build error! proposed_patch.patch text/plain 1601 Jeffrey.li ZGlmZiAtdU5yIEphdmFTY3JpcHRDb3JlX2Jhay9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBT LmggSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCi0tLSBKYXZh U2NyaXB0Q29yZV9iYWsvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCTIwMTUtMDUtMjEg MTY6MTY6NDUuMjU2MDkzMDU4ICswODAwCisrKyBKYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJNSVBTLmgJMjAxNS0wNS0yMSAxNjowODowNC4xMTA1NjA4MDAgKzA4MDAKQEAg LTE3MjksNiArMTcyOSwxMiBAQAogICAgICAgICByZXR1cm4gSnVtcCgpOw0KICAgICB9DQogDQor ICAgIEp1bXAgYnJhbmNoQWRkMzIoUmVzdWx0Q29uZGl0aW9uIGNvbmQsIEFkZHJlc3Mgc3JjLCBS ZWdpc3RlcklEIGRlc3QpDQorICAgIHsNCisgICAgICAgIGxvYWQzMihzcmMsIGltbVRlbXBSZWdp c3Rlcik7IC8vZGF0YVRlbXBSZWdpc3RlciBpcyB1c2VkIHRvIHNhdmUgdGVtcGFyYXJ5IHJlc3Vs dCBpbiAiSnVtcCBicmFuY2hBZGQzMihSZXN1bHRDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJRCBz cmMsIFJlZ2lzdGVySUQgZGVzdCkiDQorICAgICAgICByZXR1cm4gYnJhbmNoQWRkMzIoY29uZCwg aW1tVGVtcFJlZ2lzdGVyLCBkZXN0KTsNCisgICAgfQ0KKw0KICAgICBKdW1wIGJyYW5jaE11bDMy KFJlc3VsdENvbmRpdGlvbiBjb25kLCBSZWdpc3RlcklEIHNyYzEsIFJlZ2lzdGVySUQgc3JjMiwg UmVnaXN0ZXJJRCBkZXN0KQ0KICAgICB7DQogICAgICAgICBBU1NFUlQoKGNvbmQgPT0gT3ZlcmZs b3cpIHx8IChjb25kID09IFNpZ25lZCkgfHwgKGNvbmQgPT0gWmVybykgfHwgKGNvbmQgPT0gTm9u WmVybykpOw0KZGlmZiAtdU5yIEphdmFTY3JpcHRDb3JlX2Jhay9DaGFuZ2VMb2cgSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCi0tLSBKYXZhU2NyaXB0Q29yZV9iYWsvQ2hhbmdlTG9nCTIwMTUtMDUt MjEgMTY6MTY6NDUuMjcyMDkyODU4ICswODAwCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJ MjAxNS0wNS0yMSAxNzowMToxNi40Njc2OTgzMTcgKzA4MDAKQEAgLTEsMyArMSwxNSBAQAorMjAx NS0wNS0yMSAgSmVmZnJleSBMaSA8amVmZnJleS5saUBuYWdyYS5jb20+DQorDQorICAgICAgICBb TUlQU10gd2Via2l0Z3RrIGZhaWxzIHRvIGJ1aWxkIGZvciBNSVBTIHBsYXRmb3JtDQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MjQ3DQorDQorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisgICAgICAgIEFkZCBtaXNzaW5n IGltcGxlbWVudGF0aW9ucyBpbiBNYWNyb0Fzc2VtYmxlciBmb3IgTUlQUy4NCisNCisgICAgICAg ICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oOg0KKyAgICAgICAgKEpTQzo6TWFjcm9B c3NlbWJsZXJNSVBTOjpicmFuY2hBZGQzMik6DQorDQogMjAxNS0wNS0xNSAgQWxleGFuZHIgU2th Y2hrb3YgIDxnc2thY2hrb3ZAZ21haWwuY29tPg0KIA0KICAgICAgICAgRml4IHR5cG8gaW4gZnVu Y3Rpb24gbmFtZSBwYXJzZUZ1bmN0aW9uUGFyYW10ZXJzIC0+IHBhcnNlRnVuY3Rpb25QYXJhbWV0 ZXJzDQo=