145235 2015-05-20 18:00:37 -0700 Web Inspector: Use native Arguments detection instead of using toString 2015-05-20 22:12:18 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1096413 0 joepeck 2015-05-20 18:00:37 -0700 * SUMMARY Use native Arguments detection instead of using toString. Technically Object.prototype.toString could be overridden anyways. But I still think it is weird to do a toString check here. 1096421 1 253485 joepeck 2015-05-20 18:14:12 -0700 Created attachment 253485 [PATCH] Proposed Fix 1096476 2 253485 commit-queue 2015-05-20 22:12:14 -0700 Comment on attachment 253485 [PATCH] Proposed Fix Clearing flags on attachment: 253485 Committed r184697: <http://trac.webkit.org/changeset/184697> 1096477 3 commit-queue 2015-05-20 22:12:18 -0700 All reviewed patches have been landed. Closing bug. 253485 2015-05-20 18:14:12 -0700 2015-05-20 22:12:14 -0700 [PATCH] Proposed Fix arguments.patch text/plain 2797 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDZhMTc4ZTMuLjkwMTU3MDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA1LTIwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVXNlIG5h dGl2ZSBBcmd1bWVudHMgZGV0ZWN0aW9uIGluc3RlYWQgb2YgdXNpbmcgdG9TdHJpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTIzNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0lu amVjdGVkU2NyaXB0U291cmNlLmpzOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQucHJvdG90eXBl Ll9zdWJ0eXBlKToKKyAgICAgICAgRGVsZXRlZCB0aGUgb2xkIHN0cmluZyBjb2RlLgorCisgICAg ICAgICogaW5zcGVjdG9yL0pTSW5qZWN0ZWRTY3JpcHRIb3N0LmNwcDoKKyAgICAgICAgKEluc3Bl Y3Rvcjo6SlNJbmplY3RlZFNjcmlwdEhvc3Q6OnN1YnR5cGUpOgorICAgICAgICBSZXBsYWNlZCB3 aXRoIGEgc3RyaWN0ZXIsIG1vcmUgYWNjdXJhdGUgY2hlY2suCisKKzIwMTUtMDUtMjAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBObyBMTEludCBUZXN0 IEZhaWx1cmU6IGpzYy1sYXlvdXQtdGVzdHMueWFtbC9qcy9zY3JpcHQtdGVzdHMvb2JqZWN0LWxp dGVyYWwtZHVwbGljYXRlLXByb3BlcnRpZXMuanMubGF5b3V0LW5vLWxsaW50CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUyMTkKIApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5q cyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2Uu anMKaW5kZXggODdkOGNhZi4uMGM1MmJlMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcworKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCkBAIC03NDcsOCArNzQ3 LDYgQEAgSW5qZWN0ZWRTY3JpcHQucHJvdG90eXBlID0gewogICAgICAgICB0cnkgewogICAgICAg ICAgICAgaWYgKHR5cGVvZiBvYmouc3BsaWNlID09PSAiZnVuY3Rpb24iICYmIGlzRmluaXRlKG9i ai5sZW5ndGgpKQogICAgICAgICAgICAgICAgIHJldHVybiAiYXJyYXkiOwotICAgICAgICAgICAg aWYgKE9iamVjdC5wcm90b3R5cGUudG9TdHJpbmcuY2FsbChvYmopID09PSAiW29iamVjdCBBcmd1 bWVudHNdIiAmJiBpc0Zpbml0ZShvYmoubGVuZ3RoKSkgLy8gYXJndW1lbnRzLgotICAgICAgICAg ICAgICAgIHJldHVybiAiYXJyYXkiOwogICAgICAgICB9IGNhdGNoIChlKSB7CiAgICAgICAgIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0luamVjdGVk U2NyaXB0SG9zdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTSW5qZWN0 ZWRTY3JpcHRIb3N0LmNwcAppbmRleCBmZTA4ZTBiLi5iYzliOGRmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTSW5qZWN0ZWRTY3JpcHRIb3N0LmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTSW5qZWN0ZWRTY3JpcHRIb3N0LmNw cApAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgIkpTSW5qZWN0ZWRTY3JpcHRIb3N0LmgiCiAK ICNpbmNsdWRlICJEYXRlSW5zdGFuY2UuaCIKKyNpbmNsdWRlICJEaXJlY3RBcmd1bWVudHMuaCIK ICNpbmNsdWRlICJFcnJvci5oIgogI2luY2x1ZGUgIkluamVjdGVkU2NyaXB0SG9zdC5oIgogI2lu Y2x1ZGUgIkl0ZXJhdG9yT3BlcmF0aW9ucy5oIgpAQCAtNDYsNiArNDcsNyBAQAogI2luY2x1ZGUg IkpTV2Vha1NldC5oIgogI2luY2x1ZGUgIk9iamVjdENvbnN0cnVjdG9yLmgiCiAjaW5jbHVkZSAi UmVnRXhwT2JqZWN0LmgiCisjaW5jbHVkZSAiU2NvcGVkQXJndW1lbnRzLmgiCiAjaW5jbHVkZSAi U291cmNlQ29kZS5oIgogI2luY2x1ZGUgIlR5cGVkQXJyYXlJbmxpbmVzLmgiCiAjaW5jbHVkZSAi V2Vha01hcERhdGEuaCIKQEAgLTE0Niw2ICsxNDgsOSBAQCBKU1ZhbHVlIEpTSW5qZWN0ZWRTY3Jp cHRIb3N0OjpzdWJ0eXBlKEV4ZWNTdGF0ZSogZXhlYykKIAogICAgIGlmICh2YWx1ZS5pbmhlcml0 cyhKU0FycmF5OjppbmZvKCkpKQogICAgICAgICByZXR1cm4ganNOb250cml2aWFsU3RyaW5nKGV4 ZWMsIEFTQ0lJTGl0ZXJhbCgiYXJyYXkiKSk7CisgICAgaWYgKHZhbHVlLmluaGVyaXRzKERpcmVj dEFyZ3VtZW50czo6aW5mbygpKSB8fCB2YWx1ZS5pbmhlcml0cyhTY29wZWRBcmd1bWVudHM6Omlu Zm8oKSkpCisgICAgICAgIHJldHVybiBqc05vbnRyaXZpYWxTdHJpbmcoZXhlYywgQVNDSUlMaXRl cmFsKCJhcnJheSIpKTsKKwogICAgIGlmICh2YWx1ZS5pbmhlcml0cyhEYXRlSW5zdGFuY2U6Omlu Zm8oKSkpCiAgICAgICAgIHJldHVybiBqc05vbnRyaXZpYWxTdHJpbmcoZXhlYywgQVNDSUlMaXRl cmFsKCJkYXRlIikpOwogICAgIGlmICh2YWx1ZS5pbmhlcml0cyhSZWdFeHBPYmplY3Q6OmluZm8o KSkpCg==