145230 2015-05-20 16:21:23 -0700 Allow overriding the waitForDidUpdateViewState timeout 2016-08-05 14:00:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca sam simon.fraser oldest_to_newest 1096385 0 thorton 2015-05-20 16:21:23 -0700 Allow overriding the waitForDidUpdateViewState timeout 1096386 1 253474 thorton 2015-05-20 16:22:21 -0700 Created attachment 253474 Patch 1096390 2 253474 darin 2015-05-20 16:42:04 -0700 Comment on attachment 253474 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253474&action=review > Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:407 > + static std::chrono::milliseconds viewStateUpdateTimeout; > + if (viewStateUpdateTimeout == std::chrono::milliseconds::zero()) { > + if (id value = [[NSUserDefaults standardUserDefaults] objectForKey:@"WebKit2OverrideViewStateUpdateTimeoutMS"]) > + viewStateUpdateTimeout = std::chrono::milliseconds([value integerValue]); > + else { > #if PLATFORM(IOS) > - auto viewStateUpdateTimeout = std::chrono::milliseconds(500); > + viewStateUpdateTimeout = std::chrono::milliseconds(500); > #else > - auto viewStateUpdateTimeout = std::chrono::milliseconds(250); > + viewStateUpdateTimeout = std::chrono::milliseconds(250); > #endif > + } > + } We should not use zero as a magic value to mean uninitialized. We should use use a lambda and initialization syntax: static std::chrono::milliseconds viewStateUpdateTimeout = [] { ... fancy code in here ... }(); 253474 2015-05-20 16:22:21 -0700 2015-05-20 16:42:04 -0700 Patch bug-145230-20150520162217.patch text/plain 2365 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWU1MTQwNTk4YmI5NDgw NDk4NGYwNmI1YzcxYjgwNzBmOTAyM2Y1NC4uNTFiMzkyOGY0YjczOGE4ZWRjYzY4MWUzMDNiMDZh YTk2ZWEyZDk0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTIwICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IG92ZXJy aWRpbmcgdGhlIHdhaXRGb3JEaWRVcGRhdGVWaWV3U3RhdGUgdGltZW91dAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MjMwCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yMDk5MDE2Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQ cm94eS5tbToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94 eTo6d2FpdEZvckRpZFVwZGF0ZVZpZXdTdGF0ZSk6CisgICAgICAgIFVzZSB0aGUgdmFsdWUgZnJv bSBOU1VzZXJEZWZhdWx0cywgaWYgaXQgZXhpc3RzLgorICAgICAgICBXZSdsbCBvbmx5IGNoZWNr IG9uY2UsIHNvIGNoYW5naW5nIHRoZSBkZWZhdWx0IHJlcXVpcmVzIGEgcmVzdGFydCBvZiB0aGUg VUkgcHJvY2Vzcy4KKwogMjAxNS0wNS0yMCAgU3VuZ21hbm4gQ2hvICA8c3VuZ21hbm4uY2hvQG5h dmVyY29ycC5jb20+CiAKICAgICAgICAgTWlub3IgY2xlYW51cHMgdG8gUGx1Z2luUHJvY2Vzc1By b3h5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9SZW1vdGVMYXll clRyZWVEcmF3aW5nQXJlYVByb3h5Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9S ZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5Lm1tCmluZGV4IDMwMTY4MWY5NTE3OGJkOGJm NWJhNzViYjg1OTQyNWVhMjEyMjU1ZmYuLjY4ZWJlMmU0NWY5MzM1ZmJlNDVkN2M5Yzc0MDgzMzAy NTIyYzVhMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUmVtb3Rl TGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhUHJveHkubW0KQEAgLTM5MywxMSArMzkz LDE4IEBAIHZvaWQgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eTo6ZGlkUmVmcmVzaERp c3BsYXkoZG91YmxlKQogCiB2b2lkIFJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhUHJveHk6Ondh aXRGb3JEaWRVcGRhdGVWaWV3U3RhdGUoKQogeworICAgIHN0YXRpYyBzdGQ6OmNocm9ubzo6bWls bGlzZWNvbmRzIHZpZXdTdGF0ZVVwZGF0ZVRpbWVvdXQ7CisgICAgaWYgKHZpZXdTdGF0ZVVwZGF0 ZVRpbWVvdXQgPT0gc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kczo6emVybygpKSB7CisgICAgICAg IGlmIChpZCB2YWx1ZSA9IFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIG9i amVjdEZvcktleTpAIldlYktpdDJPdmVycmlkZVZpZXdTdGF0ZVVwZGF0ZVRpbWVvdXRNUyJdKQor ICAgICAgICAgICAgdmlld1N0YXRlVXBkYXRlVGltZW91dCA9IHN0ZDo6Y2hyb25vOjptaWxsaXNl Y29uZHMoW3ZhbHVlIGludGVnZXJWYWx1ZV0pOworICAgICAgICBlbHNlIHsKICNpZiBQTEFURk9S TShJT1MpCi0gICAgYXV0byB2aWV3U3RhdGVVcGRhdGVUaW1lb3V0ID0gc3RkOjpjaHJvbm86Om1p bGxpc2Vjb25kcyg1MDApOworICAgICAgICAgICAgdmlld1N0YXRlVXBkYXRlVGltZW91dCA9IHN0 ZDo6Y2hyb25vOjptaWxsaXNlY29uZHMoNTAwKTsKICNlbHNlCi0gICAgYXV0byB2aWV3U3RhdGVV cGRhdGVUaW1lb3V0ID0gc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcygyNTApOworICAgICAgICAg ICAgdmlld1N0YXRlVXBkYXRlVGltZW91dCA9IHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHMoMjUw KTsKICNlbmRpZgorICAgICAgICB9CisgICAgfQogICAgIG1fd2ViUGFnZVByb3h5LnByb2Nlc3Mo KS5jb25uZWN0aW9uKCktPndhaXRGb3JBbmREaXNwYXRjaEltbWVkaWF0ZWx5PE1lc3NhZ2VzOjpS ZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5OjpDb21taXRMYXllclRyZWU+KG1fd2ViUGFn ZVByb3h5LnBhZ2VJRCgpLCB2aWV3U3RhdGVVcGRhdGVUaW1lb3V0LCBJbnRlcnJ1cHRXYWl0aW5n SWZTeW5jTWVzc2FnZUFycml2ZXMpOwogfQogCg==