145229 2015-05-20 16:04:49 -0700 [WK2][iOS] Update WebContent process sandbox profile for AWD logging 2015-05-20 20:07:08 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ap commit-queue oldest_to_newest 1096373 0 cdumez 2015-05-20 16:04:49 -0700 Update WebContent process sandbox profile for AWD logging. Radar: <rdar://problem/20543269> 1096374 1 253469 cdumez 2015-05-20 16:05:53 -0700 Created attachment 253469 Patch 1096380 2 253469 ap 2015-05-20 16:12:58 -0700 Comment on attachment 253469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253469&action=review > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:86 > +(allow file-write-create > + (literal "/private/var/mobile/Library/Logs/awd/awd-com.apple.WebKit.WebContent.log")) Seems very unlikely that this is enough, we need at least file-write-data in addition to file-write-create. Or even file-write*. How did you test? 1096396 3 253478 cdumez 2015-05-20 16:54:23 -0700 Created attachment 253478 Patch 1096397 4 cdumez 2015-05-20 16:55:36 -0700 (In reply to comment #2) > Comment on attachment 253469 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253469&action=review > > > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:86 > > +(allow file-write-create > > + (literal "/private/var/mobile/Library/Logs/awd/awd-com.apple.WebKit.WebContent.log")) > > Seems very unlikely that this is enough, we need at least file-write-data in > addition to file-write-create. Or even file-write*. > > How did you test? I didn't try to restart the app *after* the file was created. When relaunching the app, it turns out I need file-read-data and file-write-data as well. Therefore, I used file-write* / file-read*. 1096465 5 253478 commit-queue 2015-05-20 20:07:03 -0700 Comment on attachment 253478 Patch Clearing flags on attachment: 253478 Committed r184693: <http://trac.webkit.org/changeset/184693> 1096466 6 commit-queue 2015-05-20 20:07:08 -0700 All reviewed patches have been landed. Closing bug. 253469 2015-05-20 16:05:53 -0700 2015-05-20 16:54:20 -0700 Patch bug-145229-20150520160549.patch text/plain 1839 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTc4ODEwZTViMGJlOWY5 YWNiOGU0M2Q4YTFlMGQyMWI3ZjIwZDI0OC4uMzI5M2IwYzE0NDE2YjRjOTU0OWI3MjNiNTRjYzU0 MDViZTc1YzkwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA1LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1baU9TXSBVcGRhdGUg V2ViQ29udGVudCBwcm9jZXNzIHNhbmRib3ggcHJvZmlsZSBmb3IgQVdEIGxvZ2dpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTIyOQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjA1NDMyNjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20u YXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMTUtMDUtMjAgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ29udGVudCBFeHRlbnNp b25zXSBSZWxheCByZXN0cmljdGlvbnMgb24gdHJpZ2dlcnMgdGhhdCBtYXRjaCBldmVyeXRoaW5n LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiIGIvU291cmNlL1dlYktpdDIvUmVzb3Vy Y2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCmlu ZGV4IGZlOWM0ZDIyMzU5NjU2NzEwZTcyNTg4ZTU1ZTkyN2UxM2ZmZTUxNDEuLjZlYTRhMDhhOTBi YjA2YTE0ODc5YTAwZTY1ZmQyZTgwMTljNDVjYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVu dC5zYgorKysgYi9Tb3VyY2UvV2ViS2l0Mi9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9j b20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKQEAgLTc1LDEwICs3NSwxNCBAQAogOzsgVmFy aW91cyBzZXJ2aWNlcyByZXF1aXJlZCBieSBDRk5ldHdvcmsgYW5kIG90aGVyIGZyYW1ld29ya3MK IChhbGxvdyBtYWNoLWxvb2t1cAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlBvd2VyTWFu YWdlbWVudC5jb250cm9sIikKLSAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hY2NvdW50c2Qu YWNjb3VudG1hbmFnZXIiKQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF3ZGQiKSkKKyAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hY2NvdW50c2QuYWNjb3VudG1hbmFnZXIiKSkKIAog KGRlbnkgZmlsZS13cml0ZS1jcmVhdGUgKHZub2RlLXR5cGUgU1lNTElOSykpCiAoZGVueSBmaWxl LXJlYWQteGF0dHIgZmlsZS13cml0ZS14YXR0ciAoeGF0dHItcmVnZXggIyJeY29tXC5hcHBsZVwu c2VjdXJpdHlcLnByaXZhdGVcLiIpKQogCis7OyBBV0QgbG9nZ2luZworKGFsbG93IG1hY2gtbG9v a3VwIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF3ZGQiKSkKKyhhbGxvdyBmaWxlLXdyaXRlLWNy ZWF0ZQorICAgIChsaXRlcmFsICIvcHJpdmF0ZS92YXIvbW9iaWxlL0xpYnJhcnkvTG9ncy9hd2Qv YXdkLWNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5sb2ciKSkKKwogKG5ldHdvcmstY2xpZW50 IChyZW1vdGUgdGNwKSkK 253478 2015-05-20 16:54:23 -0700 2015-05-20 20:07:03 -0700 Patch bug-145229-20150520165419.patch text/plain 1844 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTc4ODEwZTViMGJlOWY5 YWNiOGU0M2Q4YTFlMGQyMWI3ZjIwZDI0OC4uMzI5M2IwYzE0NDE2YjRjOTU0OWI3MjNiNTRjYzU0 MDViZTc1YzkwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA1LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1baU9TXSBVcGRhdGUg V2ViQ29udGVudCBwcm9jZXNzIHNhbmRib3ggcHJvZmlsZSBmb3IgQVdEIGxvZ2dpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTIyOQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjA1NDMyNjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20u YXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMTUtMDUtMjAgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ29udGVudCBFeHRlbnNp b25zXSBSZWxheCByZXN0cmljdGlvbnMgb24gdHJpZ2dlcnMgdGhhdCBtYXRjaCBldmVyeXRoaW5n LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiIGIvU291cmNlL1dlYktpdDIvUmVzb3Vy Y2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCmlu ZGV4IGZlOWM0ZDIyMzU5NjU2NzEwZTcyNTg4ZTU1ZTkyN2UxM2ZmZTUxNDEuLjBmYjY2ZjdkODQ2 OTYyYWRlYTQ3MjA3YjI4OTFhMWFmZGQ5NzRhN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVu dC5zYgorKysgYi9Tb3VyY2UvV2ViS2l0Mi9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9j b20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKQEAgLTc1LDEwICs3NSwxNCBAQAogOzsgVmFy aW91cyBzZXJ2aWNlcyByZXF1aXJlZCBieSBDRk5ldHdvcmsgYW5kIG90aGVyIGZyYW1ld29ya3MK IChhbGxvdyBtYWNoLWxvb2t1cAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlBvd2VyTWFu YWdlbWVudC5jb250cm9sIikKLSAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hY2NvdW50c2Qu YWNjb3VudG1hbmFnZXIiKQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF3ZGQiKSkKKyAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hY2NvdW50c2QuYWNjb3VudG1hbmFnZXIiKSkKIAog KGRlbnkgZmlsZS13cml0ZS1jcmVhdGUgKHZub2RlLXR5cGUgU1lNTElOSykpCiAoZGVueSBmaWxl LXJlYWQteGF0dHIgZmlsZS13cml0ZS14YXR0ciAoeGF0dHItcmVnZXggIyJeY29tXC5hcHBsZVwu c2VjdXJpdHlcLnByaXZhdGVcLiIpKQogCis7OyBBV0QgbG9nZ2luZworKGFsbG93IG1hY2gtbG9v a3VwIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF3ZGQiKSkKKyhhbGxvdyBmaWxlLXJlYWQqIGZp bGUtd3JpdGUqCisgICAgKGxpdGVyYWwgIi9wcml2YXRlL3Zhci9tb2JpbGUvTGlicmFyeS9Mb2dz L2F3ZC9hd2QtY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LmxvZyIpKQorCiAobmV0d29yay1j bGllbnQgKHJlbW90ZSB0Y3ApKQo=