145226 2015-05-20 15:56:50 -0700 Use correct String in WTF API tests 2015-05-21 09:33:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen ap oldest_to_newest 1096366 0 achristensen 2015-05-20 15:56:50 -0700 After much more investigation time than I would like to admit, I found a small and obvious error resulting in us reading from memory we're not supposed to in the API tests. 1096367 1 253468 achristensen 2015-05-20 15:58:34 -0700 Created attachment 253468 Patch 1096370 2 achristensen 2015-05-20 16:01:59 -0700 http://trac.webkit.org/changeset/184668 1096452 3 ap 2015-05-20 19:14:11 -0700 This patch doesn't seem to change any results, how is that possible? 1096587 4 achristensen 2015-05-21 09:33:06 -0700 (In reply to comment #3) > This patch doesn't seem to change any results, how is that possible? Before this patch, we had a StringView pointing to deallocated data that was almost certainly still there because we had just deallocated it and reallocated a new string with a different length. 253468 2015-05-20 15:58:34 -0700 2015-05-20 16:00:15 -0700 Patch bug-145226-20150520155830.patch text/plain 1471 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NDY2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE1LTA1LTIwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgVXNlIGNvcnJlY3QgU3RyaW5nIGZvciBTdHJpbmdWaWV3IGlu IFdURiBBUEkgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NTIyNgorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMDM2MTc4NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9U ZXN0cy9XVEYvU3RyaW5nVmlldy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToK KyAgICAgICAgVXNlIHBhdHRlcm5Ib2xkZXIgZm9yIHBhdHRlcm4uCisKIDIwMTUtMDUtMjAgIEFs ZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ29u dGVudCBFeHRlbnNpb25zXSBSZWxheCByZXN0cmljdGlvbnMgb24gdHJpZ2dlcnMgdGhhdCBtYXRj aCBldmVyeXRoaW5nLgpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5n Vmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3Ry aW5nVmlldy5jcHAJKHJldmlzaW9uIDE4NDYzOSkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV1RGL1N0cmluZ1ZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDIsNyArNDAyLDcgQEAg VEVTVChXVEYsIFN0cmluZ1ZpZXdGaW5kSWdub3JpbmdBU0NJSUNhcwogICAgIFN0cmluZyByZWZl cmVuY2VIb2xkZXI7CiAgICAgU3RyaW5nVmlldyByZWZlcmVuY2UgPSBzdHJpbmdWaWV3RnJvbVVU RjgocmVmZXJlbmNlSG9sZGVyLCAiQUJDw4lFRkciKTsKICAgICBTdHJpbmcgcGF0dGVybkhvbGRl cjsKLSAgICBTdHJpbmdWaWV3IHBhdHRlcm4gPSBzdHJpbmdWaWV3RnJvbVVURjgocmVmZXJlbmNl SG9sZGVyLCAiQUJDw4lFRkdBIik7CisgICAgU3RyaW5nVmlldyBwYXR0ZXJuID0gc3RyaW5nVmll d0Zyb21VVEY4KHBhdHRlcm5Ib2xkZXIsICJBQkPDiUVGR0EiKTsKIAogICAgIEVYUEVDVF9FUShz dGF0aWNfY2FzdDxzaXplX3Q+KFdURjo6bm90Rm91bmQpLCByZWZlcmVuY2UuZmluZElnbm9yaW5n QVNDSUlDYXNlKHBhdHRlcm4pKTsKICAgICBFWFBFQ1RfRVEoc3RhdGljX2Nhc3Q8c2l6ZV90Pigw KSwgcGF0dGVybi5maW5kSWdub3JpbmdBU0NJSUNhc2UocmVmZXJlbmNlKSk7Cg==