145222 2015-05-20 13:37:08 -0700 [Mac] inform media session of all state changes 2015-05-20 14:54:20 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson webkit-bug-importer oldest_to_newest 1096339 0 eric.carlson 2015-05-20 13:37:08 -0700 HTMLMediaSession::mediaStateDidChange isn't always called when state changes, so check for changes when a 'webkitplaybacktargetavailabilitychanged' listener is added or removed, and when the media engine changes. 1096343 1 eric.carlson 2015-05-20 13:47:34 -0700 <rdar://problem/20981137> 1096350 2 253462 eric.carlson 2015-05-20 14:20:30 -0700 Created attachment 253462 Proposed patch. 1096356 3 eric.carlson 2015-05-20 14:54:10 -0700 Committed r184662: https://trac.webkit.org/r184662 253462 2015-05-20 14:20:30 -0700 2015-05-20 14:54:20 -0700 Proposed patch. state_changes_patch_1.txt text/plain 2652 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDY1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIGluZm9ybSBt ZWRpYSBzZXNzaW9uIG9mIGFsbCBzdGF0ZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUyMjIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp+SFRNTE1lZGlhRWxlbWVudCk6IENh bGwgdXBkYXRlTWVkaWFTdGF0ZS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6 Om1lZGlhUGxheWVyRW5naW5lVXBkYXRlZCk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6SFRN TE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJGaXJzdFZpZGVvRnJhbWVBdmFpbGFibGUpOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnJlbW92ZUV2ZW50TGlzdGVu ZXIpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmVucXVldWVQ bGF5YmFja1RhcmdldEF2YWlsYWJpbGl0eUNoYW5nZWRFdmVudCk6IERpdHRvLgorCiAyMDE1LTA1 LTIwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFk ZCBhIG1lY2hhbmlzbSB0byBvcHQtb3V0IG9mIHRoZSBhdXRvbWF0aWMgc2NhbGluZyBhcHBsaWVk IHRvIG5vdC1yZWFsbHktcmVzcG9uc2l2ZSBzaXRlcwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxODQ1OTYpCisrKyBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTIsNiArNDEy LDcgQEAgSFRNTE1lZGlhRWxlbWVudDo6fkhUTUxNZWRpYUVsZW1lbnQoKQogICAgIGlmIChoYXNF dmVudExpc3RlbmVycyhldmVudE5hbWVzKCkud2Via2l0cGxheWJhY2t0YXJnZXRhdmFpbGFiaWxp dHljaGFuZ2VkRXZlbnQpKSB7CiAgICAgICAgIG1faGFzUGxheWJhY2tUYXJnZXRBdmFpbGFiaWxp dHlMaXN0ZW5lcnMgPSBmYWxzZTsKICAgICAgICAgbV9tZWRpYVNlc3Npb24tPnNldEhhc1BsYXli YWNrVGFyZ2V0QXZhaWxhYmlsaXR5TGlzdGVuZXJzKCp0aGlzLCBmYWxzZSk7CisgICAgICAgIHVw ZGF0ZU1lZGlhU3RhdGUoKTsKICAgICB9CiAjZW5kaWYKIApAQCAtNDM1MCw2ICs0MzUxLDkgQEAg dm9pZCBIVE1MTWVkaWFFbGVtZW50OjptZWRpYVBsYXllckVuZ2luZQogICAgIG1fcGxheWVyLT5z ZXRWaWRlb0Z1bGxzY3JlZW5HcmF2aXR5KG1fdmlkZW9GdWxsc2NyZWVuR3Jhdml0eSk7CiAgICAg bV9wbGF5ZXItPnNldFZpZGVvRnVsbHNjcmVlbkxheWVyKG1fdmlkZW9GdWxsc2NyZWVuTGF5ZXIu Z2V0KCkpOwogI2VuZGlmCisjaWYgRU5BQkxFKFdJUkVMRVNTX1BMQVlCQUNLX1RBUkdFVCkKKyAg ICB1cGRhdGVNZWRpYVN0YXRlKCk7CisjZW5kaWYKIH0KIAogdm9pZCBIVE1MTWVkaWFFbGVtZW50 OjptZWRpYVBsYXllckZpcnN0VmlkZW9GcmFtZUF2YWlsYWJsZShNZWRpYVBsYXllciopCkBAIC00 OTUzLDYgKzQ5NTcsNyBAQCBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OnJlbW92ZUV2ZW50TGlzdGVu CiAgICAgaWYgKGRpZFJlbW92ZUxhc3RBdmFpbGFiaWxpdHlDaGFuZ2VkTGlzdGVuZXIpIHsKICAg ICAgICAgbV9oYXNQbGF5YmFja1RhcmdldEF2YWlsYWJpbGl0eUxpc3RlbmVycyA9IGZhbHNlOwog ICAgICAgICBtX21lZGlhU2Vzc2lvbi0+c2V0SGFzUGxheWJhY2tUYXJnZXRBdmFpbGFiaWxpdHlM aXN0ZW5lcnMoKnRoaXMsIGZhbHNlKTsKKyAgICAgICAgdXBkYXRlTWVkaWFTdGF0ZSgpOwogICAg IH0KIAogICAgIHJldHVybiB0cnVlOwpAQCAtNDk2NSw2ICs0OTcwLDcgQEAgdm9pZCBIVE1MTWVk aWFFbGVtZW50OjplbnF1ZXVlUGxheWJhY2tUYQogICAgIFJlZlB0cjxFdmVudD4gZXZlbnQgPSBX ZWJLaXRQbGF5YmFja1RhcmdldEF2YWlsYWJpbGl0eUV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygp LndlYmtpdHBsYXliYWNrdGFyZ2V0YXZhaWxhYmlsaXR5Y2hhbmdlZEV2ZW50LCBoYXNUYXJnZXRz KTsKICAgICBldmVudC0+c2V0VGFyZ2V0KHRoaXMpOwogICAgIG1fYXN5bmNFdmVudFF1ZXVlLmVu cXVldWVFdmVudChldmVudC5yZWxlYXNlKCkpOworICAgIHVwZGF0ZU1lZGlhU3RhdGUoKTsKIH0K IAogdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpzZXRXaXJlbGVzc1BsYXliYWNrVGFyZ2V0KFJlZjxN ZWRpYVBsYXliYWNrVGFyZ2V0PiYmIGRldmljZSkK