145219 2015-05-20 12:29:51 -0700 No LLInt Test Failure: jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint 2015-05-20 12:35:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck fpizlo ggaren joepeck mark.lam msaboff oldest_to_newest 1096315 0 joepeck 2015-05-20 12:29:51 -0700 Bots are seeing a JSC test failure. https://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/10187/steps/webkit-32bit-jsc-test/logs/stdio FAIL: jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint Diff looks like: > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: DIFF FAILURE! > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: --- ../.tests/jsc-layout-tests.yaml/js/object-literal-duplicate-properties-expected.txt 2015-05-20 11:06:14.000000000 -0700 > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: +++ ../jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint.out 2015-05-20 11:19:37.000000000 -0700 > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: @@ -224,19 +224,19 @@ > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: PASS (function(){var __proto__ = null; o = {__proto__:null, __proto__}})() did not throw exception. > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: PASS ({__proto__:[], __proto__:{}}) threw exception SyntaxError: Attempted to redefine __proto__ property.. > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: PASS 'use strict';({__proto__:[], __proto__:{}}) threw exception SyntaxError: Attempted to redefine __proto__ property.. > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: -PASS (function(){({__proto__:[], __proto__:{}})})() threw exception SyntaxError: Attempted to redefine __proto__ property.. > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: +PASS (function(){({__proto__:[], __proto__:{}})})() threw exception RangeError: Maximum call stack size exceeded.. > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: PASS o = {__proto__:null, '__proto__':{}} threw exception SyntaxError: Attempted to redefine __proto__ property.. > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: PASS 'use strict';o = {__proto__:null, '__proto__':{}} threw exception SyntaxError: Attempted to redefine __proto__ property.. > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: -PASS (function(){o = {__proto__:null, '__proto__':{}}})() threw exception SyntaxError: Attempted to redefine __proto__ property.. > jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: +PASS (function(){o = {__proto__:null, '__proto__':{}}})() threw exception RangeError: Maximum call stack size exceeded.. > ... Note the different exception message. 1096316 1 253457 joepeck 2015-05-20 12:31:16 -0700 Created attachment 253457 [PATCH] Proposed Fix 1096317 2 253457 mark.lam 2015-05-20 12:32:27 -0700 Comment on attachment 253457 [PATCH] Proposed Fix r=me 1096318 3 joepeck 2015-05-20 12:35:55 -0700 http://trac.webkit.org/changeset/184647 253457 2015-05-20 12:31:16 -0700 2015-05-20 12:32:27 -0700 [PATCH] Proposed Fix proposed-fix.patch text/plain 1524 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGY3MjJlYTEuLmNlZGQ5MzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE1LTA1LTIwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgTm8gTExJbnQgVGVzdCBGYWlsdXJl OiBqc2MtbGF5b3V0LXRlc3RzLnlhbWwvanMvc2NyaXB0LXRlc3RzL29iamVjdC1saXRlcmFsLWR1 cGxpY2F0ZS1wcm9wZXJ0aWVzLmpzLmxheW91dC1uby1sbGludAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MjE5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvSklUT3BlcmF0aW9ucy5jcHA6Cisg ICAgICAgIFRocm93IHRoZSBlcnJvciB3ZSBqdXN0IGdvdCwgaW5zdGVhZCBvZiBhIHN0YWNrIG92 ZXJmbG93IGV4Y2VwdGlvbi4KKyAgICAgICAgVGhpcyBtYXRjaGVzIG90aGVyIGVycm9yIGhhbmRs aW5nIGZvciBjYWxsZXJzIG9mIHByZXBhcmVGb3JFeGVjdXRpb24uCisKKzIwMTUtMDUtMjAgIEpv c2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBFUzY6IEltcGxl bWVudCBPYmplY3Quc2V0UHJvdG90eXBlT2YKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NTIwMgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRPcGVyYXRpb25zLmNwcAppbmRleCBlMGFhMzBjLi5kYWU1MmY2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKQEAgLTc0Niw3ICs3NDYsNyBAQCBpbmxp bmUgY2hhciogbGlua0ZvcigKIAogICAgICAgICBKU09iamVjdCogZXJyb3IgPSBmdW5jdGlvbkV4 ZWN1dGFibGUtPnByZXBhcmVGb3JFeGVjdXRpb24oZXhlY0NhbGxlZSwgY2FsbGVlLCBzY29wZSwg a2luZCk7CiAgICAgICAgIGlmIChlcnJvcikgewotICAgICAgICAgICAgdGhyb3dTdGFja092ZXJm bG93RXJyb3IoZXhlYyk7CisgICAgICAgICAgICBleGVjLT52bSgpLnRocm93RXhjZXB0aW9uKGV4 ZWMsIGVycm9yKTsKICAgICAgICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PGNoYXIqPih2 bS0+Z2V0Q1RJU3R1Yih0aHJvd0V4Y2VwdGlvbkZyb21DYWxsU2xvd1BhdGhHZW5lcmF0b3IpLmNv ZGUoKS5leGVjdXRhYmxlQWRkcmVzcygpKTsKICAgICAgICAgfQogICAgICAgICBjb2RlQmxvY2sg PSBmdW5jdGlvbkV4ZWN1dGFibGUtPmNvZGVCbG9ja0ZvcihraW5kKTsK