145217 2015-05-20 11:46:52 -0700 ThreadableLoaderOptions::isolatedCopy() doesn't produce a copy that is safe for sending to another thread 2015-05-20 14:08:38 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=143790 P2 Normal --- 1 ap ap commit-queue japhet oldest_to_newest 1096307 0 ap 2015-05-20 11:46:52 -0700 ThreadableLoaderOptions contains an AtomicString, so even an isolated copy cannot be sent to another thread. 1096308 1 253453 ap 2015-05-20 11:50:40 -0700 Created attachment 253453 proposed fix 1096311 2 253453 andersca 2015-05-20 12:14:38 -0700 Comment on attachment 253453 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=253453&action=review > Source/WebCore/loader/ThreadableLoader.h:71 > + String initiator; // This cannot be an AtomicString, as isolatedCopy() wouldn't create an object that's safe for passing to another thread. I think this comment would be better as a ChangeLog comment - no real point in listing what types a member variable cannot be. 1096335 3 253453 ap 2015-05-20 13:32:16 -0700 Comment on attachment 253453 proposed fix I'm sure someone would change this back into an AtomicString within a week from now, and there is no better way to prevent that than a header comment, unfortunately. 1096345 4 253453 commit-queue 2015-05-20 14:08:34 -0700 Comment on attachment 253453 proposed fix Clearing flags on attachment: 253453 Committed r184657: <http://trac.webkit.org/changeset/184657> 1096346 5 commit-queue 2015-05-20 14:08:38 -0700 All reviewed patches have been landed. Closing bug. 253453 2015-05-20 11:50:40 -0700 2015-05-20 14:08:34 -0700 proposed fix IsolatedCopy.txt text/plain 2163 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDY0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTIwICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFRocmVhZGFibGVMb2FkZXJP cHRpb25zOjppc29sYXRlZENvcHkoKSBkb2Vzbid0IHByb2R1Y2UgYSBjb3B5IHRoYXQgaXMgc2Fm ZSBmb3Igc2VuZGluZyB0byBhbm90aGVyIHRocmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2F1Z2h0IGJ5IGV4aXN0aW5nIHRlc3RzLCByYXJlbHku IEkgZG9uJ3Qga25vdyBob3cgdG8gY2F0Y2ggc3VjaCBidWdzIG1vcmUgcmVsaWFibHkuCisKKyAg ICAgICAgKiBsb2FkZXIvVGhyZWFkYWJsZUxvYWRlci5jcHA6IChXZWJDb3JlOjpUaHJlYWRhYmxl TG9hZGVyT3B0aW9uczo6aXNvbGF0ZWRDb3B5KToKKyAgICAgICAgKiBsb2FkZXIvVGhyZWFkYWJs ZUxvYWRlci5oOgorCiAyMDE1LTA1LTIwICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBBWDogQXV0b0ZpbGwgYnV0dG9uIGlzIG5vdCBhY2Nlc3NpYmxlIHdpdGgg Vm9pY2VPdmVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvVGhyZWFkYWJsZUxvYWRlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL1RocmVhZGFibGVMb2FkZXIu Y3BwCShyZXZpc2lvbiAxODQ2NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvVGhyZWFkYWJs ZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4LDcgKzU4LDcgQEAgc3RkOjp1bmlxdWVf cHRyPFRocmVhZGFibGVMb2FkZXJPcHRpb25zPgogICAgIGNvcHktPmNyb3NzT3JpZ2luUmVxdWVz dFBvbGljeSA9IGNyb3NzT3JpZ2luUmVxdWVzdFBvbGljeTsKICAgICBpZiAoc2VjdXJpdHlPcmln aW4pCiAgICAgICAgIGNvcHktPnNlY3VyaXR5T3JpZ2luID0gc2VjdXJpdHlPcmlnaW4tPmlzb2xh dGVkQ29weSgpOwotICAgIGNvcHktPmluaXRpYXRvciA9IGluaXRpYXRvci5zdHJpbmcoKS5pc29s YXRlZENvcHkoKTsKKyAgICBjb3B5LT5pbml0aWF0b3IgPSBpbml0aWF0b3IuaXNvbGF0ZWRDb3B5 KCk7CiAgICAgcmV0dXJuIGNvcHk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9U aHJlYWRhYmxlTG9hZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL1Ro cmVhZGFibGVMb2FkZXIuaAkocmV2aXNpb24gMTg0NjQyKQorKysgU291cmNlL1dlYkNvcmUvbG9h ZGVyL1RocmVhZGFibGVMb2FkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNjgsNyArNjgsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFByZWZsaWdodFBvbGljeSBwcmVmbGlnaHRQb2xp Y3k7IC8vIElmIEFjY2Vzc0NvbnRyb2wgaXMgdXNlZCwgaG93IHRvIGRldGVybWluZSBpZiBhIHBy ZWZsaWdodCBpcyBuZWVkZWQuCiAgICAgICAgIENyb3NzT3JpZ2luUmVxdWVzdFBvbGljeSBjcm9z c09yaWdpblJlcXVlc3RQb2xpY3k7CiAgICAgICAgIFJlZlB0cjxTZWN1cml0eU9yaWdpbj4gc2Vj dXJpdHlPcmlnaW47Ci0gICAgICAgIEF0b21pY1N0cmluZyBpbml0aWF0b3I7CisgICAgICAgIFN0 cmluZyBpbml0aWF0b3I7IC8vIFRoaXMgY2Fubm90IGJlIGFuIEF0b21pY1N0cmluZywgYXMgaXNv bGF0ZWRDb3B5KCkgd291bGRuJ3QgY3JlYXRlIGFuIG9iamVjdCB0aGF0J3Mgc2FmZSBmb3IgcGFz c2luZyB0byBhbm90aGVyIHRocmVhZC4KICAgICB9OwogCiAgICAgLy8gVXNlZnVsIGZvciBkb2lu ZyBsb2FkZXIgb3BlcmF0aW9ucyBmcm9tIGFueSB0aHJlYWQgKG5vdCB0aHJlYWRzYWZlLCAK