145215 2015-05-20 11:25:54 -0700 [Streams API] Remove ReadableStreamReader closed promise internal slot 2015-05-21 11:08:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf benjamin calvaris commit-queue darin oldest_to_newest 1096302 0 youennf 2015-05-20 11:25:54 -0700 Now that the binding generator adds a promiseDeferred member for each promise-typed attribute, we can use it for ReadableStreamReader closed attribute and remove the internal slot routines. 1096304 1 253452 youennf 2015-05-20 11:33:25 -0700 Created attachment 253452 Patch 1096628 2 253452 commit-queue 2015-05-21 11:08:45 -0700 Comment on attachment 253452 Patch Clearing flags on attachment: 253452 Committed r184723: <http://trac.webkit.org/changeset/184723> 1096629 3 commit-queue 2015-05-21 11:08:49 -0700 All reviewed patches have been landed. Closing bug. 253452 2015-05-20 11:33:25 -0700 2015-05-21 11:08:45 -0700 Patch bug-145215-20150520203319.patch text/plain 5437 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDY5YzMyYzdkNGExYjlm ODEwOGRkNmE5M2U2MWYzZjM3ODIyN2U5MS4uZDE3NGQwMDdhNGI0N2U0OThhNTEyOWEwZWYyZjQw NzNkNzkzNDAwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTA1LTIwICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+IGFuZCBZb3Vlbm4gRmFi bGV0IDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KKworICAgICAgICBbU3RyZWFtcyBBUEld IFJlbW92ZSBSZWFkYWJsZVN0cmVhbVJlYWRlciBjbG9zZWQgcHJvbWlzZSBpbnRlcm5hbCBzbG90 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUyMTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2luZyB0 aGUgbmV3IEpTUHJvbWlzZURlZmVycmVkIG1lbWJlciBnZW5lcmF0ZWQgYnkgYmluZGluZyBnZW5l cmF0b3IgdG8gaGFuZGxlIGNsb3NlZCBwcm9taXNlIGF0dHJpYnV0ZS4KKyAgICAgICAgUmVtb3Zl ZCBpbnRlcm5hbCBzbG90cyByb3V0aW5lcyBwcmV2aW91c2x5IHVzZWQgdG8gZW5zdXJlIHBlcnNp c3RlbmN5IG9mIHRoZSBwcm9taXNlLgorCisgICAgICAgIEV4aXN0aW5nIHRlc3RzIGNvdmVyIHRo ZSBjaGFuZ2VzLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNSZWFkYWJsZVN0cmVhbVJlYWRl ckN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU1JlYWRhYmxlU3RyZWFtUmVhZGVyOjpj bG9zZWQpOgorICAgICAgICAoV2ViQ29yZTo6SlNSZWFkYWJsZVN0cmVhbVJlYWRlcjo6Y2FuY2Vs KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkpTUmVhZGFibGVTdHJlYW1SZWFkZXI6OnJl bGVhc2VMb2NrKTogRGVsZXRlZC4KKyAgICAgICAgKiBiaW5kaW5ncy9qcy9SZWFkYWJsZUpTU3Ry ZWFtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldFByb3BlcnR5RnJvbU9iamVjdCk6IERlbGV0 ZWQuCisgICAgICAgIChXZWJDb3JlOjpjYWxsRnVuY3Rpb24pOiBEZWxldGVkLgorICAgICAgICAo V2ViQ29yZTo6UmVhZGFibGVKU1N0cmVhbTo6U291cmNlOjpjcmVhdGUpOiBEZWxldGVkLgorICAg ICAgICAoV2ViQ29yZTo6UmVhZGFibGVKU1N0cmVhbTo6U291cmNlOjpTb3VyY2UpOiBEZWxldGVk LgorICAgICAgICAqIGJpbmRpbmdzL2pzL1JlYWRhYmxlSlNTdHJlYW0uaDoKKwogMjAxNS0wNS0y MCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAgICAg IEpTIGJpbmRpbmcgZ2VuZXJhdG9yIHNob3VsZCBjcmVhdGUgYSBtZW1iZXIgdmFyaWFibGUgZm9y IGVhY2ggUHJvbWlzZSBhdHRyaWJ1dGUgb2YgYW4gaW50ZXJmYWNlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1JlYWRhYmxlU3RyZWFtUmVhZGVyQ3VzdG9tLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1SZWFkZXJDdXN0b20u Y3BwCmluZGV4IGQ2ZWNhYzI0MTIwNmUxMjJjOGNkYmQyOWM4YzQ5ZGFhNTcxZGE2ZDcuLmE3N2M5 ODg3MTRmYmYxNDVlMTk0ZTlhMDRkNDg0MjI2ZDA2ZTJiYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1SZWFkZXJDdXN0b20uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1SZWFkZXJDdXN0b20u Y3BwCkBAIC00OSwzMyArNDksMTYgQEAgSlNWYWx1ZSBKU1JlYWRhYmxlU3RyZWFtUmVhZGVyOjpy ZWFkKEV4ZWNTdGF0ZSogZXhlYykKICAgICByZXR1cm4gZXhlYy0+dm0oKS50aHJvd0V4Y2VwdGlv bihleGVjLCBlcnJvcik7CiB9CiAKLXN0YXRpYyBKU1Byb21pc2VEZWZlcnJlZCogZ2V0T3JDcmVh dGVQcm9taXNlRGVmZXJyZWRGcm9tT2JqZWN0KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB0aGlz T2JqZWN0LCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBQcml2YXRlTmFtZSAmbmFtZSkK LXsKLSAgICBKU1ZhbHVlIHNsb3QgPSBnZXRJbnRlcm5hbFNsb3RGcm9tT2JqZWN0KGV4ZWMsIHRo aXNPYmplY3QsIG5hbWUpOwotICAgIEpTUHJvbWlzZURlZmVycmVkKiBwcm9taXNlRGVmZXJyZWQg PSBzbG90ID8ganNEeW5hbWljQ2FzdDxKU1Byb21pc2VEZWZlcnJlZCo+KHNsb3QpIDogbnVsbHB0 cjsKLQotICAgIGlmICghcHJvbWlzZURlZmVycmVkKSB7Ci0gICAgICAgIHByb21pc2VEZWZlcnJl ZCA9IEpTUHJvbWlzZURlZmVycmVkOjpjcmVhdGUoZXhlYywgZ2xvYmFsT2JqZWN0KTsKLSAgICAg ICAgc2V0SW50ZXJuYWxTbG90VG9PYmplY3QoZXhlYywgdGhpc09iamVjdCwgbmFtZSwgcHJvbWlz ZURlZmVycmVkKTsKLSAgICB9Ci0gICAgcmV0dXJuIHByb21pc2VEZWZlcnJlZDsKLX0KLQotc3Rh dGljIEpTQzo6UHJpdmF0ZU5hbWUmIGNsb3NlZFByb21pc2VTbG90TmFtZSgpCi17Ci0gICAgc3Rh dGljIE5ldmVyRGVzdHJveWVkPEpTQzo6UHJpdmF0ZU5hbWU+IGNsb3NlZFByb21pc2VTbG90TmFt ZSgiY2xvc2VkUHJvbWlzZSIpOwotICAgIHJldHVybiBjbG9zZWRQcm9taXNlU2xvdE5hbWU7Ci19 Ci0KIEpTVmFsdWUgSlNSZWFkYWJsZVN0cmVhbVJlYWRlcjo6Y2xvc2VkKEV4ZWNTdGF0ZSogZXhl YykgY29uc3QKIHsKLSAgICBKU1Byb21pc2VEZWZlcnJlZCogcHJvbWlzZURlZmVycmVkID0gZ2V0 T3JDcmVhdGVQcm9taXNlRGVmZXJyZWRGcm9tT2JqZWN0KGV4ZWMsIHRoaXMsIGdsb2JhbE9iamVj dCgpLCBjbG9zZWRQcm9taXNlU2xvdE5hbWUoKSk7Ci0gICAgRGVmZXJyZWRXcmFwcGVyIHdyYXBw ZXIoZXhlYywgZ2xvYmFsT2JqZWN0KCksIHByb21pc2VEZWZlcnJlZCk7CisgICAgaWYgKCFtX2Ns b3NlZFByb21pc2VEZWZlcnJlZCkKKyAgICAgICAgY29uc3RfY2FzdDxKU1JlYWRhYmxlU3RyZWFt UmVhZGVyKj4odGhpcyktPm1fY2xvc2VkUHJvbWlzZURlZmVycmVkLnNldChleGVjLT52bSgpLCBK U1Byb21pc2VEZWZlcnJlZDo6Y3JlYXRlKGV4ZWMsIGdsb2JhbE9iamVjdCgpKSk7CisgICAgRGVm ZXJyZWRXcmFwcGVyIHdyYXBwZXIoZXhlYywgZ2xvYmFsT2JqZWN0KCksIG1fY2xvc2VkUHJvbWlz ZURlZmVycmVkLmdldCgpKTsKIAogICAgIGF1dG8gc3VjY2Vzc0NhbGxiYWNrID0gW3dyYXBwZXJd KCkgbXV0YWJsZSB7CiAgICAgICAgIHdyYXBwZXIucmVzb2x2ZShqc1VuZGVmaW5lZCgpKTsKICAg ICB9OwotICAgIGF1dG8gZmFpbHVyZUNhbGxiYWNrID0gW3dyYXBwZXJdKGNvbnN0IEpTVmFsdWUm IHZhbHVlKSBtdXRhYmxlIHsKKyAgICBhdXRvIGZhaWx1cmVDYWxsYmFjayA9IFt3cmFwcGVyXShK U1ZhbHVlIHZhbHVlKSBtdXRhYmxlIHsKICAgICAgICAgd3JhcHBlci5yZWplY3QodmFsdWUpOwog ICAgIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxl SlNTdHJlYW0uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvUmVhZGFibGVKU1N0cmVh bS5jcHAKaW5kZXggYWQxZWM3OTIxZWJkMTJkNzlmY2NiZTE0NTBkZTI0MWVkZjNhNzYzOC4uMzY3 Mzg1ZjU0ZmM1NDAwMzVlMDU3MjRlNjIzZTQ0MDQxY2YwYzA4YyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvUmVhZGFibGVKU1N0cmVhbS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvUmVhZGFibGVKU1N0cmVhbS5jcHAKQEAgLTQ3LDI0ICs0Nyw2IEBA IHVzaW5nIG5hbWVzcGFjZSBKU0M7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotdm9pZCBzZXRJ bnRlcm5hbFNsb3RUb09iamVjdChFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgb2JqZWN0VmFsdWUs IFByaXZhdGVOYW1lJiBuYW1lLCBKU1ZhbHVlIHZhbHVlKQotewotICAgIEpTT2JqZWN0KiBvYmpl Y3QgPSBvYmplY3RWYWx1ZS50b09iamVjdChleGVjKTsKLSAgICBQdXRQcm9wZXJ0eVNsb3QgcHJv cGVydHlTbG90KG9iamVjdFZhbHVlKTsKLSAgICBvYmplY3QtPnB1dChvYmplY3QsIGV4ZWMsIElk ZW50aWZpZXI6OmZyb21VaWQobmFtZSksIHZhbHVlLCBwcm9wZXJ0eVNsb3QpOwotfQotCi1KU1Zh bHVlIGdldEludGVybmFsU2xvdEZyb21PYmplY3QoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIG9i amVjdFZhbHVlLCBQcml2YXRlTmFtZSYgbmFtZSkKLXsKLSAgICBKU09iamVjdCogb2JqZWN0ID0g b2JqZWN0VmFsdWUudG9PYmplY3QoZXhlYyk7Ci0gICAgUHJvcGVydHlTbG90IHByb3BlcnR5U2xv dChvYmplY3RWYWx1ZSk7Ci0KLSAgICBJZGVudGlmaWVyIHByb3BlcnR5TmFtZSA9IElkZW50aWZp ZXI6OmZyb21VaWQobmFtZSk7Ci0gICAgaWYgKCFvYmplY3QtPmdldE93blByb3BlcnR5U2xvdChv YmplY3QsIGV4ZWMsIHByb3BlcnR5TmFtZSwgcHJvcGVydHlTbG90KSkKLSAgICAgICAgcmV0dXJu IEpTVmFsdWUoKTsKLSAgICByZXR1cm4gcHJvcGVydHlTbG90LmdldFZhbHVlKGV4ZWMsIHByb3Bl cnR5TmFtZSk7Ci19Ci0KIHN0YXRpYyBpbmxpbmUgSlNWYWx1ZSBnZXRQcm9wZXJ0eUZyb21PYmpl Y3QoRXhlY1N0YXRlKiBleGVjLCBKU09iamVjdCogb2JqZWN0LCBjb25zdCBjaGFyKiBpZGVudGlm aWVyKQogewogICAgIHJldHVybiBvYmplY3QtPmdldChleGVjLCBJZGVudGlmaWVyOjpmcm9tU3Ry aW5nKGV4ZWMsIGlkZW50aWZpZXIpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1JlYWRhYmxlSlNTdHJlYW0uaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Jl YWRhYmxlSlNTdHJlYW0uaAppbmRleCA0ZDUxZDAxYmZmODRmY2NmNzFkZWM0NjYyYzU4ZjY3NzJm YTc4ZjIzLi40YjczYjg5NjQzMTc2ZWZkMzkwMzcwNDgwYWNkNTQwOTBiNGUwNTMwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9SZWFkYWJsZUpTU3RyZWFtLmgKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvUmVhZGFibGVKU1N0cmVhbS5oCkBAIC03Nyw5ICs3 Nyw2IEBAIHByaXZhdGU6CiAgICAgSlNDOjpTdHJvbmc8SlNDOjpVbmtub3duPiBtX2Vycm9yOwog fTsKIAotdm9pZCBzZXRJbnRlcm5hbFNsb3RUb09iamVjdChKU0M6OkV4ZWNTdGF0ZSosIEpTQzo6 SlNWYWx1ZSwgSlNDOjpQcml2YXRlTmFtZSYsIEpTQzo6SlNWYWx1ZSk7Ci1KU0M6OkpTVmFsdWUg Z2V0SW50ZXJuYWxTbG90RnJvbU9iamVjdChKU0M6OkV4ZWNTdGF0ZSosIEpTQzo6SlNWYWx1ZSwg SlNDOjpQcml2YXRlTmFtZSYpOwotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAv LyBFTkFCTEUoU1RSRUFNU19BUEkpCg==