145211 2015-05-20 08:57:09 -0700 [GTK] Bump GCC requirements to 4.9.0 2015-05-24 23:55:21 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 98932 1 cgarcia webkit-unassigned clopez mcatanzaro mrobinson ossy zan oldest_to_newest 1096249 0 cgarcia 2015-05-20 08:57:09 -0700 It's required to build with IndexedDB support when using GCC, clang works just fine. All the bots have already been upgraded. 1096250 1 253440 cgarcia 2015-05-20 08:58:43 -0700 Created attachment 253440 Patch 1096256 2 zan 2015-05-20 09:29:04 -0700 EWS machines apparently haven't been updated. 1096257 3 253441 cgarcia 2015-05-20 09:29:30 -0700 Created attachment 253441 Patch 1096259 4 cgarcia 2015-05-20 09:32:49 -0700 (In reply to comment #2) > EWS machines apparently haven't been updated. They were, see green boxes in bug #98932, but I think CMake stupid cache still had the old compiler version somewhere. 1096261 5 253441 zan 2015-05-20 09:42:29 -0700 Comment on attachment 253441 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253441&action=review > Source/cmake/OptionsGTK.cmake:10 > +# IndexedDB support requires GGC 4.9, see https://bugs.webkit.org/show_bug.cgi?id=98932. GCC*. 1096264 6 cgarcia 2015-05-20 09:45:53 -0700 (In reply to comment #5) > Comment on attachment 253441 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253441&action=review > > > Source/cmake/OptionsGTK.cmake:10 > > +# IndexedDB support requires GGC 4.9, see https://bugs.webkit.org/show_bug.cgi?id=98932. > > GCC*. Oops. Thanks for the review, I'll wait for EWS anyway, and even more important for Martin's approval since he was not convinced yet to bump requirements. 1096787 7 cgarcia 2015-05-21 23:07:17 -0700 Martin? 1096974 8 mrobinson 2015-05-22 15:39:42 -0700 (In reply to comment #7) > Martin? It seems pretty simple to make the build conditional. If we need to do that we can go back and do it later, so I'm not going to block this. :) 1097214 9 cgarcia 2015-05-24 23:55:21 -0700 Committed r184849: <http://trac.webkit.org/changeset/184849> 253440 2015-05-20 08:58:43 -0700 2015-05-20 09:29:30 -0700 Patch wk-gcc-4.9.diff text/plain 1516 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ODVkZWUxLi4wZTA5MTll IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTUtMDUtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIEJ1bXAgR0NDIHJlcXVpcmVtZW50cyB0byA0LjkuMAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MjExCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyByZXF1aXJlZCB0byBi dWlsZCB3aXRoIEluZGV4ZWREQiBzdXBwb3J0IHdoZW4gdXNpbmcgR0NDLAorICAgICAgICBjbGFu ZyB3b3JrcyBqdXN0IGZpbmUuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTg5MzIuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToK KwogMjAxNS0wNS0xOCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0NNYWtlXSBJZ25vcmUgd2FybmluZ3MgaW4gc3lzdGVtIGhlYWRlcnMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09w dGlvbnNHVEsuY21ha2UKaW5kZXggMzMwMDc0MS4uYTFkNTUzYSAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2UKQEAgLTcsNiArNywxMyBAQCBzZXQoUFJPSkVDVF9WRVJTSU9OX01JQ1JPIDEpCiBzZXQoUFJP SkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfS4ke1BST0pFQ1RfVkVSU0lPTl9N SU5PUn0uJHtQUk9KRUNUX1ZFUlNJT05fTUlDUk99KQogc2V0KFdFQktJVEdUS19BUElfVkVSU0lP TiA0LjApCiAKKyMgSW5kZXhlZERCIHN1cHBvcnQgcmVxdWlyZXMgR0dDIDQuOSwgc2VlIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODkzMi4KK2lmIChDTUFLRV9DWFhf Q09NUElMRVJfSUQgU1RSRVFVQUwgIkdOVSIpCisgICAgaWYgKENNQUtFX0NYWF9DT01QSUxFUl9W RVJTSU9OIFZFUlNJT05fTEVTUyAiNC45LjAiKQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9S ICJHQ0MgNC45LjAgaXMgcmVxdWlyZWQgdG8gYnVpbGQgV2ViS2l0R1RLKywgdXNlIGEgbmV3ZXIg R0NDIHZlcnNpb24gb3IgY2xhbmciKQorICAgIGVuZGlmICgpCitlbmRpZiAoKQorCiAjIExpYnRv b2wgbGlicmFyeSB2ZXJzaW9uLCBub3QgdG8gYmUgY29uZnVzZWQgd2l0aCBBUEkgdmVyc2lvbi4K ICMgU2VlIGh0dHA6Ly93d3cuZ251Lm9yZy9zb2Z0d2FyZS9saWJ0b29sL21hbnVhbC9odG1sX25v ZGUvTGlidG9vbC12ZXJzaW9uaW5nLmh0bWwKIENBTENVTEFURV9MSUJSQVJZX1ZFUlNJT05TX0ZS T01fTElCVE9PTF9UUklQTEUoV0VCS0lUMiA0NCAwIDcpCg== 253441 2015-05-20 09:29:30 -0700 2015-05-20 09:42:29 -0700 Patch wk-gcc-4.9.diff text/plain 1516 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ODVkZWUxLi4wZTA5MTll IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTUtMDUtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIEJ1bXAgR0NDIHJlcXVpcmVtZW50cyB0byA0LjkuMAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MjExCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyByZXF1aXJlZCB0byBi dWlsZCB3aXRoIEluZGV4ZWREQiBzdXBwb3J0IHdoZW4gdXNpbmcgR0NDLAorICAgICAgICBjbGFu ZyB3b3JrcyBqdXN0IGZpbmUuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTg5MzIuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToK KwogMjAxNS0wNS0xOCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0NNYWtlXSBJZ25vcmUgd2FybmluZ3MgaW4gc3lzdGVtIGhlYWRlcnMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09w dGlvbnNHVEsuY21ha2UKaW5kZXggMzMwMDc0MS4uYTFkNTUzYSAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2UKQEAgLTcsNiArNywxMyBAQCBzZXQoUFJPSkVDVF9WRVJTSU9OX01JQ1JPIDEpCiBzZXQoUFJP SkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfS4ke1BST0pFQ1RfVkVSU0lPTl9N SU5PUn0uJHtQUk9KRUNUX1ZFUlNJT05fTUlDUk99KQogc2V0KFdFQktJVEdUS19BUElfVkVSU0lP TiA0LjApCiAKKyMgSW5kZXhlZERCIHN1cHBvcnQgcmVxdWlyZXMgR0dDIDQuOSwgc2VlIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODkzMi4KK2lmIChDTUFLRV9DWFhf Q09NUElMRVJfSUQgU1RSRVFVQUwgIkdOVSIpCisgICAgaWYgKENNQUtFX0NYWF9DT01QSUxFUl9W RVJTSU9OIFZFUlNJT05fTEVTUyAiNC45LjAiKQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9S ICJHQ0MgNC45LjAgaXMgcmVxdWlyZWQgdG8gYnVpbGQgV2ViS2l0R1RLKywgdXNlIGEgbmV3ZXIg R0NDIHZlcnNpb24gb3IgY2xhbmciKQorICAgIGVuZGlmICgpCitlbmRpZiAoKQorCiAjIExpYnRv b2wgbGlicmFyeSB2ZXJzaW9uLCBub3QgdG8gYmUgY29uZnVzZWQgd2l0aCBBUEkgdmVyc2lvbi4K ICMgU2VlIGh0dHA6Ly93d3cuZ251Lm9yZy9zb2Z0d2FyZS9saWJ0b29sL21hbnVhbC9odG1sX25v ZGUvTGlidG9vbC12ZXJzaW9uaW5nLmh0bWwKIENBTENVTEFURV9MSUJSQVJZX1ZFUlNJT05TX0ZS T01fTElCVE9PTF9UUklQTEUoV0VCS0lUMiA0NCAwIDcpCg==